Page MenuHomePhabricator
Feed Advanced Search

Apr 9 2020

stephanemoore accepted D77571: [clang-tidy] Add check to find calls to NSInvocation methods under ARC that don't have proper object argument lifetimes..
Apr 9 2020, 9:13 PMRestricted Project, Restricted Project

Apr 8 2020

stephanemoore accepted D77571: [clang-tidy] Add check to find calls to NSInvocation methods under ARC that don't have proper object argument lifetimes..
Apr 8 2020, 5:56 PMRestricted Project, Restricted Project

Feb 6 2020

stephanemoore accepted D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category..

Looks good!

Feb 6 2020, 2:16 PMRestricted Project, Restricted Project

Jan 31 2020

stephanemoore requested changes to D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category..

One last correction and I think that you're all set!

Jan 31 2020, 6:24 PMRestricted Project, Restricted Project

Jan 29 2020

stephanemoore added a comment to D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category..

Looks in good shape 馃憣 A couple nits and polish ideas.

Jan 29 2020, 8:34 PMRestricted Project, Restricted Project

Jan 24 2020

stephanemoore added inline comments to D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category..
Jan 24 2020, 5:03 PMRestricted Project, Restricted Project
stephanemoore requested changes to D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category..
Jan 24 2020, 4:45 PMRestricted Project, Restricted Project

Dec 5 2019

stephanemoore added a comment to rG380a6452b2e9: [ASTMatchers] work around a miscompile; "NFC".

Thanks for the fix and for the confirmation! 馃憤

Dec 5 2019, 3:07 PM

Dec 3 2019

stephanemoore accepted rG380a6452b2e9: [ASTMatchers] work around a miscompile; "NFC".

The changes look functionally safe.

Dec 3 2019, 7:50 PM

Oct 30 2019

stephanemoore committed rG9baf4958cda4: [clang-tidy] Regenerate clang-tidy check list 馃搵 (authored by stephanemoore).
[clang-tidy] Regenerate clang-tidy check list 馃搵
Oct 30 2019, 6:21 PM
stephanemoore closed D69414: [clang-tidy] Regenerate clang-tidy check list 馃搵.
Oct 30 2019, 6:20 PMRestricted Project

Oct 24 2019

stephanemoore added a comment to D69414: [clang-tidy] Regenerate clang-tidy check list 馃搵.

Please let me know if there are any corrections that are required to the output of clang-tools-extra/clang-tidy/add_new_check.py.

Oct 24 2019, 4:35 PMRestricted Project
stephanemoore created D69414: [clang-tidy] Regenerate clang-tidy check list 馃搵.
Oct 24 2019, 4:35 PMRestricted Project
stephanemoore added a reviewer for D69414: [clang-tidy] Regenerate clang-tidy check list 馃搵: aaron.ballman.
Oct 24 2019, 4:35 PMRestricted Project

Oct 1 2019

stephanemoore committed rGe4acb971f1ea: [clang-tidy] Rename objc-avoid-spinlock check to darwin-avoid-spinlock (authored by stephanemoore).
[clang-tidy] Rename objc-avoid-spinlock check to darwin-avoid-spinlock
Oct 1 2019, 2:18 PM
stephanemoore committed rL373392: [clang-tidy] Rename objc-avoid-spinlock check to darwin-avoid-spinlock.
[clang-tidy] Rename objc-avoid-spinlock check to darwin-avoid-spinlock
Oct 1 2019, 2:17 PM
stephanemoore closed D68148: [clang-tidy] Rename objc-avoid-spinlock check to darwin-avoid-spinlock.
Oct 1 2019, 2:17 PMRestricted Project, Restricted Project, Restricted Project

Sep 30 2019

stephanemoore added a comment to D65917: [clang-tidy] Added check for the Google style guide's category method naming rule..

(sorry for the delay 馃槄)

Sep 30 2019, 5:18 PMRestricted Project, Restricted Project

Sep 29 2019

stephanemoore accepted D68148: [clang-tidy] Rename objc-avoid-spinlock check to darwin-avoid-spinlock.

I wasn't sure what the policy is for renaming checks so I dug into previous check renames. https://reviews.llvm.org/D43867 seems to indicate that it's acceptable for checks to be renamed with documentation in the release notes (though there is some discussion about the possibility of recognizing the old check name for a grace period). Based on the aforementioned precedent I don't have concerns with this proposed change.

Sep 29 2019, 4:33 PMRestricted Project, Restricted Project, Restricted Project

Sep 27 2019

stephanemoore added a comment to D68109: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage..

Looks good 馃憣

Sep 27 2019, 12:10 PMRestricted Project, Restricted Project, Restricted Project

Sep 26 2019

stephanemoore committed rGaa7d6544c14c: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non鈥 (authored by stephanemoore).
[clang-tidy] New check to warn when storing dispatch_once_t in non-static, non鈥
Sep 26 2019, 4:04 PM
stephanemoore committed rL373028: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non鈥.
[clang-tidy] New check to warn when storing dispatch_once_t in non-static, non鈥
Sep 26 2019, 4:03 PM
stephanemoore closed D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage.
Sep 26 2019, 4:03 PMRestricted Project, Restricted Project, Restricted Project
stephanemoore added a comment to D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage.

It looks like everything is in order. I will proceed with landing the patch on your behalf 馃憤

Sep 26 2019, 4:02 PMRestricted Project, Restricted Project, Restricted Project
stephanemoore accepted D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage.
Sep 26 2019, 2:59 PMRestricted Project, Restricted Project, Restricted Project
stephanemoore added a comment to D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage.

Does the check allow variables in anonymous namespaces?

namespace {
dispatch_once_t onceToken;
}

I think such variables should satisfy initialization requirements.

If not, can we update the check to not trigger on variables? Either way, can we add a test to verify behavior for variables in anonymous namespaces?

Sep 26 2019, 2:59 PMRestricted Project, Restricted Project, Restricted Project
stephanemoore added a comment to D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage.

Looks good! A couple nits/questions.

Sep 26 2019, 2:55 PMRestricted Project, Restricted Project, Restricted Project

Sep 20 2019

stephanemoore committed rG2f6a52816fc3: [clang-tidy] Add check for classes missing -hash 鈿狅笍 (authored by stephanemoore).
[clang-tidy] Add check for classes missing -hash 鈿狅笍
Sep 20 2019, 6:22 PM
stephanemoore committed rL372445: [clang-tidy] Add check for classes missing -hash 鈿狅笍.
[clang-tidy] Add check for classes missing -hash 鈿狅笍
Sep 20 2019, 6:22 PM
stephanemoore closed D67737: [clang-tidy] Add check for classes missing -hash 鈿狅笍.
Sep 20 2019, 6:22 PMRestricted Project, Restricted Project
stephanemoore added a comment to D67737: [clang-tidy] Add check for classes missing -hash 鈿狅笍.

Thanks for the review!

Sep 20 2019, 5:45 PMRestricted Project, Restricted Project
stephanemoore requested changes to D65917: [clang-tidy] Added check for the Google style guide's category method naming rule..
Sep 20 2019, 5:44 PMRestricted Project, Restricted Project

Sep 19 2019

stephanemoore added inline comments to D67737: [clang-tidy] Add check for classes missing -hash 鈿狅笍.
Sep 19 2019, 7:34 PMRestricted Project, Restricted Project
stephanemoore added inline comments to D67737: [clang-tidy] Add check for classes missing -hash 鈿狅笍.
Sep 19 2019, 12:48 AMRestricted Project, Restricted Project
stephanemoore updated the diff for D67737: [clang-tidy] Add check for classes missing -hash 鈿狅笍.

Restrict ojbc-missing-hash to Objective-C language variants and fix sorting of
release notes.

Sep 19 2019, 12:38 AMRestricted Project, Restricted Project

Sep 18 2019

stephanemoore added reviewers for D67737: [clang-tidy] Add check for classes missing -hash 鈿狅笍: aaron.ballman, benhamilton.
Sep 18 2019, 3:46 PMRestricted Project, Restricted Project
stephanemoore created D67737: [clang-tidy] Add check for classes missing -hash 鈿狅笍.
Sep 18 2019, 3:45 PMRestricted Project, Restricted Project

Sep 17 2019

stephanemoore added inline comments to D65917: [clang-tidy] Added check for the Google style guide's category method naming rule..
Sep 17 2019, 1:52 PMRestricted Project, Restricted Project

Sep 16 2019

stephanemoore requested changes to D65917: [clang-tidy] Added check for the Google style guide's category method naming rule..
Sep 16 2019, 7:08 PMRestricted Project, Restricted Project
stephanemoore added a comment to D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage.
  1. Is dispatch_once_t OSX-specific thing? Should those checks be in osx module?
  1. I don't see an osx module鈥攁m I somehow missing seeing it?

One can be added.

dispatch_once_t is something from libdispatchwhich is an Apple-created API, but is OSS and available outside Apple. It's also a C API, which is why I didn't feel objc was an appropriate module either. I'm open to a better home module for this check, it's just not clear to me where that might be.

No opinion on my question, just thought it should be asked,

As Ben commented, I don't feel this should be in an osx module, as libdispatch is highly used on iOS and other Apple platforms. I know it's available elsewhere, but it may be so seldom used that I think a darwinmodule might be reasonable. I looked at the process for creating a new module, and can do that if we'd like, but should that be part of this same review?

Sep 16 2019, 5:05 PMRestricted Project, Restricted Project, Restricted Project
stephanemoore added inline comments to D67578: [clang-tidy] New check to warn when writing to a dispatch_once_t variable..
Sep 16 2019, 3:31 PMRestricted Project, Restricted Project

Sep 11 2019

stephanemoore requested changes to D65917: [clang-tidy] Added check for the Google style guide's category method naming rule..
Sep 11 2019, 4:54 AMRestricted Project, Restricted Project

Aug 15 2019

stephanemoore committed rGa53cce943d16: [clang-tidy] Migrate objc-super-self to use isDerivedFrom 馃殯 (authored by stephanemoore).
[clang-tidy] Migrate objc-super-self to use isDerivedFrom 馃殯
Aug 15 2019, 7:28 PM
stephanemoore committed rL369081: [clang-tidy] Migrate objc-super-self to use isDerivedFrom 馃殯.
[clang-tidy] Migrate objc-super-self to use isDerivedFrom 馃殯
Aug 15 2019, 7:28 PM
stephanemoore closed D66270: [clang-tidy] Migrate objc-super-self to use isDerivedFrom 馃殯.
Aug 15 2019, 7:28 PMRestricted Project, Restricted Project
stephanemoore committed rG8c90c1d2d57d: [clang-tidy] Migrate objc-forbidden-subclassing to use isDerivedFrom 馃殯 (authored by stephanemoore).
[clang-tidy] Migrate objc-forbidden-subclassing to use isDerivedFrom 馃殯
Aug 15 2019, 6:52 PM
stephanemoore committed rL369076: [clang-tidy] Migrate objc-forbidden-subclassing to use isDerivedFrom 馃殯.
[clang-tidy] Migrate objc-forbidden-subclassing to use isDerivedFrom 馃殯
Aug 15 2019, 6:51 PM
stephanemoore closed D66269: [clang-tidy] Migrate objc-forbidden-subclassing to use isDerivedFrom 馃殯.
Aug 15 2019, 6:51 PMRestricted Project, Restricted Project

Aug 14 2019

stephanemoore updated the diff for D66270: [clang-tidy] Migrate objc-super-self to use isDerivedFrom 馃殯.

Fix example matches in comment.

Aug 14 2019, 8:01 PMRestricted Project, Restricted Project
stephanemoore created D66270: [clang-tidy] Migrate objc-super-self to use isDerivedFrom 馃殯.
Aug 14 2019, 7:59 PMRestricted Project, Restricted Project
stephanemoore added reviewers for D66269: [clang-tidy] Migrate objc-forbidden-subclassing to use isDerivedFrom 馃殯: aaron.ballman, gribozavr.
Aug 14 2019, 7:04 PMRestricted Project, Restricted Project
stephanemoore created D66269: [clang-tidy] Migrate objc-forbidden-subclassing to use isDerivedFrom 馃殯.
Aug 14 2019, 7:01 PMRestricted Project, Restricted Project

Aug 12 2019

stephanemoore committed rGa0a47d8ac113: [clang] Update isDerivedFrom to support Objective-C classes 馃攳 (authored by stephanemoore).
[clang] Update isDerivedFrom to support Objective-C classes 馃攳
Aug 12 2019, 4:24 PM
stephanemoore committed rL368632: [clang] Update isDerivedFrom to support Objective-C classes 馃攳.
[clang] Update isDerivedFrom to support Objective-C classes 馃攳
Aug 12 2019, 4:24 PM
stephanemoore closed D60543: [clang] Update isDerivedFrom to support Objective-C classes 馃攳.
Aug 12 2019, 4:23 PMRestricted Project, Restricted Project

Aug 8 2019

stephanemoore added inline comments to D60543: [clang] Update isDerivedFrom to support Objective-C classes 馃攳.
Aug 8 2019, 6:31 PMRestricted Project, Restricted Project
stephanemoore updated the diff for D60543: [clang] Update isDerivedFrom to support Objective-C classes 馃攳.

Use llvm::SmallPtrSet to store the compatible aliases instead of std::set.
Fix a stray unit test failure in RegistryTest.cpp.

Aug 8 2019, 6:29 PMRestricted Project, Restricted Project

Aug 7 2019

stephanemoore updated the diff for D60543: [clang] Update isDerivedFrom to support Objective-C classes 馃攳.

Add tests for isDirectlyDerivedFrom.

Aug 7 2019, 6:56 PMRestricted Project, Restricted Project
stephanemoore planned changes to D60543: [clang] Update isDerivedFrom to support Objective-C classes 馃攳.

Whoops; forgot to add test cases for isDirectlyDerivedFrom 馃う Will do that shortly.

Aug 7 2019, 6:15 PMRestricted Project, Restricted Project
stephanemoore removed a reviewer for D60543: [clang] Update isDerivedFrom to support Objective-C classes 馃攳: stephanemoore.
Aug 7 2019, 5:16 PMRestricted Project, Restricted Project
stephanemoore added a comment to D60543: [clang] Update isDerivedFrom to support Objective-C classes 馃攳.

I spent some time becoming familiar with how isDerivedFrom behaves for C++ classes. I think that I have managed to get the behavior for Objective-C classes to mirror that of C++ classes. Please let me know if I overlooked anything.

Aug 7 2019, 5:12 PMRestricted Project, Restricted Project
stephanemoore updated the diff for D60543: [clang] Update isDerivedFrom to support Objective-C classes 馃攳.

Update isDerivedFrom to match aliased types and compatibility aliases of
derived Objective-C classes.

Aug 7 2019, 5:06 PMRestricted Project, Restricted Project

May 31 2019

stephanemoore committed rGec1982f07f5b: Revise the google-objc-global-variable-declaration check to match the style鈥 (authored by stephanemoore).
Revise the google-objc-global-variable-declaration check to match the style鈥
May 31 2019, 4:39 PM
stephanemoore committed rL362279: Revise the google-objc-global-variable-declaration check to match the style鈥.
Revise the google-objc-global-variable-declaration check to match the style鈥
May 31 2019, 4:38 PM
stephanemoore closed D62045: Revise the google-objc-global-variable-declaration check to match the style guide..
May 31 2019, 4:38 PMRestricted Project, Restricted Project

May 29 2019

stephanemoore accepted D62045: Revise the google-objc-global-variable-declaration check to match the style guide..
May 29 2019, 8:45 PMRestricted Project, Restricted Project

May 28 2019

stephanemoore added a comment to rL361907: Revise the google-objc-global-variable-declaration check to match the style鈥.

I think your changeset caused a failure in this buildbot.
http://lab.llvm.org:8011/builders/clang-ppc64le-linux-lnt/builds/18933
Failure : http://lab.llvm.org:8011/builders/clang-ppc64le-linux-lnt/builds/18933/steps/ninja%20check%201/logs/stdio

May 28 2019, 8:43 PM
stephanemoore planned changes to D60543: [clang] Update isDerivedFrom to support Objective-C classes 馃攳.

Thanks for the input! I will get started on making changes accordingly.

May 28 2019, 8:24 PMRestricted Project, Restricted Project
stephanemoore requested changes to D62045: Revise the google-objc-global-variable-declaration check to match the style guide..
May 28 2019, 7:32 PMRestricted Project, Restricted Project
stephanemoore reopened D62045: Revise the google-objc-global-variable-declaration check to match the style guide..
May 28 2019, 7:32 PMRestricted Project, Restricted Project
stephanemoore committed rG9ac757bf09a3: Rollback "Revise the google-objc-global-variable-declaration check to match the鈥 (authored by stephanemoore).
Rollback "Revise the google-objc-global-variable-declaration check to match the鈥
May 28 2019, 7:22 PM
stephanemoore committed rL361914: Rollback "Revise the google-objc-global-variable-declaration check to match the鈥.
Rollback "Revise the google-objc-global-variable-declaration check to match the鈥
May 28 2019, 7:22 PM
stephanemoore committed rCTE361914: Rollback "Revise the google-objc-global-variable-declaration check to match the鈥.
Rollback "Revise the google-objc-global-variable-declaration check to match the鈥
May 28 2019, 7:22 PM
stephanemoore committed rG12e3726fadb0: Revise the google-objc-global-variable-declaration check to match the style鈥 (authored by stephanemoore).
Revise the google-objc-global-variable-declaration check to match the style鈥
May 28 2019, 6:37 PM
stephanemoore committed rL361907: Revise the google-objc-global-variable-declaration check to match the style鈥.
Revise the google-objc-global-variable-declaration check to match the style鈥
May 28 2019, 6:33 PM
stephanemoore committed rCTE361907: Revise the google-objc-global-variable-declaration check to match the style鈥.
Revise the google-objc-global-variable-declaration check to match the style鈥
May 28 2019, 6:33 PM
stephanemoore closed D62045: Revise the google-objc-global-variable-declaration check to match the style guide..
May 28 2019, 6:33 PMRestricted Project, Restricted Project
stephanemoore added a comment to D62045: Revise the google-objc-global-variable-declaration check to match the style guide..

It looks like all concerns have been addressed. Do you need me to land this commit for you?

May 28 2019, 1:47 PMRestricted Project, Restricted Project

May 24 2019

stephanemoore requested review of D60543: [clang] Update isDerivedFrom to support Objective-C classes 馃攳.
May 24 2019, 8:36 PMRestricted Project, Restricted Project
stephanemoore accepted D60543: [clang] Update isDerivedFrom to support Objective-C classes 馃攳.

Okay I now have an implementation of Option 2 that works.

May 24 2019, 8:36 PMRestricted Project, Restricted Project
stephanemoore updated the diff for D60543: [clang] Update isDerivedFrom to support Objective-C classes 馃攳.

Add missing braces to multi-line if statements.

May 24 2019, 8:30 PMRestricted Project, Restricted Project
stephanemoore updated the diff for D60543: [clang] Update isDerivedFrom to support Objective-C classes 馃攳.

Update isDerivedFrom and related matchers to polymorphic matchers.

May 24 2019, 8:24 PMRestricted Project, Restricted Project
stephanemoore accepted D62045: Revise the google-objc-global-variable-declaration check to match the style guide..

Looks good! Thanks for being patient with me!

May 24 2019, 3:45 PMRestricted Project, Restricted Project
stephanemoore accepted D62045: Revise the google-objc-global-variable-declaration check to match the style guide..

(sorry I forgot to send this earlier)

May 24 2019, 3:13 PMRestricted Project, Restricted Project

May 21 2019

stephanemoore planned changes to D60543: [clang] Update isDerivedFrom to support Objective-C classes 馃攳.

Out of curiosity, how invasive is Option 2 within our own code base?

May 21 2019, 9:00 PMRestricted Project, Restricted Project
stephanemoore requested changes to D62045: Revise the google-objc-global-variable-declaration check to match the style guide..

Many thanks for being patient with me 馃檹 I think there are just two more things 鉁岋笍

May 21 2019, 6:18 PMRestricted Project, Restricted Project
stephanemoore requested changes to D62045: Revise the google-objc-global-variable-declaration check to match the style guide..

Almost there. I think everything looks good after we resolve this last round of comments.

May 21 2019, 4:53 PMRestricted Project, Restricted Project

May 17 2019

stephanemoore added inline comments to D62045: Revise the google-objc-global-variable-declaration check to match the style guide..
May 17 2019, 6:09 PMRestricted Project, Restricted Project
stephanemoore requested changes to D62045: Revise the google-objc-global-variable-declaration check to match the style guide..

Thanks for restoring the support for the legacy style! I noticed that there are some cases where we can preserve an existing fixit.

May 17 2019, 3:03 PMRestricted Project, Restricted Project
stephanemoore requested changes to D62045: Revise the google-objc-global-variable-declaration check to match the style guide..
May 17 2019, 12:28 PMRestricted Project, Restricted Project

May 14 2019

stephanemoore accepted D61350: [clang-tidy] New check calling out uses of +new in Objective-C code.
May 14 2019, 3:08 PMRestricted Project, Restricted Project

May 13 2019

stephanemoore requested changes to D61350: [clang-tidy] New check calling out uses of +new in Objective-C code.
May 13 2019, 3:28 PMRestricted Project, Restricted Project
stephanemoore accepted D61350: [clang-tidy] New check calling out uses of +new in Objective-C code.

I believe that all the feedback from @gribozavr has been addressed modulo one small nit. Once that nit has been addressed, I can land this.

May 13 2019, 3:09 PMRestricted Project, Restricted Project

May 12 2019

stephanemoore committed rG3109836a60a7: [clang] Regenerate AST matcher docs 馃摉 (authored by stephanemoore).
[clang] Regenerate AST matcher docs 馃摉
May 12 2019, 2:51 PM
stephanemoore committed rL360545: [clang] Regenerate AST matcher docs 馃摉.
[clang] Regenerate AST matcher docs 馃摉
May 12 2019, 2:50 PM
stephanemoore committed rC360545: [clang] Regenerate AST matcher docs 馃摉.
[clang] Regenerate AST matcher docs 馃摉
May 12 2019, 2:50 PM
stephanemoore closed D61769: [clang] Regenerate AST matcher docs 馃摉.
May 12 2019, 2:50 PMRestricted Project, Restricted Project

May 9 2019

stephanemoore added inline comments to D60543: [clang] Update isDerivedFrom to support Objective-C classes 馃攳.
May 9 2019, 5:32 PMRestricted Project, Restricted Project
stephanemoore added a comment to D60543: [clang] Update isDerivedFrom to support Objective-C classes 馃攳.

I did some digging and I believe there are two approaches that we can take to extend isDerivedFrom to support Objective-C classes.

May 9 2019, 5:29 PMRestricted Project, Restricted Project
stephanemoore retitled D60543: [clang] Update isDerivedFrom to support Objective-C classes 馃攳 from [clang] Add matcher for subclasses of Objective-C interfaces 馃攳 to [clang] Update isDerivedFrom to support Objective-C classes 馃攳.
May 9 2019, 5:03 PMRestricted Project, Restricted Project