Page MenuHomePhabricator
Feed Advanced Search

Today

StephenTozer added inline comments to D83495: [DebugInfo] Add DWARF emission for DBG_VALUE_LIST.
Fri, Jan 15, 9:30 AM · Restricted Project, debug-info
StephenTozer updated the diff for D82363: [DebugInfo] Add new instruction and expression operator for variadic debug values.

Rebased onto recent master (resolving clashes with the DW_OP_implicit_ptr patch); rewrote dbg-value-list-spill.mir test.

Fri, Jan 15, 8:28 AM · Restricted Project, debug-info

Wed, Jan 13

StephenTozer updated the summary of D94631: [DebugInfo] Add support for multiple value references in debug values, and enable salvaging.
Wed, Jan 13, 1:09 PM · Restricted Project, debug-info
StephenTozer requested review of D94631: [DebugInfo] Add support for multiple value references in debug values, and enable salvaging.
Wed, Jan 13, 1:07 PM · Restricted Project, debug-info
StephenTozer updated the diff for D91722: [DebugInfo] Use variadic debug values to salvage BinOps and GEP instrs with non-const operands.

Rebased onto recent master, fixed test failures.

Wed, Jan 13, 12:51 PM · debug-info, Restricted Project
StephenTozer updated the diff for D88585: [DebugInfo] Support representation of multiple location operands in ISel's SDDbgValue.

Rebased onto recent master, address review comment.

Wed, Jan 13, 12:41 PM · Restricted Project, debug-info
StephenTozer updated the diff for D88232: [DebugInfo] Handle multiple variable location operands in IR.

Rebased onto recent master.

Wed, Jan 13, 12:35 PM · debug-info, Restricted Project
StephenTozer updated the diff for D88175: [DebugInfo] Add new metadata, DIArgList, for referencing a list of SSA values inside a debug variable intrinsic.

Rebased onto recent master, minor change to Args storage (std::vector -> SmallVector) and added args_begin() and args_end().

Wed, Jan 13, 12:30 PM · Restricted Project, debug-info
StephenTozer updated the diff for D88230: [DebugInfo] Support multiple location operands via DIArgList in DbgVariableIntrinsics.

Rebased onto recent master, added smarter iterator for variable location operands.

Wed, Jan 13, 12:27 PM · Restricted Project, debug-info
StephenTozer updated the diff for D83890: [DebugInfo] Process DBG_VALUE_LIST in LiveDebugValues.

Rebased onto recent master.

Wed, Jan 13, 11:50 AM · Restricted Project, debug-info
StephenTozer updated the diff for D83895: [DebugInfo] Process DBG_VALUE_LIST in LiveDebugVariables.

Rebased onto recent master, fixed test failures.

Wed, Jan 13, 11:49 AM · Restricted Project, debug-info
StephenTozer updated the diff for D83495: [DebugInfo] Add DWARF emission for DBG_VALUE_LIST.

Rebased onto recent master, fixed some test failures.

Wed, Jan 13, 11:47 AM · Restricted Project, debug-info
StephenTozer updated the diff for D92578: [DebugInfo] Handle DBG_VALUES with multiple variable location operands in MIR.

Rebased onto recent master, fixed up MachineSink implementation.

Wed, Jan 13, 11:34 AM · Restricted Project, debug-info
StephenTozer updated the diff for D82363: [DebugInfo] Add new instruction and expression operator for variadic debug values.

Rebased onto recent master (993c488ed), addressed review comments (except for the question about dbg-value-list-spill.mir).

Wed, Jan 13, 11:31 AM · Restricted Project, debug-info

Mon, Jan 11

StephenTozer added inline comments to D90046: [LiveDebugValues] Handle spill locations with a fixed and scalable component..
Mon, Jan 11, 8:35 AM · Restricted Project

Thu, Jan 7

StephenTozer added inline comments to D83495: [DebugInfo] Add DWARF emission for DBG_VALUE_LIST.
Thu, Jan 7, 9:07 AM · Restricted Project, debug-info

Wed, Jan 6

StephenTozer added inline comments to D88232: [DebugInfo] Handle multiple variable location operands in IR.
Wed, Jan 6, 2:08 PM · debug-info, Restricted Project
StephenTozer added inline comments to D82363: [DebugInfo] Add new instruction and expression operator for variadic debug values.
Wed, Jan 6, 2:08 PM · Restricted Project, debug-info
StephenTozer added a comment to D88175: [DebugInfo] Add new metadata, DIArgList, for referencing a list of SSA values inside a debug variable intrinsic.

Although — no that I read the reply — it looks like the MDTuple question hasn't actually been answered ;-)

Wed, Jan 6, 10:08 AM · Restricted Project, debug-info

Mon, Jan 4

StephenTozer added inline comments to D83495: [DebugInfo] Add DWARF emission for DBG_VALUE_LIST.
Mon, Jan 4, 6:01 AM · Restricted Project, debug-info

Dec 16 2020

StephenTozer added a comment to D83895: [DebugInfo] Process DBG_VALUE_LIST in LiveDebugVariables.

I'm hoping you can clarify something about addDefsFromCopies for me. IIUC without the patch we are adding defs from copies at kill points if possible. And with the patch a def is only added on the _first_ kill. Is that right?

Dec 16 2020, 8:14 AM · Restricted Project, debug-info

Dec 10 2020

StephenTozer added inline comments to D92851: [DebugInfo][NFC] Refactor BinOp and GEP salvaging in salvageDebugInfoImpl out to separate functions.
Dec 10 2020, 10:06 AM · Restricted Project, debug-info
StephenTozer added inline comments to D91722: [DebugInfo] Use variadic debug values to salvage BinOps and GEP instrs with non-const operands.
Dec 10 2020, 9:50 AM · debug-info, Restricted Project
StephenTozer added inline comments to D88589: [DebugInfo] Handle dbg.values with multiple variable location operands in ISel.
Dec 10 2020, 9:46 AM · Restricted Project, debug-info

Dec 8 2020

StephenTozer added a comment to D83890: [DebugInfo] Process DBG_VALUE_LIST in LiveDebugValues.

@StephenTozer Thanks for addressing the comments! Can you please share with us if you have any measurements with the respect to build time increase (e.g. on clang build itself) with this patch? I think that this patch is the only one from the stack that could give us potential performance issues.

Dec 8 2020, 9:48 AM · Restricted Project, debug-info
StephenTozer updated the diff for D91722: [DebugInfo] Use variadic debug values to salvage BinOps and GEP instrs with non-const operands.

Rebased onto recent master, no functional changes; moved the salvageDebugInfoImpl refactoring into a separate NFC patch; addressed outstanding review comments.

Dec 8 2020, 8:16 AM · debug-info, Restricted Project
StephenTozer requested review of D92851: [DebugInfo][NFC] Refactor BinOp and GEP salvaging in salvageDebugInfoImpl out to separate functions.
Dec 8 2020, 8:13 AM · Restricted Project, debug-info
StephenTozer updated the diff for D88592: [DebugInfo] Emit DBG_VALUE_LIST from ISel.

Rebased onto recent master; no functional changes.

Dec 8 2020, 7:28 AM · Restricted Project, debug-info
StephenTozer updated the diff for D88589: [DebugInfo] Handle dbg.values with multiple variable location operands in ISel.

Rebase onto recent master, no functional changes.

Dec 8 2020, 7:26 AM · Restricted Project, debug-info
StephenTozer updated the diff for D88585: [DebugInfo] Support representation of multiple location operands in ISel's SDDbgValue.

Rebase onto recent master; no functional changes except applying the existing changes to the new InstrEmitter::EmitDbgInstrRef function.

Dec 8 2020, 7:25 AM · Restricted Project, debug-info
StephenTozer updated the diff for D88232: [DebugInfo] Handle multiple variable location operands in IR.

Rebase onto recent master, no functional changes from rebase. Minor changes to findDbgUsers/findDbgValues to handle DIArgLists in which the same value appears more than once.

Dec 8 2020, 7:20 AM · debug-info, Restricted Project
StephenTozer updated the diff for D88230: [DebugInfo] Support multiple location operands via DIArgList in DbgVariableIntrinsics.

Rebase onto recent master; no functional changes from rebase. Minor change to DbgVariableIntrinsic::setUndef to handle DIArglists in which the same value appears more than once.

Dec 8 2020, 7:09 AM · Restricted Project, debug-info
StephenTozer updated the diff for D88175: [DebugInfo] Add new metadata, DIArgList, for referencing a list of SSA values inside a debug variable intrinsic.

Rebase onto recent master; minor non-functional changes (renamed "ParseX()" functions to "parseX()").

Dec 8 2020, 6:50 AM · Restricted Project, debug-info
StephenTozer updated the diff for D83890: [DebugInfo] Process DBG_VALUE_LIST in LiveDebugValues.

Rebased onto recent master, no changes.

Dec 8 2020, 6:47 AM · Restricted Project, debug-info
StephenTozer updated the diff for D83895: [DebugInfo] Process DBG_VALUE_LIST in LiveDebugVariables.

Rebased onto recent master; no functional changes from rebase.

Dec 8 2020, 6:45 AM · Restricted Project, debug-info
StephenTozer updated the diff for D83896: [DebugInfo] Add replaceArg function for removing duplicates from DBG_VALUE_LIST expressions.

Rebased to recent master, no actual changes.

Dec 8 2020, 6:37 AM · debug-info, Restricted Project
StephenTozer updated the diff for D83495: [DebugInfo] Add DWARF emission for DBG_VALUE_LIST.

Rebased onto recent master; no functional changes, minor adjustments in DwarfDebug::emitDebugLocValue.

Dec 8 2020, 6:07 AM · Restricted Project, debug-info
StephenTozer updated the diff for D92578: [DebugInfo] Handle DBG_VALUES with multiple variable location operands in MIR.

Rebased onto recent master.

Dec 8 2020, 5:59 AM · Restricted Project, debug-info
StephenTozer updated the diff for D82363: [DebugInfo] Add new instruction and expression operator for variadic debug values.

Rebased onto recent master.

Dec 8 2020, 5:54 AM · Restricted Project, debug-info
StephenTozer added inline comments to D90020: [AArch64][SVE] Emit DWARF location expression for SVE stack objects..
Dec 8 2020, 4:55 AM · Restricted Project

Dec 3 2020

StephenTozer requested review of D92578: [DebugInfo] Handle DBG_VALUES with multiple variable location operands in MIR.
Dec 3 2020, 9:09 AM · Restricted Project, debug-info
StephenTozer updated the diff for D88175: [DebugInfo] Add new metadata, DIArgList, for referencing a list of SSA values inside a debug variable intrinsic.

Fixed a pair of bugs; 1) added DIArgList support to the ValueMapper so that DIArgList arguments are properly updated during inlining, and 2) prevented RAUW from setting DIArgList arguments to null (now uses an UndefValue instead).

Dec 3 2020, 7:36 AM · Restricted Project, debug-info
StephenTozer added a comment to D91722: [DebugInfo] Use variadic debug values to salvage BinOps and GEP instrs with non-const operands.

Thanks!! So, this should be the most important one :) I would really like to see some measurements (e.g. llvm-locstats) before/after this patch.
Have you tried building llvm-project itself with this?

Dec 3 2020, 6:43 AM · debug-info, Restricted Project
StephenTozer added inline comments to D91722: [DebugInfo] Use variadic debug values to salvage BinOps and GEP instrs with non-const operands.
Dec 3 2020, 6:17 AM · debug-info, Restricted Project

Nov 20 2020

StephenTozer added a comment to D82363: [DebugInfo] Add new instruction and expression operator for variadic debug values.

@StephenTozer what's the status of the latest discussions on this patch? As far as I understand it:

  • DBG_VALUE may go away, but that'll be in another patch,
  • There was some conclusion to whether all DBG_VALUE_LISTs should be stack_values too, can't remember what, on the mailing list,
  • This patch, adding the plumbing for the DBG_VALUE_LIST, would be ready to land.
Nov 20 2020, 8:49 AM · Restricted Project, debug-info

Nov 18 2020

StephenTozer added inline comments to D91722: [DebugInfo] Use variadic debug values to salvage BinOps and GEP instrs with non-const operands.
Nov 18 2020, 8:55 AM · debug-info, Restricted Project
StephenTozer requested review of D91722: [DebugInfo] Use variadic debug values to salvage BinOps and GEP instrs with non-const operands.
Nov 18 2020, 8:50 AM · debug-info, Restricted Project

Oct 28 2020

StephenTozer updated the diff for D90234: [MCParser] Correctly handle Windows line-endings when consuming lexed line comments.

I've added a test for the symptom that revealed this bug in llvm-mca. I'm also writing a unit test for AsmLexer that tests the underlying behaviour by verifying that CommentConsumers will not be sent characters that are not part of the line comment, since the problem is not specific to llvm-mca (although it's the only place that has seen an error so far, as far as I can tell).

Oct 28 2020, 9:26 AM · Restricted Project

Oct 27 2020

StephenTozer requested review of D90234: [MCParser] Correctly handle Windows line-endings when consuming lexed line comments.
Oct 27 2020, 8:09 AM · Restricted Project

Oct 19 2020

StephenTozer added inline comments to D87233: [POC][DebugInfo] Use entry values within IR.
Oct 19 2020, 7:16 AM · Restricted Project, debug-info
StephenTozer accepted D87357: [SelectionDAG][DebugInfo] Use entry-values to recover variables values.

LGTM, this new approach looks solid. As per usual, wait for further approval from someone with more authority in this area.

Oct 19 2020, 6:09 AM · Restricted Project, debug-info

Oct 5 2020

StephenTozer added a comment to D88593: [DebugInfo] Add tests for ISel handling of variadic debug values.

Are you going to do GlobalISel, too?

Oct 5 2020, 9:52 AM · debug-info, Restricted Project

Oct 1 2020

StephenTozer added inline comments to D82363: [DebugInfo] Add new instruction and expression operator for variadic debug values.
Oct 1 2020, 4:44 AM · Restricted Project, debug-info
StephenTozer updated the diff for D83890: [DebugInfo] Process DBG_VALUE_LIST in LiveDebugValues.
  • Fixed a few minor errors, including a linux compile error
  • Rebased onto latest master, moving changes into VarLocBasedImpl.cpp.
Oct 1 2020, 3:25 AM · Restricted Project, debug-info

Sep 30 2020

StephenTozer requested review of D88593: [DebugInfo] Add tests for ISel handling of variadic debug values.
Sep 30 2020, 10:10 AM · debug-info, Restricted Project
StephenTozer requested review of D88592: [DebugInfo] Emit DBG_VALUE_LIST from ISel.
Sep 30 2020, 10:05 AM · Restricted Project, debug-info
StephenTozer added a reviewer for D88589: [DebugInfo] Handle dbg.values with multiple variable location operands in ISel: dblaikie.
Sep 30 2020, 9:55 AM · Restricted Project, debug-info
StephenTozer added a reviewer for D88585: [DebugInfo] Support representation of multiple location operands in ISel's SDDbgValue: dblaikie.
Sep 30 2020, 9:54 AM · Restricted Project, debug-info
StephenTozer requested review of D88589: [DebugInfo] Handle dbg.values with multiple variable location operands in ISel.
Sep 30 2020, 9:53 AM · Restricted Project, debug-info
StephenTozer requested review of D88585: [DebugInfo] Support representation of multiple location operands in ISel's SDDbgValue.
Sep 30 2020, 9:02 AM · Restricted Project, debug-info
StephenTozer added inline comments to D82363: [DebugInfo] Add new instruction and expression operator for variadic debug values.
Sep 30 2020, 3:20 AM · Restricted Project, debug-info

Sep 28 2020

StephenTozer updated the diff for D82363: [DebugInfo] Add new instruction and expression operator for variadic debug values.

Add documentation for DBG_VALUE_LIST and DW_OP_LLVM_arg.

Sep 28 2020, 10:33 AM · Restricted Project, debug-info
StephenTozer added inline comments to D88232: [DebugInfo] Handle multiple variable location operands in IR.
Sep 28 2020, 10:01 AM · debug-info, Restricted Project
StephenTozer added inline comments to D88230: [DebugInfo] Support multiple location operands via DIArgList in DbgVariableIntrinsics.
Sep 28 2020, 9:58 AM · Restricted Project, debug-info
StephenTozer added inline comments to D88175: [DebugInfo] Add new metadata, DIArgList, for referencing a list of SSA values inside a debug variable intrinsic.
Sep 28 2020, 9:19 AM · Restricted Project, debug-info
StephenTozer added a comment to D82545: [Debugify] Make the debugify aware of the original (-g) Debug Info.

LGTM, though recommend waiting for a more experienced reviewer to give approval.

Sep 28 2020, 5:44 AM · debug-info, Restricted Project

Sep 25 2020

StephenTozer added a comment to D82545: [Debugify] Make the debugify aware of the original (-g) Debug Info.

I think wait for someone with more experience in this area to give approval, but aside from the outstanding comments, LGTM.

Sep 25 2020, 9:06 AM · debug-info, Restricted Project
StephenTozer added inline comments to D82545: [Debugify] Make the debugify aware of the original (-g) Debug Info.
Sep 25 2020, 7:36 AM · debug-info, Restricted Project
StephenTozer added inline comments to D82545: [Debugify] Make the debugify aware of the original (-g) Debug Info.
Sep 25 2020, 6:57 AM · debug-info, Restricted Project

Sep 24 2020

StephenTozer accepted D87233: [POC][DebugInfo] Use entry values within IR.

LGTM. I think the Implicit flag idea might be able to be folded into this patch without much issue, but it's not urgent and can definitely be shifted to another patch (or even just left as a TODO). Should probably be looked at by others with experience in the area, but I think most of the comments are probably going to be for the later patches in this stack.

Sep 24 2020, 8:58 AM · Restricted Project, debug-info
StephenTozer requested review of D88232: [DebugInfo] Handle multiple variable location operands in IR.
Sep 24 2020, 8:04 AM · debug-info, Restricted Project
StephenTozer requested review of D88230: [DebugInfo] Support multiple location operands via DIArgList in DbgVariableIntrinsics.
Sep 24 2020, 7:23 AM · Restricted Project, debug-info

Sep 23 2020

StephenTozer updated the summary of D88175: [DebugInfo] Add new metadata, DIArgList, for referencing a list of SSA values inside a debug variable intrinsic.
Sep 23 2020, 11:41 AM · Restricted Project, debug-info
StephenTozer requested review of D88175: [DebugInfo] Add new metadata, DIArgList, for referencing a list of SSA values inside a debug variable intrinsic.
Sep 23 2020, 11:40 AM · Restricted Project, debug-info
StephenTozer added inline comments to D87357: [SelectionDAG][DebugInfo] Use entry-values to recover variables values.
Sep 23 2020, 9:50 AM · Restricted Project, debug-info
StephenTozer updated the diff for D82363: [DebugInfo] Add new instruction and expression operator for variadic debug values.

Updated changes for latest master (there may be some lurking unseen errors, still trying to flush any out), addressed some review comments. Right now, I think the only thing holding this patch up is the discussion on the llvm-dev mailing list about using DBG_VALUE_LIST as the default for all debug values. If anyone on this review has any input for that, please go ahead and reply to the chain - I think that the latest proposal I put forward should satisfy everyone's requirements, but I don't want to push ahead without being sure of that.

Sep 23 2020, 8:26 AM · Restricted Project, debug-info
StephenTozer added inline comments to D87357: [SelectionDAG][DebugInfo] Use entry-values to recover variables values.
Sep 23 2020, 7:51 AM · Restricted Project, debug-info
StephenTozer added inline comments to D87357: [SelectionDAG][DebugInfo] Use entry-values to recover variables values.
Sep 23 2020, 3:38 AM · Restricted Project, debug-info
StephenTozer added inline comments to D87357: [SelectionDAG][DebugInfo] Use entry-values to recover variables values.
Sep 23 2020, 2:21 AM · Restricted Project, debug-info

Aug 27 2020

StephenTozer added a comment to D82363: [DebugInfo] Add new instruction and expression operator for variadic debug values.

In a normal year I would have suggested a round table at the upcoming LLVM dev meeting, but this time around we'll have to improvise :-)
In the past, a post to LLVM-dev with (it does not have to be a fully fleshed out RFC at all) was always a good way to get a discussing with all stakeholders started.

Aug 27 2020, 2:29 AM · Restricted Project, debug-info

Jul 24 2020

StephenTozer updated the diff for D83495: [DebugInfo] Add DWARF emission for DBG_VALUE_LIST.

Add test to confirm that addMachineRegExpression is being correctly used for DBG_VALUE_LIST regs; replace if-else chain with switch in AsmPrinter::emitDebugValueComment.

Jul 24 2020, 10:16 AM · Restricted Project, debug-info
StephenTozer updated the diff for D83896: [DebugInfo] Add replaceArg function for removing duplicates from DBG_VALUE_LIST expressions.

Add a simple unit test for the new function.

Jul 24 2020, 7:48 AM · debug-info, Restricted Project

Jul 21 2020

StephenTozer updated the diff for D83895: [DebugInfo] Process DBG_VALUE_LIST in LiveDebugVariables.

Remove unused MF attributes.

Jul 21 2020, 3:56 AM · Restricted Project, debug-info
StephenTozer updated the diff for D83890: [DebugInfo] Process DBG_VALUE_LIST in LiveDebugValues.

Remove unused data from tests, add/modify comments, move VarVec declaration up, fix error in duplicated-op-removal.

Jul 21 2020, 3:16 AM · Restricted Project, debug-info

Jul 17 2020

StephenTozer added a comment to D83495: [DebugInfo] Add DWARF emission for DBG_VALUE_LIST.

Could we reduce complexity by entirely replacing DBG_VALUE with DBG_VALUE_LIST, *, DW_OP_arg 0, *?

Jul 17 2020, 1:43 PM · Restricted Project, debug-info
StephenTozer added inline comments to D83890: [DebugInfo] Process DBG_VALUE_LIST in LiveDebugValues.
Jul 17 2020, 7:49 AM · Restricted Project, debug-info

Jul 15 2020

StephenTozer updated the summary of D83896: [DebugInfo] Add replaceArg function for removing duplicates from DBG_VALUE_LIST expressions.
Jul 15 2020, 5:33 PM · debug-info, Restricted Project
StephenTozer updated the summary of D83895: [DebugInfo] Process DBG_VALUE_LIST in LiveDebugVariables.
Jul 15 2020, 11:36 AM · Restricted Project, debug-info
StephenTozer added a project to D83896: [DebugInfo] Add replaceArg function for removing duplicates from DBG_VALUE_LIST expressions: debug-info.
Jul 15 2020, 11:35 AM · debug-info, Restricted Project
Herald added a project to D83896: [DebugInfo] Add replaceArg function for removing duplicates from DBG_VALUE_LIST expressions: Restricted Project.
Jul 15 2020, 11:31 AM · debug-info, Restricted Project
Herald added a project to D83895: [DebugInfo] Process DBG_VALUE_LIST in LiveDebugVariables: Restricted Project.
Jul 15 2020, 11:25 AM · Restricted Project, debug-info
Herald added a project to D83890: [DebugInfo] Process DBG_VALUE_LIST in LiveDebugValues: Restricted Project.
Jul 15 2020, 10:58 AM · Restricted Project, debug-info

Jul 10 2020

StephenTozer updated the diff for D82363: [DebugInfo] Add new instruction and expression operator for variadic debug values.

Rename appendOpsToLoc->appendOpsToArg to fit the rest of the names, update isUndefDebugValue check to check all operands (pulled ahead from a patch further up the stack).

Jul 10 2020, 6:15 AM · Restricted Project, debug-info
StephenTozer updated the diff for D82363: [DebugInfo] Add new instruction and expression operator for variadic debug values.

Remove useless const, add rename that somehow escaped last diff.

Jul 10 2020, 5:25 AM · Restricted Project, debug-info
StephenTozer updated the diff for D83495: [DebugInfo] Add DWARF emission for DBG_VALUE_LIST.

Remove old comments from tests.

Jul 10 2020, 4:30 AM · Restricted Project, debug-info
StephenTozer added inline comments to D83495: [DebugInfo] Add DWARF emission for DBG_VALUE_LIST.
Jul 10 2020, 4:28 AM · Restricted Project, debug-info

Jul 9 2020

Herald added a project to D83495: [DebugInfo] Add DWARF emission for DBG_VALUE_LIST: Restricted Project.
Jul 9 2020, 11:09 AM · Restricted Project, debug-info
StephenTozer updated the diff for D82363: [DebugInfo] Add new instruction and expression operator for variadic debug values.

Address latest review comments.

Jul 9 2020, 9:25 AM · Restricted Project, debug-info
StephenTozer added inline comments to D82363: [DebugInfo] Add new instruction and expression operator for variadic debug values.
Jul 9 2020, 8:25 AM · Restricted Project, debug-info
StephenTozer updated the diff for D82363: [DebugInfo] Add new instruction and expression operator for variadic debug values.

Update: Duplicate registers in the debug operands could be an issue with the previous patch version, and duplicates aren't easy to prevent, so always treat DBG_VALUE_LISTs as potentially having them.

Jul 9 2020, 5:56 AM · Restricted Project, debug-info