Page MenuHomePhabricator
Feed Advanced Search

Wed, Nov 18

sylvestre.ledru added a comment to D85600: [clang-format] use spaces for alignment of binary/ternary expressions with UT_AlignWithSpaces.

I am not 100% that it is thanks to this patch but reformatting Firefox code with clang-format 11 significantly improves the readability of the usage
of ternary operators. See: https://phabricator.services.mozilla.com/D90795

Wed, Nov 18, 12:55 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Nov 17

sylvestre.ledru added a comment to D91598: Allow packager to provide a default configuration file for clang.

@sylvestre.ledru Can you drop the picture?

Tue, Nov 17, 9:04 AM
sylvestre.ledru added a comment to D91598: Allow packager to provide a default configuration file for clang.

Great idea. Do you have an example of what the configuration could look like on a distro?
Merci!

Tue, Nov 17, 3:22 AM

Sat, Nov 7

sylvestre.ledru accepted D90972: [clang-tidy] Install run-clang-tidy.py in bin/ as run-clang-tidy.

Sounds great. You might want to ask feedback to other reviews too!

Sat, Nov 7, 6:35 AM · Restricted Project, Restricted Project
sylvestre.ledru requested changes to D90972: [clang-tidy] Install run-clang-tidy.py in bin/ as run-clang-tidy.

Thanks.
Could you please also update the release notes for 12?

Sat, Nov 7, 4:41 AM · Restricted Project, Restricted Project
sylvestre.ledru added a comment to D90972: [clang-tidy] Install run-clang-tidy.py in bin/ as run-clang-tidy.

FWIW, I am doing this change already in Debian & Ubuntu ( https://salsa.debian.org/pkg-llvm-team/llvm-toolchain/-/blob/10/debian/clang-tidy-X.Y.links.in#L2 )

Sat, Nov 7, 12:46 AM · Restricted Project, Restricted Project

Sat, Oct 31

sylvestre.ledru committed rG43e451f9f316: Fix gendered documentation (authored by pedro.gonnet).
Fix gendered documentation
Sat, Oct 31, 4:17 AM
sylvestre.ledru closed D78807: Fix gendered documentation.
Sat, Oct 31, 4:17 AM · Restricted Project, Restricted Project
sylvestre.ledru resigned from D23975: Support of kfreebsd & GNU Hurd in llvm-shlib.

I think it is now fixed

Sat, Oct 31, 4:07 AM
sylvestre.ledru resigned from D34100: fix the bug of opening the file with the bytes can't be decoded to 'utf-8'.

Sorry, I am not a good reviewer for this file

Sat, Oct 31, 4:07 AM · Restricted Project, Restricted Project
sylvestre.ledru accepted D58118: Fix llvm-config behavior when LLVM_TOOLS_INSTALL_DIR has a depth greater than one.
Sat, Oct 31, 4:06 AM · Restricted Project
sylvestre.ledru added a comment to D58118: Fix llvm-config behavior when LLVM_TOOLS_INSTALL_DIR has a depth greater than one.

I guess it isn't possible to write a test for this?

Sat, Oct 31, 4:06 AM · Restricted Project
sylvestre.ledru accepted D88084: [clang-format] Changed default styles BraceWrappping bool table to directly use variables.

Much better

Sat, Oct 31, 4:05 AM · Restricted Project, Restricted Project
sylvestre.ledru accepted D89481: [scan-build] Fix clang++ pathname again.

Looks good to me

Sat, Oct 31, 4:04 AM · Restricted Project
sylvestre.ledru resigned from D89974: [driver][CUDA] Use CMake's FindCUDA as default --cuda-path..
Sat, Oct 31, 4:03 AM · Restricted Project, Restricted Project

Thu, Oct 29

sylvestre.ledru committed rG5d1eae7d23e3: Add support of the next Ubuntu (Ubuntu 21.04 - Hirsute Hippo) (authored by sylvestre.ledru).
Add support of the next Ubuntu (Ubuntu 21.04 - Hirsute Hippo)
Thu, Oct 29, 11:12 AM

Oct 21 2020

sylvestre.ledru added a comment to D88922: [CMake] Avoid accidental C++ standard library dependency in sanitizers.

I can reproduce the build issue on apt.llvm.org
Full log:
https://llvm-jenkins.debian.net/job/llvm-toolchain-xenial-binaries/architecture=amd64,distribution=xenial/2554/consoleFull

Oct 21 2020, 12:48 PM · Restricted Project
sylvestre.ledru committed rG0784e17f1b4a: Remove .svn from exclude list as we moved to git (authored by sylvestre.ledru).
Remove .svn from exclude list as we moved to git
Oct 21 2020, 7:09 AM
sylvestre.ledru closed D89859: Remove .svn from exclude list as we moved to git.
Oct 21 2020, 7:09 AM · Restricted Project, Restricted Project, Restricted Project
sylvestre.ledru added a comment to D89859: Remove .svn from exclude list as we moved to git.

ed if you want to approve it ;)

Oct 21 2020, 7:03 AM · Restricted Project, Restricted Project, Restricted Project
sylvestre.ledru added a reviewer for D89859: Remove .svn from exclude list as we moved to git: emaste.
Oct 21 2020, 7:03 AM · Restricted Project, Restricted Project, Restricted Project
sylvestre.ledru requested review of D89859: Remove .svn from exclude list as we moved to git.
Oct 21 2020, 2:05 AM · Restricted Project, Restricted Project, Restricted Project

Oct 17 2020

sylvestre.ledru added a reverting change for rGb2eb43931757: [clang-format] Fix AlignConsecutive on PP blocks: rGb9e789447f14: Revert "[clang-format] Fix AlignConsecutive on PP blocks".
Oct 17 2020, 10:53 AM
sylvestre.ledru committed rGb9e789447f14: Revert "[clang-format] Fix AlignConsecutive on PP blocks" (authored by sylvestre.ledru).
Revert "[clang-format] Fix AlignConsecutive on PP blocks"
Oct 17 2020, 10:53 AM
sylvestre.ledru added a reverting change for D79388: [clang-format] Fix AlignConsecutive on PP blocks: rGb9e789447f14: Revert "[clang-format] Fix AlignConsecutive on PP blocks".
Oct 17 2020, 10:53 AM · Restricted Project, Restricted Project
sylvestre.ledru closed D89464: Revert "[clang-format] Fix AlignConsecutive on PP blocks".
Oct 17 2020, 10:53 AM · Restricted Project

Oct 16 2020

sylvestre.ledru updated the diff for D89464: Revert "[clang-format] Fix AlignConsecutive on PP blocks".

Add the test which was failing + add the previous tests (but disabled)

Oct 16 2020, 8:41 AM · Restricted Project

Oct 15 2020

sylvestre.ledru added inline comments to D89464: Revert "[clang-format] Fix AlignConsecutive on PP blocks".
Oct 15 2020, 8:03 AM · Restricted Project
sylvestre.ledru added reviewers for D89464: Revert "[clang-format] Fix AlignConsecutive on PP blocks": JakeMerdichAMD, MyDeveloperDay.
Oct 15 2020, 8:03 AM · Restricted Project
sylvestre.ledru added a reverting change for rGb2eb43931757: [clang-format] Fix AlignConsecutive on PP blocks: D89464: Revert "[clang-format] Fix AlignConsecutive on PP blocks".
Oct 15 2020, 7:08 AM
sylvestre.ledru requested review of D89464: Revert "[clang-format] Fix AlignConsecutive on PP blocks".
Oct 15 2020, 7:08 AM · Restricted Project
sylvestre.ledru added a reverting change for D79388: [clang-format] Fix AlignConsecutive on PP blocks: D89464: Revert "[clang-format] Fix AlignConsecutive on PP blocks".
Oct 15 2020, 7:08 AM · Restricted Project, Restricted Project

Oct 13 2020

sylvestre.ledru committed rG002968a32046: [clang-tidy] Add an example for misc-unused-alias-decls (authored by sylvestre.ledru).
[clang-tidy] Add an example for misc-unused-alias-decls
Oct 13 2020, 4:57 AM
sylvestre.ledru closed D89270: [clang-tidy] Add an example for misc-unused-alias-decls.
Oct 13 2020, 4:56 AM · Restricted Project

Oct 12 2020

sylvestre.ledru requested review of D89270: [clang-tidy] Add an example for misc-unused-alias-decls.
Oct 12 2020, 2:36 PM · Restricted Project
sylvestre.ledru added a comment to D79388: [clang-format] Fix AlignConsecutive on PP blocks.

@JakeMerdichAMD as the regression caused by this change is way more significant than the initial bug, I am planning to revert this patch in the next few days (both in master and 11).
Please let me know if you have any objection.

Oct 12 2020, 10:04 AM · Restricted Project, Restricted Project

Oct 8 2020

sylvestre.ledru added a comment to D79388: [clang-format] Fix AlignConsecutive on PP blocks.

@JakeMerdichAMD @MyDeveloperDay Do you know if the regression has been fixed?
thanks

Oct 8 2020, 3:52 AM · Restricted Project, Restricted Project

Oct 7 2020

sylvestre.ledru accepted D88990: Update documentation on stage3 cmake build.
Oct 7 2020, 11:04 AM · Restricted Project, Restricted Project

Sep 21 2020

sylvestre.ledru added a comment to D75791: [clang-format] Added new option IndentExternBlock.

@MarcusJohnson91 I know it is confusing but we don't use the Mozilla coding style. We are using the Google style.

Sep 21 2020, 11:52 PM · Restricted Project, Restricted Project, Restricted Project

Sep 20 2020

sylvestre.ledru added a comment to D75791: [clang-format] Added new option IndentExternBlock.

Any chance this changes could have caused this regression https://bugs.llvm.org/show_bug.cgi?id=47589 ?

Sep 20 2020, 3:24 AM · Restricted Project, Restricted Project, Restricted Project
sylvestre.ledru added a comment to D81272: [clang-tidy] New check `bugprone-redundant-branch-condition`.
Sep 20 2020, 3:11 AM · Restricted Project, Restricted Project

Sep 17 2020

sylvestre.ledru added a comment to D87758: Provide a hook to customize missing library error handling.

I am sure you are planning to do it but please don't forget the release notes and the documentation.

Sep 17 2020, 5:34 AM · Restricted Project

Sep 16 2020

sylvestre.ledru added a comment to D81272: [clang-tidy] New check `bugprone-redundant-branch-condition`.

Thanks for this checker. FYI, it found (at least) 3 defects in Firefox code (fixed with the autofix):
https://hg.mozilla.org/mozilla-central/rev/651e68f628d0

Sep 16 2020, 3:26 AM · Restricted Project, Restricted Project

Sep 9 2020

sylvestre.ledru added a comment to D87187: [Driver] Perform Linux distribution detection just once.

I guess it isn't possible to write tests for this?

Sep 9 2020, 11:30 PM · Restricted Project

Jul 8 2020

sylvestre.ledru committed rGbbea4d5e6b82: clang: Don't show a trailing space with --version when not built from the repo (authored by sylvestre.ledru).
clang: Don't show a trailing space with --version when not built from the repo
Jul 8 2020, 5:02 AM
sylvestre.ledru closed D83386: clang: Don't show a trailing space with --version when not built from the repo.
Jul 8 2020, 5:02 AM · Restricted Project
Herald added a project to D83386: clang: Don't show a trailing space with --version when not built from the repo: Restricted Project.
Jul 8 2020, 4:46 AM · Restricted Project

Jun 22 2020

sylvestre.ledru accepted D81932: [clang-tidy] Improved accuracy of check list updater script.

Excellent, thanks :)

Jun 22 2020, 1:01 AM · Restricted Project

Jun 19 2020

sylvestre.ledru added a comment to D75284: [Sphinx] Adjust for source_parsers deprecation in Sphinx 3.0 .

it breaks the build on Debian stable (and probably some Ubuntu LTS). With sphinx 1.8.4
Could you please revert the change ?

Jun 19 2020, 6:59 AM · Restricted Project

Jun 18 2020

sylvestre.ledru added a comment to D76012: [OpenMP][Tool] Header-only multiplexing of OMPT tools.

@protze.joachim @jdoerfert ompt-multiplex.h is installed by default in /usr/include/
others opemp headers are installed in /usr/include/openmp/

Jun 18 2020, 4:18 AM · Restricted Project
sylvestre.ledru added a comment to D76012: [OpenMP][Tool] Header-only multiplexing of OMPT tools.

maybe this improvement should be added to the release notes too ?

Jun 18 2020, 4:18 AM · Restricted Project
sylvestre.ledru resigned from D66390: [PATCH] [llvm] [Support] Update license on ConvertUTF.* per upstream license change.

I would like to see that happening but I am not a lawyer and important enough person in the project to make such call.

Jun 18 2020, 4:18 AM · Restricted Project
sylvestre.ledru accepted D78867: [docs] avoid 'arc land' command.

works for me
I like "arc land" but I am not opposed to changing the doc

Jun 18 2020, 3:46 AM · Restricted Project
sylvestre.ledru resigned from D34083: fix crash on thumb backend, only visit first and last operands of GEP on ConstantHoisting.
Jun 18 2020, 3:46 AM · Restricted Project
sylvestre.ledru accepted D75284: [Sphinx] Adjust for source_parsers deprecation in Sphinx 3.0 .

thanks!

Jun 18 2020, 3:46 AM · Restricted Project

Jun 4 2020

sylvestre.ledru added a comment to D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function.

@zequanwu could you please update the release notes? thanks
https://github.com/llvm/llvm-project/blob/master/clang/docs/ReleaseNotes.rst

Jun 4 2020, 8:11 AM · Restricted Project

May 29 2020

sylvestre.ledru committed rGa3418631e8aa: libclc: update website url (authored by davidak <davidak@users.noreply.github.com>).
libclc: update website url
May 29 2020, 12:30 AM
sylvestre.ledru committed rGca467542eecf: [CMake] Pass CLANG_VENDOR variables into later stages (authored by sylvestre.ledru).
[CMake] Pass CLANG_VENDOR variables into later stages
May 29 2020, 12:30 AM

May 28 2020

sylvestre.ledru added inline comments to D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project.
May 28 2020, 6:30 AM · Restricted Project, Restricted Project
sylvestre.ledru added a comment to D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project.

Well done!

May 28 2020, 5:57 AM · Restricted Project, Restricted Project

May 18 2020

sylvestre.ledru committed rGdbb034947cc1: Add support of the next Ubuntu (Ubuntu 20.10 - Groovy Gorilla) (authored by sylvestre.ledru).
Add support of the next Ubuntu (Ubuntu 20.10 - Groovy Gorilla)
May 18 2020, 11:57 PM

May 13 2020

sylvestre.ledru updated subscribers of rG13a633b438b6: [gcov] Delete CC1 option -coverage-no-function-names-in-data.

Can you point to me how Firefox uses -Xclang -coverage-no-function-names-in-data? Debian code search does not reveal anything.

May 13 2020, 10:17 AM
sylvestre.ledru updated subscribers of rG13a633b438b6: [gcov] Delete CC1 option -coverage-no-function-names-in-data.
May 13 2020, 4:48 AM
sylvestre.ledru added a comment to rG13a633b438b6: [gcov] Delete CC1 option -coverage-no-function-names-in-data.

@MaskRay Please don't land such patch without review.

May 13 2020, 4:48 AM

May 10 2020

sylvestre.ledru added a comment to D78052: add_new_check.py: Update of the template to add an autofix section.

has been reverted

May 10 2020, 4:47 AM · Restricted Project
sylvestre.ledru reopened D78052: add_new_check.py: Update of the template to add an autofix section.
May 10 2020, 4:47 AM · Restricted Project
sylvestre.ledru reopened D77983: clang-tidy doc: add a note for every checker with an autofix.

has been reverted

May 10 2020, 4:47 AM · Restricted Project
sylvestre.ledru committed rGa832fc4b0c1e: Revert two patches, not ready to be shared (authored by sylvestre.ledru).
Revert two patches, not ready to be shared
May 10 2020, 2:40 AM
sylvestre.ledru added a reverting change for rGdc0f79ea5b99: clang-tidy doc: add a note for checkers with an autofix: rGa832fc4b0c1e: Revert two patches, not ready to be shared.
May 10 2020, 2:40 AM
sylvestre.ledru added a reverting change for rGf97f92e5b0fd: add_new_check.py: Update of the template to add an autofix section: rGa832fc4b0c1e: Revert two patches, not ready to be shared.
May 10 2020, 2:40 AM
sylvestre.ledru committed rGb0828135dbe3: clang-tidy doc: Fix the syntax to use rst list type (authored by sylvestre.ledru).
clang-tidy doc: Fix the syntax to use rst list type
May 10 2020, 2:39 AM
sylvestre.ledru committed rGf97f92e5b0fd: add_new_check.py: Update of the template to add an autofix section (authored by sylvestre.ledru).
add_new_check.py: Update of the template to add an autofix section
May 10 2020, 2:39 AM
sylvestre.ledru committed rGdc0f79ea5b99: clang-tidy doc: add a note for checkers with an autofix (authored by sylvestre.ledru).
clang-tidy doc: add a note for checkers with an autofix
May 10 2020, 2:39 AM
sylvestre.ledru closed D77983: clang-tidy doc: add a note for every checker with an autofix.
May 10 2020, 2:39 AM · Restricted Project
sylvestre.ledru closed D78052: add_new_check.py: Update of the template to add an autofix section.
May 10 2020, 2:39 AM · Restricted Project
sylvestre.ledru added a comment to D78052: add_new_check.py: Update of the template to add an autofix section.

@alexfh ping ? :)

May 10 2020, 2:39 AM · Restricted Project
sylvestre.ledru added a comment to D77983: clang-tidy doc: add a note for every checker with an autofix.

@alexfh ping

May 10 2020, 2:39 AM · Restricted Project

May 1 2020

sylvestre.ledru committed rG68e89c5b9603: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu Add… (authored by sthibaul).
[Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu Add…
May 1 2020, 3:37 AM
sylvestre.ledru committed rGc298e5a02292: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu (authored by sthibaul).
[Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu
May 1 2020, 3:13 AM

Apr 28 2020

sylvestre.ledru added a comment to D78867: [docs] avoid 'arc land' command.

are you sure? D<revision> worked for me in the past

Apr 28 2020, 1:34 AM · Restricted Project

Apr 27 2020

sylvestre.ledru accepted D78909: [clang-format] NFC clang-format the clang-format sources.
Apr 27 2020, 4:15 AM · Restricted Project, Restricted Project

Apr 25 2020

sylvestre.ledru added a comment to D69573: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions.

FYI, in Mozilla build of clang-format, we reverted this change.
It was causing more issues than fixes.
https://bugzilla.mozilla.org/show_bug.cgi?id=1629853

Apr 25 2020, 2:37 AM · Restricted Project, Restricted Project, Restricted Project

Apr 24 2020

sylvestre.ledru accepted D78807: Fix gendered documentation.

thanks!

Apr 24 2020, 5:54 AM · Restricted Project, Restricted Project

Apr 23 2020

sylvestre.ledru accepted D77882: [clang-tidy] Add option to use alpha checkers from clang-analyzer when using `run-clang-tidy.py`.
Apr 23 2020, 1:34 AM · Restricted Project, Restricted Project

Apr 18 2020

sylvestre.ledru added a comment to D77983: clang-tidy doc: add a note for every checker with an autofix.

@alexfh ping

Apr 18 2020, 4:18 AM · Restricted Project
sylvestre.ledru added a comment to D78052: add_new_check.py: Update of the template to add an autofix section.

@alexfh ping ? :)

Apr 18 2020, 4:18 AM · Restricted Project

Apr 17 2020

sylvestre.ledru added a comment to D78332: Fix interaction of static plugins with -DLLVM_LINK_LLVM_DYLIB=ON..

The cmake configure is fixed, thanks.
Running a full build now

Apr 17 2020, 1:02 AM · Restricted Project

Apr 16 2020

sylvestre.ledru updated subscribers of D76866: Enable new passmanager plugin support for LTO..

@eli.friedman @serge-sans-paille
Looks like it caused:
https://bugs.llvm.org/show_bug.cgi?id=45571
breaking builds on Debian & Ubuntu

Apr 16 2020, 2:14 AM · Restricted Project

Apr 14 2020

sylvestre.ledru added a comment to D74669: [clang-tidy] New check: bugprone-suspicious-include.

Firefox uses a unified build model. For better performances in the binary, the C++ files are compiled as the same time from a single file (ex: Unified_cpp_netwerk_base3.cpp) which will include the .cpp files.

Apr 14 2020, 4:45 AM · Restricted Project, Restricted Project

Apr 13 2020

sylvestre.ledru updated the diff for D77983: clang-tidy doc: add a note for every checker with an autofix.

Doing it by hand. @alexfh please let me know if you would be ok with it
(I will do it by hand)

Apr 13 2020, 2:07 PM · Restricted Project
sylvestre.ledru created D78052: add_new_check.py: Update of the template to add an autofix section.
Apr 13 2020, 1:34 PM · Restricted Project
sylvestre.ledru added a comment to D77983: clang-tidy doc: add a note for every checker with an autofix.

Makes sense.
I will give it a try :)
thanks

Apr 13 2020, 7:29 AM · Restricted Project
sylvestre.ledru updated the diff for D77983: clang-tidy doc: add a note for every checker with an autofix.

2 spaces instead of 4

Apr 13 2020, 2:07 AM · Restricted Project

Apr 12 2020

sylvestre.ledru created D77983: clang-tidy doc: add a note for every checker with an autofix.
Apr 12 2020, 4:33 PM · Restricted Project
sylvestre.ledru added a reviewer for D77882: [clang-tidy] Add option to use alpha checkers from clang-analyzer when using `run-clang-tidy.py`: pfultz2.
Apr 12 2020, 3:11 AM · Restricted Project, Restricted Project
sylvestre.ledru added a reviewer for D77882: [clang-tidy] Add option to use alpha checkers from clang-analyzer when using `run-clang-tidy.py`: lebedev.ri.
Apr 12 2020, 3:11 AM · Restricted Project, Restricted Project
sylvestre.ledru added a comment to D77882: [clang-tidy] Add option to use alpha checkers from clang-analyzer when using `run-clang-tidy.py`.

LGTM! thanks

Apr 12 2020, 3:11 AM · Restricted Project, Restricted Project

Apr 11 2020

sylvestre.ledru added a comment to D77882: [clang-tidy] Add option to use alpha checkers from clang-analyzer when using `run-clang-tidy.py`.

please add this to the release notes too :)
something like "new option -allow-enabling-alpha-checkers added to run-clang-tidy to enable alpha checkers"

Apr 11 2020, 11:43 AM · Restricted Project, Restricted Project

Apr 10 2020

sylvestre.ledru added inline comments to D76471: Remap the target SDK directory to the host SDK directory.
Apr 10 2020, 2:08 AM · Restricted Project

Apr 7 2020

sylvestre.ledru added a comment to D77574: [OpenMP] Fix layering problem with FrontendOpenMP.

@lebedev.ri @jdoerfert Looks like it might have caused:
https://bugs.llvm.org/show_bug.cgi?id=45453

Apr 7 2020, 1:03 AM · Restricted Project