Page MenuHomePhabricator
Feed Advanced Search

Jan 4 2021

cchen15 committed rG975b64b29375: [docs] Release notes for IsDecl in DIModule. (authored by cchen15).
[docs] Release notes for IsDecl in DIModule.
Jan 4 2021, 4:06 AM
cchen15 closed D93558: [docs] Release notes for IsDecl in DIModule..
Jan 4 2021, 4:05 AM · Restricted Project

Dec 18 2020

cchen15 updated the diff for D93558: [docs] Release notes for IsDecl in DIModule..

Updated the test filename to reflect the change made in D93559.

Dec 18 2020, 1:17 PM · Restricted Project
cchen15 committed rG08c4b4054b3d: Rename files with same (case insensitive) name (authored by cchen15).
Rename files with same (case insensitive) name
Dec 18 2020, 1:05 PM
cchen15 closed D93559: Rename files with same (case insensitive) name.
Dec 18 2020, 1:04 PM · Restricted Project
cchen15 added a comment to D93559: Rename files with same (case insensitive) name.

Thanks a lot, Aditya. Again, my apologies for the screw-up. I will make sure I won't make the same mistake next time I add a new file.

Dec 18 2020, 12:09 PM · Restricted Project
cchen15 added a comment to D93462: [DebugInfo] Support Fortran 'use <external module>' statement..
In D93462#2463742, @gkm wrote:

@cchen15 @SouraVX @aprantl

This diff breaks git source trees on case-insensitive filesystems, such as on macOS.
I did this on Linux, which is case-sensitive:

$ find . |fgrep -i llvm/test/DebugInfo/X86/DIModule.ll
./llvm/test/DebugInfo/X86/DIModule.ll
./llvm/test/DebugInfo/X86/dimodule.ll

On a case-insensitive filesystem, these names collide and one overwrites the other, yeilding a tree with irreconcilable conflicts.

Please fix ASAP! Thanx!

Dec 18 2020, 11:58 AM · debug-info, Restricted Project
cchen15 added a comment to D93559: Rename files with same (case insensitive) name.

Thanks for catching this for me. I don't work on Mac. :(

Dec 18 2020, 11:54 AM · Restricted Project
cchen15 requested review of D93558: [docs] Release notes for IsDecl in DIModule..
Dec 18 2020, 11:36 AM · Restricted Project
cchen15 committed rG5f75dcf5719f: [DebugInfo] Support Fortran 'use <external module>' statement. (authored by cchen15).
[DebugInfo] Support Fortran 'use <external module>' statement.
Dec 18 2020, 10:12 AM
cchen15 closed D93462: [DebugInfo] Support Fortran 'use <external module>' statement..
Dec 18 2020, 10:11 AM · debug-info, Restricted Project
cchen15 added a comment to D93462: [DebugInfo] Support Fortran 'use <external module>' statement..

LGTM! Thanks for the patch.
One small thing, do you mind adding a one liner to release notes ? It would help in tracking extensions to Debug Metadata(previous extensions of DIModule were part of LLVM11).

Dec 18 2020, 5:30 AM · debug-info, Restricted Project

Dec 17 2020

cchen15 requested review of D93462: [DebugInfo] Support Fortran 'use <external module>' statement..
Dec 17 2020, 8:29 AM · debug-info, Restricted Project

Dec 8 2020

cchen15 committed rG1f67247eea13: [DebugInfo] Add handling of stringLengthExp operand of DIStringType. (authored by cchen15).
[DebugInfo] Add handling of stringLengthExp operand of DIStringType.
Dec 8 2020, 11:50 AM
cchen15 closed D92412: [DebugInfo] Add handling of stringLengthExp operand of DIStringType.
Dec 8 2020, 11:50 AM · debug-info, Restricted Project

Dec 7 2020

cchen15 added a comment to D92412: [DebugInfo] Add handling of stringLengthExp operand of DIStringType.
Dec 7 2020, 3:45 AM · debug-info, Restricted Project

Dec 3 2020

cchen15 added a watcher for debug-info: cchen15.
Dec 3 2020, 12:20 PM
cchen15 added inline comments to D92412: [DebugInfo] Add handling of stringLengthExp operand of DIStringType.
Dec 3 2020, 9:38 AM · debug-info, Restricted Project
cchen15 updated the diff for D92412: [DebugInfo] Add handling of stringLengthExp operand of DIStringType.

Made changes based on the review comments.

Dec 3 2020, 9:35 AM · debug-info, Restricted Project
cchen15 updated the summary of D92412: [DebugInfo] Add handling of stringLengthExp operand of DIStringType.
Dec 3 2020, 9:34 AM · debug-info, Restricted Project

Dec 1 2020

cchen15 added inline comments to D92412: [DebugInfo] Add handling of stringLengthExp operand of DIStringType.
Dec 1 2020, 11:21 AM · debug-info, Restricted Project
cchen15 requested review of D92412: [DebugInfo] Add handling of stringLengthExp operand of DIStringType.
Dec 1 2020, 11:19 AM · debug-info, Restricted Project

Oct 28 2020

cchen15 added inline comments to D90323: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder..
Oct 28 2020, 1:32 PM · Restricted Project
cchen15 added a comment to D90323: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder..
Oct 28 2020, 11:13 AM · Restricted Project
cchen15 requested review of D90323: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder..
Oct 28 2020, 11:07 AM · Restricted Project

Oct 26 2020

cchen15 added inline comments to D89817: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder..
Oct 26 2020, 1:05 PM · Restricted Project
cchen15 updated the diff for D89817: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder..

Typed the attributes as PointerUnion<DIExpression *, DIVariable *>, and updated the test to exercise the DIVariable case.

Oct 26 2020, 1:02 PM · Restricted Project
cchen15 added a comment to D89817: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder..

We can do that, but then the debugger would need to work a bit harder in order to get a constant, doesn't it? I don't feel strongly either way. If you do want it done the way you prefer, please let me know and I will make the change.

That's an interesting point. Do we emit different DWARF FORMs for constant vs constant DIExpression? An elegant solution would be to recognize constant DIExpressions in AsmPrinter (DIExpression::isConstant) and emit the same DWARF FORM we would emit for an IR constant if the expression is a constant.

Oct 26 2020, 12:59 PM · Restricted Project

Oct 23 2020

cchen15 updated the diff for D89817: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder..

Reverted back to type those attributes as Metadata to allow DIVairbale.

Oct 23 2020, 4:04 AM · Restricted Project

Oct 22 2020

cchen15 added a comment to D89817: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder..

Also, DIBuilder::createConstantValueExpression(uint64_t) is already available for doing constant via DIExpression,, and its usage is demonstrated in the unit test.

Oct 22 2020, 1:42 PM · Restricted Project
cchen15 updated the diff for D89817: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder..

Typed the attributes as DIExpression*, as suggested by @aprantl.

Oct 22 2020, 1:39 PM · Restricted Project
cchen15 added a comment to D89817: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder..

These can be DIExpression, ConstantAsMetadata, etc, so Metadata looks to be the right specificity (and the underlying 'get' function it calls types them as Metadata too).

Why do we need to accept both DIExpression and ConstantAsMetadata? Since we can also represent all constants as DIExpression, I think I would prefer to have only one way to represent a constant. Would it be feasible to expect clients to pass constants as DIExpression(DW_OP_constu, <number>, DW_OP_stack_value)? And if it doesn't already exist perhaps add a DIExpression *DIBuilder::createConstantExpression(unsigned value) API?

Oct 22 2020, 10:49 AM · Restricted Project

Oct 21 2020

cchen15 updated the diff for D89817: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder..

Including the rank attribute in the patch.

Oct 21 2020, 9:19 AM · Restricted Project
cchen15 updated the diff for D89817: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder..

Added a unit test for the patch.

Oct 21 2020, 8:29 AM · Restricted Project
cchen15 added a comment to D89817: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder..

Sorry. Please ignore Patch 2.

Oct 21 2020, 6:04 AM · Restricted Project
cchen15 updated the diff for D89817: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder..

Per review comments, fixed/enhanced the description of createTypeArray.

Oct 21 2020, 6:03 AM · Restricted Project
cchen15 updated the diff for D89817: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder..

Per review comments, fixed/enhanced the description of createArrayType.

Oct 21 2020, 5:59 AM · Restricted Project
cchen15 added a comment to D89817: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder..

Regarding test: Does the test idea laid out in my opening comment sound reasonable?

Oct 21 2020, 3:54 AM · Restricted Project

Oct 20 2020

cchen15 added a comment to D89817: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder..

I'd appreciate some guidance on what test to add for this change. Would it be sufficient to have a unittest that calls createArrayType to create a DICompositeType, and then get the three new attributes back from the DICompositeType using the getRaw* functions to check that they match with the arguments to the createArrayType call? Thanks.

Oct 20 2020, 12:45 PM · Restricted Project
cchen15 requested review of D89817: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder..
Oct 20 2020, 12:40 PM · Restricted Project