Page MenuHomePhabricator
Feed Advanced Search

Today

kadircet accepted D88567: [clangd] Fix invalid UTF8 when extracting doc comments..

Should we also have another test for SymbolCollector, to ensure we don't regress this somehow in the future?

Wed, Sep 30, 6:57 AM · Restricted Project
kadircet added a reviewer for D88502: [llvm][Support] Delete unused is_absolute_gnu helper: tinti.

Hi @tinti this code seems to be recently introduced without any usage, and as pointed out by @certl it doesn't consider multi-byte drive letters.

Wed, Sep 30, 4:45 AM · Restricted Project
kadircet committed rG64e8fd540ecc: [clangd][remote] Make sure relative paths are absolute with respect to posix… (authored by kadircet).
[clangd][remote] Make sure relative paths are absolute with respect to posix…
Wed, Sep 30, 2:09 AM
kadircet closed D88507: [clangd][remote] Make sure relative paths are absolute with respect to posix style.
Wed, Sep 30, 2:08 AM · Restricted Project

Yesterday

kadircet accepted D88297: [clangd] Trivial setter support when moving items to fields.
Tue, Sep 29, 12:28 PM · Restricted Project
kadircet committed rG962a247aebba: [clangd] Fix assertion in remote-index marshalling (authored by kadircet).
[clangd] Fix assertion in remote-index marshalling
Tue, Sep 29, 11:41 AM
kadircet requested review of D88507: [clangd][remote] Make sure relative paths are absolute with respect to posix style.
Tue, Sep 29, 11:16 AM · Restricted Project
kadircet requested review of D88502: [llvm][Support] Delete unused is_absolute_gnu helper.
Tue, Sep 29, 10:19 AM · Restricted Project
kadircet added a comment to D88338: [clangd] clangd --check: standalone diagnosis of common problems.

thanks! this mostly looks good, as discussed offline I believe having an infra that we can improve over time is better than not having anything until we've got the "perfect" solution.

Tue, Sep 29, 4:05 AM · Restricted Project

Mon, Sep 28

kadircet requested review of D88417: [clangd] Record memory usages after each notification.
Mon, Sep 28, 7:33 AM · Restricted Project
kadircet requested review of D88415: [clangd] Introduce memory usage dumping to TUScheduler, for Preambles and ASTCache.
Mon, Sep 28, 6:39 AM · Restricted Project
kadircet requested review of D88414: [clangd] Introduce memory dumping to FileIndex, FileSymbols and BackgroundIndex.
Mon, Sep 28, 6:18 AM · Restricted Project
kadircet requested review of D88413: [clangd] Add a metric for tracking memory usage.
Mon, Sep 28, 6:17 AM · Restricted Project
kadircet requested review of D88411: [clangd] Introduce MemoryTrees.
Mon, Sep 28, 6:01 AM · Restricted Project

Fri, Sep 25

kadircet added inline comments to D88297: [clangd] Trivial setter support when moving items to fields.
Fri, Sep 25, 6:42 AM · Restricted Project

Thu, Sep 24

kadircet requested review of D88204: [clangd] Drop path suffix mapping for std symbols.
Thu, Sep 24, 2:06 AM · Restricted Project
kadircet committed rG64168c6d996b: [clangd] Disable suffix matching fallback for C during include insertion (authored by kadircet).
[clangd] Disable suffix matching fallback for C during include insertion
Thu, Sep 24, 1:46 AM
kadircet closed D88144: [clangd] Disable suffix matching fallback for C during include insertion.
Thu, Sep 24, 1:46 AM · Restricted Project
kadircet added a comment to D88144: [clangd] Disable suffix matching fallback for C during include insertion.

(I do wonder whether it's safe to just drop the mapping table entirely now...)

Thu, Sep 24, 1:45 AM · Restricted Project

Wed, Sep 23

kadircet added a comment to D87891: [clangd] findNearbyIdentifier(): guaranteed to give up after 2^N lines.

Hey! Sorry for the late reply, this has been open in my tabs since day 1 just didn't get a chance to take a look at it.

Wed, Sep 23, 11:49 PM · Restricted Project
kadircet requested review of D88144: [clangd] Disable suffix matching fallback for C during include insertion.
Wed, Sep 23, 5:32 AM · Restricted Project
kadircet accepted D88103: [JSON] Add error reporting facility, used in fromJSON and ObjectMapper..

Thanks! This looks great. I've mostly did the full review anyway but feel free to land in small patches just in case some compiler becomes upset and you need to revert.

Wed, Sep 23, 4:57 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Sep 21

kadircet planned changes to D86077: [clangd] Add a way for exporting memory usage metrics.

Just for the record, as I think Kadir and Adam are both aware...

We discussed making this a bit richer and less reliant on static state.
We'd build a tree-shaped profile by passing a tree-builder recursively into various components.
Then the metrics would be exported at the top level, but we'd also want to expose it via debugging actions. (The tree edges from e.g. dynamic index to individual files would probably be optional - collapsed for metrics but present for debugging)

LMK if I have this wrong and you want to move forward with a simpler approch.

Mon, Sep 21, 1:46 AM · Restricted Project
kadircet added inline comments to D87256: [clangd] Avoid relations being overwritten in a header shard.
Mon, Sep 21, 1:30 AM · Restricted Project

Wed, Sep 16

kadircet accepted D87450: [clangd] Implement hot index reloading for clangd-index-server.

Thanks, LGTM!

Wed, Sep 16, 2:02 AM · Restricted Project
kadircet added inline comments to D87450: [clangd] Implement hot index reloading for clangd-index-server.
Wed, Sep 16, 1:36 AM · Restricted Project

Tue, Sep 15

kadircet added a comment to D87710: [clangd] Actually parse Index section of the YAML file..

oh shoot, thanks for catching this. i'll leave the stamp to sam, just came here to remind that this needs to be cherry-picked into release branch :/

Tue, Sep 15, 2:33 PM · Restricted Project
kadircet added a comment to D87450: [clangd] Implement hot index reloading for clangd-index-server.

oops, looks like i forgot to hit submit in the morning..

Tue, Sep 15, 2:25 PM · Restricted Project
kadircet added a comment to D87450: [clangd] Implement hot index reloading for clangd-index-server.

Thanks! Mostly looks good, just couple of nits.

Tue, Sep 15, 3:22 AM · Restricted Project

Mon, Sep 14

kadircet committed rG574dd6054717: [clangd] Track tweaks that fail the apply stage (authored by kadircet).
[clangd] Track tweaks that fail the apply stage
Mon, Sep 14, 2:24 AM
kadircet closed D87501: [clangd] Track tweaks that fail the apply stage.
Mon, Sep 14, 2:24 AM · Restricted Project
kadircet added inline comments to D87450: [clangd] Implement hot index reloading for clangd-index-server.
Mon, Sep 14, 1:54 AM · Restricted Project

Fri, Sep 11

kadircet requested review of D87501: [clangd] Track tweaks that fail the apply stage.
Fri, Sep 11, 2:41 AM · Restricted Project
kadircet committed rGbceca7a99624: [clangd][NFC] Get rid of an `else after return` (authored by kadircet).
[clangd][NFC] Get rid of an `else after return`
Fri, Sep 11, 2:32 AM
kadircet added inline comments to D87450: [clangd] Implement hot index reloading for clangd-index-server.
Fri, Sep 11, 2:22 AM · Restricted Project

Wed, Sep 9

kadircet added a comment to D87244: [clang] Add fix-it for -Wreorder-ctor..

thanks, comments around some implementations. the only high level question i have is about the choice of location for fix-it (see the detailed comment inline)

Wed, Sep 9, 3:00 AM · Restricted Project

Tue, Sep 8

kadircet added a comment to D87253: [libTooling] Change CDB heuristic to look further for files in a given language..

As discussed offline, this is trading off some accuracy between getting -I correct vs -std and it is unclear whether that's beneficial or harmful. It is easy to come up with examples for both and we were split 50/50 between each.
In the end all of this is a heuristic work and it is quite likely that we might break this for more people, while trying to fix this one specific case. So I don't think it's worth it.

Tue, Sep 8, 9:46 AM · Restricted Project

Aug 20 2020

kadircet accepted D86279: [clangd] Don't crash on `#pragma clang __debug parser_crash`.

thanks, lgtm!

Aug 20 2020, 5:32 AM · Restricted Project

Aug 17 2020

kadircet added inline comments to D83536: [clangd] Index refs to main-file symbols as well.
Aug 17 2020, 9:40 AM · Restricted Project
kadircet updated the diff for D86077: [clangd] Add a way for exporting memory usage metrics.
  • Rename the overload
  • Add comments around possible caveats that might result in inaccuracies.
  • Move the metric recording itself into another thread.
  • Keep the calculations in the main thread, as they seemed to have <1ms latency, even with huge preambles/asts.
Aug 17 2020, 9:17 AM · Restricted Project
kadircet added inline comments to D86077: [clangd] Add a way for exporting memory usage metrics.
Aug 17 2020, 9:17 AM · Restricted Project
kadircet added inline comments to D86077: [clangd] Add a way for exporting memory usage metrics.
Aug 17 2020, 8:07 AM · Restricted Project
kadircet requested review of D86077: [clangd] Add a way for exporting memory usage metrics.
Aug 17 2020, 7:20 AM · Restricted Project
kadircet committed rG53c593c2c893: [clang] Make signature help work with dependent args (authored by kadircet).
[clang] Make signature help work with dependent args
Aug 17 2020, 1:15 AM
kadircet closed D85826: [clang] Make signature help work with dependent args.
Aug 17 2020, 1:15 AM · Restricted Project
kadircet added inline comments to D85826: [clang] Make signature help work with dependent args.
Aug 17 2020, 1:06 AM · Restricted Project
kadircet accepted D83536: [clangd] Index refs to main-file symbols as well.

thanks, LGTM!

Aug 17 2020, 1:01 AM · Restricted Project

Aug 13 2020

kadircet committed rG0464acd0197c: [clangd] Move clang-tidy check modifications into ClangdServer (authored by kadircet).
[clangd] Move clang-tidy check modifications into ClangdServer
Aug 13 2020, 9:34 AM
kadircet committed rG66a2e3a52564: [clangd] Send EOF before resetting diagnostics consumer (authored by kadircet).
[clangd] Send EOF before resetting diagnostics consumer
Aug 13 2020, 9:34 AM
kadircet closed D83224: [clangd] Move clang-tidy check modifications into ClangdServer.
Aug 13 2020, 9:34 AM · Restricted Project
kadircet closed D83178: [clangd] Send EOF before resetting diagnostics consumer.
Aug 13 2020, 9:33 AM · Restricted Project
kadircet updated the diff for D83224: [clangd] Move clang-tidy check modifications into ClangdServer.
  • Address comments
Aug 13 2020, 8:47 AM · Restricted Project
kadircet added inline comments to D83224: [clangd] Move clang-tidy check modifications into ClangdServer.
Aug 13 2020, 8:47 AM · Restricted Project
kadircet added a comment to D85883: [clangd] Add ClangdServer::customAction() extension point.

no I am totally fine with the change. I just wanted to give Adam some time to take a look too :D

Aug 13 2020, 5:27 AM · Restricted Project
kadircet added a comment to D85883: [clangd] Add ClangdServer::customAction() extension point.

mostly looks good to me, as discussed offline I would rather expose AST within a thread, both to keep the API changes to a minimum in the future and possibly indicating the "view-ness" of the exposed structs like AST more explicitly.

Aug 13 2020, 3:01 AM · Restricted Project

Aug 12 2020

kadircet added inline comments to D83224: [clangd] Move clang-tidy check modifications into ClangdServer.
Aug 12 2020, 11:21 AM · Restricted Project
kadircet updated the diff for D85826: [clang] Make signature help work with dependent args.
  • Change logic to find all signatures without any dependent args and post filter non-viable overloads using the argument counts.
Aug 12 2020, 11:07 AM · Restricted Project
kadircet added inline comments to D85826: [clang] Make signature help work with dependent args.
Aug 12 2020, 9:59 AM · Restricted Project
kadircet updated the diff for D85826: [clang] Make signature help work with dependent args.
  • Fix typo in comment
Aug 12 2020, 9:35 AM · Restricted Project
kadircet updated the diff for D85826: [clang] Make signature help work with dependent args.
  • Add tests into clang-lit
  • Make sure current number of args is less than overloads param count.
Aug 12 2020, 9:34 AM · Restricted Project
kadircet added inline comments to D85753: [clangd] Discard diagnostics from another SourceManager..
Aug 12 2020, 6:21 AM · Restricted Project
kadircet added inline comments to D83224: [clangd] Move clang-tidy check modifications into ClangdServer.
Aug 12 2020, 3:38 AM · Restricted Project
kadircet accepted D85789: [Parser] Suppress -Wempty-translation-unit if this is a header file.
Aug 12 2020, 3:35 AM · Restricted Project
kadircet requested review of D85826: [clang] Make signature help work with dependent args.
Aug 12 2020, 3:33 AM · Restricted Project

Aug 11 2020

kadircet added inline comments to D85753: [clangd] Discard diagnostics from another SourceManager..
Aug 11 2020, 12:22 PM · Restricted Project
kadircet added a comment to D83536: [clangd] Index refs to main-file symbols as well.

thanks, lgtm. mostly comments arounds tests, sorry for not looking at them before.

Aug 11 2020, 7:22 AM · Restricted Project
kadircet committed rGea8e71c3da56: [clang][HeaderInsert] Do not treat defines with values as header guards (authored by kadircet).
[clang][HeaderInsert] Do not treat defines with values as header guards
Aug 11 2020, 7:09 AM
kadircet closed D85590: [clang][HeaderInsert] Do not treat defines with values as header guards.
Aug 11 2020, 7:09 AM · Restricted Project
kadircet updated the diff for D85590: [clang][HeaderInsert] Do not treat defines with values as header guards.
  • Move new test closer to other FakeHeaderGuard tests.
Aug 11 2020, 7:02 AM · Restricted Project
kadircet committed rG24a816c7d392: [clangd] Disable ExtractFunction for C (authored by kadircet).
[clangd] Disable ExtractFunction for C
Aug 11 2020, 7:01 AM
kadircet committed rGb626f45329e8: [clangd] Unify macro matching in code completion for AST and Index based macros (authored by kadircet).
[clangd] Unify macro matching in code completion for AST and Index based macros
Aug 11 2020, 7:01 AM
kadircet closed D85727: [clangd] Disable ExtractFunction for C.
Aug 11 2020, 7:00 AM · Restricted Project
kadircet closed D85721: [clangd] Unify macro matching in code completion for AST and Index based macros.
Aug 11 2020, 7:00 AM · Restricted Project
kadircet updated the diff for D85721: [clangd] Unify macro matching in code completion for AST and Index based macros.
  • Drop the comment
Aug 11 2020, 6:54 AM · Restricted Project
kadircet requested review of D85727: [clangd] Disable ExtractFunction for C.
Aug 11 2020, 6:04 AM · Restricted Project
kadircet requested review of D85721: [clangd] Unify macro matching in code completion for AST and Index based macros.
Aug 11 2020, 4:32 AM · Restricted Project

Aug 10 2020

kadircet accepted D85532: Correctly set CompilingPCH in PrecompilePreambleAction..

thanks, lgtm!

Aug 10 2020, 6:09 AM · Restricted Project
kadircet added inline comments to D83536: [clangd] Index refs to main-file symbols as well.
Aug 10 2020, 2:43 AM · Restricted Project

Aug 8 2020

kadircet requested review of D85590: [clang][HeaderInsert] Do not treat defines with values as header guards.
Aug 8 2020, 4:03 PM · Restricted Project

Aug 7 2020

kadircet accepted D85502: [clangd] Add more error details on the remote index server side.

LGTM

Aug 7 2020, 3:39 PM · Restricted Project
kadircet added a comment to D85532: Correctly set CompilingPCH in PrecompilePreambleAction..

Regarding tests, it feels like we can also test this in ASTUnitTests which is directly in clang, as it is also using PrecompiledPreamble::Build. What about moving the test there instead?

Aug 7 2020, 9:24 AM · Restricted Project

Aug 5 2020

kadircet requested review of D85354: [clangd] Reduce availability of extract function.
Aug 5 2020, 1:22 PM · Restricted Project
kadircet committed rG618db6803d6c: [clangd][NFC] Delete dead code in ExtractFunction code action (authored by kadircet).
[clangd][NFC] Delete dead code in ExtractFunction code action
Aug 5 2020, 12:15 PM
kadircet committed rGd3ac30188666: [clangd] Disable define out-of-line code action on templates (authored by kadircet).
[clangd] Disable define out-of-line code action on templates
Aug 5 2020, 12:01 PM
kadircet closed D85310: [clangd] Disable define out-of-line code action on templates.
Aug 5 2020, 12:01 PM · Restricted Project
kadircet added a comment to D85318: [clangd] Hide "swap if branch" tweak.

you might want this to be cherry-picked into 11 release

Aug 5 2020, 9:27 AM · Restricted Project
kadircet accepted D85318: [clangd] Hide "swap if branch" tweak.
Aug 5 2020, 9:26 AM · Restricted Project
kadircet added a comment to D85253: [clangd] Show correct hover tooltip for non-preamble macro definition..

I'm not quite sure there should be no tooltip for a #define. Such tooltip is not really useful, but at the same time clangd shows tooltips for function declarations/defnitions, namespaces, variables, etc. and not showing it for macro definition will be a little bit inconsistent from my point of view.

Aug 5 2020, 9:19 AM · Restricted Project
kadircet updated the diff for D85310: [clangd] Disable define out-of-line code action on templates.
  • Address comments
Aug 5 2020, 9:07 AM · Restricted Project
kadircet added inline comments to D85310: [clangd] Disable define out-of-line code action on templates.
Aug 5 2020, 9:07 AM · Restricted Project
kadircet committed rG011732852c2c: [clangd] Fix a crash in DefineInline (authored by kadircet).
[clangd] Fix a crash in DefineInline
Aug 5 2020, 8:38 AM
kadircet closed D85291: [clangd] Fix a crash in DefineInline.
Aug 5 2020, 8:38 AM · Restricted Project
kadircet requested review of D85310: [clangd] Disable define out-of-line code action on templates.
Aug 5 2020, 7:22 AM · Restricted Project
kadircet requested review of D85291: [clangd] Fix a crash in DefineInline.
Aug 5 2020, 4:34 AM · Restricted Project
kadircet added a comment to D85253: [clangd] Show correct hover tooltip for non-preamble macro definition..

Sigh, (I think) this is working for macros defined in preamble region as a side effect of preamble being loaded separately and before anything in the main file. E.g.

Aug 5 2020, 3:27 AM · Restricted Project

Aug 3 2020

kadircet committed rG76c3ec814dec: [clang][Tooling] Optimize addTargetAndMode in case of invalid modes (authored by kadircet).
[clang][Tooling] Optimize addTargetAndMode in case of invalid modes
Aug 3 2020, 5:01 AM
kadircet closed D85077: [clang][Tooling] Optimize addTargetAndMode in case of invalid modes.
Aug 3 2020, 5:01 AM · Restricted Project
kadircet updated the diff for D85077: [clang][Tooling] Optimize addTargetAndMode in case of invalid modes.
  • Change bitwise assignment to logical operators, as bitwise operators do not have short-circuting.
Aug 3 2020, 4:51 AM · Restricted Project
kadircet updated the diff for D85077: [clang][Tooling] Optimize addTargetAndMode in case of invalid modes.
  • Rename AlreadyHas to ShouldAdd (and revert the logic)
Aug 3 2020, 2:58 AM · Restricted Project
kadircet committed rG87de54dbb6ef: [clang][Tooling] Fix addTargetAndModeForProgramName to use correct flag names (authored by kadircet).
[clang][Tooling] Fix addTargetAndModeForProgramName to use correct flag names
Aug 3 2020, 2:47 AM