Page MenuHomePhabricator
Feed Advanced Search

Oct 25 2020

xiangzhangllvm updated the summary of D86673: [StackColoring] Conservatively merge point pV = &(&Variable) in catch(Variable).
Oct 25 2020, 6:59 PM · Restricted Project
xiangzhangllvm updated the diff for D86673: [StackColoring] Conservatively merge point pV = &(&Variable) in catch(Variable).
Oct 25 2020, 6:58 PM · Restricted Project

Oct 24 2020

xiangzhangllvm added a comment to D89178: [X86] Alternate implementation of D88194..

Are we ok with this implementation?

I don't have a great way to protect intrinsics not using TargetConstant properly in the future, but I think we're ok at the moment based on what I see in the isel table.

Oct 24 2020, 11:36 PM · Restricted Project

Oct 21 2020

xiangzhangllvm added a comment to D88631: [X86] Support customizing stack protector guard.

TKS all review!!

Oct 21 2020, 7:11 PM · Restricted Project, Restricted Project
xiangzhangllvm committed rG7c3fea7721e4: [X86] Support customizing stack protector guard (authored by xiangzhangllvm).
[X86] Support customizing stack protector guard
Oct 21 2020, 7:09 PM
xiangzhangllvm closed D88631: [X86] Support customizing stack protector guard.
Oct 21 2020, 7:08 PM · Restricted Project, Restricted Project

Oct 20 2020

xiangzhangllvm updated the diff for D88631: [X86] Support customizing stack protector guard.
Oct 20 2020, 6:48 PM · Restricted Project, Restricted Project

Oct 19 2020

xiangzhangllvm added inline comments to D88631: [X86] Support customizing stack protector guard.
Oct 19 2020, 5:17 PM · Restricted Project, Restricted Project
xiangzhangllvm added inline comments to D88631: [X86] Support customizing stack protector guard.
Oct 19 2020, 1:36 AM · Restricted Project, Restricted Project

Oct 18 2020

xiangzhangllvm updated the diff for D88631: [X86] Support customizing stack protector guard.
Oct 18 2020, 7:49 PM · Restricted Project, Restricted Project
xiangzhangllvm added inline comments to D88631: [X86] Support customizing stack protector guard.
Oct 18 2020, 7:46 PM · Restricted Project, Restricted Project

Oct 15 2020

xiangzhangllvm added a comment to D88631: [X86] Support customizing stack protector guard.

TKS for reviewing!

Oct 15 2020, 11:45 PM · Restricted Project, Restricted Project
xiangzhangllvm updated the diff for D88631: [X86] Support customizing stack protector guard.
Oct 15 2020, 11:34 PM · Restricted Project, Restricted Project
xiangzhangllvm added a comment to D88631: [X86] Support customizing stack protector guard.

ping

Oct 15 2020, 12:12 AM · Restricted Project, Restricted Project

Oct 12 2020

xiangzhangllvm added a comment to D88194: [X86] CET endbr enhance.

Thanks for your reviews! Please let me suspend this patch first.

Oct 12 2020, 2:12 AM · Restricted Project

Oct 9 2020

xiangzhangllvm added inline comments to D89178: [X86] Alternate implementation of D88194..
Oct 9 2020, 9:59 PM · Restricted Project
xiangzhangllvm added a comment to D88194: [X86] CET endbr enhance.

Ok, I don't have any other questions/comments (other than it would still be helpful to reduce/pre-commit the tests).

Oct 9 2020, 6:42 PM · Restricted Project
xiangzhangllvm updated the diff for D88194: [X86] CET endbr enhance.
Oct 9 2020, 6:40 PM · Restricted Project
xiangzhangllvm committed rG0232f2d36d0a: [X86] Add CET test, NFC (authored by xiangzhangllvm).
[X86] Add CET test, NFC
Oct 9 2020, 6:13 PM
xiangzhangllvm added a comment to D88194: [X86] CET endbr enhance.

Hello @spatel, Sorrry, I don't much understand the "reduce/pre-commit tests",
did you mean the test here "cet_endbr_imm_enhance.ll" should be merge into other existing test ?

Oct 9 2020, 5:10 PM · Restricted Project

Oct 8 2020

xiangzhangllvm added a comment to D88194: [X86] CET endbr enhance.

@spatel thank you very much for your review! and very sorry for the later update!
CET stands for Intel Control-flow Enforcement Technology, which was designed by H.J. and has already implemented in llvm and gcc. Now it can be googled out.
CET adds an Indirect Branch Tracking capability (by inserting Endbr instruction at the destination of the indirect branch) to provide software the ability to restrict COP/JOP attacks.

Oct 8 2020, 2:02 AM · Restricted Project
xiangzhangllvm updated the diff for D88194: [X86] CET endbr enhance.
Oct 8 2020, 1:52 AM · Restricted Project
xiangzhangllvm updated the diff for D88194: [X86] CET endbr enhance.
Oct 8 2020, 1:33 AM · Restricted Project

Oct 7 2020

xiangzhangllvm added a comment to D88631: [X86] Support customizing stack protector guard.

@nickdesaulniers thank you very much for your guide!
Sorry for the later update, I take a travel these days.

Oct 7 2020, 6:09 PM · Restricted Project, Restricted Project
xiangzhangllvm updated the diff for D88631: [X86] Support customizing stack protector guard.
Oct 7 2020, 6:03 PM · Restricted Project, Restricted Project

Oct 1 2020

xiangzhangllvm added a comment to D88631: [X86] Support customizing stack protector guard.

@Craig and MaskRay , thank you very much for your careful reviews !!

Oct 1 2020, 1:51 AM · Restricted Project, Restricted Project
xiangzhangllvm updated the diff for D88631: [X86] Support customizing stack protector guard.
Oct 1 2020, 1:41 AM · Restricted Project, Restricted Project

Sep 30 2020

xiangzhangllvm added a reviewer for D88631: [X86] Support customizing stack protector guard: MaskRay.
Sep 30 2020, 8:05 PM · Restricted Project, Restricted Project
xiangzhangllvm added a reviewer for D88631: [X86] Support customizing stack protector guard: wxiao3.
Sep 30 2020, 7:59 PM · Restricted Project, Restricted Project
xiangzhangllvm requested review of D88631: [X86] Support customizing stack protector guard.
Sep 30 2020, 7:57 PM · Restricted Project, Restricted Project
xiangzhangllvm added a comment to D88194: [X86] CET endbr enhance.

I tend not do it for -O0, most projects/libs not use -O0 to build.
This is not a bug, we just refine the CET.

Sep 30 2020, 6:41 PM · Restricted Project
xiangzhangllvm added a comment to D88194: [X86] CET endbr enhance.

Hello Craig, could you help accept, TKS!

Sep 30 2020, 5:05 PM · Restricted Project
xiangzhangllvm committed rG413577a87904: [X86] Support Intel Key Locker (authored by xiangzhangllvm).
[X86] Support Intel Key Locker
Sep 30 2020, 3:09 AM
xiangzhangllvm closed D88398: [X86] Support Intel Key Locker.
Sep 30 2020, 3:09 AM · Restricted Project, Restricted Project

Sep 29 2020

xiangzhangllvm added inline comments to D88398: [X86] Support Intel Key Locker.
Sep 29 2020, 11:04 PM · Restricted Project, Restricted Project
xiangzhangllvm updated the diff for D88398: [X86] Support Intel Key Locker.
Sep 29 2020, 11:03 PM · Restricted Project, Restricted Project

Sep 28 2020

xiangzhangllvm requested review of D88398: [X86] Support Intel Key Locker.
Sep 28 2020, 2:17 AM · Restricted Project, Restricted Project
xiangzhangllvm added inline comments to D88194: [X86] CET endbr enhance.
Sep 28 2020, 12:23 AM · Restricted Project
xiangzhangllvm updated the diff for D88194: [X86] CET endbr enhance.
Sep 28 2020, 12:21 AM · Restricted Project

Sep 27 2020

xiangzhangllvm added inline comments to D88194: [X86] CET endbr enhance.
Sep 27 2020, 6:27 PM · Restricted Project
xiangzhangllvm updated the diff for D88194: [X86] CET endbr enhance.
Sep 27 2020, 6:25 PM · Restricted Project

Sep 24 2020

xiangzhangllvm added a comment to D88194: [X86] CET endbr enhance.

Done, TKS !!

Sep 24 2020, 2:35 AM · Restricted Project
xiangzhangllvm updated the diff for D88194: [X86] CET endbr enhance.
Sep 24 2020, 2:34 AM · Restricted Project

Sep 23 2020

xiangzhangllvm requested review of D88194: [X86] CET endbr enhance.
Sep 23 2020, 6:55 PM · Restricted Project

Sep 8 2020

xiangzhangllvm added a comment to D87320: [X86] Check if call is indirect before emitting NT_CALL.

Should we add a test here ?

Sep 8 2020, 5:51 PM · Restricted Project

Aug 27 2020

xiangzhangllvm added inline comments to D86673: [StackColoring] Conservatively merge point pV = &(&Variable) in catch(Variable).
Aug 27 2020, 10:17 PM · Restricted Project
xiangzhangllvm added a comment to D86673: [StackColoring] Conservatively merge point pV = &(&Variable) in catch(Variable).
Aug 27 2020, 10:13 PM · Restricted Project
xiangzhangllvm updated the summary of D86673: [StackColoring] Conservatively merge point pV = &(&Variable) in catch(Variable).
Aug 27 2020, 1:28 AM · Restricted Project

Aug 26 2020

xiangzhangllvm added a reviewer for D86673: [StackColoring] Conservatively merge point pV = &(&Variable) in catch(Variable): wxiao3.
Aug 26 2020, 11:18 PM · Restricted Project
xiangzhangllvm added a comment to D86673: [StackColoring] Conservatively merge point pV = &(&Variable) in catch(Variable).

Hello efriedma, first thanks for your suggestion.
I agree with"specific load instruction isn't good approach", I just don't know how to easily identify the catch variable in Machine IR.
So I choose the first Load in landing-pad. (I think this can be checked in catch's lowering)

Aug 26 2020, 11:03 PM · Restricted Project
xiangzhangllvm updated the summary of D86673: [StackColoring] Conservatively merge point pV = &(&Variable) in catch(Variable).
Aug 26 2020, 10:48 PM · Restricted Project
xiangzhangllvm added a reviewer for D86673: [StackColoring] Conservatively merge point pV = &(&Variable) in catch(Variable): annita.zhang.
Aug 26 2020, 10:44 PM · Restricted Project
xiangzhangllvm added reviewers for D86673: [StackColoring] Conservatively merge point pV = &(&Variable) in catch(Variable): craig.topper, LuoYuanke, pengfei, MaskRay.
Aug 26 2020, 10:41 PM · Restricted Project
xiangzhangllvm requested review of D86673: [StackColoring] Conservatively merge point pV = &(&Variable) in catch(Variable).
Aug 26 2020, 8:24 PM · Restricted Project

Jul 30 2020

xiangzhangllvm added a comment to D84862: [X86] Make ENDBR instruction a scheduling boundary.

+1

Jul 30 2020, 1:59 AM · Restricted Project

Jul 28 2020

xiangzhangllvm abandoned D58102: Support X86 Control-flow Enforcement Technology (CET) in LLD.
Jul 28 2020, 6:11 PM · Restricted Project, lld

Jul 7 2020

xiangzhangllvm added a comment to D83366: [MC] Simplify the logic of applying fixup for fragments, NFCI.

That is really more clear than old code. I +1 for this refine.

Jul 7 2020, 10:53 PM · Restricted Project

Jul 6 2020

xiangzhangllvm added a comment to D83111: [X86-64] Support Intel AMX Intrinsic.

LGTM with all instances of "pointer point" replace with just "pointer"

Jul 6 2020, 7:15 PM · Restricted Project, Restricted Project
xiangzhangllvm committed rG939d8309dbd4: [X86-64] Support Intel AMX Intrinsic (authored by xiangzhangllvm).
[X86-64] Support Intel AMX Intrinsic
Jul 6 2020, 7:14 PM
xiangzhangllvm closed D83111: [X86-64] Support Intel AMX Intrinsic.
Jul 6 2020, 7:14 PM · Restricted Project, Restricted Project
xiangzhangllvm updated the diff for D83111: [X86-64] Support Intel AMX Intrinsic.

Fix some missed change last time.
1 doxygen comments: amxintrin.h --> x86intrin.h

refine ldtilecfg and sttilecfg comment.

2 replace tile reg num 8 with TileRegHigh+1

Jul 6 2020, 6:27 PM · Restricted Project, Restricted Project

Jul 4 2020

xiangzhangllvm updated the diff for D83111: [X86-64] Support Intel AMX Intrinsic.
Jul 4 2020, 9:34 PM · Restricted Project, Restricted Project
xiangzhangllvm added inline comments to D83111: [X86-64] Support Intel AMX Intrinsic.
Jul 4 2020, 9:02 PM · Restricted Project, Restricted Project
xiangzhangllvm added inline comments to D83111: [X86-64] Support Intel AMX Intrinsic.
Jul 4 2020, 9:02 PM · Restricted Project, Restricted Project

Jul 3 2020

xiangzhangllvm updated the diff for D83111: [X86-64] Support Intel AMX Intrinsic.
Jul 3 2020, 11:15 PM · Restricted Project, Restricted Project
xiangzhangllvm added inline comments to D83111: [X86-64] Support Intel AMX Intrinsic.
Jul 3 2020, 10:52 PM · Restricted Project, Restricted Project

Jul 2 2020

xiangzhangllvm updated the diff for D83111: [X86-64] Support Intel AMX Intrinsic.
Jul 2 2020, 10:07 PM · Restricted Project, Restricted Project
xiangzhangllvm created D83111: [X86-64] Support Intel AMX Intrinsic.
Jul 2 2020, 8:29 PM · Restricted Project, Restricted Project

Jul 1 2020

xiangzhangllvm added a comment to D82705: [X86-64] Support Intel AMX instructions.

I tried it, it just remove tags, not tags with their info, I miss-understand at first, thank you!

Jul 1 2020, 10:43 PM · Restricted Project
xiangzhangllvm committed rGaded4f0cc070: [X86-64] Support Intel AMX instructions (authored by xiangzhangllvm).
[X86-64] Support Intel AMX instructions
Jul 1 2020, 6:23 PM
xiangzhangllvm closed D82705: [X86-64] Support Intel AMX instructions.
Jul 1 2020, 6:23 PM · Restricted Project
xiangzhangllvm added a comment to D82705: [X86-64] Support Intel AMX instructions.

Hello, Craig, can I commit it now?

Jul 1 2020, 12:29 AM · Restricted Project

Jun 30 2020

xiangzhangllvm added a comment to D82705: [X86-64] Support Intel AMX instructions.

check-llvm passed.
LGTM

Jun 30 2020, 7:32 PM · Restricted Project
xiangzhangllvm accepted D82705: [X86-64] Support Intel AMX instructions.
Jun 30 2020, 7:00 PM · Restricted Project
xiangzhangllvm added a comment to D82705: [X86-64] Support Intel AMX instructions.

-Fix the previously noted missing break
-Prevent trying to create a register encoding past tmm7

Jun 30 2020, 5:55 PM · Restricted Project
xiangzhangllvm added a comment to D82705: [X86-64] Support Intel AMX instructions.

3 case failed

LLVM :: MC/Disassembler/X86/simple-tests.txt
LLVM :: MC/Disassembler/X86/x86-16.txt
LLVM :: MC/Disassembler/X86/x86-32.txt
Jun 30 2020, 1:35 AM · Restricted Project

Jun 29 2020

xiangzhangllvm updated the diff for D82705: [X86-64] Support Intel AMX instructions.

Change VTILE to TILE

Jun 29 2020, 7:29 PM · Restricted Project
xiangzhangllvm added a comment to D82705: [X86-64] Support Intel AMX instructions.

Done, but I find the last llvm code can not pass "make check-all", no relation with this patch.

Jun 29 2020, 3:44 AM · Restricted Project

Jun 28 2020

xiangzhangllvm updated the diff for D82705: [X86-64] Support Intel AMX instructions.
Jun 28 2020, 7:48 PM · Restricted Project

Jun 27 2020

xiangzhangllvm created D82705: [X86-64] Support Intel AMX instructions.
Jun 27 2020, 11:59 PM · Restricted Project

May 19 2020

xiangzhangllvm added a comment to D79617: Add cet.h for writing CET-enabled assembly code.

Hello rsmith,
first, very sorry for have committed this patch before your reply, I waited 10 days, I thought you have agreed it.
I think the linux-ABI can be the specification of this head file. The context of this cet.h is according to the linux ABI about CET.
We explained in which case we should use this cet.h file. (line 2-4)
tks

May 19 2020, 6:43 PM · Restricted Project

May 18 2020

xiangzhangllvm committed rGbcc0c894f38f: Add cet.h for writing CET-enabled assembly code (authored by xiangzhangllvm).
Add cet.h for writing CET-enabled assembly code
May 18 2020, 11:18 PM
xiangzhangllvm closed D79617: Add cet.h for writing CET-enabled assembly code.
May 18 2020, 11:18 PM · Restricted Project
xiangzhangllvm committed rG62a9eca859d6: Test asm-cet.S fail for window clang (authored by xiangzhangllvm).
Test asm-cet.S fail for window clang
May 18 2020, 10:45 PM
xiangzhangllvm added a reverting change for rGe7e84ff24a5f: Add cet.h for writing CET-enabled assembly code: rG62a9eca859d6: Test asm-cet.S fail for window clang.
May 18 2020, 10:45 PM
xiangzhangllvm added a comment to D79617: Add cet.h for writing CET-enabled assembly code.

@rsmith

May 18 2020, 10:45 PM · Restricted Project
xiangzhangllvm committed rGe7e84ff24a5f: Add cet.h for writing CET-enabled assembly code (authored by xiangzhangllvm).
Add cet.h for writing CET-enabled assembly code
May 18 2020, 8:05 PM
xiangzhangllvm closed D79617: Add cet.h for writing CET-enabled assembly code.
May 18 2020, 8:04 PM · Restricted Project

May 12 2020

xiangzhangllvm added a comment to D79617: Add cet.h for writing CET-enabled assembly code.

Hello @rsmith if you feel OK too, could you help accept it. Thank you!
Hello every friends, I plan to commit it in these days, if you do not oppose it, thank you!

May 12 2020, 5:48 PM · Restricted Project

May 11 2020

xiangzhangllvm added a comment to D79617: Add cet.h for writing CET-enabled assembly code.

! In D79617#2029228, @hjl.tools wrote:
Works for me.

Hello, H.J., could you help accept this patch, I hope it can go to llvm 10.0.1.
Thank you!!

May 11 2020, 5:52 AM · Restricted Project

May 10 2020

xiangzhangllvm updated the diff for D79617: Add cet.h for writing CET-enabled assembly code.

Refine the Macro _CET_ENDBR

May 10 2020, 10:20 PM · Restricted Project
xiangzhangllvm added inline comments to D79617: Add cet.h for writing CET-enabled assembly code.
May 10 2020, 8:19 PM · Restricted Project
xiangzhangllvm updated the diff for D79617: Add cet.h for writing CET-enabled assembly code.

Add #undef _CET_ENDBR

May 10 2020, 8:18 PM · Restricted Project
xiangzhangllvm added inline comments to D79617: Add cet.h for writing CET-enabled assembly code.
May 10 2020, 8:13 PM · Restricted Project
xiangzhangllvm added inline comments to D79617: Add cet.h for writing CET-enabled assembly code.
May 10 2020, 7:41 PM · Restricted Project
xiangzhangllvm updated the diff for D79617: Add cet.h for writing CET-enabled assembly code.
May 10 2020, 5:37 PM · Restricted Project
xiangzhangllvm added inline comments to D79617: Add cet.h for writing CET-enabled assembly code.
May 10 2020, 5:33 PM · Restricted Project

May 9 2020

xiangzhangllvm added a comment to D79617: Add cet.h for writing CET-enabled assembly code.

I want to put this patch to llvm10.0.1, could you help review and then accept this patch?

May 9 2020, 1:33 AM · Restricted Project

May 8 2020

xiangzhangllvm updated the diff for D79617: Add cet.h for writing CET-enabled assembly code.

Good thing is that: CET is already defined to 1/2/3 according to -fcf-protection=xxx at front end, So we directly used it for preprocessor.

May 8 2020, 11:57 PM · Restricted Project
xiangzhangllvm added inline comments to D79617: Add cet.h for writing CET-enabled assembly code.
May 8 2020, 6:17 PM · Restricted Project