Page MenuHomePhabricator
Feed Advanced Search

Thu, Sep 24

tmsriram committed rGe39286510deb: Temporary fix for D85085 debug_loc bug with basic block sections. (authored by tmsriram).
Temporary fix for D85085 debug_loc bug with basic block sections.
Thu, Sep 24, 2:43 PM
tmsriram closed D87787: Temporary fix for debug loc list bug with basic block sections.
Thu, Sep 24, 2:43 PM · Restricted Project

Wed, Sep 23

tmsriram added a comment to rG7d0bbe40901c: Re-apply https://reviews.llvm.org/D87921, was reverted to triage a PPC bot….

v

Wed, Sep 23, 11:04 AM
tmsriram committed rG7d0bbe40901c: Re-apply https://reviews.llvm.org/D87921, was reverted to triage a PPC bot… (authored by tmsriram).
Re-apply https://reviews.llvm.org/D87921, was reverted to triage a PPC bot…
Wed, Sep 23, 10:33 AM

Tue, Sep 22

tmsriram committed rGb89059a31347: Revert "The wrong placement of add pass with optimizations led to -funique… (authored by tmsriram).
Revert "The wrong placement of add pass with optimizations led to -funique…
Tue, Sep 22, 12:34 PM
tmsriram added a reverting change for rG6950db36d33d: The wrong placement of add pass with optimizations led to -funique-internal…: rGb89059a31347: Revert "The wrong placement of add pass with optimizations led to -funique….
Tue, Sep 22, 12:34 PM
tmsriram added a reverting change for D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager: rGb89059a31347: Revert "The wrong placement of add pass with optimizations led to -funique….
Tue, Sep 22, 12:34 PM · Restricted Project

Mon, Sep 21

tmsriram added a comment to D87813: [llvm] Add -bbsections-cold-text-prefix to emit cold clusters to a different section..

This LGTM after I understood the rationale:

Mon, Sep 21, 2:55 PM · Restricted Project
tmsriram committed rG6950db36d33d: The wrong placement of add pass with optimizations led to -funique-internal… (authored by tmsriram).
The wrong placement of add pass with optimizations led to -funique-internal…
Mon, Sep 21, 10:02 AM
tmsriram closed D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager.
Mon, Sep 21, 10:02 AM · Restricted Project

Fri, Sep 18

tmsriram updated the summary of D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager.
Fri, Sep 18, 12:31 PM · Restricted Project
tmsriram added a reviewer for D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager: MaskRay.
Fri, Sep 18, 11:15 AM · Restricted Project
tmsriram updated the diff for D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager.

Remove braces around single statement if.

Fri, Sep 18, 11:15 AM · Restricted Project
tmsriram requested review of D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager.
Fri, Sep 18, 11:05 AM · Restricted Project

Thu, Sep 17

tmsriram added inline comments to D87813: [llvm] Add -bbsections-cold-text-prefix to emit cold clusters to a different section..
Thu, Sep 17, 10:31 AM · Restricted Project

Wed, Sep 16

tmsriram added a comment to D87787: Temporary fix for debug loc list bug with basic block sections.

Could you include the source and any command lines (clang, what optimization level, etc) was used to generate the test IR? It can make the test a bit easier to read at a glance and help if the test needs to be regenerated for some reason.

Wed, Sep 16, 8:13 PM · Restricted Project
tmsriram updated the summary of D87787: Temporary fix for debug loc list bug with basic block sections.
Wed, Sep 16, 12:44 PM · Restricted Project
tmsriram requested review of D87787: Temporary fix for debug loc list bug with basic block sections.
Wed, Sep 16, 12:38 PM · Restricted Project

Wed, Sep 9

tmsriram accepted D87047: [clang] Add command line options for the Machine Function Splitter..

This LGTM.

Wed, Sep 9, 9:13 AM · Restricted Project

Wed, Sep 2

tmsriram added a comment to D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols..

I am still reading the patch, but I have noticed one thing worth discussing. .bb_addr_map is a non-SHF_ALLOC section (meaning that it is not part of the memory image). An absolute relocation type (.quad .Lfunc_begin0) works but the value is a link-time address, not taking account of the load base (PIE/shared object)). (If .bb_addr_map has the SHF_ALLOC flag, linkers will report a text relocation) How do you intend to use .bb_addr_map at runtime?

Wed, Sep 2, 1:02 PM · Restricted Project, Restricted Project
tmsriram added a reviewer for D87047: [clang] Add command line options for the Machine Function Splitter.: rsmith.
Wed, Sep 2, 11:35 AM · Restricted Project

Aug 25 2020

tmsriram added a comment to D85085: Fix debug_loc offset difference with basic block sections.
Aug 25 2020, 3:21 PM · Restricted Project
tmsriram updated the diff for D85085: Fix debug_loc offset difference with basic block sections.

Redo the patch according to @dblaikie 's observation that loc list need not be used even with sections.

Aug 25 2020, 11:02 AM · Restricted Project

Aug 24 2020

tmsriram accepted D85368: [llvm][CodeGen] Machine Function Splitter.

LGTM, thanks for doing this!

Aug 24 2020, 3:38 PM · Restricted Project

Aug 18 2020

tmsriram added a comment to D85085: Fix debug_loc offset difference with basic block sections.

@amharc

When basic block sections are on and the debug_loc entries span multiple sections, emit entries for each section. This keeps the fidelity and there is no loss of debug information.

To summarize, by default there is only one entry which is collapsed into a DW_AT_const_value.

WIth basic block sections, this one entry spans multiple sections and must be split into an entry for each section.

if the location is valid for the entire range of the enclosing scope, it could still be described with a single DW_AT_const_value, I think?

DWARFv5 spec: "[single (non-loclist) location descriptions] are sufficient for describing the location of any object as long as its lifetime is either static or the same as the lexical block that owns it, and it does not move during its lifetime"

Aug 18 2020, 9:38 PM · Restricted Project
tmsriram updated the diff for D85085: Fix debug_loc offset difference with basic block sections.

When basic block sections are on and the debug_loc entries span multiple sections, emit entries for each section. This keeps the fidelity and there is no loss of debug information.

Aug 18 2020, 9:28 PM · Restricted Project
tmsriram added inline comments to D85368: [llvm][CodeGen] Machine Function Splitter.
Aug 18 2020, 12:37 PM · Restricted Project
tmsriram added inline comments to D85368: [llvm][CodeGen] Machine Function Splitter.
Aug 18 2020, 12:35 PM · Restricted Project

Aug 7 2020

tmsriram added inline comments to D85368: [llvm][CodeGen] Machine Function Splitter.
Aug 7 2020, 5:32 PM · Restricted Project

Aug 6 2020

tmsriram added inline comments to D85368: [llvm][CodeGen] Machine Function Splitter.
Aug 6 2020, 8:21 PM · Restricted Project

Aug 5 2020

tmsriram accepted D85380: [NFC] Rename BBSectionsPrepare -> BasicBlockSections..

IMO, I think this naming is very clear as this pass exists to carve basic block sections.

Aug 5 2020, 5:31 PM · Restricted Project
tmsriram added a comment to D85085: Fix debug_loc offset difference with basic block sections.

Trying to reproduce this (by taking the .ll test case and compiling it with clang -c) I don't get any debug_loc section or DW_AT_locations. Is there something I'm missing about how to reproduce this?

(trying to see what the non-bb-sections location description looks like - if it depends on basic block ordering, it's probably incorrect anyway, and might be worth fixing so it doesn't depend on that non-guaranteed property & then there'll be less divergence between bb-sections and not)

I see why debug_loc is not produced in the default case. This is what happens:

+ For the default case (no bbsections), DebugLoc in https://github.com/llvm/llvm-project/blob/master/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp#L1744 , it has exactly one value that contains the whole function scope as the start label is lfunc_begin and the end label is the end of the function.
+ Such location lists are handled specially here when the scope is the whole function : https://github.com/llvm/llvm-project/blob/master/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp#L1841 and the debug_loc is not generated.

OK ^ and with bb sections do we see the same behavior? If not, why not?

Aug 5 2020, 5:27 PM · Restricted Project
tmsriram added inline comments to D85368: [llvm][CodeGen] Machine Function Splitter.
Aug 5 2020, 3:55 PM · Restricted Project

Aug 4 2020

tmsriram added a comment to D83885: [Propeller]: Use a descriptive temporary symbol name for the end of the basic block..

This patch is simple enough and LGTM.

Aug 4 2020, 11:54 PM · Restricted Project

Aug 3 2020

tmsriram added a comment to D85085: Fix debug_loc offset difference with basic block sections.

Trying to reproduce this (by taking the .ll test case and compiling it with clang -c) I don't get any debug_loc section or DW_AT_locations. Is there something I'm missing about how to reproduce this?

(trying to see what the non-bb-sections location description looks like - if it depends on basic block ordering, it's probably incorrect anyway, and might be worth fixing so it doesn't depend on that non-guaranteed property & then there'll be less divergence between bb-sections and not)

Aug 3 2020, 7:29 PM · Restricted Project
tmsriram added a comment to D85085: Fix debug_loc offset difference with basic block sections.

Trying to reproduce this (by taking the .ll test case and compiling it with clang -c) I don't get any debug_loc section or DW_AT_locations. Is there something I'm missing about how to reproduce this?

(trying to see what the non-bb-sections location description looks like - if it depends on basic block ordering, it's probably incorrect anyway, and might be worth fixing so it doesn't depend on that non-guaranteed property & then there'll be less divergence between bb-sections and not)

Aug 3 2020, 2:38 PM · Restricted Project

Aug 1 2020

tmsriram requested review of D85085: Fix debug_loc offset difference with basic block sections.
Aug 1 2020, 9:42 PM · Restricted Project

Jul 31 2020

tmsriram committed rG938adf42e6b0: Fix a test typo which caused a breakage. (authored by tmsriram).
Fix a test typo which caused a breakage.
Jul 31 2020, 12:28 PM
tmsriram committed rGa77afc62d9e4: New test for basic block sections options. (authored by tmsriram).
New test for basic block sections options.
Jul 31 2020, 12:03 PM
tmsriram committed rGca6b6d40ffba: Rename basic block sections options to be consistent. (authored by tmsriram).
Rename basic block sections options to be consistent.
Jul 31 2020, 11:53 AM
tmsriram closed D84462: Rename options for basic block sections to be consistent.
Jul 31 2020, 11:53 AM · Restricted Project

Jul 30 2020

tmsriram added a comment to D84462: Rename options for basic block sections to be consistent.

lld/test/ELF/lto/basic-block-sections.ll should be placed in another patch. Adding a new test is unrelated to renaming the whole bunch of test files.

Jul 30 2020, 9:50 AM · Restricted Project

Jul 29 2020

tmsriram added a comment to D84462: Rename options for basic block sections to be consistent.

Add extra test without long section names and other nits.

Looks like I messsed up the renaming somehow. Let me fix that.

Jul 29 2020, 10:13 PM · Restricted Project
tmsriram added a comment to D84462: Rename options for basic block sections to be consistent.

Add extra test without long section names and other nits.

Jul 29 2020, 10:11 PM · Restricted Project
tmsriram updated the diff for D84462: Rename options for basic block sections to be consistent.

Add extra test without long section names and other nits.

Jul 29 2020, 10:09 PM · Restricted Project

Jul 23 2020

tmsriram updated the diff for D84462: Rename options for basic block sections to be consistent.

Rename test files too.

Jul 23 2020, 2:20 PM · Restricted Project
tmsriram added inline comments to D84462: Rename options for basic block sections to be consistent.
Jul 23 2020, 1:40 PM · Restricted Project
Herald added a project to D84462: Rename options for basic block sections to be consistent: Restricted Project.
Jul 23 2020, 1:36 PM · Restricted Project

Jul 15 2020

tmsriram added a comment to D83885: [Propeller]: Use a descriptive temporary symbol name for the end of the basic block..

Some inital comments. Expanding the summary to provide a bit more detail on why this symbol naming scheme is better might be useful. Thanks for doing this.

Jul 15 2020, 10:54 PM · Restricted Project

Jul 14 2020

tmsriram committed rGc3e6555616fd: Call Frame Information (CFI) Handling for Basic Block Sections (authored by amharc).
Call Frame Information (CFI) Handling for Basic Block Sections
Jul 14 2020, 12:58 PM
tmsriram closed D79978: Call Frame Information (CFI) Handling for Basic Block Sections.
Jul 14 2020, 12:58 PM · Restricted Project

Jul 13 2020

tmsriram updated the diff for D79978: Call Frame Information (CFI) Handling for Basic Block Sections.

Address reviewer comments.

Jul 13 2020, 7:43 PM · Restricted Project
tmsriram added a comment to D79978: Call Frame Information (CFI) Handling for Basic Block Sections.

Ping, is this alright?

Jul 13 2020, 2:44 PM · Restricted Project

Jul 12 2020

tmsriram added a comment to D79978: Call Frame Information (CFI) Handling for Basic Block Sections.

Let me try a slightly different approach here. It is not clear to us what more is needed to land the patch. In the interests of resolving conflict :

  1. I will also explicitly test assembly too for callee saved registers with bb sections when they are being pushed and popped.

Just on this point - it's not clear to me the motivation for the difference in testing between the two tests (one testing assembly, the other testing LLVM's MIR) - was there some particular difference/detail that these different strategies enabled testing? Otherwise, yeah, I'd probably just go with only testing assembly in both cases, for consistency/simplicity? (any variation in tests always makes me wonder "what's the reason for this difference? Must be something important or they'd be the same and so I'm not understanding some important difference")

Jul 12 2020, 4:01 PM · Restricted Project
tmsriram updated the diff for D79978: Call Frame Information (CFI) Handling for Basic Block Sections.
  • Change the callee saved register test to use a simple clobber on all callee saved registers and test cfi_offset for all the callee-save registers including rbp.
  • The tests now cover the 2 issues that need special handling with sections: CFA tracking with and without frame pointer and cfi directives for callee saved registers.
  • Other reviewer mentioned changes.
Jul 12 2020, 4:00 PM · Restricted Project

Jul 11 2020

tmsriram added a comment to D79978: Call Frame Information (CFI) Handling for Basic Block Sections.

Let me try a slightly different approach here. It is not clear to us what more is needed to land the patch. In the interests of resolving conflict :

Jul 11 2020, 7:32 PM · Restricted Project
tmsriram added a comment to D79978: Call Frame Information (CFI) Handling for Basic Block Sections.

I cannot find a test with .cfa_offset or describing a non-rbp register, so the implementation is under-tested. How about leveraging inline asm to clobber callee-saved registers?

I'm not exactly sure which CFI instruction this comment refers to (there is no .cfa_offset directive, see e.g. https://sourceware.org/binutils/docs/as/CFI-directives.html).

If to .cfi_def_cfa_offset - the question was answered before: we emit a full CFA definition (.cfi_def_cfa - setting both the offset and the register) which is equivalent to a .cfi_def_cfa_offset (only setting the offset) plus a .cfi_def_cfa_register (only setting the register). Moreover, for code following the SysV ABI the register used in the .cfi_def_cfa_register/.cfi_def_cfa instructions is conventionally always set to either rbp (if the frame pointer is kept explicitly) or in rsp (when it's omitted). Both cases are covered by the existing tests. We are not aware of any easy way to force a different register to be the frame pointer.

If the review comment above refers to .cfi_offset instead, please note that the cfi-basic-block-sections-1.ll test checks that .cfi_offset is emitted properly in the generated assembly and cfi-inserter-basic-block-sections-callee-save-registers.ll checks that the CFI Inserter Pass actually inserts the corresponding CFI_INSTRUCTION offset instructions for clobbered callee-saved registers. I'm not exactly sure what would be gained by using inline assembly instead.

I ran llc for both tests. Neither has a section with CFI describing a non-rbp register at the top, thus I say I am not sure the implementation is properly tested.

Jul 11 2020, 5:49 PM · Restricted Project
tmsriram added a comment to D79978: Call Frame Information (CFI) Handling for Basic Block Sections.

...
Now, what happens when we start placing individual basic blocks in unique sections:

  • Basic block sections allow the linker to randomly reorder basic blocks in the address space such that a given basic block can become non-contiguous with the original function.
  • The different basic block sections can no longer share the cfi_startproc and cfi_endproc directives. So, each basic block section should emit this independently.
  • Each (cfi_startproc, cfi_endproc) directive will result in a new FDE that caters to that basic block section.
  • Now, this basic block section needs to duplicate the information from the entry block to compute the CFA as it is an independent entity. It cannot refer to the FDE of the original function and hence must duplicate all the stuff that is needed to compute the CFA on its own.

...

Thanks for the detailed write-up! I I've learned a bit from it. I think at least the quoted items should be placed in the description.

Note also that only rbp is described. I think we need another register to demonstrate the effect.

rbp is the usual frame pointer register for the x86 architecture and I'm not really sure we can easily force the compiler to choose a different register to hold the frame pointer. If you know how to force a different register to be the frame pointer, please let us know - we will add a corresponding test.

I cannot find a test with .cfa_offset or describing a non-rbp register, so the implementation is under-tested. How about leveraging inline asm to clobber callee-saved registers?

Jul 11 2020, 5:29 PM · Restricted Project

Jul 10 2020

tmsriram updated the diff for D79978: Call Frame Information (CFI) Handling for Basic Block Sections.

Enhance test cfi-basic-block-sections-1.ll to also check for frame-pointer=none.

Jul 10 2020, 9:07 PM · Restricted Project
tmsriram added a comment to D79978: Call Frame Information (CFI) Handling for Basic Block Sections.

Honestly I am not a CFI expert but I have read enough bits of LLVM libunwind and am not completely CFI illiterate (I have fixed a very subtle negative cfiDefCfa bug). The description of the patch is still puzzling me.
I think it lacks a summary about what the patch intends to do.

Jul 10 2020, 4:48 PM · Restricted Project
tmsriram added a comment to D79978: Call Frame Information (CFI) Handling for Basic Block Sections.
In D79978#2141992, @wmi wrote:

Ack. Then what instructions should be placed at the top of these basic blocks? Should .cfi_def_cfa_register %rbp be placed as well? If you move these basic blocks around, .cfi_def_cfa_register %rbp is currently not tracked.

That is because .cfi_def_cfa %rbp, 16 is identical to the following:
.cfi_def_cfa_register %rbp
.cfi_def_cfa_offset 16

Honestly I am not a CFI expert but I have read enough bits of LLVM libunwind and am not completely CFI illiterate (I have fixed a very subtle negative cfiDefCfa bug). The description of the patch is still puzzling me.

Jul 10 2020, 2:07 PM · Restricted Project
tmsriram added a comment to D79978: Call Frame Information (CFI) Handling for Basic Block Sections.

Ping, Is this alright now?

Jul 10 2020, 10:47 AM · Restricted Project

Jul 9 2020

tmsriram updated the diff for D79978: Call Frame Information (CFI) Handling for Basic Block Sections.

Move tests to CodeGen/X86/cfi*.

Jul 9 2020, 1:27 PM · Restricted Project
tmsriram added a comment to D79978: Call Frame Information (CFI) Handling for Basic Block Sections.
In D79978#2141768, @wmi wrote:

I haven't looked into the details, but the test suggests that the patch is wrong:

# basic-block-sections-cfi-1.ll
        .section        .text,"ax",@progbits,unique,2
_Z2f3b.2:                               # %if.end
        .cfi_startproc
        .cfi_def_cfa %rbp, 16    # this should be inserted after addq $16, %rsp
        .cfi_offset %rbp, -16    # this should be after .cfi_def_cfa %rbp, 16
        addq    $16, %rsp
        popq    %rbp
        .cfi_def_cfa %rsp, 8
        retq

I think the position where the cfi directives are currently inserted is correct. Those directives at the beginning of BB are not to maintain call frame information for instructions inside of BB like "addq $16, %rsp" and "popq %rbp", but to setup the call frame information correctly at the beginning of BB because the BB could be moved around.

Ack. Then what instructions should be placed at the top of these basic blocks? Should .cfi_def_cfa_register %rbp be placed as well? If you move these basic blocks around, .cfi_def_cfa_register %rbp is currently not tracked.

For basic-block-sections-cfiinstr_1.ll, have you considered places like CodeGen/X86/cfi-inserter-*? You may even create a subdirectory there.

This question still stands. I haven't seen other CFI tests in`DebugInfo/X86/`

Jul 9 2020, 9:33 AM · Restricted Project
tmsriram added a comment to D79978: Call Frame Information (CFI) Handling for Basic Block Sections.
In D79978#2141768, @wmi wrote:

I haven't looked into the details, but the test suggests that the patch is wrong:

# basic-block-sections-cfi-1.ll
        .section        .text,"ax",@progbits,unique,2
_Z2f3b.2:                               # %if.end
        .cfi_startproc
        .cfi_def_cfa %rbp, 16    # this should be inserted after addq $16, %rsp
        .cfi_offset %rbp, -16    # this should be after .cfi_def_cfa %rbp, 16
        addq    $16, %rsp
        popq    %rbp
        .cfi_def_cfa %rsp, 8
        retq

I think the position where the cfi directives are currently inserted is correct. Those directives at the beginning of BB are not to maintain call frame information for instructions inside of BB like "addq $16, %rsp" and "popq %rbp", but to setup the call frame information correctly at the beginning of BB because the BB could be moved around.

Jul 9 2020, 8:46 AM · Restricted Project

Jul 8 2020

tmsriram updated the diff for D79978: Call Frame Information (CFI) Handling for Basic Block Sections.

Address reviewer comments:

Jul 8 2020, 5:01 PM · Restricted Project
tmsriram added a comment to D79978: Call Frame Information (CFI) Handling for Basic Block Sections.

I have studied CFIInstrInserter in May. If you don't mind, please give me some time to review as well.

For basic-block-sections-cfiinstr_1.ll, have you considered places like CodeGen/X86/cfi-inserter-*? You may even create a subdirectory there.
_1 is not very common. -1 is more common.

Jul 8 2020, 5:00 PM · Restricted Project

Jul 7 2020

tmsriram added inline comments to D79978: Call Frame Information (CFI) Handling for Basic Block Sections.
Jul 7 2020, 9:41 PM · Restricted Project
tmsriram updated the diff for D79978: Call Frame Information (CFI) Handling for Basic Block Sections.

Fix CFIInstr test and address other reviewer comments.

Jul 7 2020, 9:40 PM · Restricted Project
tmsriram added inline comments to D79978: Call Frame Information (CFI) Handling for Basic Block Sections.
Jul 7 2020, 8:21 PM · Restricted Project
tmsriram added inline comments to D79978: Call Frame Information (CFI) Handling for Basic Block Sections.
Jul 7 2020, 8:07 PM · Restricted Project
tmsriram added inline comments to D79978: Call Frame Information (CFI) Handling for Basic Block Sections.
Jul 7 2020, 2:24 PM · Restricted Project
tmsriram updated the diff for D79978: Call Frame Information (CFI) Handling for Basic Block Sections.

Simplify CFI instructions test.

Jul 7 2020, 2:19 PM · Restricted Project

Jul 1 2020

tmsriram committed rGe4b3c138deb8: This patch adds basic debug info support with basic block sections. (authored by amharc).
This patch adds basic debug info support with basic block sections.
Jul 1 2020, 11:57 PM
tmsriram closed D78851: Debug Info Support for Basic Block Sections.
Jul 1 2020, 11:57 PM · Restricted Project
tmsriram added inline comments to D78851: Debug Info Support for Basic Block Sections.
Jul 1 2020, 3:40 PM · Restricted Project
tmsriram updated the diff for D78851: Debug Info Support for Basic Block Sections.

Remove check for skipping debug info in DebugHandlerBase.cpp as it is not needed.

Jul 1 2020, 3:40 PM · Restricted Project

Jun 29 2020

tmsriram updated the diff for D79978: Call Frame Information (CFI) Handling for Basic Block Sections.

Simplify cfiinstr test .ll file

Jun 29 2020, 8:56 PM · Restricted Project
tmsriram updated the diff for D79978: Call Frame Information (CFI) Handling for Basic Block Sections.

Simplify CFI test.

Jun 29 2020, 2:58 PM · Restricted Project

Jun 26 2020

tmsriram added inline comments to D79978: Call Frame Information (CFI) Handling for Basic Block Sections.
Jun 26 2020, 3:39 PM · Restricted Project
tmsriram added inline comments to D79978: Call Frame Information (CFI) Handling for Basic Block Sections.
Jun 26 2020, 1:41 PM · Restricted Project

Jun 25 2020

tmsriram updated the summary of D79978: Call Frame Information (CFI) Handling for Basic Block Sections.
Jun 25 2020, 11:59 PM · Restricted Project
tmsriram updated subscribers of D79978: Call Frame Information (CFI) Handling for Basic Block Sections.
Jun 25 2020, 11:59 PM · Restricted Project
tmsriram added inline comments to D79978: Call Frame Information (CFI) Handling for Basic Block Sections.
Jun 25 2020, 11:59 PM · Restricted Project
tmsriram updated the diff for D79978: Call Frame Information (CFI) Handling for Basic Block Sections.

Split deduplication out of base CFI patch.

Jun 25 2020, 11:59 PM · Restricted Project

Jun 23 2020

tmsriram added inline comments to D78851: Debug Info Support for Basic Block Sections.
Jun 23 2020, 8:31 PM · Restricted Project
tmsriram updated the diff for D78851: Debug Info Support for Basic Block Sections.

Use MapVector for MBBSectionRanges instead of IndexedMap.

Jun 23 2020, 8:31 PM · Restricted Project

Jun 19 2020

tmsriram added inline comments to D78851: Debug Info Support for Basic Block Sections.
Jun 19 2020, 12:29 AM · Restricted Project

Jun 18 2020

tmsriram added inline comments to D78851: Debug Info Support for Basic Block Sections.
Jun 18 2020, 4:26 PM · Restricted Project

Jun 17 2020

tmsriram added inline comments to D78851: Debug Info Support for Basic Block Sections.
Jun 17 2020, 10:39 PM · Restricted Project
tmsriram updated the diff for D78851: Debug Info Support for Basic Block Sections.

Address reviewer comments :

Jun 17 2020, 10:39 PM · Restricted Project

Jun 12 2020

tmsriram added inline comments to D78851: Debug Info Support for Basic Block Sections.
Jun 12 2020, 3:24 PM · Restricted Project
tmsriram updated the diff for D78851: Debug Info Support for Basic Block Sections.

Rebase and address reviewer comments which are code refactoring and enhancing the test case.

Jun 12 2020, 3:24 PM · Restricted Project

Jun 2 2020

tmsriram committed rGe0bca46b0854: Options for Basic Block Sections, enabled in D68063 and D73674. (authored by tmsriram).
Options for Basic Block Sections, enabled in D68063 and D73674.
Jun 2 2020, 1:05 AM
tmsriram closed D68049: Propeller: Clang options for basic block sections .
Jun 2 2020, 1:05 AM · Restricted Project, Restricted Project

Jun 1 2020

tmsriram added a comment to D68049: Propeller: Clang options for basic block sections .

LLD side changes look good. Are you waiting on an explicit approval from @rmisth ?

Jun 1 2020, 12:25 PM · Restricted Project, Restricted Project
tmsriram added a comment to D68049: Propeller: Clang options for basic block sections .

Ping.

Jun 1 2020, 11:18 AM · Restricted Project, Restricted Project

May 26 2020

tmsriram added a comment to D68049: Propeller: Clang options for basic block sections .

Ping.

May 26 2020, 12:32 PM · Restricted Project, Restricted Project
tmsriram added a comment to D78851: Debug Info Support for Basic Block Sections.

Ping.

May 26 2020, 12:32 PM · Restricted Project

May 21 2020

tmsriram updated the diff for D79978: Call Frame Information (CFI) Handling for Basic Block Sections.

Code refactoring in CFIInstrInserter.cpp

May 21 2020, 6:25 PM · Restricted Project