Page MenuHomePhabricator
Feed Advanced Search

Today

xbolva00 requested review of D89885: [MemLoc] Adjust memccpy support in MemoryLocation::getForArgument.
Wed, Oct 21, 7:56 AM · Restricted Project
xbolva00 added inline comments to D89321: [MemLoc] Support memchr/memccpy in MemoryLocation::getForArgument.
Wed, Oct 21, 2:52 AM · Restricted Project
xbolva00 added a comment to D89381: [SCEV] Re-enable "Use nw flag and symbolic iteration count to sharpen ranges of AddRecs", attempt 3.

+1

Wed, Oct 21, 2:49 AM · Restricted Project
xbolva00 added a comment to D89645: [InferAttrs] Add nocapture/writeonly to string/mem libcalls.

ping

Wed, Oct 21, 1:25 AM · Restricted Project

Yesterday

xbolva00 added a comment to D75815: [InstCombine] Simplify calls with "returned" attribute.

@nikic, @spatel do we also need a fix for register allocator? it seems like this optimization can lead to supoptimal codegen.

Tue, Oct 20, 2:59 PM · Restricted Project
xbolva00 added a comment to D88735: [SLP] Also try to vectorize incoming values of PHIs ..

@spatel, @RKSimon any concerns?

Tue, Oct 20, 2:24 AM · Restricted Project

Mon, Oct 19

xbolva00 committed rGd605a119939a: [Intrinsics] Added writeonly attribute to the first arg of llvm.memmove (authored by xbolva00).
[Intrinsics] Added writeonly attribute to the first arg of llvm.memmove
Mon, Oct 19, 2:10 PM
xbolva00 closed D89724: [Intrinsics] Added writeonly attribute to the first arg of llvm.memmove.
Mon, Oct 19, 2:09 PM · Restricted Project
xbolva00 edited reviewers for D89724: [Intrinsics] Added writeonly attribute to the first arg of llvm.memmove, added: fhahn; removed: Florian.
Mon, Oct 19, 1:18 PM · Restricted Project
xbolva00 added reviewers for D89724: [Intrinsics] Added writeonly attribute to the first arg of llvm.memmove: Florian, jdoerfert.
Mon, Oct 19, 1:15 PM · Restricted Project
xbolva00 requested review of D89724: [Intrinsics] Added writeonly attribute to the first arg of llvm.memmove.
Mon, Oct 19, 1:14 PM · Restricted Project

Sun, Oct 18

xbolva00 added a comment to rG65e94cc946b0: [InferAttrs] Add argmemonly attribute to string libcalls.

Ok, no-builtin fix works fine

Sun, Oct 18, 8:58 AM
xbolva00 committed rG2554619adbc8: [ASAN] Restore and adjust tests (authored by xbolva00).
[ASAN] Restore and adjust tests
Sun, Oct 18, 8:29 AM
xbolva00 added a comment to rG65e94cc946b0: [InferAttrs] Add argmemonly attribute to string libcalls.

Why were the sanitizer tests deleted? It seems to me like they are valid. If the new attributes causes them to be optimized out can't you just build them with -fno-builtin?

Sun, Oct 18, 8:21 AM
xbolva00 added a comment to D88328: [InferAttrs] Improve DSE for libcalls (partial fix for PR47644).

Thanks for fast fix!

Sun, Oct 18, 8:03 AM · Restricted Project
xbolva00 added inline comments to D88328: [InferAttrs] Improve DSE for libcalls (partial fix for PR47644).
Sun, Oct 18, 8:00 AM · Restricted Project
Herald added a project to D18714: Add writeonly IR attribute: Restricted Project.

Also start using the attribute for memset, memcpy, and memmove intrinsics,

and remove their special-casing in BasicAliasAnalysis.

Sun, Oct 18, 6:49 AM · Restricted Project
xbolva00 requested review of D89645: [InferAttrs] Add nocapture/writeonly to string/mem libcalls.
Sun, Oct 18, 6:41 AM · Restricted Project
xbolva00 committed rG935cb12280ff: [LoopIdiom] Regenerate test checks; NFC (authored by xbolva00).
[LoopIdiom] Regenerate test checks; NFC
Sun, Oct 18, 5:07 AM
xbolva00 added a comment to D88328: [InferAttrs] Improve DSE for libcalls (partial fix for PR47644).

Test cases works for me with clang/opt 11 with mssa dse

Sun, Oct 18, 4:33 AM · Restricted Project
xbolva00 added a comment to D88328: [InferAttrs] Improve DSE for libcalls (partial fix for PR47644).

Ok, I should be ready to make progress here again.

Sun, Oct 18, 4:28 AM · Restricted Project

Sat, Oct 17

xbolva00 committed rG0334fa091a91: [Tests] Added tests for D88328 (authored by xbolva00).
[Tests] Added tests for D88328
Sat, Oct 17, 5:07 PM
xbolva00 committed rG65e94cc946b0: [InferAttrs] Add argmemonly attribute to string libcalls (authored by xbolva00).
[InferAttrs] Add argmemonly attribute to string libcalls
Sat, Oct 17, 4:33 PM
xbolva00 added a reverting change for rGb77dd32a6fcc: [InferAttrs] Add argmemonly attribute to string libcalls: rG2a75e956e5ce: Revert "[InferAttrs] Add argmemonly attribute to string libcalls".
Sat, Oct 17, 2:30 PM
xbolva00 committed rG2a75e956e5ce: Revert "[InferAttrs] Add argmemonly attribute to string libcalls" (authored by xbolva00).
Revert "[InferAttrs] Add argmemonly attribute to string libcalls"
Sat, Oct 17, 2:30 PM
xbolva00 added a reverting change for D89602: [InferAttrs] Add argmemonly attribute to string libcalls: rG2a75e956e5ce: Revert "[InferAttrs] Add argmemonly attribute to string libcalls".
Sat, Oct 17, 2:29 PM · Restricted Project
xbolva00 abandoned D89634: [Tests] Added tests for D88328.
Sat, Oct 17, 2:28 PM · Restricted Project
xbolva00 requested review of D89634: [Tests] Added tests for D88328.
Sat, Oct 17, 2:18 PM · Restricted Project
xbolva00 committed rGb77dd32a6fcc: [InferAttrs] Add argmemonly attribute to string libcalls (authored by xbolva00).
[InferAttrs] Add argmemonly attribute to string libcalls
Sat, Oct 17, 1:43 PM
xbolva00 closed D89602: [InferAttrs] Add argmemonly attribute to string libcalls.
Sat, Oct 17, 1:43 PM · Restricted Project

Fri, Oct 16

xbolva00 requested review of D89602: [InferAttrs] Add argmemonly attribute to string libcalls.
Fri, Oct 16, 4:13 PM · Restricted Project
xbolva00 added a comment to D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM.

+1 for revert

Fri, Oct 16, 8:38 AM · Restricted Project, Restricted Project
xbolva00 committed rG28691cdd714f: [MemLoc] Support memchr/memccpy in MemoryLocation::getForArgument (authored by xbolva00).
[MemLoc] Support memchr/memccpy in MemoryLocation::getForArgument
Fri, Oct 16, 2:38 AM
xbolva00 closed D89321: [MemLoc] Support memchr/memccpy in MemoryLocation::getForArgument.
Fri, Oct 16, 2:38 AM · Restricted Project

Wed, Oct 14

xbolva00 added a comment to D89207: [MemCpyOpt] Port to MemorySSA.

CMakeFiles/7zip-benchmark.dir/CPP/7zip/Compress/ShrinkDecoder.cpp.o 4KiB 4KiB (+0.44%)

Wed, Oct 14, 2:28 PM · Restricted Project
xbolva00 added inline comments to D89381: [SCEV] Re-enable "Use nw flag and symbolic iteration count to sharpen ranges of AddRecs", attempt 3.
Wed, Oct 14, 5:12 AM · Restricted Project

Tue, Oct 13

xbolva00 added inline comments to D89249: [SimplifyLibCalls] Preserve tail call indicator.
Tue, Oct 13, 8:33 AM · Restricted Project
xbolva00 requested review of D89321: [MemLoc] Support memchr/memccpy in MemoryLocation::getForArgument.
Tue, Oct 13, 8:29 AM · Restricted Project
xbolva00 added a comment to D84951: [LV] Try to sink users recursively for first-order recurrences..

Any futher comments, @bmahjour?

Nope, I'm fine with the changes.

Tue, Oct 13, 4:47 AM · Restricted Project
xbolva00 added a reviewer for D89249: [SimplifyLibCalls] Preserve tail call indicator: efriedma.
Tue, Oct 13, 1:38 AM · Restricted Project

Mon, Oct 12

xbolva00 added a comment to D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments..

Can you please upload again with full context?

My apologies, I am new to LLVM contribution. What is the best way to do that such that it squashes all of my local git commits?

Mon, Oct 12, 11:17 AM · Restricted Project
xbolva00 updated the summary of D89249: [SimplifyLibCalls] Preserve tail call indicator.
Mon, Oct 12, 9:18 AM · Restricted Project
xbolva00 requested review of D89249: [SimplifyLibCalls] Preserve tail call indicator.
Mon, Oct 12, 9:18 AM · Restricted Project
xbolva00 committed rG2f66bfac280f: [Tests] Regenerate test checks; NFC (authored by xbolva00).
[Tests] Regenerate test checks; NFC
Mon, Oct 12, 8:55 AM

Sun, Oct 11

xbolva00 added reviewers for D88735: [SLP] Also try to vectorize incoming values of PHIs .: greened, lebedev.ri, craig.topper.
Sun, Oct 11, 4:47 PM · Restricted Project

Fri, Oct 9

xbolva00 committed rGcaf28b0a1288: [Diagnostics] Diagnose -Wsizeof-array-div for array of pointers (authored by xbolva00).
[Diagnostics] Diagnose -Wsizeof-array-div for array of pointers
Fri, Oct 9, 3:56 AM
xbolva00 closed D87990: [Diagnostics] Diagnose -Wsizeof-array-div for array of pointers .
Fri, Oct 9, 3:56 AM · Restricted Project

Thu, Oct 8

xbolva00 added a comment to D87990: [Diagnostics] Diagnose -Wsizeof-array-div for array of pointers .

I implemented suggested change so I assume it is fine. I will commit it tomorrow if no futher comments.

Thu, Oct 8, 2:00 AM · Restricted Project
xbolva00 added inline comments to D82588: [DSE] Look through memory PHI arguments when removing noop stores in MSSA..
Thu, Oct 8, 1:37 AM · Restricted Project

Tue, Oct 6

xbolva00 committed rG86429c4eaf22: [SimplifyLibCalls] Optimize mempcpy_chk to mempcpy (authored by xbolva00).
[SimplifyLibCalls] Optimize mempcpy_chk to mempcpy
Tue, Oct 6, 8:09 AM

Mon, Oct 5

xbolva00 added a reverting change for rG3f1fd59de300: [SLC] Optimize mempcpy_chk to mempcpy: rGa4bae56ab8e9: Revert "[SLC] Optimize mempcpy_chk to mempcpy".
Mon, Oct 5, 1:28 PM
xbolva00 committed rGa4bae56ab8e9: Revert "[SLC] Optimize mempcpy_chk to mempcpy" (authored by xbolva00).
Revert "[SLC] Optimize mempcpy_chk to mempcpy"
Mon, Oct 5, 1:28 PM
xbolva00 added a reverting change for D86019: [SLC] Optimize mempcpy_chk to mempcpy: rGa4bae56ab8e9: Revert "[SLC] Optimize mempcpy_chk to mempcpy".
Mon, Oct 5, 1:27 PM · Restricted Project
xbolva00 committed rG3f1fd59de300: [SLC] Optimize mempcpy_chk to mempcpy (authored by xbolva00).
[SLC] Optimize mempcpy_chk to mempcpy
Mon, Oct 5, 1:19 PM
xbolva00 closed D86019: [SLC] Optimize mempcpy_chk to mempcpy.
Mon, Oct 5, 1:19 PM · Restricted Project
xbolva00 added a comment to D88307: [DON'T MERGE] Jump-threading for finite state automata.

Yeah, I agree that it is quite questionable how useful the AJT is. But JT for FSMs is definitely useful and should be added.

Mon, Oct 5, 11:31 AM · Restricted Project
xbolva00 added a comment to D88307: [DON'T MERGE] Jump-threading for finite state automata.

Did you consider to implement more Agressive Jump Threading instead of a new pass for specific use (FSMs)? Like following solutions:

Do you mean to improve the existing LLVM Jump Threading pass?

Mon, Oct 5, 5:10 AM · Restricted Project
xbolva00 added a comment to D88307: [DON'T MERGE] Jump-threading for finite state automata.

Did you consider to implement more Agressive Jump Threading instead of a new pass for specific use (FSMs)? Like following solutions:

Mon, Oct 5, 2:47 AM · Restricted Project

Sun, Oct 4

xbolva00 added a comment to D87990: [Diagnostics] Diagnose -Wsizeof-array-div for array of pointers .

Ping @rsmith

Sun, Oct 4, 11:05 AM · Restricted Project
xbolva00 added a comment to D84951: [LV] Try to sink users recursively for first-order recurrences..

Any futher comments, @bmahjour?

Sun, Oct 4, 1:59 AM · Restricted Project
xbolva00 accepted D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling.

I'll just say this LGTM as it establishes parity with what NewPM has been doing for a while already.

Sun, Oct 4, 1:15 AM · Restricted Project, Restricted Project

Fri, Oct 2

xbolva00 added a comment to D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling.

I'm not really sure what are my potential next steps here.

Fri, Oct 2, 10:17 AM · Restricted Project, Restricted Project
xbolva00 added a comment to D88087: [SCEV] Limited support for unsigned preds in isImpliedViaOperations.

Compile time regressed a bit but I see no binary changes so.. how useful this is in practise? Any benchmark data to justify small regression?

Fri, Oct 2, 1:44 AM · Restricted Project

Wed, Sep 30

xbolva00 added a comment to D87990: [Diagnostics] Diagnose -Wsizeof-array-div for array of pointers .

Ping @rsmith

Wed, Sep 30, 6:03 AM · Restricted Project
xbolva00 added a comment to D86019: [SLC] Optimize mempcpy_chk to mempcpy.

Ping @efriedma

Wed, Sep 30, 6:02 AM · Restricted Project

Tue, Sep 29

xbolva00 added a comment to D88492: [InstCombine] visitTrunc - remove dead trunc(lshr (zext A), C) combine.

Binary changes

Tue, Sep 29, 11:42 PM · Restricted Project

Sun, Sep 27

xbolva00 committed rG155ac333945d: [BuildLibCalls] Add noalias for strcat and stpcpy (authored by xbolva00).
[BuildLibCalls] Add noalias for strcat and stpcpy
Sun, Sep 27, 12:39 PM
xbolva00 closed D88335: [BuildLibCalls] Add noalias for strcat and stpcpy.
Sun, Sep 27, 12:39 PM · Restricted Project

Sat, Sep 26

xbolva00 added a comment to D88335: [BuildLibCalls] Add noalias for strcat and stpcpy.

FWIW, noalias on these arguments is, by itself, not doing anything. It does something if you know how much memory is accessed by the function through such an argument *for sure* and what other memory is accessed for sure. Such memory regions are not overlapping. (This is way too vague actually but I guess it doesn't matter for the gist.)

Sat, Sep 26, 1:12 AM · Restricted Project

Fri, Sep 25

xbolva00 added a comment to D88335: [BuildLibCalls] Add noalias for strcat and stpcpy.

That would be really overconservative

Fri, Sep 25, 1:42 PM · Restricted Project
xbolva00 added a comment to D88328: [InferAttrs] Improve DSE for libcalls (partial fix for PR47644).

I think it would be good to update the commit message to just state that this adds no capture and write only to the first arg of strcpy & co. It also unifies strcpy & stpcpy handling. might be good to do separately first.

Fri, Sep 25, 12:59 PM · Restricted Project
xbolva00 requested review of D88335: [BuildLibCalls] Add noalias for strcat and stpcpy.
Fri, Sep 25, 12:58 PM · Restricted Project
xbolva00 added a comment to D88328: [InferAttrs] Improve DSE for libcalls (partial fix for PR47644).

Interestingly, as we can see, something is broken with NPM (hopefully not a blocker for this patch)

Fri, Sep 25, 12:08 PM · Restricted Project
xbolva00 requested review of D88328: [InferAttrs] Improve DSE for libcalls (partial fix for PR47644).
Fri, Sep 25, 12:06 PM · Restricted Project
xbolva00 committed rG179e15d53acd: [SystemZ] Optimize bcmp calls (PR47420) (authored by xbolva00).
[SystemZ] Optimize bcmp calls (PR47420)
Fri, Sep 25, 8:56 AM
xbolva00 closed D87988: [SystemZ] Optimize bcmp calls (PR47420).
Fri, Sep 25, 8:56 AM · Restricted Project
xbolva00 added a comment to D87990: [Diagnostics] Diagnose -Wsizeof-array-div for array of pointers .
Fri, Sep 25, 6:08 AM · Restricted Project
xbolva00 added reviewers for D88293: [ControlDependentDCE] Add Control Dependent DCE pass: efriedma, asbirlea, fhahn.
Fri, Sep 25, 5:20 AM · Restricted Project
xbolva00 added a comment to D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling.

Does that sound reasonable?

Fri, Sep 25, 2:13 AM · Restricted Project, Restricted Project

Wed, Sep 23

xbolva00 added a comment to D87988: [SystemZ] Optimize bcmp calls (PR47420).

Right, I will adjust to make it more clear.

I still think it would be nice to mention this in SelectionDAGTargetInfo.h (in the comment for EmitTargetCodeForMemcmp()) as well...?

Wed, Sep 23, 1:02 PM · Restricted Project
xbolva00 updated the diff for D87988: [SystemZ] Optimize bcmp calls (PR47420).
Wed, Sep 23, 1:01 PM · Restricted Project

Tue, Sep 22

xbolva00 added a comment to rG8fdac7cb7abb: Revert D71539 "Recommit "[SCEV] Look through single value PHIs."".

mafft regressed quite a lot (compile time) so it would be good to handle possibly weird cases well - some limit/threshold/bailout?

Tue, Sep 22, 12:45 PM
xbolva00 added a comment to D84951: [LV] Try to sink users recursively for first-order recurrences..

Cool, great!

Tue, Sep 22, 12:35 PM · Restricted Project
xbolva00 updated the diff for D87988: [SystemZ] Optimize bcmp calls (PR47420).
Tue, Sep 22, 11:10 AM · Restricted Project
xbolva00 added a comment to D87988: [SystemZ] Optimize bcmp calls (PR47420).

Maybe also have the test case from my original patch which transforms a memcmp to a bcmp...?

Tue, Sep 22, 11:01 AM · Restricted Project
xbolva00 added a comment to D87988: [SystemZ] Optimize bcmp calls (PR47420).

Maybe also have the test case from my original patch which transforms a memcmp to a bcmp...?

If it is really ok to pass bcmp to visitMemCmpCall(), I think a comment on that specifies this would be nice, both for visitMemCmpCall() and EmitTargetCodeForMemcmp().

Tue, Sep 22, 10:57 AM · Restricted Project
xbolva00 added a reviewer for D87988: [SystemZ] Optimize bcmp calls (PR47420): jonpa.
Tue, Sep 22, 3:30 AM · Restricted Project

Sep 21 2020

xbolva00 updated subscribers of D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling.
Sep 21 2020, 12:03 PM · Restricted Project, Restricted Project
xbolva00 added a comment to D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling.

X86 data collected by @lebedev.ri looks good as well.

Sep 21 2020, 12:02 PM · Restricted Project, Restricted Project
xbolva00 added inline comments to D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling.
Sep 21 2020, 5:55 AM · Restricted Project, Restricted Project

Sep 20 2020

xbolva00 added inline comments to D87990: [Diagnostics] Diagnose -Wsizeof-array-div for array of pointers .
Sep 20 2020, 3:01 PM · Restricted Project
xbolva00 updated the diff for D87990: [Diagnostics] Diagnose -Wsizeof-array-div for array of pointers .

Addressed review comments.
New test cases.

Sep 20 2020, 3:00 PM · Restricted Project
xbolva00 requested review of D87990: [Diagnostics] Diagnose -Wsizeof-array-div for array of pointers .
Sep 20 2020, 11:15 AM · Restricted Project
xbolva00 added a comment to rG7903ae4720a8: [InstCombine] factorize left shifts of add/sub.

Thanks, great! :)

Sep 20 2020, 10:07 AM
xbolva00 added a comment to D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling.

I have tested this patch internally and seen gains and losses. On one document search related benchmark 3~5% improvement. One zippy (snappy) there is 3~5% regression. Perhaps we do need a conditional extra SROA run.

Sep 20 2020, 10:02 AM · Restricted Project, Restricted Project
xbolva00 added a comment to D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling.

I have tested this patch internally and seen gains and losses. On one document search related benchmark 3~5% improvement. One zippy (snappy) there is 3~5% regression. Perhaps we do need a conditional extra SROA run.

Sep 20 2020, 9:51 AM · Restricted Project, Restricted Project
xbolva00 retitled D87988: [SystemZ] Optimize bcmp calls (PR47420) from [SystemZ] Optimize bcmp calls to [SystemZ] Optimize bcmp calls (PR47420).
Sep 20 2020, 9:21 AM · Restricted Project
xbolva00 requested review of D87988: [SystemZ] Optimize bcmp calls (PR47420).
Sep 20 2020, 9:19 AM · Restricted Project
xbolva00 committed rG2ae182258c49: [Diagnostics] Fixed -Wsizeof-array-div false positive when divisor is sizeof… (authored by xbolva00).
[Diagnostics] Fixed -Wsizeof-array-div false positive when divisor is sizeof…
Sep 20 2020, 8:43 AM
xbolva00 committed rG2990518b0324: [MemLoc] Support lllvm.memcpy.inline in MemoryLocation::getForArgument (authored by xbolva00).
[MemLoc] Support lllvm.memcpy.inline in MemoryLocation::getForArgument
Sep 20 2020, 5:02 AM