Page MenuHomePhabricator
Feed Advanced Search

Wed, Feb 3

alokmishra.besu added a comment to D91944: OpenMP 5.0 metadirective.

There are no test cases anymore, as far as I can tell.

Wed, Feb 3, 1:13 PM · Restricted Project, Restricted Project, Restricted Project
alokmishra.besu updated the diff for D91944: OpenMP 5.0 metadirective.
Wed, Feb 3, 1:10 PM · Restricted Project, Restricted Project, Restricted Project
alokmishra.besu updated the diff for D91944: OpenMP 5.0 metadirective.

I've rebase this patch with the latest git code.
All test cases pass.
I've also applied this patch to a new git clone. It applies and builds successfully.

Wed, Feb 3, 12:54 PM · Restricted Project, Restricted Project, Restricted Project

Jan 18 2021

alokmishra.besu added a comment to D91944: OpenMP 5.0 metadirective.

Are the test all passing?

Can we fix the failing tests so we can merge this?

Jan 18 2021, 10:56 AM · Restricted Project, Restricted Project, Restricted Project

Jan 1 2021

alokmishra.besu updated the diff for D91944: OpenMP 5.0 metadirective.

Rebased with current branch to avoid patch failure

Jan 1 2021, 12:33 PM · Restricted Project, Restricted Project, Restricted Project
alokmishra.besu added a comment to D91944: OpenMP 5.0 metadirective.

Emitting error instead of instantiation in clang/lib/Sema/TreeTransform.h. Added a TODO for future.

Jan 1 2021, 8:52 AM · Restricted Project, Restricted Project, Restricted Project
alokmishra.besu updated the diff for D91944: OpenMP 5.0 metadirective.

All clang test and clang-tidy pass. Ran clang-format on all code, except clang/include/clang/Serialization/ASTBitCodes.h which was formatting unrelated code as well.

Jan 1 2021, 8:49 AM · Restricted Project, Restricted Project, Restricted Project

Dec 3 2020

alokmishra.besu added inline comments to D91944: OpenMP 5.0 metadirective.
Dec 3 2020, 3:12 PM · Restricted Project, Restricted Project, Restricted Project
alokmishra.besu updated the diff for D91944: OpenMP 5.0 metadirective.
Dec 3 2020, 3:09 PM · Restricted Project, Restricted Project, Restricted Project
alokmishra.besu added inline comments to D91944: OpenMP 5.0 metadirective.
Dec 3 2020, 9:55 AM · Restricted Project, Restricted Project, Restricted Project
alokmishra.besu updated the diff for D91944: OpenMP 5.0 metadirective.

Updated version of metadirective supporting OpenMP 5.0 features

Dec 3 2020, 8:37 AM · Restricted Project, Restricted Project, Restricted Project

Nov 25 2020

alokmishra.besu added a comment to D91944: OpenMP 5.0 metadirective.

I have replied to the comments and will update the code accordingly. Some of the codes are intentionally left to be update in 5.1 implementation. Will add TODO comments there.
I will revisit the implementation of getBestWhenMatchForContext and also add more test cases over the weekend and submit new code by next week.

Nov 25 2020, 8:44 PM · Restricted Project, Restricted Project, Restricted Project

Nov 23 2020

alokmishra.besu requested review of D91944: OpenMP 5.0 metadirective.
Nov 23 2020, 12:56 AM · Restricted Project, Restricted Project, Restricted Project

Sep 13 2020

alokmishra.besu updated the diff for D76211: OpenMP Metadirective with user defined condition.

Updated patch to make it extendable to more selectors
Implemented device_arch and implementation_vendor selectors as well

Sep 13 2020, 1:27 AM · Restricted Project, Restricted Project, Restricted Project

Aug 12 2020

alokmishra.besu added a comment to D76211: OpenMP Metadirective with user defined condition.

Are you planning to add support for the actual OpenMP selectors as well?
All the other traits, scoring, etc. I left a comment below that points you to the right place as we have almost all of that already ready to be reused.
On this note, I would recommend you take a look at the OpenMP 5.1 draft, it contains proper wording for a dynamic context extension, and we will need support in the declare variant as well. That means we need to allow dynamic expressions in OMPTraitInfo and similar places eventually anyway.

Aug 12 2020, 5:11 AM · Restricted Project, Restricted Project, Restricted Project

Apr 6 2020

alokmishra.besu updated the diff for D76211: OpenMP Metadirective with user defined condition.

Updated the test cases.
Fixed an issue where correct code was not generated if directive variant was not provided in when/default clause

Apr 6 2020, 8:44 PM · Restricted Project, Restricted Project, Restricted Project

Mar 24 2020

alokmishra.besu updated the diff for D76211: OpenMP Metadirective with user defined condition.

Updated the test files

Mar 24 2020, 6:47 PM · Restricted Project, Restricted Project, Restricted Project

Mar 17 2020

alokmishra.besu added inline comments to D76211: OpenMP Metadirective with user defined condition.
Mar 17 2020, 7:59 PM · Restricted Project, Restricted Project, Restricted Project
alokmishra.besu updated the diff for D76211: OpenMP Metadirective with user defined condition.

Fixed formatting issues and replaced SmallVector with ArrayRef .

Mar 17 2020, 7:59 PM · Restricted Project, Restricted Project, Restricted Project
alokmishra.besu updated the diff for D76211: OpenMP Metadirective with user defined condition.

Fixed build error and test files

Mar 17 2020, 11:16 AM · Restricted Project, Restricted Project, Restricted Project

Mar 16 2020

alokmishra.besu updated the diff for D76211: OpenMP Metadirective with user defined condition.

Adding test case

Mar 16 2020, 8:44 PM · Restricted Project, Restricted Project, Restricted Project

Mar 15 2020

alokmishra.besu created D76211: OpenMP Metadirective with user defined condition.
Mar 15 2020, 10:18 PM · Restricted Project, Restricted Project, Restricted Project