Page MenuHomePhabricator
Feed Advanced Search

Fri, Dec 3

slydiman added a comment to D111289: [LNT] Refactored the Graph page to use the library plotly instead of jQuery.flot.

Can you update this patch now that some of the changes have landed?

Fri, Dec 3, 11:29 AM · Restricted Project

Mon, Nov 29

slydiman added a comment to D111289: [LNT] Refactored the Graph page to use the library plotly instead of jQuery.flot.

Applying this locally, the regression triangles seem to be gone, was this intentionally?

Mon, Nov 29, 5:37 AM · Restricted Project

Thu, Nov 25

slydiman added inline comments to D114337: Support Windows.
Thu, Nov 25, 2:12 PM · Restricted Project
slydiman added inline comments to D114337: Support Windows.
Thu, Nov 25, 9:42 AM · Restricted Project

Wed, Nov 17

slydiman added inline comments to D112411: [LNT] Updated cPerf to read the section Attributes (support Simpleperf).
Wed, Nov 17, 2:28 AM · Restricted Project

Oct 27 2021

slydiman added a comment to D111289: [LNT] Refactored the Graph page to use the library plotly instead of jQuery.flot.

Please look at https://reviews.llvm.org/D112607

Oct 27 2021, 2:43 AM · Restricted Project

Oct 26 2021

slydiman added inline comments to D112525: [LNT] Add more information to error messages.
Oct 26 2021, 4:18 AM · Restricted Project

Oct 25 2021

slydiman added a comment to D111289: [LNT] Refactored the Graph page to use the library plotly instead of jQuery.flot.

As a start, split the non-patch related changes out. Specifically, at least split the changes in: test_matrix_page.py, test_api.py, the renames, the error message updates in views.py, the refactoring in api.py.

Oct 25 2021, 2:34 PM · Restricted Project
slydiman added inline comments to D112411: [LNT] Updated cPerf to read the section Attributes (support Simpleperf).
Oct 25 2021, 2:26 AM · Restricted Project

Oct 21 2021

slydiman added a comment to D112185: Fix Python2 support in PlistFormat.py.

Looks good.
Probably https://reviews.llvm.org/D112202 is little bit faster on python 2.7.

Oct 21 2021, 12:20 AM

Oct 20 2021

slydiman added a comment to D110839: [LNT] Added reading nm and objdump paths from env variables.

Please add some tests for the environment variables and possibly for the bug fixes depending on what they are. This should also be split into 4 patches, one for each items mentioned. They are all independent, even if you likely made them in one go to get Linux perf work for you. One important reason for splitting is if an issue is found with one of the items the whole patch might need to be reverted. It also allow for easier cherry-pick for people who maintain their own branch of LNT.

Besides the missing tests, the patch LGTM and I'll be happy to approve it.

Oct 20 2021, 8:42 AM · Restricted Project

Oct 6 2021

slydiman added inline comments to D110839: [LNT] Added reading nm and objdump paths from env variables.
Oct 6 2021, 3:45 AM · Restricted Project

Sep 22 2021

slydiman added inline comments to rLNT953e0f220fed: Fixed relative address in LNT profile control-flow graph..
Sep 22 2021, 2:08 AM

Sep 16 2021

slydiman added a comment to D109577: [LNT] Fixed incorrect orders behavior in case of miss formatted llvm_project_revision.

Today I worked with the LNT instance which is configured to generate reports (format_version=1) with run_order like "76543-toolchain-default-heuristic-change-09-13-2021-14:59-392". The limitation to digits and dots will break too much. It is not an option.

Sep 16 2021, 11:13 AM · Restricted Project
slydiman committed rLNT6ba06570364b: Fixed relative address in LNT profile control-flow graph. (authored by slydiman).
Fixed relative address in LNT profile control-flow graph.
Sep 16 2021, 2:14 AM

Sep 12 2021

slydiman added inline comments to D109578: [LNT] Fixed incomplete feature for submit JSON to a local instance.
Sep 12 2021, 2:02 PM · Restricted Project

Sep 3 2021

slydiman added inline comments to D109216: [LNT] Fixed fieldchanges grouping to a regression.
Sep 3 2021, 3:26 AM

Dec 4 2014

slydiman removed a reviewer for D6524: Fixed ParseLocalName() in FastDemangle: vvereschaka.
Dec 4 2014, 9:59 AM
slydiman updated subscribers of D6524: Fixed ParseLocalName() in FastDemangle.
Dec 4 2014, 9:55 AM
slydiman added a reviewer for D6524: Fixed ParseLocalName() in FastDemangle: k8stone.
Dec 4 2014, 9:52 AM
slydiman updated the diff for D6524: Fixed ParseLocalName() in FastDemangle.
Dec 4 2014, 9:41 AM
slydiman added a reviewer for D6524: Fixed ParseLocalName() in FastDemangle: vvereschaka.
Dec 4 2014, 5:52 AM
slydiman updated subscribers of D6524: Fixed ParseLocalName() in FastDemangle.
Dec 4 2014, 5:36 AM
slydiman retitled D6524: Fixed ParseLocalName() in FastDemangle from to Fixed ParseLocalName() in FastDemangle.
Dec 4 2014, 5:33 AM