Page MenuHomePhabricator
Feed Advanced Search

Mon, Oct 19

danielkiss added a comment to D85005: [libunwind] Support DW_CFA_remember/restore_state without heap allocation..

ping

Mon, Oct 19, 7:53 AM

Sat, Oct 17

danielkiss updated the diff for D89570: [WIP][Arm][Unwind] Add _Unwind_ForcedUnwind to EHABI..
Sat, Oct 17, 4:11 PM
danielkiss updated the diff for D89570: [WIP][Arm][Unwind] Add _Unwind_ForcedUnwind to EHABI..

Add a simple test and fixes.
This version passes on arm32 - armv7l-unknown-linux-gnueabihf -

Sat, Oct 17, 4:07 PM
danielkiss planned changes to D89570: [WIP][Arm][Unwind] Add _Unwind_ForcedUnwind to EHABI..
Sat, Oct 17, 1:54 PM

Fri, Oct 16

danielkiss updated the diff for D89570: [WIP][Arm][Unwind] Add _Unwind_ForcedUnwind to EHABI..

_Unwind_Stop_Fn shall not have different signature for EHABI.

Fri, Oct 16, 12:53 PM
danielkiss changed the visibility for D89570: [WIP][Arm][Unwind] Add _Unwind_ForcedUnwind to EHABI..
Fri, Oct 16, 11:05 AM
danielkiss requested review of D89570: [WIP][Arm][Unwind] Add _Unwind_ForcedUnwind to EHABI..
Fri, Oct 16, 11:04 AM

Thu, Oct 15

danielkiss added a comment to D72365: [MTE] Pin the tagged base pointer to one of the stack slots..

Those are gone from the view, so ignore what I said.

Thu, Oct 15, 9:49 AM · Restricted Project

Mon, Oct 12

danielkiss accepted D72365: [MTE] Pin the tagged base pointer to one of the stack slots..

LGTM, just please fix the lint issues in the llvm/lib/Target/AArch64/AArch64MachineFunctionInfo.h

Mon, Oct 12, 6:49 AM · Restricted Project
danielkiss accepted D72366: [AArch64] Stack frame reordering..

LGTM

Mon, Oct 12, 4:05 AM · Restricted Project
danielkiss added a comment to D88027: [libcxx] Add targets to available features..

The system-* and native are used in clang and lldb only, so dropped.
I only added them for consistency across llvm components.

Mon, Oct 12, 4:03 AM · Restricted Project
danielkiss updated the diff for D88027: [libcxx] Add targets to available features..
Mon, Oct 12, 3:58 AM · Restricted Project

Tue, Sep 29

danielkiss committed rGf34ae1b9de68: [AArch64] Add v8.5 Branch Target Identification support. (authored by danielkiss).
[AArch64] Add v8.5 Branch Target Identification support.
Tue, Sep 29, 6:51 AM
danielkiss closed D77786: [AArch64] Add v8.5 Branch Target Identification support..
Tue, Sep 29, 6:51 AM · Unknown Object (Project), Restricted Project
danielkiss committed rGc5a4900e1a00: [AArch64] Add BTI to CFI jumptables. (authored by danielkiss).
[AArch64] Add BTI to CFI jumptables.
Tue, Sep 29, 4:50 AM
danielkiss closed D81251: [AArch64] Add BTI to CFI jumptables..
Tue, Sep 29, 4:50 AM · Restricted Project
danielkiss added inline comments to D85005: [libunwind] Support DW_CFA_remember/restore_state without heap allocation..
Tue, Sep 29, 3:32 AM
danielkiss updated the diff for D85005: [libunwind] Support DW_CFA_remember/restore_state without heap allocation..
Tue, Sep 29, 3:31 AM
danielkiss added a comment to D88027: [libcxx] Add targets to available features..

some test never runs due to these features are missing. I realised this when tried to run this one: https://github.com/llvm/llvm-project/blob/master/libunwind/test/remember_state_leak.pass.sh.s#L1

Tue, Sep 29, 3:14 AM · Restricted Project
danielkiss added reviewers for D88027: [libcxx] Add targets to available features.: jgorbe, lhames.
Tue, Sep 29, 3:13 AM · Restricted Project

Mon, Sep 28

danielkiss added inline comments to D85005: [libunwind] Support DW_CFA_remember/restore_state without heap allocation..
Mon, Sep 28, 8:50 AM
danielkiss updated the diff for D85005: [libunwind] Support DW_CFA_remember/restore_state without heap allocation..
Mon, Sep 28, 8:49 AM
danielkiss committed rGa48f6079f288: [AArch64] Generate .note.gnu.property based on module flags. (authored by danielkiss).
[AArch64] Generate .note.gnu.property based on module flags.
Mon, Sep 28, 5:14 AM
danielkiss closed D80791: [AArch64] Generate .note.gnu.property based on module flags..
Mon, Sep 28, 5:14 AM · Restricted Project, Restricted Project

Sep 25 2020

danielkiss updated the diff for D81251: [AArch64] Add BTI to CFI jumptables..

update module flag handling due to the change is merged in: D85649.

Sep 25 2020, 8:42 AM · Restricted Project
danielkiss updated the diff for D80791: [AArch64] Generate .note.gnu.property based on module flags..
Sep 25 2020, 5:09 AM · Restricted Project, Restricted Project

Sep 24 2020

danielkiss added a comment to D85005: [libunwind] Support DW_CFA_remember/restore_state without heap allocation..

Thanks for the review. It looks like I still need someone from the libunwind group to accept it.

Sep 24 2020, 2:29 PM
danielkiss committed rG2a96f47c5ffc: [AArch64] __builtin_return_address for PAuth. (authored by danielkiss).
[AArch64] __builtin_return_address for PAuth.
Sep 24 2020, 2:24 PM
danielkiss closed D75044: [AArch64] __builtin_return_address for PAuth..
Sep 24 2020, 2:24 PM · Restricted Project, Restricted Project
danielkiss added inline comments to D86972: [IRSim] Adding a basic similarity identifier..
Sep 24 2020, 7:43 AM · Restricted Project
danielkiss accepted D85649: [AArch64] PAC/BTI code generation for LLVM generated functions.

@nickdesaulniers

one kernel image that runs on hardware both with and without BTI ISA extensions?

In case of BTI one image could run on both HW due to BTI is in the no-op space.

Sep 24 2020, 6:32 AM · Restricted Project, Restricted Project
danielkiss added a comment to D75044: [AArch64] __builtin_return_address for PAuth..

@chill ping.

Sep 24 2020, 4:30 AM · Restricted Project, Restricted Project

Sep 21 2020

danielkiss added inline comments to D77786: [AArch64] Add v8.5 Branch Target Identification support..
Sep 21 2020, 2:20 PM · Unknown Object (Project), Restricted Project
danielkiss requested review of D88027: [libcxx] Add targets to available features..
Sep 21 2020, 8:43 AM · Restricted Project
danielkiss accepted D87880: [libunwind] Combine dl_iterate_phdr codepaths for DWARF and EHABI.

LGTM, refactor looks correct. in case of _LIBUNWIND_ARM_EHABI the director of the iteration over the phdrs changed but that is fine.

Sep 21 2020, 2:15 AM · Unknown Object (Project), Restricted Project

Sep 18 2020

danielkiss added a comment to D85649: [AArch64] PAC/BTI code generation for LLVM generated functions.

I think error is fine because realistically linking modules with different BTI settings will result probably a binary that crash runtime anyway if BTI is on.
otherwise turning BTI on just of a subset of object is useless.

Sep 18 2020, 9:43 AM · Restricted Project, Restricted Project
danielkiss committed rG22b615a96593: [libunwind] Support for leaf function unwinding. (authored by danielkiss).
[libunwind] Support for leaf function unwinding.
Sep 18 2020, 6:12 AM
danielkiss updated subscribers of D83573: [libunwind] Support for leaf function unwinding..

Sorry for the trouble for now the patch is reverted.
I you agre I will resubmit it with ; REQUIRES: x86_64-linux and then figure out the rest of the targets later.

Sep 18 2020, 3:20 AM · Unknown Object (Project), Restricted Project
danielkiss added a reverting change for rG23bef7ee9923: [libunwind] Support for leaf function unwinding.: rG5831adb8c38f: Revert "[libunwind] Support for leaf function unwinding.".
Sep 18 2020, 2:38 AM
danielkiss committed rG5831adb8c38f: Revert "[libunwind] Support for leaf function unwinding." (authored by danielkiss).
Revert "[libunwind] Support for leaf function unwinding."
Sep 18 2020, 2:38 AM
danielkiss added a reverting change for D83573: [libunwind] Support for leaf function unwinding.: rG5831adb8c38f: Revert "[libunwind] Support for leaf function unwinding.".
Sep 18 2020, 2:38 AM · Unknown Object (Project), Restricted Project

Sep 17 2020

danielkiss added inline comments to D77786: [AArch64] Add v8.5 Branch Target Identification support..
Sep 17 2020, 1:59 AM · Unknown Object (Project), Restricted Project

Sep 16 2020

danielkiss committed rGf70baaf71f62: [AArch64] Add -mmark-bti-property flag. (authored by danielkiss).
[AArch64] Add -mmark-bti-property flag.
Sep 16 2020, 4:21 PM
danielkiss added a reverting change for rG95e43f84b7b9: [AArch64] Add -mmark-bti-property flag.: rG60e244f82c1f: Revert "[AArch64] Add -mmark-bti-property flag.".
Sep 16 2020, 4:21 PM
danielkiss committed rG60e244f82c1f: Revert "[AArch64] Add -mmark-bti-property flag." (authored by danielkiss).
Revert "[AArch64] Add -mmark-bti-property flag."
Sep 16 2020, 4:21 PM
danielkiss added a reverting change for D81930: [AArch64] Add -mmark-bti-property flag.: rG60e244f82c1f: Revert "[AArch64] Add -mmark-bti-property flag.".
Sep 16 2020, 4:21 PM · Restricted Project, Restricted Project
danielkiss committed rG95e43f84b7b9: [AArch64] Add -mmark-bti-property flag. (authored by danielkiss).
[AArch64] Add -mmark-bti-property flag.
Sep 16 2020, 3:24 PM
danielkiss closed D81930: [AArch64] Add -mmark-bti-property flag..
Sep 16 2020, 3:24 PM · Restricted Project, Restricted Project
danielkiss committed rG23bef7ee9923: [libunwind] Support for leaf function unwinding. (authored by danielkiss).
[libunwind] Support for leaf function unwinding.
Sep 16 2020, 2:54 PM
danielkiss closed D83573: [libunwind] Support for leaf function unwinding..
Sep 16 2020, 2:53 PM · Unknown Object (Project), Restricted Project
danielkiss updated the diff for D81251: [AArch64] Add BTI to CFI jumptables..

rebasing to the new patch series.

Sep 16 2020, 1:56 PM · Restricted Project
danielkiss added inline comments to D81251: [AArch64] Add BTI to CFI jumptables..
Sep 16 2020, 1:52 PM · Restricted Project
danielkiss updated the diff for D80791: [AArch64] Generate .note.gnu.property based on module flags..

Rebased top of D85649.

Sep 16 2020, 9:18 AM · Restricted Project, Restricted Project
danielkiss updated the diff for D85005: [libunwind] Support DW_CFA_remember/restore_state without heap allocation..

adding an option _LIBUNWIND_REMEMBER_HEAP to store the state on the heap.
I kept the default on the stack because it should be fine for most cases.

Sep 16 2020, 7:58 AM
danielkiss accepted D85649: [AArch64] PAC/BTI code generation for LLVM generated functions.

LGTM

Sep 16 2020, 3:51 AM · Restricted Project, Restricted Project

Sep 15 2020

danielkiss added a comment to D81930: [AArch64] Add -mmark-bti-property flag..

@nickdesaulniers Thanks for the review, comments are addressed.

Sep 15 2020, 7:49 AM · Restricted Project, Restricted Project
danielkiss updated the diff for D81930: [AArch64] Add -mmark-bti-property flag..
Sep 15 2020, 7:46 AM · Restricted Project, Restricted Project
danielkiss added inline comments to D83573: [libunwind] Support for leaf function unwinding..
Sep 15 2020, 3:27 AM · Unknown Object (Project), Restricted Project
danielkiss updated the diff for D83573: [libunwind] Support for leaf function unwinding..
Sep 15 2020, 3:26 AM · Unknown Object (Project), Restricted Project

Sep 11 2020

danielkiss planned changes to D77565: [AArch64] Remove implicit landing pads..

I'll update this after other PAC/BTI patches got merged.

Sep 11 2020, 8:53 AM · Restricted Project
danielkiss added reviewers for D81930: [AArch64] Add -mmark-bti-property flag.: nickdesaulniers, srhines, enh, rprichard.
Sep 11 2020, 7:14 AM · Restricted Project, Restricted Project
danielkiss updated the diff for D83573: [libunwind] Support for leaf function unwinding..
Sep 11 2020, 7:10 AM · Unknown Object (Project), Restricted Project
danielkiss added a comment to D85005: [libunwind] Support DW_CFA_remember/restore_state without heap allocation..

ping

Sep 11 2020, 5:04 AM
danielkiss added reviewers for D85005: [libunwind] Support DW_CFA_remember/restore_state without heap allocation.: phosek, mstorsjo, steven_wu.
Sep 11 2020, 5:03 AM

Sep 4 2020

danielkiss added a comment to D75044: [AArch64] __builtin_return_address for PAuth..

@chill Could you check the latest update? I think it should be submitted with D84502 together.

Sep 4 2020, 4:33 AM · Restricted Project, Restricted Project

Sep 1 2020

danielkiss added inline comments to D81251: [AArch64] Add BTI to CFI jumptables..
Sep 1 2020, 4:59 AM · Restricted Project
danielkiss added a comment to D85649: [AArch64] PAC/BTI code generation for LLVM generated functions.

I support the idea, once I proposed back then ( see D75181 )

Sep 1 2020, 4:58 AM · Restricted Project, Restricted Project

Aug 29 2020

danielkiss planned changes to D81251: [AArch64] Add BTI to CFI jumptables..

I need to update it due to changes in the dependent patches.

Aug 29 2020, 6:37 AM · Restricted Project
danielkiss updated the diff for D80791: [AArch64] Generate .note.gnu.property based on module flags..

Sync with D85649.

Aug 29 2020, 6:35 AM · Restricted Project, Restricted Project
danielkiss abandoned D75181: [AArch64] Handle BTI/PAC in case of generated functions..

Abandoning in favour of D85649.

Aug 29 2020, 5:41 AM · Restricted Project, Restricted Project
danielkiss added inline comments to D85649: [AArch64] PAC/BTI code generation for LLVM generated functions.
Aug 29 2020, 5:38 AM · Restricted Project, Restricted Project
danielkiss updated the diff for D81930: [AArch64] Add -mmark-bti-property flag..
Aug 29 2020, 1:51 AM · Restricted Project, Restricted Project

Aug 27 2020

danielkiss added a reviewer for D85005: [libunwind] Support DW_CFA_remember/restore_state without heap allocation.: Restricted Project.
Aug 27 2020, 4:33 AM
danielkiss updated the diff for D75044: [AArch64] __builtin_return_address for PAuth..

updating tests too. check-llvm, check-clang passes.

Aug 27 2020, 4:32 AM · Restricted Project, Restricted Project

Aug 13 2020

danielkiss added inline comments to D81930: [AArch64] Add -mmark-bti-property flag..
Aug 13 2020, 2:06 PM · Restricted Project, Restricted Project
danielkiss updated the diff for D81930: [AArch64] Add -mmark-bti-property flag..

Fix review comments.

Aug 13 2020, 2:04 PM · Restricted Project, Restricted Project
danielkiss updated the diff for D75044: [AArch64] __builtin_return_address for PAuth..

Always emit xpac* instructions as discussed in D84502.

Aug 13 2020, 4:35 AM · Restricted Project, Restricted Project

Aug 11 2020

danielkiss added a comment to D80791: [AArch64] Generate .note.gnu.property based on module flags..

it is not useful to have a bti annotated function unless everything else is bti compatible too: it is all or nothing per elf module.

This is false. Some functions in an elf module could be in a guarded region, some in a non-guarded region. Some function may always
be called in a "BTI-safe" way, which may be unknown to the compiler.

Aug 11 2020, 7:53 AM · Restricted Project, Restricted Project
danielkiss updated the diff for D85005: [libunwind] Support DW_CFA_remember/restore_state without heap allocation..

And now uploading the new patch.

Aug 11 2020, 4:40 AM
danielkiss added inline comments to D83573: [libunwind] Support for leaf function unwinding..
Aug 11 2020, 4:35 AM · Unknown Object (Project), Restricted Project
danielkiss updated the diff for D85005: [libunwind] Support DW_CFA_remember/restore_state without heap allocation..
Aug 11 2020, 4:31 AM

Aug 10 2020

danielkiss added inline comments to D85005: [libunwind] Support DW_CFA_remember/restore_state without heap allocation..
Aug 10 2020, 1:02 PM
danielkiss updated the diff for D85005: [libunwind] Support DW_CFA_remember/restore_state without heap allocation..
Aug 10 2020, 12:59 PM
danielkiss added reviewers for D83573: [libunwind] Support for leaf function unwinding.: Restricted Project, compnerd, jgorbe.
Aug 10 2020, 11:09 AM · Unknown Object (Project), Restricted Project
danielkiss updated the diff for D83573: [libunwind] Support for leaf function unwinding..
Aug 10 2020, 11:07 AM · Unknown Object (Project), Restricted Project
danielkiss added a comment to D85644: AArch64: don't sign the return address in noreturn functions.

The produced code for the non return function might save an unsigned LR to the stack and that might be usable to craft a gadget IMHO. The probability is quite low but still.

Aug 10 2020, 9:52 AM · Restricted Project
danielkiss added a reviewer for D85644: AArch64: don't sign the return address in noreturn functions: danielkiss.
Aug 10 2020, 9:44 AM · Restricted Project

Aug 6 2020

danielkiss accepted D85412: [AArch64][NFC] require aarch64 support for hwasan test.

LGTM

Aug 6 2020, 5:03 AM · Restricted Project

Aug 5 2020

danielkiss added a comment to D84502: [AArch64][GlobalISel] Implement __builtin_return_address for PAC-RET.

XPACI could be emit when it is available, only the if (MF.getFunction().hasFnAttribute("sign-return-address")) { need do be dropped from the patches IMHO.

Aug 5 2020, 9:44 AM · Restricted Project
danielkiss added a comment to D75181: [AArch64] Handle BTI/PAC in case of generated functions..

FWIW GCC has a "sign-return-address" function attribute with a default value of "none". It is considered deprecated, however, in favour of "branch-protection"

This is just the internal representation, the function attribute in C/C++ source is the "branch-protection".

Aug 5 2020, 8:38 AM · Restricted Project, Restricted Project
danielkiss updated the diff for D80791: [AArch64] Generate .note.gnu.property based on module flags..

This version of the patch behaves as gcc for case when no function present and when function has -mbranch-protection attribute without compiler flag.
The logic should be in clang because in llvm we won't have enough information to handle these things. (see D75181)

Aug 5 2020, 2:30 AM · Restricted Project, Restricted Project

Aug 4 2020

danielkiss added a comment to D75181: [AArch64] Handle BTI/PAC in case of generated functions..

Would it be better to add a new value to "sign-return-address" as "none"? I don't see any other alternative option, I'm open to any other idea.

Aug 4 2020, 7:47 AM · Restricted Project, Restricted Project

Aug 3 2020

danielkiss added inline comments to D77786: [AArch64] Add v8.5 Branch Target Identification support..
Aug 3 2020, 5:24 AM · Unknown Object (Project), Restricted Project
danielkiss updated the diff for D77786: [AArch64] Add v8.5 Branch Target Identification support..

fix review comment.

Aug 3 2020, 5:23 AM · Unknown Object (Project), Restricted Project
danielkiss committed rG9c3f6fb68807: [libunwind] Make the test depend on the libunwind explicitly. (authored by danielkiss).
[libunwind] Make the test depend on the libunwind explicitly.
Aug 3 2020, 12:46 AM
danielkiss closed D85004: [libunwind] Make the test depend on the libunwind explicitly..
Aug 3 2020, 12:46 AM · Unknown Object (Project), Restricted Project

Jul 31 2020

danielkiss added a reviewer for D84502: [AArch64][GlobalISel] Implement __builtin_return_address for PAC-RET: danielkiss.
Jul 31 2020, 12:31 PM · Restricted Project
danielkiss added inline comments to D84502: [AArch64][GlobalISel] Implement __builtin_return_address for PAC-RET.
Jul 31 2020, 12:30 PM · Restricted Project
danielkiss added a comment to D84502: [AArch64][GlobalISel] Implement __builtin_return_address for PAC-RET.
Jul 31 2020, 12:24 PM · Restricted Project
danielkiss added a comment to D85004: [libunwind] Make the test depend on the libunwind explicitly..

Added here as I see:
https://github.com/llvm/llvm-project/blob/19bc9ea480b60b607a3e303f20c7a3a2ea553369/libcxxabi/test/CMakeLists.txt#L57

Jul 31 2020, 12:20 PM · Unknown Object (Project), Restricted Project