Page MenuHomePhabricator
Feed Advanced Search

May 19 2020

danielframpton added a comment to D80218: Use configure depends to trigger reconfiguration when LLVMBuild files change.

Looks good to me. I presume we didn't use this because of CMake version dependencies. Was this feature available in our current minimum CMake version?

May 19 2020, 10:55 AM · Restricted Project
danielframpton created D80218: Use configure depends to trigger reconfiguration when LLVMBuild files change.
May 19 2020, 8:42 AM · Restricted Project

Mar 31 2020

danielframpton added a comment to D77015: Fix mismatch in prologue and epilogue for funclets on AArch64 Windows.

LGTM

I assume you don't have commit access, so I'll commit it for you.

That would be great. I am doing some final validation of the version you accepted (using it to self-host rustc). I will let you know that is complete.

Mar 31 2020, 2:10 AM · Restricted Project
danielframpton added a comment to D77016: Change AArch64 Windows EH UnwindHelp object to be a fixed object.

LGTM

I assume you don't have commit access, so I'll commit it for you. How would you like me to credit you in the commit message (name and email address)?

(The unnecessary alignment is probably something we could fix, but not worth the complexity.)

I do not have commit access, so that would be very helpful, Thanks! You can use Daniel Frampton <Daniel.Frampton@microsoft.com>

I am doing some final validation of the version you accepted (using it to self-host rustc on windows). I will let you know that is complete.

Mar 31 2020, 2:10 AM · Restricted Project

Mar 30 2020

danielframpton added a comment to D77015: Fix mismatch in prologue and epilogue for funclets on AArch64 Windows.

LGTM

I assume you don't have commit access, so I'll commit it for you.

Mar 30 2020, 11:25 PM · Restricted Project
danielframpton added a comment to D77016: Change AArch64 Windows EH UnwindHelp object to be a fixed object.

LGTM

I assume you don't have commit access, so I'll commit it for you. How would you like me to credit you in the commit message (name and email address)?

(The unnecessary alignment is probably something we could fix, but not worth the complexity.)

I do not have commit access, so that would be very helpful, Thanks! You can use Daniel Frampton <Daniel.Frampton@microsoft.com>

Mar 30 2020, 11:25 PM · Restricted Project
danielframpton updated the summary of D77015: Fix mismatch in prologue and epilogue for funclets on AArch64 Windows.
Mar 30 2020, 5:29 PM · Restricted Project
danielframpton added a comment to D77016: Change AArch64 Windows EH UnwindHelp object to be a fixed object.

LGTM

I assume you don't have commit access, so I'll commit it for you. How would you like me to credit you in the commit message (name and email address)?

(The unnecessary alignment is probably something we could fix, but not worth the complexity.)

Mar 30 2020, 2:44 PM · Restricted Project

Mar 29 2020

danielframpton added a comment to D77016: Change AArch64 Windows EH UnwindHelp object to be a fixed object.

Added responses to the review and pointed out places where there are important codegen differences.

Mar 29 2020, 3:00 PM · Restricted Project
danielframpton updated the diff for D77015: Fix mismatch in prologue and epilogue for funclets on AArch64 Windows.

Updated to include context.

Mar 29 2020, 2:28 PM · Restricted Project
danielframpton added a comment to D77016: Change AArch64 Windows EH UnwindHelp object to be a fixed object.

Thanks for the review!

Mar 29 2020, 2:28 PM · Restricted Project
danielframpton updated the diff for D77016: Change AArch64 Windows EH UnwindHelp object to be a fixed object.

Updates from review feedback.

Mar 29 2020, 2:28 PM · Restricted Project
danielframpton added inline comments to D77015: Fix mismatch in prologue and epilogue for funclets on AArch64 Windows.
Mar 29 2020, 12:50 PM · Restricted Project
danielframpton updated the diff for D77015: Fix mismatch in prologue and epilogue for funclets on AArch64 Windows.

Move the COPY to after the end of the prologue (SEH_PrologEnd) as suggested in the review.

Mar 29 2020, 12:50 PM · Restricted Project
danielframpton added a comment to D77015: Fix mismatch in prologue and epilogue for funclets on AArch64 Windows.

If I'm understanding correctly, the space that wasn't getting allocated in the prologue is the space for arguments to calls inside the funclet?

Mar 29 2020, 12:50 PM · Restricted Project
danielframpton created D77016: Change AArch64 Windows EH UnwindHelp object to be a fixed object.
Mar 29 2020, 10:08 AM · Restricted Project
danielframpton created D77015: Fix mismatch in prologue and epilogue for funclets on AArch64 Windows.
Mar 29 2020, 10:08 AM · Restricted Project