@MaskRay It seems linkerMain is okay?
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Dec 11 2020
Rename LinkerDriver::link and LinkerDriver::main (in ELF) to LinkerDriver::linkerMain
Dec 3 2020
In D91418#2431314, @MaskRay wrote:I think changing from main to to avoids an issue and adds a new issue. We should fix the issues all together, and this requires consensus from others ports to proceed.
In D91418#2430988, @aganea wrote:This is consistent with the other drivers, LGTM.
Do you have commit access? Please ask for it if you're planning more changes in the future. Otherwise I can land it for you.
Ping
Nov 19 2020
link seems to be a more consistent name as pointed out by @MaskRay
Can we ignore its clash with lld::*::link as the general intent with setting a breakpoint at main is to trap the main function and not the lld::elf::LinkerDriver::main which may not be true for link
Nov 14 2020
However I think this current patch is orthogonal to all that and simply aims to solve a gdb breakpoint issue?
In D91418#2394337, @MaskRay wrote:I am always trapped on this. In gdb both b main and b ::main set a breakpoint on lld::elf::LinkerDriver::main. For consistency, I would suggest lld::*::LinkerDriver::link which is used by COFF and wasm ports. However, that has the name collision problems with the free functions lld::*::link... (This may be less of a problem because developers don't often set breakpoints on link? :) )