Page MenuHomePhabricator
Feed Advanced Search

Yesterday

CarolineConcatto added a comment to D92094: [CostModel]Replace FixedVectorType by VectorType in costgetIntrinsicInstrCost.

Thank you @samparker for your review. I agree with you that we should also test the code path of getCmpSelInstrCost and getArithmeticInstrCost, but at the moment these code paths were/are broken for scalable vector.
We are working to make these paths work for scalable vectors by replacing FixedVector with VectorType and using the ElementType class.
These will be addressed in upcoming patches. I don’t think that we should fix these code paths in this patch because the chain to fix it is long and will make the patch long and complex
What I can do is add tests with XFAIL for now, and remove in the future.
Is this a good solution for now?

Fri, Nov 27, 1:57 AM · Restricted Project

Wed, Nov 25

CarolineConcatto added reviewers for D92094: [CostModel]Replace FixedVectorType by VectorType in costgetIntrinsicInstrCost: sdesmalen, david-arm, ctetreau, samparker.
Wed, Nov 25, 5:33 AM · Restricted Project
CarolineConcatto requested review of D92094: [CostModel]Replace FixedVectorType by VectorType in costgetIntrinsicInstrCost.
Wed, Nov 25, 5:30 AM · Restricted Project

Wed, Nov 18

CarolineConcatto added inline comments to D91532: [NFC][CostModel]Extend class IntrinsicCostAttributes to use ElementCount Type.
Wed, Nov 18, 7:52 AM · Restricted Project
CarolineConcatto added inline comments to D91532: [NFC][CostModel]Extend class IntrinsicCostAttributes to use ElementCount Type.
Wed, Nov 18, 5:29 AM · Restricted Project
CarolineConcatto updated the diff for D91532: [NFC][CostModel]Extend class IntrinsicCostAttributes to use ElementCount Type.

-address review's comment

Wed, Nov 18, 5:20 AM · Restricted Project

Mon, Nov 16

CarolineConcatto retitled D91532: [NFC][CostModel]Extend class IntrinsicCostAttributes to use ElementCount Type from [SVE][CostModel]Extend class IntrinsicCostAttributes to use ElementCount Type to [NFC][CostModel]Extend class IntrinsicCostAttributes to use ElementCount Type.
Mon, Nov 16, 7:44 AM · Restricted Project
CarolineConcatto added reviewers for D91532: [NFC][CostModel]Extend class IntrinsicCostAttributes to use ElementCount Type: sdesmalen, david-arm, ctetreau, samparker.
Mon, Nov 16, 5:32 AM · Restricted Project
CarolineConcatto updated the diff for D91532: [NFC][CostModel]Extend class IntrinsicCostAttributes to use ElementCount Type.

-remove non-related changes on Target AMDGPU

Mon, Nov 16, 5:22 AM · Restricted Project
CarolineConcatto requested review of D91532: [NFC][CostModel]Extend class IntrinsicCostAttributes to use ElementCount Type.
Mon, Nov 16, 5:14 AM · Restricted Project
CarolineConcatto committed rG6c4d8f4651fd: [AArch64] Add check for widening instruction for SVE. (authored by CarolineConcatto).
[AArch64] Add check for widening instruction for SVE.
Mon, Nov 16, 4:53 AM
CarolineConcatto closed D91260: [AArch64] Add check for widening instruction for SVE..
Mon, Nov 16, 4:53 AM · Restricted Project

Fri, Nov 13

CarolineConcatto updated the diff for D91260: [AArch64] Add check for widening instruction for SVE..
  • add a warning check in the llvm test
Fri, Nov 13, 7:04 AM · Restricted Project

Wed, Nov 11

CarolineConcatto added reviewers for D91260: [AArch64] Add check for widening instruction for SVE.: sdesmalen, mssimpso.
Wed, Nov 11, 7:08 AM · Restricted Project
CarolineConcatto requested review of D91260: [AArch64] Add check for widening instruction for SVE..
Wed, Nov 11, 7:04 AM · Restricted Project
CarolineConcatto committed rG37f4ccb27545: [AArch64]Add memory op cost model for SVE (authored by CarolineConcatto).
[AArch64]Add memory op cost model for SVE
Wed, Nov 11, 4:55 AM
CarolineConcatto closed D90950: [AArch64]Add memory op cost model for SVE.
Wed, Nov 11, 4:55 AM · Restricted Project

Mon, Nov 9

CarolineConcatto added inline comments to D90950: [AArch64]Add memory op cost model for SVE.
Mon, Nov 9, 5:44 AM · Restricted Project
CarolineConcatto retitled D90950: [AArch64]Add memory op cost model for SVE from [AArch64]Add memory op cost model for Neon to [AArch64]Add memory op cost model for SVE.
Mon, Nov 9, 5:43 AM · Restricted Project
CarolineConcatto updated the diff for D90950: [AArch64]Add memory op cost model for SVE.
  • address review's comment
Mon, Nov 9, 5:22 AM · Restricted Project

Fri, Nov 6

CarolineConcatto added reviewers for D90950: [AArch64]Add memory op cost model for SVE: sdesmalen, evandro, t.p.northover, david-arm, kmclaughlin.
Fri, Nov 6, 8:28 AM · Restricted Project
CarolineConcatto requested review of D90950: [AArch64]Add memory op cost model for SVE.
Fri, Nov 6, 8:22 AM · Restricted Project

Mon, Nov 2

CarolineConcatto accepted D90300: [flang][driver] Rename the accessors (NFC).

Thank you @awarzynski,
LGTM!

Mon, Nov 2, 2:42 AM · Restricted Project
CarolineConcatto added a reverting change for rG8b281bfaf35d: [AArch64][AsmParser] Remove 'x31' alias for 'sp/xzr' register.: rG71038788ce1a: Revert "[AArch64][AsmParser] Remove 'x31' alias for 'sp/xzr' register.".
Mon, Nov 2, 12:17 AM
CarolineConcatto committed rG71038788ce1a: Revert "[AArch64][AsmParser] Remove 'x31' alias for 'sp/xzr' register." (authored by CarolineConcatto).
Revert "[AArch64][AsmParser] Remove 'x31' alias for 'sp/xzr' register."
Mon, Nov 2, 12:17 AM
CarolineConcatto added a reverting change for D90153: [AArch64][AsmParser] Remove 'x31' alias for 'sp/xzr' register.: rG71038788ce1a: Revert "[AArch64][AsmParser] Remove 'x31' alias for 'sp/xzr' register.".
Mon, Nov 2, 12:17 AM · Restricted Project

Sun, Nov 1

CarolineConcatto committed rG8b281bfaf35d: [AArch64][AsmParser] Remove 'x31' alias for 'sp/xzr' register. (authored by CarolineConcatto).
[AArch64][AsmParser] Remove 'x31' alias for 'sp/xzr' register.
Sun, Nov 1, 11:58 PM
CarolineConcatto closed D90153: [AArch64][AsmParser] Remove 'x31' alias for 'sp/xzr' register..
Sun, Nov 1, 11:58 PM · Restricted Project

Oct 29 2020

CarolineConcatto updated the diff for D90153: [AArch64][AsmParser] Remove 'x31' alias for 'sp/xzr' register..

-update message on the release note for llvm

Oct 29 2020, 11:16 AM · Restricted Project
CarolineConcatto updated the diff for D90153: [AArch64][AsmParser] Remove 'x31' alias for 'sp/xzr' register..
  • update the release note page on llvm
Oct 29 2020, 10:53 AM · Restricted Project

Oct 28 2020

CarolineConcatto accepted D90306: [flang][driver] Use --match-full-lines in tests for `-test-io`.

It looks good to me Andrzej.
As it is only test changes I do not expect this to be a problem outside flang.

Oct 28 2020, 7:43 AM · Restricted Project
CarolineConcatto added a comment to D90300: [flang][driver] Rename the accessors (NFC).

Thank you @awarzynski for changing this to be compatible with Flang style, it is not the nicest job.
First time we implemented it was very different so I missed some standards.
What I notice is that you did not changed any of the get for diagnostic. Is there any reasons for that?

Oct 28 2020, 7:33 AM · Restricted Project

Oct 26 2020

CarolineConcatto added reviewers for D90153: [AArch64][AsmParser] Remove 'x31' alias for 'sp/xzr' register.: sdesmalen, SjoerdMeijer, c-rhodes.
Oct 26 2020, 6:59 AM · Restricted Project
CarolineConcatto requested review of D90153: [AArch64][AsmParser] Remove 'x31' alias for 'sp/xzr' register..
Oct 26 2020, 6:50 AM · Restricted Project

Oct 23 2020

CarolineConcatto committed rG241563647555: [SVE]Clarify TypeSize comparisons in llvm/lib/Transforms (authored by CarolineConcatto).
[SVE]Clarify TypeSize comparisons in llvm/lib/Transforms
Oct 23 2020, 1:16 AM
CarolineConcatto closed D89703: [SVE]Clarify TypeSize comparisons in llvm/lib/Transforms.
Oct 23 2020, 1:15 AM · Restricted Project

Oct 21 2020

CarolineConcatto retitled D89703: [SVE]Clarify TypeSize comparisons in llvm/lib/Transforms from [SVE][ValueTracking] Clarify TypeSize comparisons in llvm/lib/Transforms to [SVE]Clarify TypeSize comparisons in llvm/lib/Transforms.
Oct 21 2020, 8:11 AM · Restricted Project
CarolineConcatto added a comment to D89703: [SVE]Clarify TypeSize comparisons in llvm/lib/Transforms.

Thank you Sander and David.
I've changed the points you've raised.
I had to run some test to make sure no scalable vectors would reach the places you've raised.
We can relax, atm no scalable vectors can reach the paths where we are using getFixedSize().

Oct 21 2020, 7:59 AM · Restricted Project
CarolineConcatto updated the diff for D89703: [SVE]Clarify TypeSize comparisons in llvm/lib/Transforms.

-address review's comments

Oct 21 2020, 7:54 AM · Restricted Project

Oct 19 2020

CarolineConcatto added reviewers for D89703: [SVE]Clarify TypeSize comparisons in llvm/lib/Transforms: david-arm, sdesmalen.
Oct 19 2020, 8:16 AM · Restricted Project
CarolineConcatto requested review of D89703: [SVE]Clarify TypeSize comparisons in llvm/lib/Transforms.
Oct 19 2020, 8:12 AM · Restricted Project

Oct 16 2020

CarolineConcatto committed rGe8d9ee9c7cfe: [SVE][CodeGen]Use getFixedSize() function for TypeSize comparison in clang (authored by CarolineConcatto).
[SVE][CodeGen]Use getFixedSize() function for TypeSize comparison in clang
Oct 16 2020, 3:23 AM
CarolineConcatto closed D89312: [SVE][CodeGen]Use getFixedSize() function for TypeSize comparison in clang.
Oct 16 2020, 3:22 AM · Restricted Project

Oct 15 2020

CarolineConcatto committed rG145e44bb1885: [SVE]Fix implicit TypeSize casts in EmitCheckValue (authored by CarolineConcatto).
[SVE]Fix implicit TypeSize casts in EmitCheckValue
Oct 15 2020, 5:31 AM
CarolineConcatto closed D89313: [SVE]Fix implicit TypeSize casts in EmitCheckValue.
Oct 15 2020, 5:30 AM · Restricted Project

Oct 13 2020

CarolineConcatto retitled D89312: [SVE][CodeGen]Use getFixedSize() function for TypeSize comparison in clang from [SVE][CodeGen]Use TypeSize comparison functions in clang to [SVE][CodeGen]Use getFixedSize() function for TypeSize comparison in clang.
Oct 13 2020, 9:22 AM · Restricted Project
CarolineConcatto updated the diff for D89312: [SVE][CodeGen]Use getFixedSize() function for TypeSize comparison in clang.

-Use getFixedSize instead of isKnowXY

Oct 13 2020, 9:20 AM · Restricted Project
CarolineConcatto updated the summary of D89313: [SVE]Fix implicit TypeSize casts in EmitCheckValue.
Oct 13 2020, 7:21 AM · Restricted Project
CarolineConcatto updated the summary of D89312: [SVE][CodeGen]Use getFixedSize() function for TypeSize comparison in clang.
Oct 13 2020, 7:19 AM · Restricted Project
CarolineConcatto retitled D89313: [SVE]Fix implicit TypeSize casts in EmitCheckValue from Fix implicit TypeSize casts in EmitCheckValue to [SVE]Fix implicit TypeSize casts in EmitCheckValue.
Oct 13 2020, 6:53 AM · Restricted Project
CarolineConcatto added a reviewer for D89313: [SVE]Fix implicit TypeSize casts in EmitCheckValue: sdesmalen.
Oct 13 2020, 6:52 AM · Restricted Project
CarolineConcatto retitled D89312: [SVE][CodeGen]Use getFixedSize() function for TypeSize comparison in clang from [SVE][CodeGen]Use TypeSize comparison operators in clang to [SVE][CodeGen]Use TypeSize comparison functions in clang.
Oct 13 2020, 6:52 AM · Restricted Project
CarolineConcatto added a reviewer for D89313: [SVE]Fix implicit TypeSize casts in EmitCheckValue: david-arm.
Oct 13 2020, 6:15 AM · Restricted Project
CarolineConcatto requested review of D89313: [SVE]Fix implicit TypeSize casts in EmitCheckValue.
Oct 13 2020, 6:14 AM · Restricted Project
CarolineConcatto added a reviewer for D89312: [SVE][CodeGen]Use getFixedSize() function for TypeSize comparison in clang: david-arm.
Oct 13 2020, 5:43 AM · Restricted Project
CarolineConcatto requested review of D89312: [SVE][CodeGen]Use getFixedSize() function for TypeSize comparison in clang.
Oct 13 2020, 5:43 AM · Restricted Project

Oct 9 2020

CarolineConcatto accepted D89030: flang-aarch64: Refine the number of parallel jobs.

Thank you @awarzynski.

Oct 9 2020, 12:06 AM

Oct 6 2020

CarolineConcatto accepted D88874: flang-aarch64-ubuntu-clang-build: increase the number of parellel jobs.

Thank you @awarzynski for making the slave faster.

Oct 6 2020, 2:51 AM

Oct 5 2020

CarolineConcatto accepted D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend.

Thank you @awarzynski for working on this.
It is good because now we do not depend on clang frontend to build flang frontend.
LGTM

Oct 5 2020, 2:27 AM · Restricted Project
CarolineConcatto accepted D88811: flang-aarch64-ubuntu-clang: Refine the set-up for `-WError`.

LGTM

Oct 5 2020, 1:09 AM

Oct 4 2020

CarolineConcatto added a reviewer for D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O: sameeranjoshi.
Oct 4 2020, 12:11 PM · Restricted Project, Restricted Project, Restricted Project
CarolineConcatto added a comment to D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O.

@awarzynski patch updated.

Oct 4 2020, 11:55 AM · Restricted Project, Restricted Project, Restricted Project
CarolineConcatto updated the diff for D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O.

address reviews comment

Oct 4 2020, 11:47 AM · Restricted Project, Restricted Project, Restricted Project

Sep 28 2020

CarolineConcatto added a comment to D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend.

Hi Folks,
@awarzynski and @sameeranjoshi, Diana was working in an out-of-tree build.

Sep 28 2020, 11:58 PM · Restricted Project
CarolineConcatto added a comment to D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend.

Thank you @awarzynski for updating the patch.
It looks good to me. I've build it locally and played a little bit.
It works fine with gcc9.3. I did not try to build out-of-tree. But I don't see any reason it should not work.
I have two minor comments. But besides that the patch looks good to me.
If you fix them it is all fine for me.

Sep 28 2020, 1:27 AM · Restricted Project
CarolineConcatto retitled D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O from [Flang][Driver] Add InputOutputTest frontend action with new -test-IO flag to [Flang][Driver] Add infrastructure for basic frontend actions and file I/O.
Sep 28 2020, 1:03 AM · Restricted Project, Restricted Project, Restricted Project
CarolineConcatto updated the diff for D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction.

Remove -E from FlangOptions

Sep 28 2020, 12:09 AM · Restricted Project, Restricted Project

Sep 27 2020

CarolineConcatto added a reviewer for D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction: awarzynski.
Sep 27 2020, 10:41 AM · Restricted Project, Restricted Project
CarolineConcatto updated the diff for D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction.

Fix typos

Sep 27 2020, 10:40 AM · Restricted Project, Restricted Project
CarolineConcatto requested review of D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction.
Sep 27 2020, 10:33 AM · Restricted Project, Restricted Project

Sep 25 2020

CarolineConcatto updated the diff for D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O.

Rebase on top of master

Sep 25 2020, 9:53 AM · Restricted Project, Restricted Project, Restricted Project
CarolineConcatto added a comment to D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O.

@awarzynski thank you for the review.
It is a big patch to review at once.
I accepted almost all of your changes.

Sep 25 2020, 5:54 AM · Restricted Project, Restricted Project, Restricted Project
CarolineConcatto updated the diff for D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O.

Solve review comments

Sep 25 2020, 5:42 AM · Restricted Project, Restricted Project, Restricted Project

Sep 24 2020

CarolineConcatto added inline comments to D88219: [flang][driver] Remove unnecessary includes in the unittest.
Sep 24 2020, 5:15 AM · Restricted Project

Sep 23 2020

CarolineConcatto accepted D88108: [flang][driver] Fix options flang in the frontend driver.

Thank you @awarzynski.
I've missed that on the previous patch.

Sep 23 2020, 2:23 AM · Restricted Project

Sep 22 2020

CarolineConcatto added a comment to D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend.

Thank you @awarzynski for this patch.
Very good that you added color feature for Fortran.
It is just a shame that we do not test. Is there a way to add a regression test for it?
I don't see any inconsistency with what we have on clang side, so it is good.
My comments are in the code, but two things that need an overall look:
1- style is not yet according to Flang, mainly functions and variables in the classes
2 -I believe that the name space is Fortran::frontend to be consistent with the other files at Frontend.

Sep 22 2020, 2:24 AM · Restricted Project

Sep 21 2020

CarolineConcatto committed rZORG965bd9eb785e: Update recipe for flang-aarch64 slaves (authored by CarolineConcatto).
Update recipe for flang-aarch64 slaves
Sep 21 2020, 11:55 PM
CarolineConcatto closed D87125: Update recipe for flang-aarch64 slaves.
Sep 21 2020, 11:55 PM
CarolineConcatto added a comment to D87125: Update recipe for flang-aarch64 slaves.

@gkistanova is now fine?

Sep 21 2020, 6:37 AM

Sep 20 2020

CarolineConcatto updated the diff for D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O.
  • remove changes from cmakefiles
Sep 20 2020, 11:28 AM · Restricted Project, Restricted Project, Restricted Project
CarolineConcatto added a reviewer for D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O: awarzynski.
Sep 20 2020, 11:14 AM · Restricted Project, Restricted Project, Restricted Project
CarolineConcatto requested review of D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O.
Sep 20 2020, 11:13 AM · Restricted Project, Restricted Project, Restricted Project
CarolineConcatto updated the summary of D87125: Update recipe for flang-aarch64 slaves.
Sep 20 2020, 10:12 AM
CarolineConcatto updated the diff for D87125: Update recipe for flang-aarch64 slaves.

Update compile location for flang-aarch64-ubuntu{clang and gcc10}

Sep 20 2020, 10:11 AM

Sep 11 2020

CarolineConcatto committed rG257b29715bb2: [flang][driver] Add the new flang compiler and frontend drivers (authored by CarolineConcatto).
[flang][driver] Add the new flang compiler and frontend drivers
Sep 11 2020, 3:01 AM
CarolineConcatto closed D86089: [flang][driver]Add experimental flang driver and frontend with help screen.
Sep 11 2020, 3:00 AM · Restricted Project, Restricted Project, Restricted Project

Sep 10 2020

CarolineConcatto added a comment to D87125: Update recipe for flang-aarch64 slaves.

Thank you @gkistanova, I did miss that.
It was updated on my local repo, but not in here.

Sep 10 2020, 11:42 PM
CarolineConcatto retitled D87125: Update recipe for flang-aarch64 slaves from Add extra recipient mail for flang-aarch64 slaves to Update recipe for flang-aarch64 slaves.
Sep 10 2020, 11:40 PM

Sep 9 2020

CarolineConcatto updated the diff for D87125: Update recipe for flang-aarch64 slaves.

Add the build of the new driver as default for flang-aarch64 slaves

Sep 9 2020, 5:43 AM
CarolineConcatto committed rG0fd425af071a: [flang]Add Semantic Checks for OpenMP Allocate Clause (authored by Rin).
[flang]Add Semantic Checks for OpenMP Allocate Clause
Sep 9 2020, 4:09 AM
CarolineConcatto closed D86051: [flang]Add Semantic Checks for OpenMP Allocate Clause.
Sep 9 2020, 4:09 AM · Restricted Project, Restricted Project, Restricted Project
CarolineConcatto added a comment to D87125: Update recipe for flang-aarch64 slaves.

@gkistanova is it fine for me to push?

Sep 9 2020, 1:21 AM

Sep 4 2020

CarolineConcatto updated the diff for D87125: Update recipe for flang-aarch64 slaves.

-correct mail for flang

Sep 4 2020, 12:19 AM
CarolineConcatto requested review of D87125: Update recipe for flang-aarch64 slaves.
Sep 4 2020, 12:16 AM

Aug 23 2020

CarolineConcatto added a comment to D86089: [flang][driver]Add experimental flang driver and frontend with help screen.

Hey Folks,
Fist of all, thank you very much for your review.
I have answered some questions and update some of the requests.
There are some that I did not had time to go inside yet.
I have the week of 24th off. IN my return I will tackle all the reviews as:
out of build tree
and some question about the driver

Aug 23 2020, 1:55 PM · Restricted Project, Restricted Project, Restricted Project
CarolineConcatto updated the diff for D86089: [flang][driver]Add experimental flang driver and frontend with help screen.

Address review comments

Aug 23 2020, 1:15 PM · Restricted Project, Restricted Project, Restricted Project

Aug 19 2020

CarolineConcatto committed rG33c554d8444a: [clang][driver]Add quotation mark in test/fortran.f95 to avoid false positive (authored by CarolineConcatto).
[clang][driver]Add quotation mark in test/fortran.f95 to avoid false positive
Aug 19 2020, 9:55 AM
CarolineConcatto closed D86132: [clang][driver]Add quotation mark in test/fortran.f95 to avoid false positive.
Aug 19 2020, 9:55 AM · Restricted Project
CarolineConcatto added a comment to D85622: Separate the Registration from Loading dialects in the Context.

@mehdi_amini this patch is breaking flang buildbot.
http://lab.llvm.org:8011/builders/flang-aarch64-ubuntu/builds/2928
Do you mind to revert?

Aug 19 2020, 9:51 AM · Restricted Project

Aug 18 2020

CarolineConcatto updated the diff for D86132: [clang][driver]Add quotation mark in test/fortran.f95 to avoid false positive.

Missing a -

Aug 18 2020, 5:21 AM · Restricted Project