Page MenuHomePhabricator
Feed Advanced Search

Mar 23 2020

krytarowski created D76665: [asan] Stop instrumenting user-defined ELF sections.
Mar 23 2020, 8:41 PM · Restricted Project, Restricted Project

Mar 17 2020

krytarowski added inline comments to D73245: Avoid using std::max_align_t in pre-C++11 mode.
Mar 17 2020, 5:06 AM · Restricted Project

Mar 15 2020

krytarowski committed rG7f6b25ad1bb3: [compiler-rt] [netbsd] Add support for the MKIPFILTER=no distribution (authored by krytarowski).
[compiler-rt] [netbsd] Add support for the MKIPFILTER=no distribution
Mar 15 2020, 5:10 PM

Feb 20 2020

krytarowski added a comment to D73067: [lldb/CMake] Auto-generate the Initialize and Terminate calls for plugin.

Autogeneration of the code puts extra burden on us for tracking what is defined where and for repackaging LLDB with custom build rules (we need plain Makefile in the distribution). I presume the same problem is for gn users, for FreeBSD etc.

Feb 20 2020, 10:38 AM · Restricted Project

Feb 11 2020

krytarowski committed rGb664321ff14f: [compiler-rt] Restrict sanitizer_linux.cpp dlinfo(3) to FreeBSD (authored by krytarowski).
[compiler-rt] Restrict sanitizer_linux.cpp dlinfo(3) to FreeBSD
Feb 11 2020, 3:16 AM

Feb 10 2020

krytarowski accepted D73990: [Sanitizers] Get link map on FreeBSD via documented API.
Feb 10 2020, 3:14 AM · Restricted Project, Restricted Project

Feb 9 2020

krytarowski committed rG273f638384d6: [LLDB] [doc] Document NetBSD status and sort OSs alphabetically (authored by krytarowski).
[LLDB] [doc] Document NetBSD status and sort OSs alphabetically
Feb 9 2020, 9:05 AM
krytarowski committed rG5a285f207e10: [LLDB] [doc] Remove note about libpanel(3) and NetBSD (authored by krytarowski).
[LLDB] [doc] Remove note about libpanel(3) and NetBSD
Feb 9 2020, 6:03 AM
krytarowski committed rG0ea4d18a288b: [LLDB] [doc] Update the current status of pkgsrc (NetBSD) building (authored by krytarowski).
[LLDB] [doc] Update the current status of pkgsrc (NetBSD) building
Feb 9 2020, 6:03 AM

Feb 7 2020

krytarowski added inline comments to D73990: [Sanitizers] Get link map on FreeBSD via documented API.
Feb 7 2020, 12:28 AM · Restricted Project, Restricted Project

Feb 6 2020

krytarowski added inline comments to D73990: [Sanitizers] Get link map on FreeBSD via documented API.
Feb 6 2020, 7:57 AM · Restricted Project, Restricted Project
krytarowski added inline comments to D73990: [Sanitizers] Get link map on FreeBSD via documented API.
Feb 6 2020, 6:17 AM · Restricted Project, Restricted Project
krytarowski added a comment to D73990: [Sanitizers] Get link map on FreeBSD via documented API.

systems were not supported by hard coding 560

Feb 6 2020, 3:10 AM · Restricted Project, Restricted Project

Feb 5 2020

krytarowski accepted D73802: [lldb] Introduce i386 support in NetBSD Process plugin.
Feb 5 2020, 12:50 AM · Restricted Project

Feb 4 2020

krytarowski resigned from D73976: [compiler-rt] fix OpenBSD and Solaris build with sigaltstack interception.

NetBSD fix landed here:

Feb 4 2020, 2:41 PM · Restricted Project, Restricted Project
krytarowski committed rGb79b7674eb47: [compiler-rt] [netbsd] Fix build after "implement sigaltstack interception" (authored by krytarowski).
[compiler-rt] [netbsd] Fix build after "implement sigaltstack interception"
Feb 4 2020, 2:33 PM
krytarowski added a comment to D73990: [Sanitizers] Get link map on FreeBSD via documented API.

I will mirror it in NetBSD whatever will be decided here.

Feb 4 2020, 2:05 PM · Restricted Project, Restricted Project
krytarowski added a comment to D73816: [compiler-rt] implement sigaltstack interception.

For fixing NetBSD, remember to go for #define sigaltstack __sigaltstack14 as the symbol is renamed.

Feb 4 2020, 6:05 AM · Restricted Project, Restricted Project

Feb 1 2020

krytarowski added inline comments to D73802: [lldb] Introduce i386 support in NetBSD Process plugin.
Feb 1 2020, 4:01 PM · Restricted Project
krytarowski added inline comments to D73802: [lldb] Introduce i386 support in NetBSD Process plugin.
Feb 1 2020, 8:47 AM · Restricted Project
krytarowski added inline comments to D73802: [lldb] Introduce i386 support in NetBSD Process plugin.
Feb 1 2020, 12:23 AM · Restricted Project

Jan 31 2020

krytarowski added inline comments to D73802: [lldb] Introduce i386 support in NetBSD Process plugin.
Jan 31 2020, 1:50 PM · Restricted Project
krytarowski committed rG3a200f3f2e52: [compiler-rt] Fix build on NetBSD 9.99.44 (authored by krytarowski).
[compiler-rt] Fix build on NetBSD 9.99.44
Jan 31 2020, 6:02 AM

Jan 23 2020

krytarowski added a comment to D63785: Add support for MUSL libc.

(!defined(__MUSL__) || !__MUSL__) is pretty ugly. There is obviously a need for SANITIZER_MUSL, but then it's up to Linux maintainers whether to accept it.

Jan 23 2020, 10:48 AM · Restricted Project, Restricted Project

Jan 13 2020

krytarowski accepted D72578: [compiler-rt] [builtins] Fix clear_cache_test to work with MPROTECT.
Jan 13 2020, 12:25 AM · Restricted Project, Restricted Project

Jan 2 2020

krytarowski added a comment to D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld).

LLVM Release Schedule: 10.0.0: Jan 15, 2020: branch, then rc1

Jan 2 2020, 8:16 PM · Restricted Project, Restricted Project, lld
krytarowski committed rG0da15ff31848: [compiler-rt] [netbsd] Switch to syscall for ThreadSelfTlsTcb() (authored by krytarowski).
[compiler-rt] [netbsd] Switch to syscall for ThreadSelfTlsTcb()
Jan 2 2020, 5:48 PM

Jan 1 2020

krytarowski added a comment to D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld).

Ping?

Jan 1 2020, 6:34 AM · Restricted Project, Restricted Project, lld

Dec 27 2019

krytarowski committed rG84afd9c5368c: [compiler-rt] [netbsd] Add support for versioned statvfs interceptors (authored by krytarowski).
[compiler-rt] [netbsd] Add support for versioned statvfs interceptors
Dec 27 2019, 9:56 AM

Dec 26 2019

krytarowski committed rG78f714f824fa: [compiler-rt] [netbsd] Add support for versioned statvfs interceptors (authored by krytarowski).
[compiler-rt] [netbsd] Add support for versioned statvfs interceptors
Dec 26 2019, 4:17 PM
krytarowski closed D71700: [compiler-rt] [netbsd] Add support for versioned statvfs interceptors.
Dec 26 2019, 4:17 PM · Restricted Project, Restricted Project
krytarowski committed rGdaa62c8ed46f: [compiler-rt] [netbsd] Add support for versioned statvfs interceptors (authored by krytarowski).
[compiler-rt] [netbsd] Add support for versioned statvfs interceptors
Dec 26 2019, 4:13 PM
krytarowski updated the diff for D71700: [compiler-rt] [netbsd] Add support for versioned statvfs interceptors.
  • rebase to HEAD
Dec 26 2019, 4:13 PM · Restricted Project, Restricted Project

Dec 25 2019

krytarowski committed rGaff6c9db9a96: [compiler-rt] [netbsd] Correct the fallback definition of PT_LWPNEXT (authored by krytarowski).
[compiler-rt] [netbsd] Correct the fallback definition of PT_LWPNEXT
Dec 25 2019, 9:24 AM

Dec 24 2019

krytarowski committed rG52b5fe5f45b1: [compiler-rt] [netbsd] Define _RTLD_SOURCE to fix build (authored by krytarowski).
[compiler-rt] [netbsd] Define _RTLD_SOURCE to fix build
Dec 24 2019, 7:14 PM
krytarowski committed rGab8a7a29bf15: [lldb] Adapt for NetBSD-9.99.30 ptrace(2) API changes (authored by krytarowski).
[lldb] Adapt for NetBSD-9.99.30 ptrace(2) API changes
Dec 24 2019, 11:42 AM
krytarowski committed rG4b8232d4f0bf: [compiler-rt] Adapt for ptrace(2) changes in NetBSD-9.99.30 (authored by krytarowski).
[compiler-rt] Adapt for ptrace(2) changes in NetBSD-9.99.30
Dec 24 2019, 11:42 AM
krytarowski committed rGfc356dcc11c1: [compiler-rt] Adapt stop-the-world for ptrace changes in NetBSD-9.99.30 (authored by krytarowski).
[compiler-rt] Adapt stop-the-world for ptrace changes in NetBSD-9.99.30
Dec 24 2019, 11:42 AM

Dec 20 2019

krytarowski added a comment to D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld).

@MaskRay I will mail you off-list with one question.

Dec 20 2019, 3:38 PM · Restricted Project, Restricted Project, lld
krytarowski added a comment to D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld).

Ping?

Dec 20 2019, 3:38 PM · Restricted Project, Restricted Project, lld
krytarowski added a comment to D71740: [msan] Intercept qsort, qsort_r..

If possible, it would be nice to follow up with heapsort(3) and mergesort(3).

Dec 20 2019, 12:34 PM · Restricted Project, Restricted Project
krytarowski accepted D71511: [libc++] Update feature list for NetBSD.
Dec 20 2019, 3:23 AM · Restricted Project

Dec 19 2019

krytarowski accepted D71513: [compiler-rt] [test] Disable MPROTECT on two builtin tests.
Dec 19 2019, 1:42 PM · Restricted Project, Restricted Project
krytarowski created D71700: [compiler-rt] [netbsd] Add support for versioned statvfs interceptors.
Dec 19 2019, 5:46 AM · Restricted Project, Restricted Project

Dec 18 2019

krytarowski committed rG3a189bac9bb1: [compiler-rt] Enable SANITIZER_CAN_USE_PREINIT_ARRAY on NetBSD (authored by krytarowski).
[compiler-rt] Enable SANITIZER_CAN_USE_PREINIT_ARRAY on NetBSD
Dec 18 2019, 6:28 PM
krytarowski committed rGd15241ed2c23: [compiler-rt] [fuzzer] Enable LSan in libFuzzer tests on NetBSD (authored by krytarowski).
[compiler-rt] [fuzzer] Enable LSan in libFuzzer tests on NetBSD
Dec 18 2019, 4:24 PM
krytarowski committed rG7e8541f3df06: [compiler-rt] [fuzzer] Include stdarg.h for va_list (authored by krytarowski).
[compiler-rt] [fuzzer] Include stdarg.h for va_list
Dec 18 2019, 4:14 PM
krytarowski accepted D71623: [compiler-rt] [test] Add missing %run to fread_fwrite MSAN test.
Dec 18 2019, 2:19 PM · Restricted Project, Restricted Project
krytarowski committed rG3f9668670012: Correct version check 9.9.26 -> 9.99.26 (authored by krytarowski).
Correct version check 9.9.26 -> 9.99.26
Dec 18 2019, 12:15 PM
krytarowski committed rGe14ff22694c2: [compiler-rt] Sync NetBSD ioctl definitions with 9.99.26 (authored by krytarowski).
[compiler-rt] Sync NetBSD ioctl definitions with 9.99.26
Dec 18 2019, 6:47 AM

Dec 16 2019

krytarowski added a comment to D58892: [ELF] Split RW PT_LOAD on the PT_GNU_RELRO boundary.

We would like to get this PT_LOAD split as a tunable, ignoring whether tests are passed or not when it is disabled.

Dec 16 2019, 4:28 AM · Restricted Project

Dec 13 2019

krytarowski added a comment to D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld).

Stating it from a different side. If you do not care about GNU ld drop-in replacement property for Linux it's not our business, but we do care about this in NetBSD and we restrict this to our project only (from ELF targets). If you do not care about NetBSD, you shall not care how and whether we use LLD. We try hard to not interfere with Linux looking for a consensus.

Dec 13 2019, 5:16 PM · Restricted Project, Restricted Project, lld
krytarowski added a comment to D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld).

@joerg works on the ELF loader and we just need to wait for him. We wrote our temporary patch, but it was not ideal as the long term solution.

Dec 13 2019, 2:59 PM · Restricted Project, Restricted Project, lld
krytarowski added a comment to D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld).

We attempted to patch internally LLD rebasing our code for the buildbot purposes but LLD without being used rots quickly, see: https://reviews.llvm.org/D58892

Dec 13 2019, 2:07 AM · Restricted Project, Restricted Project, lld

Dec 5 2019

krytarowski added inline comments to D70958: [compiler-rt] [test] Disable ASLR on ASAN/MSAN/TSAN tests on NetBSD.
Dec 5 2019, 3:12 PM · Restricted Project, Restricted Project

Dec 3 2019

krytarowski added a comment to D70958: [compiler-rt] [test] Disable ASLR on ASAN/MSAN/TSAN tests on NetBSD.

Could this go into the common lit config in compiler-rt/test?

Dec 3 2019, 6:36 PM · Restricted Project, Restricted Project

Nov 30 2019

krytarowski added a comment to D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld).

Ping?

Nov 30 2019, 6:13 AM · Restricted Project, Restricted Project, lld

Nov 25 2019

krytarowski added a comment to D70025: [lldb] [Process/NetBSD] Fix handling concurrent watchpoint events.

LGTM, since this seems to be the best we can do given the current netbsd behavior.

However, I'd like to repeat what I said on the IRC, that I consider this behavior of netbsd to be unreasonable.

Nov 25 2019, 8:46 AM · Restricted Project

Nov 22 2019

krytarowski added inline comments to D70022: [lldb] [Process/NetBSD] Improve threading support.
Nov 22 2019, 6:23 AM · Restricted Project

Nov 19 2019

krytarowski added a reviewer for D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld): chandlerc.

We are in the process of switching our buildbot to newer NetBSD snapshot (-8 to -9) and we keep waiting for this patch to land.

Nov 19 2019, 6:25 AM · Restricted Project, Restricted Project, lld

Nov 18 2019

krytarowski accepted D70363: [lldb] [Process/NetBSD] Implement thread name getting.
Nov 18 2019, 12:19 AM · Restricted Project
krytarowski added inline comments to D70363: [lldb] [Process/NetBSD] Implement thread name getting.
Nov 18 2019, 12:19 AM · Restricted Project

Nov 17 2019

krytarowski added inline comments to D70363: [lldb] [Process/NetBSD] Implement thread name getting.
Nov 17 2019, 3:36 PM · Restricted Project

Nov 16 2019

krytarowski added inline comments to D70335: [lldb] [test] Enable lldb-server tests on NetBSD, and set XFAILs.
Nov 16 2019, 7:40 AM · Restricted Project

Nov 14 2019

krytarowski added a comment to D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld).

ping?

Nov 14 2019, 6:54 AM · Restricted Project, Restricted Project, lld

Nov 10 2019

krytarowski added a comment to D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld).

Short summary:

Nov 10 2019, 10:05 AM · Restricted Project, Restricted Project, lld
krytarowski added a comment to D69317: Fixed a profdata file size detection on Windows system. .

-o is an unportable extension.

Nov 10 2019, 9:40 AM · Restricted Project

Nov 9 2019

krytarowski abandoned D69755: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld).

Better patch in https://reviews.llvm.org/D70048

Nov 9 2019, 2:31 PM · Restricted Project, Restricted Project, lld
krytarowski updated the diff for D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld).
  • fix a typo in a comment.
Nov 9 2019, 2:07 PM · Restricted Project, Restricted Project, lld
krytarowski added a comment to D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld).

Another approach to achieve the same goal as previous attempts. It is already better as it avoids two forks.

Nov 9 2019, 1:55 PM · Restricted Project, Restricted Project, lld
krytarowski created D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld).
Nov 9 2019, 1:49 PM · Restricted Project, Restricted Project, lld

Nov 8 2019

krytarowski added inline comments to D70025: [lldb] [Process/NetBSD] Fix handling concurrent watchpoint events.
Nov 8 2019, 1:47 PM · Restricted Project
krytarowski added a comment to D70023: [lldb] [Process/NetBSD] Copy watchpoints to newly-created threads.

How does it deal with security.models.extensions.user_set_dbregs? If there is a handled error than it's fine.

Nov 8 2019, 1:29 PM · Restricted Project
krytarowski added inline comments to D70022: [lldb] [Process/NetBSD] Improve threading support.
Nov 8 2019, 1:20 PM · Restricted Project

Nov 5 2019

krytarowski added inline comments to D69765: [compiler-rt] Support more CPUs in LSan Allocator Address Space.
Nov 5 2019, 2:01 PM · Restricted Project, Restricted Project
krytarowski added a comment to D69755: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld).

burden with the upstream

Nov 5 2019, 12:57 PM · Restricted Project, Restricted Project, lld
krytarowski added a comment to D69755: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld).

I don't want to diverge this patch on offtopic or general discussion.

Nov 5 2019, 12:57 PM · Restricted Project, Restricted Project, lld

Nov 4 2019

krytarowski updated subscribers of D69765: [compiler-rt] Support more CPUs in LSan Allocator Address Space.
Nov 4 2019, 5:48 AM · Restricted Project, Restricted Project

Nov 3 2019

krytarowski added inline comments to D69765: [compiler-rt] Support more CPUs in LSan Allocator Address Space.
Nov 3 2019, 5:36 PM · Restricted Project, Restricted Project
krytarowski committed rG858b15cb9cf6: [compiler-rt] [msan] Correct the __libc_thr_keycreate prototype (authored by krytarowski).
[compiler-rt] [msan] Correct the __libc_thr_keycreate prototype
Nov 3 2019, 4:25 PM
krytarowski committed rGe345bc6e65a3: [compiler-rt] [msan] Support POSIX iconv(3) on NetBSD 9.99.17+ (authored by krytarowski).
[compiler-rt] [msan] Support POSIX iconv(3) on NetBSD 9.99.17+
Nov 3 2019, 4:25 PM
krytarowski updated subscribers of D69765: [compiler-rt] Support more CPUs in LSan Allocator Address Space.
Nov 3 2019, 3:48 PM · Restricted Project, Restricted Project
krytarowski added inline comments to D69765: [compiler-rt] Support more CPUs in LSan Allocator Address Space.
Nov 3 2019, 1:33 PM · Restricted Project, Restricted Project
krytarowski created D69765: [compiler-rt] Support more CPUs in LSan Allocator Address Space.
Nov 3 2019, 8:19 AM · Restricted Project, Restricted Project
krytarowski committed rG983c4dd8edbe: [compiler-rt] Harmonize __sanitizer_addrinfo with the NetBSD headers (authored by krytarowski).
[compiler-rt] Harmonize __sanitizer_addrinfo with the NetBSD headers
Nov 3 2019, 7:52 AM
krytarowski committed rG01f91c3526ef: [compiler-rt] Sync NetBSD syscall hooks with 9.99.17 (authored by krytarowski).
[compiler-rt] Sync NetBSD syscall hooks with 9.99.17
Nov 3 2019, 7:25 AM

Nov 2 2019

krytarowski added a comment to D69755: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld).

I still have the feeling that such configurations should be added to clangDriver/gcc specs or a shell script wrapper of lld.

Nov 2 2019, 4:26 PM · Restricted Project, Restricted Project, lld
krytarowski added inline comments to D69755: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld).
Nov 2 2019, 4:07 PM · Restricted Project, Restricted Project, lld
krytarowski updated the diff for D69755: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld).
  • upload diff with wider context
Nov 2 2019, 2:54 PM · Restricted Project, Restricted Project, lld
krytarowski created D69755: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld).
Nov 2 2019, 2:45 PM · Restricted Project, Restricted Project, lld

Oct 22 2019

krytarowski added a comment to D69320: [lldb] [Python] Do not attempt to flush() a read-only fd.

Same here, I cannot commit.

Oct 22 2019, 5:31 PM · Restricted Project
krytarowski added a comment to D68856: convert SBDebugger::***FileHandle() wrappers to native files..

now I'm stuck on this trying to install cmake.

pkg_add: no pkg found for 'libunistring>=0.9.4', sorry.
pkg_add: Can't install dependency libunistring>=0.9.4
pkg_add: 1 package addition failed
*** Error code 1
Oct 22 2019, 10:49 AM · Restricted Project
krytarowski added a comment to D68856: convert SBDebugger::***FileHandle() wrappers to native files..

For the git part you will need to install mozilla-rootcerts and follow post-install instructions, as otherwise https:// won't work nicely.

Oct 22 2019, 3:44 AM · Restricted Project
krytarowski added a comment to D68856: convert SBDebugger::***FileHandle() wrappers to native files..

@mgorny

I can't get anything to work. I've tried running a local VM with virtualbox but it's networking driver crashes my kernel. I've tried a local VM with VMware but it won't boot netbsd. I've tried AWS but they only have netbsd 7, which is too old. I've tried google cloud, but their image creator script only works for netbsd 9, and python won't build because x11 isn't installed. I've tried installing the pkgsrc binaries from netbsd 8 onto netbsd 9, but that doesn't work either. I'm completely at a loss. I can't figure out how to make a netbsd VM that can actually build LLDB.

Do you have a machine image on AWS or google cloud or even a VMDK or something that I could use?

Oct 22 2019, 3:35 AM · Restricted Project

Oct 21 2019

krytarowski added a comment to D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK.

This looks good as an intermediate step to make lld saner.

Oct 21 2019, 10:46 AM · Restricted Project

Sep 24 2019

krytarowski committed rGb2077fdc3723: [tblgen] Disable Leak detection for ASan/GCC and LSan/LLVM (authored by krytarowski).
[tblgen] Disable Leak detection for ASan/GCC and LSan/LLVM
Sep 24 2019, 4:24 AM

Sep 23 2019

krytarowski added a comment to D67908: [tblgen] Disable Leak detection for ASan/GCC and LSan/LLVM.

Interesting - I had tried to add has_feature for lsan to clang in the past and couldn’t get the change accepted. Nice to see it works now :)

Sep 23 2019, 5:17 AM · Restricted Project
krytarowski updated subscribers of D67908: [tblgen] Disable Leak detection for ASan/GCC and LSan/LLVM.

Once GCC will grow support for __SANITIZE_LEAK__ (already pending in review) there will be included as a separate revision support for LSan/GCC.

Sep 23 2019, 5:02 AM · Restricted Project
krytarowski created D67908: [tblgen] Disable Leak detection for ASan/GCC and LSan/LLVM.
Sep 23 2019, 5:02 AM · Restricted Project

Sep 21 2019

Herald added a project to D52386: [Lexer] Add udefined_behavior_sanitizer feature: Restricted Project.

This is needed in the NetBSD kernel, more fine-grained checks would be acceptable too, but one global feature detection is what I need.

Sep 21 2019, 4:03 AM · Restricted Project, Restricted Project