Page MenuHomePhabricator
Feed Advanced Search

Tue, Sep 8

dsanders added a comment to D85603: IR: Add convergence control operand bundle and intrinsics.

I've only read up to Formal Rules so later sections might change things but I figure it's potentially useful to see a readers thoughts mid-read. I'm pretty sure I've misunderstood the anchor intrinsic based on what I've read of the doc and comments so far.

Tue, Sep 8, 10:04 PM · Restricted Project

Fri, Sep 4

dsanders committed rG5e04b539c835: [compiler-rt] Try again to correct test after 3f1a9b7eca0 added segment names… (authored by dsanders).
[compiler-rt] Try again to correct test after 3f1a9b7eca0 added segment names…
Fri, Sep 4, 3:49 PM
dsanders requested review of D87170: [json] Provide a means to delegate writing a value to another API.
Fri, Sep 4, 3:22 PM · Restricted Project
dsanders committed rG1eae19a87f54: [compiler-rt] Try to correct test after 3f1a9b7eca0 added segment names to… (authored by dsanders).
[compiler-rt] Try to correct test after 3f1a9b7eca0 added segment names to…
Fri, Sep 4, 12:25 PM
dsanders committed rG8760048384f5: [lld] Test corrections after 3f1a9b7eca0 added segment names to objdump output (authored by dsanders).
[lld] Test corrections after 3f1a9b7eca0 added segment names to objdump output
Fri, Sep 4, 10:26 AM
dsanders committed rG3f1a9b7eca0a: [objdump][macho] Emit segment names along with section names (authored by dsanders).
[objdump][macho] Emit segment names along with section names
Fri, Sep 4, 9:57 AM
dsanders closed D87119: [objdump][macho] Emit segment names along with section names.
Fri, Sep 4, 9:57 AM · Restricted Project

Thu, Sep 3

dsanders requested review of D87119: [objdump][macho] Emit segment names along with section names.
Thu, Sep 3, 5:12 PM · Restricted Project

Thu, Aug 27

dsanders added a comment to D86664: [GlobalISel] Rewrite the elide-br-by-swapping-icmp-ops combine to do less..

The IRTranslator chooses to omit the G_BR if it can use a fallthrough. Should it not do that either, and the verifier enforce always having G_BR and G_BRCOND?

I think this is a reasonable idea. We discussed this a long time ago internally but ultimately didn't have any strong opinions to change it.

Thu, Aug 27, 1:36 PM · Restricted Project

Aug 14 2020

dsanders accepted D85858: [TableGen] Allow mnemonics with uppercase letters to be matched.

LGTM

Aug 14 2020, 10:28 AM · Restricted Project

Aug 4 2020

dsanders requested review of D85247: [Darwin] [Driver] Clang should invoke dsymutil for multiarch builds.
Aug 4 2020, 2:11 PM · Restricted Project
dsanders requested review of D85213: Use --dsym-dir when compiling with a compiler that supports it.
Aug 4 2020, 7:59 AM · Restricted Project, Restricted Project

Aug 3 2020

dsanders updated the diff for D84127: Make LLVM_ENABLE_LTO function with multi-arch values for CMAKE_OSX_ARCHITECTURES.

Make standalone clang builds work correctly. LLVM_SOURCE_DIR isn't set for those
Small naming change to match that directory

Aug 3 2020, 7:38 PM · Restricted Project
dsanders committed rG1beb00db1f51: Fix use-after-scope in 7209f83112db caught by the sanitizer bots (authored by dsanders).
Fix use-after-scope in 7209f83112db caught by the sanitizer bots
Aug 3 2020, 4:55 PM
dsanders updated the diff for D84127: Make LLVM_ENABLE_LTO function with multi-arch values for CMAKE_OSX_ARCHITECTURES.

Last one our own testing hit: Fix the case where lack of debug info means we didn't extract dsyms

Aug 3 2020, 3:02 PM · Restricted Project
dsanders updated the diff for D84127: Make LLVM_ENABLE_LTO function with multi-arch values for CMAKE_OSX_ARCHITECTURES.

Fix the non-LTO path. It wasn't externalizing the debug info in single-slice builds

Aug 3 2020, 2:27 PM · Restricted Project
dsanders committed rG7209f83112db: Allow .dSYM's to be directly placed in an alternate directory (authored by dsanders).
Allow .dSYM's to be directly placed in an alternate directory
Aug 3 2020, 1:19 PM
dsanders closed D84572: Allow .dSYM's to be directly placed in an alternate directory.
Aug 3 2020, 1:19 PM · Restricted Project

Jul 28 2020

dsanders updated the diff for D84572: Allow .dSYM's to be directly placed in an alternate directory.

Remove external- prefix

Jul 28 2020, 3:09 PM · Restricted Project
dsanders committed rGabf1ed70d60f: [globalisel][cse] Merge debug locations when CSE'ing (authored by dsanders).
[globalisel][cse] Merge debug locations when CSE'ing
Jul 28 2020, 2:25 PM
dsanders closed D78388: [globalisel][cse] Merge debug locations when CSE'ing.
Jul 28 2020, 2:25 PM · Restricted Project

Jul 27 2020

dsanders added inline comments to D84127: Make LLVM_ENABLE_LTO function with multi-arch values for CMAKE_OSX_ARCHITECTURES.
Jul 27 2020, 2:21 PM · Restricted Project
dsanders added inline comments to D84572: Allow .dSYM's to be directly placed in an alternate directory.
Jul 27 2020, 2:07 PM · Restricted Project

Jul 24 2020

dsanders updated the diff for D84572: Allow .dSYM's to be directly placed in an alternate directory.

Attempt to fix the windows-specific failure by using posix-style path::append()

Jul 24 2020, 7:50 PM · Restricted Project
dsanders added inline comments to D84565: [Darwin] [Driver] Clang should invoke dsymutil for lto builds -g*.
Jul 24 2020, 6:57 PM · Restricted Project
dsanders added a comment to D84565: [Darwin] [Driver] Clang should invoke dsymutil for lto builds -g*.

@JDevlieghere you are right, I'm missing the change to how clang determines it needs to pass the linker the object file path. Update coming momentarily.

Isn't that already based on isUsingLTO() and getLTOMode() or is there another bit? I'm looking at darwin::Linker::AddLinkArgs()

Jul 24 2020, 6:42 PM · Restricted Project
dsanders added a comment to D84565: [Darwin] [Driver] Clang should invoke dsymutil for lto builds -g*.

@JDevlieghere you are right, I'm missing the change to how clang determines it needs to pass the linker the object file path. Update coming momentarily.

Jul 24 2020, 6:40 PM · Restricted Project
dsanders added a comment to D84565: [Darwin] [Driver] Clang should invoke dsymutil for lto builds -g*.

When you don’t pass any specific options to the linker, it’s going to generate a temporary lto.o file in /tmp and delete it after the link. When dsymutil will try to read that, it won't be there anymore. Unless I'm missing I don't think this is going to work. If it turns out I'm mistaken please add that situation as a test case.

Jul 24 2020, 6:32 PM · Restricted Project
dsanders updated the diff for D84127: Make LLVM_ENABLE_LTO function with multi-arch values for CMAKE_OSX_ARCHITECTURES.
  • Comment on the emit+move too
Jul 24 2020, 5:49 PM · Restricted Project
dsanders updated the diff for D84127: Make LLVM_ENABLE_LTO function with multi-arch values for CMAKE_OSX_ARCHITECTURES.
  • Add comment referencing the bug
Jul 24 2020, 5:46 PM · Restricted Project
dsanders added a comment to D84127: Make LLVM_ENABLE_LTO function with multi-arch values for CMAKE_OSX_ARCHITECTURES.

I was talking to @bogner about this. I think this patch is reasonable, but it is important to note that this patch (and the previous version) are both workarounds for a bug in clang. Anytime the clang driver is provided a flag to generate debug info and it is linking temporary object files, clang should insert a dsymutil step. Right now it only inserts the step if there is a compiler or assembler input to the compiler. I filed a bug to track it (https://bugs.llvm.org/show_bug.cgi?id=46841), and I will upload a patch to the clang driver to fix this issue.

Jul 24 2020, 5:41 PM · Restricted Project
Herald added a project to D84572: Allow .dSYM's to be directly placed in an alternate directory: Restricted Project.
Jul 24 2020, 5:26 PM · Restricted Project
dsanders added inline comments to D83034: [GlobalISel] Don't skip adding predicate matcher.
Jul 24 2020, 12:20 PM · Restricted Project

Jul 20 2020

dsanders added a reviewer for D84127: Make LLVM_ENABLE_LTO function with multi-arch values for CMAKE_OSX_ARCHITECTURES: beanz.
Jul 20 2020, 10:22 AM · Restricted Project
dsanders added inline comments to D83034: [GlobalISel] Don't skip adding predicate matcher.
Jul 20 2020, 10:09 AM · Restricted Project

Jul 19 2020

dsanders added a comment to D84127: Make LLVM_ENABLE_LTO function with multi-arch values for CMAKE_OSX_ARCHITECTURES.

tools/lto/hide-linkonce-odr.ll failed on my test run but it seems to be down to my system rather than the compiler (a library is genuinely missing). Will check if it fails without this change too

Jul 19 2020, 2:20 PM · Restricted Project
dsanders added a comment to D84127: Make LLVM_ENABLE_LTO function with multi-arch values for CMAKE_OSX_ARCHITECTURES.

tools/lto/hide-linkonce-odr.ll failed on my test run but it seems to be down to my system rather than the compiler (a library is genuinely missing). Will check if it fails without this change too

Jul 19 2020, 10:20 AM · Restricted Project
Herald added a project to D84127: Make LLVM_ENABLE_LTO function with multi-arch values for CMAKE_OSX_ARCHITECTURES: Restricted Project.
Jul 19 2020, 10:18 AM · Restricted Project

Jul 15 2020

dsanders added inline comments to D83034: [GlobalISel] Don't skip adding predicate matcher.
Jul 15 2020, 6:05 PM · Restricted Project
dsanders added a comment to D83034: [GlobalISel] Don't skip adding predicate matcher.

Could you add a test case or point us at a example of an existing test that goes wrong? The description in the commit message is unlikely to be the full story as we already cover loads with non-null MemoryVT's. My best guess is you are attempting to use builtin predicates and custom predicates together. I don't see a reason why that shouldn't be allowed but it's not something that was intended as the goal was aiming to fully remove the custom C++ from the tablegen headers so that tablegen could do some transformations on sextload/zextload and similar to fix DAGISel vs GlobalISel modelling mismatches.

I think the problem is broader than just combining custom predicates and builtin. The emitter here implicitly assumes all of these builtin PatFrag predicates are used exactly as the hierarchy used to define the default/generic load/store patterns.

Jul 15 2020, 6:03 PM · Restricted Project

Jul 13 2020

dsanders accepted D82331: TableGen/GlobalISel: Partially fix nontrivial, custom predicates.

Yeah, there isn't really a better way to do it as there's no dependency tracking in the importer. GIMatchDAG can track exactly what needs to be available for the predicate to be testable (making it just an issue of how to represent that in the source) but we aren't using that in the importer.

Jul 13 2020, 10:49 AM · Restricted Project

Jul 7 2020

dsanders added a comment to D83275: [llc] (almost) remove `--print-machineinstrs`.

I was worried for a moment that we'd be losing the ability to print between all machine passes but it looks like -print-after-all covers that now (I don't think that was always the case). So long as we aren't losing any inter-pass dumps this LGTM but I'd suggest giving it a few days to see if anyone was using this in a way that isn't evident from the tests.

-print-after/-stop-after since isel pass does not have commandline name.

IIRC, there's something weird going on in this area. I vaguely remember a problem I never got to the bottom of where there was no name when AMDGPU was omitted but when it was compiled, everybody's pass was called amdgpu-isel. It had something to do with AMDGPU needing additional dependencies and using INITIALIZE_PASS to get them.

I don't know if it is the cause but AMDGPUDAGToDAGISel::ID is actually SelectionDAGISel::ID.

Jul 7 2020, 9:08 AM · Restricted Project

Jul 6 2020

dsanders accepted D83275: [llc] (almost) remove `--print-machineinstrs`.

I was worried for a moment that we'd be losing the ability to print between all machine passes but it looks like -print-after-all covers that now (I don't think that was always the case). So long as we aren't losing any inter-pass dumps this LGTM but I'd suggest giving it a few days to see if anyone was using this in a way that isn't evident from the tests.

Jul 6 2020, 9:36 PM · Restricted Project
dsanders added a comment to D83034: [GlobalISel] Don't skip adding predicate matcher.

Could you add a test case or point us at a example of an existing test that goes wrong? The description in the commit message is unlikely to be the full story as we already cover loads with non-null MemoryVT's. My best guess is you are attempting to use builtin predicates and custom predicates together. I don't see a reason why that shouldn't be allowed but it's not something that was intended as the goal was aiming to fully remove the custom C++ from the tablegen headers so that tablegen could do some transformations on sextload/zextload and similar to fix DAGISel vs GlobalISel modelling mismatches.

Jul 6 2020, 9:42 AM · Restricted Project

Jun 29 2020

dsanders added a comment to D82765: GlobalISel: Disallow undef generic virtual register uses.

From that it *sounds* like a DBG_VALUE of an undef vreg doesn't make sense?

Jun 29 2020, 5:13 PM · Restricted Project
dsanders added a comment to D82765: GlobalISel: Disallow undef generic virtual register uses.

My MIR is lacking here: What does it mean for a USE to be UNDEF? DBG_VALUE accepts UNDEF as an operand, but it's not clear to me what an undef vreg means / how it can be created.

You can set the undef flag on the MachineOperand.

ProcessImplicitDefs turns

%0 = IMPLICIT_DEF
FOO %0

into

FOO undef %0

You can also hand write this, but I don't think any pass before ProcessImplicitDefs and co should be using these

Jun 29 2020, 5:13 PM · Restricted Project
dsanders added reviewers for D82765: GlobalISel: Disallow undef generic virtual register uses: vsk, aprantl.

@vsk + @aprantl: I believe this is going to need an exception for DBG_VALUE. Could you confirm if that's correct?

Jun 29 2020, 10:48 AM · Restricted Project

Jun 22 2020

dsanders accepted D81074: [TableGen] Add error messages.

LGTM

Jun 22 2020, 10:12 AM · Restricted Project

Jun 16 2020

dsanders committed rG778db88723d7: [gicombiner] Allow disable-rule option to disable all-except-... (authored by dsanders).
[gicombiner] Allow disable-rule option to disable all-except-...
Jun 16 2020, 5:02 PM
dsanders closed D81889: [gicombiner] Allow disable-rule option to disable all-except-....
Jun 16 2020, 5:02 PM · Restricted Project
dsanders updated the diff for D81889: [gicombiner] Allow disable-rule option to disable all-except-....

Add only-enable-rule and make it interact with disable-rule correctly.

Jun 16 2020, 4:29 PM · Restricted Project
dsanders added a comment to D81889: [gicombiner] Allow disable-rule option to disable all-except-....

The point here is to allow people to only enable specific rules, right?

Jun 16 2020, 3:23 PM · Restricted Project
dsanders committed rGe35ba09961c8: [gicombiner] Allow generated combiners to store additional members (authored by dsanders).
[gicombiner] Allow generated combiners to store additional members
Jun 16 2020, 2:52 PM
dsanders closed D81863: [gicombiner] Allow generated combiners to store additional members.
Jun 16 2020, 2:51 PM · Restricted Project
dsanders committed rG28ebdf1a02eb: [gicombiner] Allow generated CombinerHelpers to have additional arguments (authored by dsanders).
[gicombiner] Allow generated CombinerHelpers to have additional arguments
Jun 16 2020, 2:22 PM
dsanders closed D81862: [gicombiner] Allow generated CombinerHelpers to have additional arguments.
Jun 16 2020, 2:21 PM · Restricted Project
dsanders added inline comments to D81899: [gicombiner] Unify common state for current targets into CommonTargetCombinerHelperState.
Jun 16 2020, 11:00 AM · Restricted Project
dsanders added a comment to D81889: [gicombiner] Allow disable-rule option to disable all-except-....

It's not clear to me what "'!foo-bar' - Enable rules from 'foo' to (and including) 'bar'" means. These have some kind of ordering?

Jun 16 2020, 10:26 AM · Restricted Project

Jun 15 2020

dsanders updated the summary of D81889: [gicombiner] Allow disable-rule option to disable all-except-....
Jun 15 2020, 6:14 PM · Restricted Project
dsanders updated the summary of D81889: [gicombiner] Allow disable-rule option to disable all-except-....
Jun 15 2020, 6:14 PM · Restricted Project
dsanders created D81899: [gicombiner] Unify common state for current targets into CommonTargetCombinerHelperState.
Jun 15 2020, 5:42 PM · Restricted Project
dsanders created D81889: [gicombiner] Allow disable-rule option to disable all-except-....
Jun 15 2020, 3:29 PM · Restricted Project
dsanders added inline comments to D81863: [gicombiner] Allow generated combiners to store additional members.
Jun 15 2020, 3:29 PM · Restricted Project
dsanders added a comment to D81862: [gicombiner] Allow generated CombinerHelpers to have additional arguments.

Doesn't https://reviews.llvm.org/D81863 make this unnecessary?

Jun 15 2020, 3:29 PM · Restricted Project
dsanders added inline comments to D81863: [gicombiner] Allow generated combiners to store additional members.
Jun 15 2020, 1:14 PM · Restricted Project
dsanders created D81863: [gicombiner] Allow generated combiners to store additional members.
Jun 15 2020, 12:08 PM · Restricted Project
dsanders created D81862: [gicombiner] Allow generated CombinerHelpers to have additional arguments.
Jun 15 2020, 12:07 PM · Restricted Project

Jun 12 2020

dsanders accepted D81587: [MachineVerifier][GlobalISel] Check that branches have a MBB operand or are declared indirect. Add missing properties to G_BRJT, G_BRINDIRECT.
Jun 12 2020, 9:01 PM · Restricted Project
dsanders created D81778: [llvmbuild] Add optional_libraries, i.e. a dependency iff the target is enabled.
Jun 12 2020, 5:08 PM · Restricted Project
dsanders created D81777: [llvmbuild] --enable-optional-components should not be a substring match.
Jun 12 2020, 5:08 PM · Restricted Project
dsanders updated the diff for D81773: [llvmbuild] Allow OptionalLibrary's to be enabled by default and disabled.

Remove a bit of the next patch that snuck into this one while organizing the patches

Jun 12 2020, 4:34 PM · Restricted Project
dsanders added a comment to D81773: [llvmbuild] Allow OptionalLibrary's to be enabled by default and disabled.

Just to give you some context and an overview of the direction, we have some hacks we use to make our LLVM dylib smaller by omitting subcomponents of LLVM that we don't actually use in practice. This is part of a small series of patches to try to eliminate these hacks by rounding out llvmbuild's support for optional libraries. This patch allows libraries to be included by default and optionally disabled, and it will be followed by a small bugfix for --enable-optional-components, and then the addition of an optional_libraries to go with the existing required_libraries.

Jun 12 2020, 4:34 PM · Restricted Project
dsanders created D81773: [llvmbuild] Allow OptionalLibrary's to be enabled by default and disabled.
Jun 12 2020, 4:34 PM · Restricted Project

Jun 11 2020

dsanders accepted D81625: [GISel][NFC]: Add unit test for clarifying CSE behavior.

LGTM

Jun 11 2020, 10:27 AM · Restricted Project
dsanders added inline comments to D81587: [MachineVerifier][GlobalISel] Check that branches have a MBB operand or are declared indirect. Add missing properties to G_BRJT, G_BRINDIRECT.
Jun 11 2020, 9:53 AM · Restricted Project

Jun 10 2020

dsanders committed rGf743975e0ab6: Support other llc-like tools in update_llc_test_checks.py (authored by dsanders).
Support other llc-like tools in update_llc_test_checks.py
Jun 10 2020, 5:48 PM
dsanders closed D80960: Support other llc-like tools in update_llc_test_checks.py.
Jun 10 2020, 5:48 PM · Restricted Project

Jun 9 2020

dsanders accepted D81387: GlobalISel: Set instr/debugloc before any legalizer action.

LGTM

Jun 9 2020, 9:53 AM · debug-info, Restricted Project
dsanders accepted D81461: GlobalISel: Fix double printing new instructions in legalizer.

I'm not sure this is the correct instance to remove; now the visible
ordering is different. Now you will typically see the one erased
instruction message before all the new instructions in order. I think
this is the more logical view of typical legalization changes,
although it's mechanically backwards from the normal
insert-new-erase-old pattern.

Jun 9 2020, 9:52 AM · Restricted Project

Jun 3 2020

dsanders accepted D81057: [SVE] Fix ubsan issues in DecodeIITType.

LGTM

Jun 3 2020, 9:53 AM · Restricted Project
dsanders added inline comments to D81074: [TableGen] Add error messages.
Jun 3 2020, 9:53 AM · Restricted Project

Jun 2 2020

dsanders accepted D81021: [TableGen] Avoid generating switch with just default.

LGTM

Jun 2 2020, 12:04 PM · Restricted Project

Jun 1 2020

dsanders added inline comments to rG1c3d9c2f3629: [SVE] Remove IITDescriptor::ScalableVecArgument.
Jun 1 2020, 5:54 PM
dsanders created D80960: Support other llc-like tools in update_llc_test_checks.py.
Jun 1 2020, 3:43 PM · Restricted Project
dsanders added a comment to D80390: [mips] Support 64-bit relative relocations.

LGTM once all other reviewers are happy with this patch.

You don't really need to wait for all of us but you should probably wait for @MaskRay and @atanasyan as they had comments.

Jun 1 2020, 12:59 PM · Restricted Project

May 29 2020

dsanders added inline comments to rG1c3d9c2f3629: [SVE] Remove IITDescriptor::ScalableVecArgument.
May 29 2020, 2:14 PM

May 19 2020

dsanders added inline comments to D80056: GlobalISel: Merge G_PTR_MASK with llvm.ptrmask intrinsic.
May 19 2020, 7:16 PM · Restricted Project
dsanders added a comment to D77446: Add MIR-level debugify with only locations support for now.

Thanks for this work! I've missed this, since it was not marked as 'debug-info' project.

I think we should document this at https://llvm.org/docs/SourceLevelDebugging.html#testing-debug-info-preservation-in-optimizations.

The D80052 will address this comment.

May 19 2020, 7:16 PM · debug-info, Restricted Project
dsanders added a comment to D80052: [docs] Sketch outline for HowToUpdateDebugInfo.rst.

Thanks for working on this. I had a couple inline comments.

May 19 2020, 7:16 PM · debug-info, Restricted Project

May 18 2020

dsanders created D80145: [docs] Enable syntax highlight of MIR (requires pygments 2.6.1).
May 18 2020, 10:48 AM · Restricted Project

May 7 2020

dsanders added a comment to D78796: [Support] Refactor LEB128 encoding into an input iterator.

I'm inclined to agree that the patch series as-is doesn't really warrant the iterators as the interface as no callers have been updated. However, I also don't see much that's iterator specific (ULEBifier would be roughly similar code leaving the iterator portion as trivial wrappers on the ULEBifier) and there are a few places (particularly in tablegen) that are emitting LEB's into containers where the loop to add bytes one by one is just noise and something like std::copy(to_uleb(...), std::back_inserter(Table)); would be somewhat nice. The loop could easily be hidden in something like append_uleb(Table, ...) though I don't think there's a strong argument for (or against) iterators.

What I would suggest is separating out the byte-sequence generation into a ULEBifier as David suggested but still keeping the iterator object as a thin adapter (effectively implementing that while loop) to support inter-operation with STL functions like std::copy.

What is the core issue with the iterator interface that makes it desirable to have something like ULEBifier<T> instead?

May 7 2020, 2:09 PM · Restricted Project
dsanders added a comment to D78796: [Support] Refactor LEB128 encoding into an input iterator.

I'm inclined to agree that the patch series as-is doesn't really warrant the iterators as the interface as no callers have been updated. However, I also don't see much that's iterator specific (ULEBifier would be roughly similar code leaving the iterator portion as trivial wrappers on the ULEBifier) and there are a few places (particularly in tablegen) that are emitting LEB's into containers where the loop to add bytes one by one is just noise and something like std::copy(to_uleb(...), std::back_inserter(Table)); would be somewhat nice. The loop could easily be hidden in something like append_uleb(Table, ...) though I don't think there's a strong argument for (or against) iterators.

May 7 2020, 11:55 AM · Restricted Project

May 5 2020

dsanders accepted D79419: [clang/clang-tools-extra] Fix BZ44437 - add_new_check.py does not work with Python 3.

LGTM

May 5 2020, 1:30 PM · Restricted Project

Apr 29 2020

dsanders added a comment to D78245: [LIT] Make `%T` unique for every test.

@thakis Could you link to previous discussions about %T? I'm sure there are reasons for the way things are today, but I'd like to understand them.

I remember reading the discussion, but I failed to find it just now. @dsanders added the docs that say "deprecated"; maybe he remembers where the thread on moving off %T was?

Apr 29 2020, 2:00 PM · Restricted Project, Restricted Project, Restricted Project

Apr 28 2020

dsanders added inline comments to D78852: [AArch64][GlobalISel] Add a post-legalizer combiner + remove undef stores.
Apr 28 2020, 3:40 PM · Restricted Project
dsanders accepted D79031: [GlobalISel] Assign the correct debug location when combining G_SEXT/G_ANYEXT/G_ZEXT.

LGTM but double check -verify-machineinstrs works with -run-pass

Apr 28 2020, 2:34 PM · Restricted Project

Apr 27 2020

dsanders added inline comments to D78309: [LLVM] Remove wrong DBG_VALUE instruction with one operand in AArch64 test case.
Apr 27 2020, 4:11 PM · Restricted Project
dsanders accepted D78450: CMake: Missing GlobalISel TableGen link.

I don't think it's safe to remove Support since llvm/lib/TableGen/CMakeLists.txt doesn't mention it but adding TableGen to the existing list would LGTM

Apr 27 2020, 3:39 PM · Restricted Project

Apr 21 2020

dsanders accepted D78135: [MachineDebugify] Insert synthetic DBG_VALUE instructions.

LGTM

Apr 21 2020, 2:39 PM · Restricted Project

Apr 17 2020

dsanders committed rG14ad8dc0761a: Don't accidentally create MachineFunctions in mir-debugify/mir-strip-debugify (authored by dsanders).
Don't accidentally create MachineFunctions in mir-debugify/mir-strip-debugify
Apr 17 2020, 2:38 PM