Page MenuHomePhabricator
Feed Advanced Search

Yesterday

mstorsjo added inline comments to D91171: [16/N] [libcxx] Implement the permissions function for windows.
Fri, Dec 4, 12:37 PM · Restricted Project
mstorsjo updated subscribers of D92558: [llvm-rc] Handle driveless absolute windows paths when loading external files.

If you're fine with this randomly breaking one day when someone changes path handling, I think this is fine as is. It is difficult to test.

Fri, Dec 4, 5:06 AM · Restricted Project
mstorsjo updated the diff for D91170: [15/N] [libcxx] Implement the canonical function for windows.

Check the return value of GetFinalPathNameFromHandleW if it overflowed the buffer size and handle it appropriately.

Fri, Dec 4, 4:07 AM · Restricted Project
mstorsjo added inline comments to D91170: [15/N] [libcxx] Implement the canonical function for windows.
Fri, Dec 4, 4:05 AM · Restricted Project
mstorsjo committed rG0b71bf793924: [libcxx] [test] Add a test for conversions between wchar_t, utf8, char16_t… (authored by mstorsjo).
[libcxx] [test] Add a test for conversions between wchar_t, utf8, char16_t…
Fri, Dec 4, 1:43 AM
mstorsjo committed rG6be11e35d539: [libcxx] Implement c++2a char8_t input/output of std::filesystem::path (authored by mstorsjo).
[libcxx] Implement c++2a char8_t input/output of std::filesystem::path
Fri, Dec 4, 1:43 AM
mstorsjo committed rGc17fdca1883d: [clang] [Headers] Use the corresponding _aligned_free or __mingw_aligned_free… (authored by mstorsjo).
[clang] [Headers] Use the corresponding _aligned_free or __mingw_aligned_free…
Fri, Dec 4, 1:43 AM
mstorsjo closed D91133: [2/N] [libcxx] [test] Add a test for conversions between wchar_t, utf8, char16_t, char32_t and windows native narrow code pages.
Fri, Dec 4, 1:43 AM · Restricted Project
mstorsjo closed D90222: [1/N] [libcxx] Implement c++2a char8_t input/output of std::filesystem::path.
Fri, Dec 4, 1:43 AM · Restricted Project
mstorsjo closed D92570: [clang] [Headers] Use the corresponding _aligned_free or __mingw_aligned_free in _mm_free.
Fri, Dec 4, 1:43 AM · Restricted Project

Thu, Dec 3

mstorsjo added a comment to D91379: [libc++] Factor out common logic for calling aligned allocation.

I haven't run into this issue - how do you end up getting intrin.h included before the other includes here?

Any case with intrin.h coming first should do it:

$ cat test.cpp
#include <intrin.h>
#include <new>

$ ./clang/bin/x86_64-w64-mingw32-clang++ -c test.cpp 
In file included from test.cpp:2:
/home/vm/Desktop/mingwtest/clang/bin/../x86_64-w64-mingw32/include/c++/v1/new:314:12: error: no member named '_aligned_malloc' in the global namespace
  return ::_aligned_malloc(__size, __alignment);
         ~~^
/home/vm/Desktop/mingwtest/clang/bin/../x86_64-w64-mingw32/include/c++/v1/new:326:5: error: no type named '_aligned_free' in the global namespace
  ::_aligned_free(__ptr);
  ~~^
2 errors generated.

Ah, doh. Indeed, I can reproduce that. Apparently the code I build regularly doesn't happen to use that setup.

I'll look into fixing the mingw-w64 header bug.

Thu, Dec 3, 11:47 PM · Restricted Project, Restricted Project
mstorsjo added inline comments to D92073: [CodeGen] Add text section prefix for COFF object file.
Thu, Dec 3, 11:26 PM · Restricted Project
mstorsjo updated the diff for D91133: [2/N] [libcxx] [test] Add a test for conversions between wchar_t, utf8, char16_t, char32_t and windows native narrow code pages.

Updated ifdefs according to suggestions.

Thu, Dec 3, 11:23 AM · Restricted Project
mstorsjo added inline comments to D91133: [2/N] [libcxx] [test] Add a test for conversions between wchar_t, utf8, char16_t, char32_t and windows native narrow code pages.
Thu, Dec 3, 11:21 AM · Restricted Project
mstorsjo added inline comments to D91133: [2/N] [libcxx] [test] Add a test for conversions between wchar_t, utf8, char16_t, char32_t and windows native narrow code pages.
Thu, Dec 3, 10:59 AM · Restricted Project
mstorsjo added inline comments to D92570: [clang] [Headers] Use the corresponding _aligned_free or __mingw_aligned_free in _mm_free.
Thu, Dec 3, 10:58 AM · Restricted Project
mstorsjo updated the diff for D90222: [1/N] [libcxx] Implement c++2a char8_t input/output of std::filesystem::path.

Added a release note about source incompatibility.

Thu, Dec 3, 9:53 AM · Restricted Project
mstorsjo added inline comments to D90222: [1/N] [libcxx] Implement c++2a char8_t input/output of std::filesystem::path.
Thu, Dec 3, 8:35 AM · Restricted Project
mstorsjo added a comment to D91139: [7/N] [libcxx] Don't use __int128 for msvc targets.
In D91139#2429595, @rnk wrote:

After having dealt with an increasing number of user complaints about lack of i128 support, I am of the opinion that we should start shipping, auto-linking, and requiring clang_rt.builtins in clang-cl.

However, it's a bit of a project to make this work out of the box, since clang's runtime libraries are not on the linker search path. We'd need to update our msbuild integration bits and some documentation. But it's time to do that work already.

So, if I understand correctly, you're suggesting that the int128 builtins should be provided on Windows, and this workaround shouldn't be necessary once that's done? In that case, unless @mstorsjo disagrees, I think we're better holding off with this patch.

Thu, Dec 3, 8:29 AM · Restricted Project
mstorsjo committed rGd3fef7a7c25e: [compiler-rt] Fix building the aarch64 out-of-line atomics assembly for non-ELF… (authored by mstorsjo).
[compiler-rt] Fix building the aarch64 out-of-line atomics assembly for non-ELF…
Thu, Dec 3, 5:31 AM
mstorsjo closed D92549: [compiler-rt] Fix building the aarch64 out-of-line atomics assembly for non-ELF platforms.
Thu, Dec 3, 5:31 AM · Restricted Project
mstorsjo added inline comments to D91169: [14/N] [libcxx] Implement the current_path function for windows.
Thu, Dec 3, 5:09 AM · Restricted Project
mstorsjo added a comment to D91156: [AArch64] Compiler-rt interface for out-of-line atomics..

Also, I see that this wasn't actually sent to any mailing list - I guess we should have some list auto-added for anything touching compiler-rt?

Plans and questions were sent to llvm-dev http://lists.llvm.org/pipermail/llvm-dev/2020-October/145841.html.

Thu, Dec 3, 4:42 AM · Restricted Project
mstorsjo requested review of D92570: [clang] [Headers] Use the corresponding _aligned_free or __mingw_aligned_free in _mm_free.
Thu, Dec 3, 4:35 AM · Restricted Project
mstorsjo requested review of D92558: [llvm-rc] Handle driveless absolute windows paths when loading external files.
Thu, Dec 3, 2:15 AM · Restricted Project
mstorsjo updated subscribers of D91156: [AArch64] Compiler-rt interface for out-of-line atomics..

Also, I see that this wasn't actually sent to any mailing list - I guess we should have some list auto-added for anything touching compiler-rt?

Thu, Dec 3, 12:40 AM · Restricted Project
mstorsjo requested review of D92549: [compiler-rt] Fix building the aarch64 out-of-line atomics assembly for non-ELF platforms.
Thu, Dec 3, 12:38 AM · Restricted Project
mstorsjo added a comment to D91156: [AArch64] Compiler-rt interface for out-of-line atomics..

This broke building for non-ELF targets, I'll send a patch for fixing that.

Thu, Dec 3, 12:27 AM · Restricted Project

Wed, Dec 2

mstorsjo added a comment to D91379: [libc++] Factor out common logic for calling aligned allocation.

Actually, is there any chance that mingw could implement aligned_alloc from C11? This would increase their level of conformance, and solve this issue at the same time by providing a canonical, standardized name to do aligned allocation.

Wed, Dec 2, 2:37 PM · Restricted Project, Restricted Project
mstorsjo added inline comments to D92073: [CodeGen] Add text section prefix for COFF object file.
Wed, Dec 2, 1:23 PM · Restricted Project
mstorsjo added a comment to D91379: [libc++] Factor out common logic for calling aligned allocation.

I haven't run into this issue - how do you end up getting intrin.h included before the other includes here?

Any case with intrin.h coming first should do it:

$ cat test.cpp
#include <intrin.h>
#include <new>

$ ./clang/bin/x86_64-w64-mingw32-clang++ -c test.cpp 
In file included from test.cpp:2:
/home/vm/Desktop/mingwtest/clang/bin/../x86_64-w64-mingw32/include/c++/v1/new:314:12: error: no member named '_aligned_malloc' in the global namespace
  return ::_aligned_malloc(__size, __alignment);
         ~~^
/home/vm/Desktop/mingwtest/clang/bin/../x86_64-w64-mingw32/include/c++/v1/new:326:5: error: no type named '_aligned_free' in the global namespace
  ::_aligned_free(__ptr);
  ~~^
2 errors generated.
Wed, Dec 2, 1:17 PM · Restricted Project, Restricted Project
mstorsjo updated the diff for D90222: [1/N] [libcxx] Implement c++2a char8_t input/output of std::filesystem::path.

Updated the status of P1423, removed unnecessary comments, added optional references to char8_t in static assert messages, removed a dummy variable in the pre-C++20 version of the test helper, updated the commit message to include references to both papers.

Wed, Dec 2, 3:49 AM · Restricted Project
mstorsjo added inline comments to D90222: [1/N] [libcxx] Implement c++2a char8_t input/output of std::filesystem::path.
Wed, Dec 2, 3:21 AM · Restricted Project
mstorsjo added a comment to D91379: [libc++] Factor out common logic for calling aligned allocation.

That didn't fix our issue. On closer inspection I think this is a weirdness in the mingw headers but I could use a double check: https://github.com/mirror/mingw-w64/search?q=_MM_MALLOC_H_INCLUDED

_aligned_malloc can be provided by either <malloc.h> or <stdlib.h>, as long as you haven't defined _MM_MALLOC_H_INCLUDED. Previously, new.cpp worked because it included <stdlib.h> first thing. Now, in our build, translation units that first include <intrin.h> will set _MM_MALLOC_H_INCLUDED which prevents anything later from picking up _aligned_malloc. Am I interpreting that correctly? This trickery in <intrin.h> seems very strange...

Wed, Dec 2, 1:06 AM · Restricted Project, Restricted Project
mstorsjo updated the diff for D91181: [24/N] [libcxx] Make generic_*string return paths with forward slashes on windows.

Updated to use _VSTD:: instead of std::.

Wed, Dec 2, 12:33 AM · Restricted Project
mstorsjo updated the diff for D91138: [6/N] [libcxx] Handle backslash as path separator on windows.

Updated to use _VSTD::replace instead of std::replace in the installed header.

Wed, Dec 2, 12:31 AM · Restricted Project
mstorsjo updated the diff for D91176: [20/N] [libcxx] Implement parsing of root_name for paths on windows.

Updated after moving one bit of this patch into D91135.

Wed, Dec 2, 12:22 AM · Restricted Project
mstorsjo updated the diff for D91135: [3/N] [libcxx] Make filesystem::path::value_type wchar_t on windows.

Rebased; moved bit from later patch for making PathParser::operator* return backslashes where relevant into this patch.

Wed, Dec 2, 12:20 AM · Restricted Project
mstorsjo added reviewers for D90222: [1/N] [libcxx] Implement c++2a char8_t input/output of std::filesystem::path: curdeius, ldionne.
Wed, Dec 2, 12:18 AM · Restricted Project
mstorsjo updated the diff for D90222: [1/N] [libcxx] Implement c++2a char8_t input/output of std::filesystem::path.

Rebased on top of D92250.

Wed, Dec 2, 12:17 AM · Restricted Project

Tue, Dec 1

mstorsjo committed rG0d7bd72f5ab4: [libcxx] Apply msvcrt specific exception for lgamma() to mingw configurations… (authored by mstorsjo).
[libcxx] Apply msvcrt specific exception for lgamma() to mingw configurations…
Tue, Dec 1, 11:55 PM
mstorsjo closed D92379: [libcxx] Apply msvcrt specific exception for lgamma() to mingw configurations, too.
Tue, Dec 1, 11:55 PM · Restricted Project
mstorsjo added a comment to D91133: [2/N] [libcxx] [test] Add a test for conversions between wchar_t, utf8, char16_t, char32_t and windows native narrow code pages.

Oh, and while the test itself works mostly correct on libc++ on posix platforms, the test is written to exercise the new C++20 char8_t input/outputs, so those aspects of the test depends on D90222 (not terribly complex) to make those bits C++20 correct in libc++.

Tue, Dec 1, 11:49 PM · Restricted Project
mstorsjo updated the diff for D91133: [2/N] [libcxx] [test] Add a test for conversions between wchar_t, utf8, char16_t, char32_t and windows native narrow code pages.

Added a large descriptive comment at the head of the new test file, removed using namespace fs; so that all uses of path and u8path are qualified into fs::path and fs::u8path.

Tue, Dec 1, 11:47 PM · Restricted Project
mstorsjo updated the diff for D91138: [6/N] [libcxx] Handle backslash as path separator on windows.

Use wide char literals for forward and back slashes within an windows ifdef.

Tue, Dec 1, 11:17 PM · Restricted Project
mstorsjo added inline comments to D91138: [6/N] [libcxx] Handle backslash as path separator on windows.
Tue, Dec 1, 11:10 PM · Restricted Project
mstorsjo updated subscribers of D91133: [2/N] [libcxx] [test] Add a test for conversions between wchar_t, utf8, char16_t, char32_t and windows native narrow code pages.

These test look pretty thorough. I think these will be useful in finding portability problems.

Given the TODO in the description, I'll hold off on accepting this revision.

Tue, Dec 1, 2:08 PM · Restricted Project
mstorsjo added inline comments to D91135: [3/N] [libcxx] Make filesystem::path::value_type wchar_t on windows.
Tue, Dec 1, 2:04 PM · Restricted Project
mstorsjo added inline comments to D91135: [3/N] [libcxx] Make filesystem::path::value_type wchar_t on windows.
Tue, Dec 1, 2:01 PM · Restricted Project
mstorsjo requested review of D92379: [libcxx] Apply msvcrt specific exception for lgamma() to mingw configurations, too.
Tue, Dec 1, 3:40 AM · Restricted Project
mstorsjo updated the diff for D90222: [1/N] [libcxx] Implement c++2a char8_t input/output of std::filesystem::path.

Rebased past conflicts in include/__config.

Tue, Dec 1, 12:36 AM · Restricted Project
mstorsjo added a comment to D91189: Add support for Intel's umonitor/umwait.

Build problems associated with target attribute for waitpkg should be fixed now. Please try the new diff.

Tue, Dec 1, 12:21 AM · Restricted Project
mstorsjo added inline comments to D91853: [compiler-rt] [sanitizer] Silence -Wframe-larger-than= for a few windows functions with large stack buffers.
Tue, Dec 1, 12:11 AM · Restricted Project
mstorsjo committed rG2e5aaf65a344: [compiler-rt] [emutls] Handle unused parameters in a compiler agnostic way (authored by mstorsjo).
[compiler-rt] [emutls] Handle unused parameters in a compiler agnostic way
Tue, Dec 1, 12:08 AM
mstorsjo closed D91851: [compiler-rt] [emutls] Handle unused parameters in a compiler agnostic way.
Tue, Dec 1, 12:08 AM · Restricted Project
mstorsjo added inline comments to D91852: [compiler-rt] [windows] Add UNUSED attributes on variables/functions only used for 64 bit targets.
Tue, Dec 1, 12:05 AM · Restricted Project

Fri, Nov 27

mstorsjo added a reverting change for rG8166ed1a7a26: [BasicAA] Fix BatchAA results for phi-phi assumptions: rGfa103836649c: Revert "[BasicAA] Fix BatchAA results for phi-phi assumptions".
Fri, Nov 27, 11:51 AM
mstorsjo committed rGfa103836649c: Revert "[BasicAA] Fix BatchAA results for phi-phi assumptions" (authored by mstorsjo).
Revert "[BasicAA] Fix BatchAA results for phi-phi assumptions"
Fri, Nov 27, 11:51 AM
mstorsjo added a reverting change for D91936: [BasicAA] Fix BatchAA results for phi-phi assumptions: rGfa103836649c: Revert "[BasicAA] Fix BatchAA results for phi-phi assumptions".
Fri, Nov 27, 11:51 AM · Restricted Project
mstorsjo added a comment to D91936: [BasicAA] Fix BatchAA results for phi-phi assumptions.

Which does make this a mild compile-time regression, but not too bad.

Fri, Nov 27, 12:01 AM · Restricted Project

Thu, Nov 26

mstorsjo added a comment to D91692: [OpenMP][OMPT] Introduce a guard to handle OMPT return address.

This broke building with OMPT disabled, but I went ahead and pushed a fix for that in 6b429668ded1aa7de4d586fc6dc8a469799b4d9c, by moving OmptReturnAddressGuard to inside the OMPT_SUPPORT ifdef.

Thu, Nov 26, 12:11 AM · Restricted Project
mstorsjo committed rG6b429668ded1: [OpenMP][OMPT] Fix building with OMPT disabled after 6d3b81664a4b79 (authored by mstorsjo).
[OpenMP][OMPT] Fix building with OMPT disabled after 6d3b81664a4b79
Thu, Nov 26, 12:10 AM

Wed, Nov 25

mstorsjo updated the diff for D91851: [compiler-rt] [emutls] Handle unused parameters in a compiler agnostic way.

Removed the pragmas altogether and replaced with casts to void.

Wed, Nov 25, 1:10 PM · Restricted Project
mstorsjo committed rGd2b71ea03d9c: [ORC] Cast to const void* to silence a GCC warning. NFC. (authored by mstorsjo).
[ORC] Cast to const void* to silence a GCC warning. NFC.
Wed, Nov 25, 2:11 AM
mstorsjo committed rGdf54f50437db: [ORC] Remove a superfluous semicolon, silencing GCC warnings. NFC. (authored by mstorsjo).
[ORC] Remove a superfluous semicolon, silencing GCC warnings. NFC.
Wed, Nov 25, 2:11 AM

Tue, Nov 24

mstorsjo updated subscribers of D91851: [compiler-rt] [emutls] Handle unused parameters in a compiler agnostic way.
Tue, Nov 24, 2:38 AM · Restricted Project
mstorsjo added a comment to D91851: [compiler-rt] [emutls] Handle unused parameters in a compiler agnostic way.
clang -target x86_64-unknown-windows-itanium -x c -E - -dM <<< '' | grep _MSC_VER

This is the reason that I prefer the "inverted" logic.

Tue, Nov 24, 2:13 AM · Restricted Project
mstorsjo committed rG0b2d84fba84b: [LLD] [COFF] Allow wrapping dllimported functions (authored by mstorsjo).
[LLD] [COFF] Allow wrapping dllimported functions
Tue, Nov 24, 12:16 AM
mstorsjo closed D91689: [LLD] [COFF] Allow wrapping dllimported functions.
Tue, Nov 24, 12:15 AM · Restricted Project

Mon, Nov 23

mstorsjo added a comment to D91058: [DebugInfo] Refactor code for emitting DWARF expressions for FP constants.

I also ran into this issue (and added a second repro to the bug report); I'd suggest a revert, but I think @labath may get to it fairly soon, so holding off of reverting until the end of the day.

Mon, Nov 23, 11:29 PM · Restricted Project
mstorsjo added a comment to D73156: [clang] Build clang-shlib on mingw.

This actually is done (almost) like this in current git master, see D87547 and D89225.

Mon, Nov 23, 9:15 PM · Restricted Project
mstorsjo added a comment to D91851: [compiler-rt] [emutls] Handle unused parameters in a compiler agnostic way.

Would be nice to actually mention that in the commit message and adjust the condition to indicate that (!defined(__MINGW32__) && !defined(__MINGW64__)).

I think that's kind of inverts the logic IMO. We have an MSVC specific pragma in win32-generic code, and thus the ifdef should check for presence of _MSC_VER, not the absence of something else.

Mon, Nov 23, 2:56 PM · Restricted Project
mstorsjo added a comment to D91851: [compiler-rt] [emutls] Handle unused parameters in a compiler agnostic way.

Would be nice to actually mention that in the commit message and adjust the condition to indicate that (!defined(__MINGW32__) && !defined(__MINGW64__)).

Mon, Nov 23, 1:32 PM · Restricted Project
mstorsjo committed rG6f792041a5cb: Reapply "[CodeGen] [WinException] Only produce handler data at the end of the… (authored by mstorsjo).
Reapply "[CodeGen] [WinException] Only produce handler data at the end of the…
Mon, Nov 23, 1:17 PM
mstorsjo closed D87448: [CodeGen] [WinException] Only produce handler data at the end of the function if needed.
Mon, Nov 23, 1:17 PM · Restricted Project
mstorsjo added a comment to D91851: [compiler-rt] [emutls] Handle unused parameters in a compiler agnostic way.

I don't have an objection to the change, but would like more details added to the commit message. It is unclear to me why the change is needed as clang does accept this I believe (and a quick test seems to indicate so as well).

Mon, Nov 23, 12:32 PM · Restricted Project
mstorsjo added inline comments to D87448: [CodeGen] [WinException] Only produce handler data at the end of the function if needed.
Mon, Nov 23, 7:42 AM · Restricted Project
mstorsjo added a comment to D87448: [CodeGen] [WinException] Only produce handler data at the end of the function if needed.

lgtm

(I added a naming comment, but feel free to resolve that as you feel is best.)

Mon, Nov 23, 7:28 AM · Restricted Project
mstorsjo added a comment to D87448: [CodeGen] [WinException] Only produce handler data at the end of the function if needed.

Awesome, thanks! Do you want to have a look at the patch itself and review it, or does @rnk have time? (It's his original suggestion, to emit xdata in .seh_endproc, but the implementation is entirely trivial.)

@rnk knows this stuff much better than I do. Let's see if he has time, otherwise I can try to ramp up on it.

Mon, Nov 23, 5:19 AM · Restricted Project

Sat, Nov 21

mstorsjo committed rG33fb9679ec6e: [compiler-rt] [profile] Silence a warning about an unused function on mingw… (authored by mstorsjo).
[compiler-rt] [profile] Silence a warning about an unused function on mingw…
Sat, Nov 21, 12:15 PM
mstorsjo closed D91850: [compiler-rt] [profile] Silence a warning about an unused function on mingw targets.
Sat, Nov 21, 12:15 PM · Restricted Project
mstorsjo added a reviewer for D91181: [24/N] [libcxx] Make generic_*string return paths with forward slashes on windows: EricWF.
Sat, Nov 21, 6:24 AM · Restricted Project
mstorsjo added a reviewer for D91179: [23/N] [libcxx] Have lexically_normal return the path with preferred separators: EricWF.
Sat, Nov 21, 6:23 AM · Restricted Project
mstorsjo added a reviewer for D91178: [22/N] [libcxx] Implement append and operator/ properly for windows: EricWF.
Sat, Nov 21, 6:23 AM · Restricted Project
mstorsjo added a reviewer for D91177: [21/N] [libcxx] Implement is_absolute properly for windows: EricWF.
Sat, Nov 21, 6:22 AM · Restricted Project
mstorsjo added a reviewer for D91176: [20/N] [libcxx] Implement parsing of root_name for paths on windows: EricWF.
Sat, Nov 21, 6:22 AM · Restricted Project
mstorsjo added a reviewer for D91175: [19/N] [libcxx] Fix the fallback case in temp_directory_path for windows: EricWF.
Sat, Nov 21, 6:22 AM · Restricted Project
mstorsjo added a reviewer for D91173: [18/N] [libcxx] Use the posix code for directory_entry::__do_refresh: EricWF.
Sat, Nov 21, 6:22 AM · Restricted Project
mstorsjo added a reviewer for D91172: [17/N] [libcxx] Implement the read_symlink function for windows: EricWF.
Sat, Nov 21, 6:21 AM · Restricted Project
mstorsjo added a reviewer for D91171: [16/N] [libcxx] Implement the permissions function for windows: EricWF.
Sat, Nov 21, 6:21 AM · Restricted Project
mstorsjo added a reviewer for D91170: [15/N] [libcxx] Implement the canonical function for windows: EricWF.
Sat, Nov 21, 6:20 AM · Restricted Project
mstorsjo added a reviewer for D91169: [14/N] [libcxx] Implement the current_path function for windows: EricWF.
Sat, Nov 21, 6:20 AM · Restricted Project
mstorsjo added a reviewer for D91168: [13/N] [libcxx] Implement the space function for windows: EricWF.
Sat, Nov 21, 6:20 AM · Restricted Project
mstorsjo added a reviewer for D91143: [11/N] [libcxx] Hook up a number of operation functions to their windows counterparts: EricWF.
Sat, Nov 21, 6:19 AM · Restricted Project
mstorsjo added a reviewer for D91142: [10/N] [libcxx] Implement _FilesystemClock::now() and __last_write_time for windows: EricWF.
Sat, Nov 21, 6:19 AM · Restricted Project
mstorsjo added a reviewer for D91141: [9/N] [libcxx] Implement the stat function family on top of native windows APIs: EricWF.
Sat, Nov 21, 6:19 AM · Restricted Project
mstorsjo added a reviewer for D91140: [8/N] [libcxx] Fix the preexisting directory_iterator code for windows: EricWF.
Sat, Nov 21, 6:18 AM · Restricted Project
mstorsjo added a reviewer for D91139: [7/N] [libcxx] Don't use __int128 for msvc targets: EricWF.
Sat, Nov 21, 6:18 AM · Restricted Project
mstorsjo added a reviewer for D91138: [6/N] [libcxx] Handle backslash as path separator on windows: EricWF.
Sat, Nov 21, 6:18 AM · Restricted Project
mstorsjo added a reviewer for D91137: [5/N] [libcxx] Convert paths to/from the right narrow code page for narrow strings on windows: EricWF.
Sat, Nov 21, 6:17 AM · Restricted Project