Page MenuHomePhabricator
Feed Advanced Search

Yesterday

hans added a comment to D86091: [cmake] Fix build of attribute plugin example on Windows.

@hans sorry for not spotting it earlier but is it possible to still backport it to LLVM 11?
It's totally OK if it's too late. I can easily keep it as a patch in MSYS2 repository.

Mon, Sep 28, 3:43 AM · Restricted Project
hans added a comment to D88190: C API: functions to get mask of a ShuffleVector.

For those following along, the follow-up patch was https://reviews.llvm.org/D88367

Mon, Sep 28, 3:39 AM · Restricted Project

Fri, Sep 25

hans committed rG4f1897c6f008: Move PassBuilder::registerParseTopLevelPipelineCallback out-of-line (authored by hans).
Move PassBuilder::registerParseTopLevelPipelineCallback out-of-line
Fri, Sep 25, 10:56 AM
hans added a comment to D88190: C API: functions to get mask of a ShuffleVector.

This is my first contribution to LLVM, I'm not sure what the typical practice is, but if it's a normal Git commit, then Craig Disselkoen <craigdissel@gmail.com> is fine. Thanks for the review!

Also, again I'm new here, but since this fixes a regression, if there's any possibility of landing this on the 11.x branch in addition to master, I'd appreciate it. I know it's probably too late for 11.0.0.

Fri, Sep 25, 4:35 AM · Restricted Project

Thu, Sep 17

hans added a comment to D87698: [SelectionDAG] Check any use of negation result before removal.

Cherry-picked to 11.x as b78e5de029c26c309f541ab883fa5d6d953b073d.

Thu, Sep 17, 4:40 AM · Restricted Project
hans added a comment to D31413: [libc++] Use __attribute__((init_priority(101))) to ensure streams get initialized early.

Might even be worth backporting such as simple but useful fix to the 11 release?

Thu, Sep 17, 4:36 AM · Restricted Project
hans added a comment to D87270: [Flang] Add GettingInvolved documentation page and sidebar..

Cherry-picked to 11.x as 4fe4e35452ef17ce3db08b080e3b0642d36c5094.

Thu, Sep 17, 4:31 AM · Restricted Project
hans added a comment to D85782: [X86][ELF] Prefer lowering MC_GlobalAddress operands to .Lfoo$local only for STV_DEFAULT globals.

Okay, cherry-picked to 11.x as 80e2fc1e6e68d6ed57dccc03c6a5121e216bfd43.

Thu, Sep 17, 4:26 AM · Restricted Project

Wed, Sep 16

hans added a comment to D87710: [clangd] Actually parse Index section of the YAML file..

Pushed to 11.x as 4a26e3b33798424dc5a4843f7b29a617bef81656.

Wed, Sep 16, 5:51 AM · Restricted Project
hans added a comment to D87710: [clangd] Actually parse Index section of the YAML file..

Argh, sorry. I think this might be too late to get into 11 - we're in the "soon=final" stage and maybe any changes at all cause logistical problems? :-(

@hans to confirm - this is a feature that was meant to be in the 11 release (and was implemented and tested) but the flag to enable it wasn't wired up.

Wed, Sep 16, 2:22 AM · Restricted Project
hans added a comment to D87714: [flang] Fix docs build.

Cherry-picked to the branch as 8f2c29681ce768afb739b6cf5ccca81dd87d5326.

Wed, Sep 16, 1:49 AM · Restricted Project
hans accepted D86369: [Sema][MSVC] warn at dynamic_cast when /GR- is given.

lgtm

Wed, Sep 16, 1:43 AM · Restricted Project

Tue, Sep 15

hans accepted D87714: [flang] Fix docs build.

Nice! I tried this out, and it appears to work.

Tue, Sep 15, 12:06 PM · Restricted Project
hans accepted D87425: [CodeGen][typeid] Emit typeinfo directly if type is known at compile-time.

lgtm

Tue, Sep 15, 12:04 PM · Restricted Project
hans added a comment to D87242: [flang] Add new documentation main page.

Sadly after this commit, I'm no longer able to build the Flang docs, my build failing like this:

Tue, Sep 15, 11:09 AM · Restricted Project
hans added a comment to D77882: [clang-tidy] Add option to use alpha checkers from clang-analyzer when using `run-clang-tidy.py`.
Tue, Sep 15, 10:08 AM · Restricted Project, Restricted Project
hans added a comment to D86958: [Docs] Add/update release notes for D71913 (LTO WPD changes).

I see it now. Thanks!

Tue, Sep 15, 10:06 AM · Restricted Project, Restricted Project
hans added a comment to D87425: [CodeGen][typeid] Emit typeinfo directly if type is known at compile-time.

I think it would be safer to do the change purely as an optimization in codegen (maybe we could add a new helper method that could also be used by the warning).

For "optimization in codegen", do you mean optimization after the IR is generated or like I did in CodeGenFunction::EmitCXXTypeidExpr?

Tue, Sep 15, 10:04 AM · Restricted Project
hans added a comment to D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x)..

Please go ahead and commit.

Hi Hans, can you commit it yourself? I have some technical issues and not able to commit it. And I don't know when it is going to be resolved. :(

Tue, Sep 15, 9:40 AM · Restricted Project
hans added a comment to D77882: [clang-tidy] Add option to use alpha checkers from clang-analyzer when using `run-clang-tidy.py`.

This seems to have caused https://bugs.llvm.org/show_bug.cgi?id=47512

Tue, Sep 15, 8:05 AM · Restricted Project, Restricted Project
hans added a comment to D86533: (Urgent!) [release][docs][analyzer] Add 11.0.0. release notes.

No worries :) Thanks for the notes!

Tue, Sep 15, 7:53 AM · Restricted Project
hans added a comment to D86958: [Docs] Add/update release notes for D71913 (LTO WPD changes).

Please go ahead and commit to the branch.

Tue, Sep 15, 6:54 AM · Restricted Project, Restricted Project
hans added a comment to D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x)..

Please go ahead and commit.

Tue, Sep 15, 6:52 AM · Restricted Project
hans accepted D86532: (Urgent!) [docs][analyzer] Add documentation for alpha.fuchsia.Lock and alpha.core.C11Lock.

lgtm please commit so this makes it into the release.

Tue, Sep 15, 6:50 AM · Restricted Project
hans accepted D86533: (Urgent!) [release][docs][analyzer] Add 11.0.0. release notes.

This has probably had enough time for review. Please commit.

Tue, Sep 15, 6:49 AM · Restricted Project
hans added a comment to D85782: [X86][ELF] Prefer lowering MC_GlobalAddress operands to .Lfoo$local only for STV_DEFAULT globals.

@hans, I think that we should put this change onto the release branch for llvm11.

Tue, Sep 15, 6:09 AM · Restricted Project
hans added a reverting change for rG66251f7e1de7: RegAllocFast: Record internal state based on register units: rGa21387c65470: Revert "RegAllocFast: Record internal state based on register units".
Tue, Sep 15, 4:29 AM
hans committed rGa21387c65470: Revert "RegAllocFast: Record internal state based on register units" (authored by hans).
Revert "RegAllocFast: Record internal state based on register units"
Tue, Sep 15, 4:29 AM
hans committed rG7b58eb50d96b: [Support] Make building with snmalloc work (authored by hans).
[Support] Make building with snmalloc work
Tue, Sep 15, 1:17 AM
hans closed D87471: [Support] Make building with snmalloc work.
Tue, Sep 15, 1:17 AM · Restricted Project

Mon, Sep 14

hans added a comment to D87521: [MinGW][llvm-config] Use unversioned library name.

@hans - Does that sound right to you?

Mon, Sep 14, 5:26 AM · Restricted Project
hans updated the diff for D87471: [Support] Make building with snmalloc work.

Added target condition.

Mon, Sep 14, 5:17 AM · Restricted Project

Fri, Sep 11

hans added a comment to D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE.

This is new functionality, so I don't think we should merge it so late in the release process.

Fri, Sep 11, 2:10 AM · Restricted Project, Restricted Project

Thu, Sep 10

hans added a comment to D71786: [Support] On Windows, add optional support for {rpmalloc|snmalloc|mimalloc}.

For rpmalloc make sure to use the latest develop branch, the use of hard _exit in lld coupled with the use of fiber local storage made the allocator sometimes end up in a deadlock. It should be fixed on the develop branch.

Thu, Sep 10, 10:44 AM · Restricted Project
hans added a comment to D86875: [Flang][NFC] Remove license comments from files in docs/ folder..

Cherrty-picked the revert to 11.x as 8ae3293030d9691ebe0006b79cec1b06bb8015cf

Thu, Sep 10, 10:41 AM · Restricted Project
hans added a comment to D71786: [Support] On Windows, add optional support for {rpmalloc|snmalloc|mimalloc}.

https://reviews.llvm.org/D87471 makes building with snmalloc work for me, both with msvc and clang-cl.

Thu, Sep 10, 10:36 AM · Restricted Project
hans requested review of D87471: [Support] Make building with snmalloc work.
Thu, Sep 10, 10:35 AM · Restricted Project
hans added a comment to D71786: [Support] On Windows, add optional support for {rpmalloc|snmalloc|mimalloc}.

I've been trying to use this, but not with much luck so far.

Thu, Sep 10, 8:10 AM · Restricted Project
hans added a comment to D87425: [CodeGen][typeid] Emit typeinfo directly if type is known at compile-time.

I'm not sure that changing isPotentiallyEvaluated() is the right thing to do. The meaning of that corresponds to text in the standard: https://eel.is/c++draft/expr.typeid#3 so changing it to something that doesn't match the standard exactly seems wrong.

Thu, Sep 10, 5:18 AM · Restricted Project
hans accepted D87118: Add an explicit toggle for the static analyzer in clang-tidy.

lgtm

Thu, Sep 10, 2:15 AM · Restricted Project

Wed, Sep 9

hans added a comment to D86131: [FLANG] Pick `.md` files when building sphinx documentation..

Hi @hans
The problem here is the version of recommonmark.
We strictly need version 0.5.0 or above.
See the note at https://www.sphinx-doc.org/en/master/usage/markdown.html#configuration
and https://github.com/llvm/llvm-project/blob/0fd425af071a9bc5c0891a4db09f4d9a466b7be9/flang/docs/conf.py#L44

I tried with the mentioned version and I can see the comments in the HTML files.
@sscalpone as well has verified it with recommonmark 0.6.0 version

Hopefully, @hans if you can verify it with a sample comment on your machine then I can revert the old patch D86875 and bring back licence text.

Thanks.

Wed, Sep 9, 5:10 AM · Restricted Project, Restricted Project
hans added a comment to D80197: [DebugInfo] Upgrade DISubrange to support Fortran dynamic arrays.

Alok, Adrian: please work on addressing the concerns raised in https://bugs.llvm.org/show_bug.cgi?id=47287, or please revert this change.

Wed, Sep 9, 1:56 AM · Restricted Project, Restricted Project, debug-info

Tue, Sep 8

hans added a reverting change for rG3e782bf8090c: [Sema][MSVC] warn at dynamic_cast when /GR- is given: rG2d9d270e7791: Revert 3e782bf809 "[Sema][MSVC] warn at dynamic_cast when /GR- is given".
Tue, Sep 8, 7:17 AM
hans committed rG2d9d270e7791: Revert 3e782bf809 "[Sema][MSVC] warn at dynamic_cast when /GR- is given" (authored by hans).
Revert 3e782bf809 "[Sema][MSVC] warn at dynamic_cast when /GR- is given"
Tue, Sep 8, 7:17 AM
hans added a reverting change for D86369: [Sema][MSVC] warn at dynamic_cast when /GR- is given: rG2d9d270e7791: Revert 3e782bf809 "[Sema][MSVC] warn at dynamic_cast when /GR- is given".
Tue, Sep 8, 7:16 AM · Restricted Project
hans committed rG2168dbf4cc76: getClangStripDependencyFileAdjuster(): Do not remove -M args when using MSVC cl… (authored by shivanshu3).
getClangStripDependencyFileAdjuster(): Do not remove -M args when using MSVC cl…
Tue, Sep 8, 1:21 AM
hans closed D86999: getClangStripDependencyFileAdjuster(): Do not remove -M args when using MSVC cl driver.
Tue, Sep 8, 1:21 AM · Restricted Project

Mon, Sep 7

hans accepted D86369: [Sema][MSVC] warn at dynamic_cast when /GR- is given.

But please add a -triple parameter to the test files, and check the dynamic_cast<void*> behavior in each case before committing.

Mon, Sep 7, 10:30 AM · Restricted Project
hans added a comment to D87110: [WebAssembly] Fix incorrect assumption of simple value types.

Pushed to 11.x as 8399522c96a94bfb7c1cbf4df2bed0b3d826fbf6. Please let me know if there any follow-ups.

Mon, Sep 7, 10:27 AM · Restricted Project
hans added a comment to D87118: Add an explicit toggle for the static analyzer in clang-tidy.

Cool!

Mon, Sep 7, 2:15 AM · Restricted Project

Thu, Sep 3

hans added inline comments to D86369: [Sema][MSVC] warn at dynamic_cast when /GR- is given.
Thu, Sep 3, 1:04 PM · Restricted Project
hans added a comment to D86369: [Sema][MSVC] warn at dynamic_cast when /GR- is given.

Okay, almost there..

Thu, Sep 3, 6:02 AM · Restricted Project
hans added inline comments to D86999: getClangStripDependencyFileAdjuster(): Do not remove -M args when using MSVC cl driver.
Thu, Sep 3, 5:48 AM · Restricted Project

Wed, Sep 2

hans added inline comments to D86369: [Sema][MSVC] warn at dynamic_cast when /GR- is given.
Wed, Sep 2, 10:53 AM · Restricted Project
hans added a comment to D86999: getClangStripDependencyFileAdjuster(): Do not remove -M args when using MSVC cl driver.

Seems reasonable to me. Just some nits.

Wed, Sep 2, 7:38 AM · Restricted Project
hans accepted D86820: [X86] Add a /tune: option for clang-cl.

lgtm

Wed, Sep 2, 2:21 AM · Restricted Project
hans accepted D86958: [Docs] Add/update release notes for D71913 (LTO WPD changes).

Looks great, thanks!

Wed, Sep 2, 2:14 AM · Restricted Project, Restricted Project

Tue, Sep 1

hans added a comment to D84238: [PowerPC] Set v1i128 to expand for SETCC to avoid crash.

Pushed to 11.x as 7569e8c696288cd9c9409936b4fe9b846d0bd0b7 to fix https://bugs.llvm.org/show_bug.cgi?id=47374

Tue, Sep 1, 8:21 AM · Restricted Project
hans added a comment to D86820: [X86] Add a /tune: option for clang-cl.

Okay, adding it to clang-cl seems fine to me. But I think it could be a simple alias?

Tue, Sep 1, 4:38 AM · Restricted Project
hans added a comment to D86875: [Flang][NFC] Remove license comments from files in docs/ folder..

@sameeranjoshi Please consider fixing this issue in the conversion tool (maybe commonmark.py) & propagating the fix to llvm.org?

Tue, Sep 1, 1:21 AM · Restricted Project

Mon, Aug 31

hans accepted D86875: [Flang][NFC] Remove license comments from files in docs/ folder..

lgtm

Mon, Aug 31, 6:19 AM · Restricted Project
hans added a comment to D86820: [X86] Add a /tune: option for clang-cl.

Would it be enough for users to specify /clang:-mtune instead? How does icc spell its option?

Mon, Aug 31, 5:47 AM · Restricted Project
hans added a comment to D85630: [cmake] Don't build with -O3 -fPIC on Solaris/sparcv9.

Pushed to 11.x as 7166d2653be30b18d87a112ca99ae706dd998ba2

Mon, Aug 31, 5:45 AM · Restricted Project
hans added inline comments to D86369: [Sema][MSVC] warn at dynamic_cast when /GR- is given.
Mon, Aug 31, 5:38 AM · Restricted Project
hans added a comment to D86689: [DAGCombine] Don't delete the node if it has uses immediately.

Cherry-picked to 11.x as defbc77a7c951d8cc47daf49df15c7f548cada05.

Mon, Aug 31, 5:17 AM · Restricted Project
hans added a comment to D86131: [FLANG] Pick `.md` files when building sphinx documentation..

I tried building the Flang docs with this applied, and they build fine, but show up empty in my web browser.

Mon, Aug 31, 4:57 AM · Restricted Project, Restricted Project

Aug 28 2020

hans added a comment to D71786: [Support] On Windows, add optional support for {rpmalloc|snmalloc|mimalloc}.

This seems to have broken 32-bit builds for me. In an x86 VS 2019 prompt:

Aug 28 2020, 5:26 AM · Restricted Project
hans added inline comments to D86369: [Sema][MSVC] warn at dynamic_cast when /GR- is given.
Aug 28 2020, 2:30 AM · Restricted Project
hans added a comment to D85630: [cmake] Don't build with -O3 -fPIC on Solaris/sparcv9.

Are you still ok with the revised version? It was prompted by a question in Bug 47304 which showed that I'd missed some cases before.

Aug 28 2020, 2:25 AM · Restricted Project
hans added a comment to D86626: [OpenCL][Docs] 10.x release notes.

@hans, would you be able to commit this to the release branch?

Aug 28 2020, 2:12 AM
hans added a comment to D86715: [CodeGen] Properly propagating Calling Convention information when lowering vector arguments.

Pushed to 11.x as ba3413982cbd7a5b5aeaf2ea34e0a91d5561202d. Please let me know if there are any follow-ups.

Aug 28 2020, 2:06 AM · Restricted Project
hans added a comment to D85007: [PowerPC] PPCBoolRetToInt: Don't translate Constant's operands.

Pushed to 11.x as b931e22c954374acf75c4f1d1f2666f3f8e67470. Please let me know if there are any follow-ups.

Aug 28 2020, 2:01 AM · Restricted Project
hans added a comment to D86764: [Bindings] Add LLVMAddInstructionSimplifyPass.

Looks great to me, that'll certainly fit the bill for mesa (not sure though on the name should it have the Legacy in the name too for consistency - either way looks fine to me however).

Aug 28 2020, 1:14 AM · Restricted Project

Aug 27 2020

hans accepted D85630: [cmake] Don't build with -O3 -fPIC on Solaris/sparcv9.

Feels like a hack, but I'm not strongly opposed either.

Aug 27 2020, 5:14 AM · Restricted Project
hans added a comment to D85210: [OpenMP] Don't use MSVC workaround with MinGW.

@mstorsjo @hans I apologize but we will have to backport https://reviews.llvm.org/D86552 (should affect only MinGW so it's rather low risk) or revert this cherry-pick on LLVM 11 branch.

Okay, I'll backport it once it lands (or revert if it drags out).

Aug 27 2020, 5:04 AM · Restricted Project
hans added a comment to D86552: [OpenMP] Fix import library installation with MinGW.

Cherry-picked to 11.x as 522d80ab553b42e2feadfd4178932069dfc51d3f.

Aug 27 2020, 5:04 AM · Restricted Project
hans added inline comments to D86369: [Sema][MSVC] warn at dynamic_cast when /GR- is given.
Aug 27 2020, 4:44 AM · Restricted Project
hans accepted D71786: [Support] On Windows, add optional support for {rpmalloc|snmalloc|mimalloc}.

Thanks for the update! I'm excited to get this in.

Aug 27 2020, 2:50 AM · Restricted Project

Aug 26 2020

hans added a comment to D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x)..

but we can merge this right away (IMHO)

It is up to Hans if he has some time. But I think I covered almost all new features (+ complex for NVPTX), so after the update it can be merged with 11.x release.

Aug 26 2020, 8:22 AM · Restricted Project
hans added inline comments to D86369: [Sema][MSVC] warn at dynamic_cast when /GR- is given.
Aug 26 2020, 8:20 AM · Restricted Project
hans added a comment to D85785: [ELF] -r: allow SHT_X86_64_UNWIND to be merged into SHT_PROGBITS.

@hans This is a good candidate for release/11.x

Aug 26 2020, 8:03 AM · Restricted Project
hans added a comment to D85210: [OpenMP] Don't use MSVC workaround with MinGW.

@mstorsjo @hans I apologize but we will have to backport https://reviews.llvm.org/D86552 (should affect only MinGW so it's rather low risk) or revert this cherry-pick on LLVM 11 branch.

Aug 26 2020, 7:48 AM · Restricted Project
hans committed rG8421503300c6: Bump -len_control value in fuzzer-custommutator.test (PR47286) (authored by hans).
Bump -len_control value in fuzzer-custommutator.test (PR47286)
Aug 26 2020, 7:46 AM
hans committed rG7a34dca0f391: Fix failing tests after VCTOOLSDIR change (authored by zahen).
Fix failing tests after VCTOOLSDIR change
Aug 26 2020, 7:35 AM
hans added a comment to D86622: Fix failing tests after VCTOOLSDIR change.

Sorry again about the break! As with the initial patch, I'll need you to land this change.

Aug 26 2020, 7:35 AM · Restricted Project
hans closed D86622: Fix failing tests after VCTOOLSDIR change.
Aug 26 2020, 7:34 AM · Restricted Project
hans accepted D86622: Fix failing tests after VCTOOLSDIR change.
Aug 26 2020, 7:30 AM · Restricted Project
hans added inline comments to D86579: Add lld/ELF release notes for release/11.x.
Aug 26 2020, 6:37 AM · Restricted Project
hans added a comment to D85579: [ELF] --gdb-index: skip SHF_GROUP .debug_info.

@hans This patch can be cleanly cherry-picked to release/11.x It addresses a pain for DWARF v5 -fdebug-types-section users.

Aug 26 2020, 6:36 AM · Restricted Project
hans committed rG087047144210: Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain (authored by zahen).
Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain
Aug 26 2020, 6:09 AM
hans closed D85998: Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain.
Aug 26 2020, 6:09 AM · Restricted Project

Aug 25 2020

hans added a comment to rG10658691951f: [Matrix] Add matrix type to Clang..

Should this be mentioned in the release notes?

Aug 25 2020, 11:37 AM
hans added a comment to rG03f43b3aca36: [lld] Initial commit for new Mach-O backend.

Would you like to add a mention of this in the lld release notes?

Aug 25 2020, 11:28 AM
hans added a comment to rGdfecec65e679: [AVR] Include AVR by default in LLVM builds.

Would you like to add a mention of this in docs/ReleaseNotes.rst? Thanks.

Aug 25 2020, 11:23 AM
hans added a comment to rG10c11e4e2d05: This option allows selecting the TLS size in the local exec TLS model, which is….

Should this be mentioned in the release notes for llvm 11? Please send a patch :-)

Aug 25 2020, 11:11 AM
hans added a comment to D85998: Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain.

I'll land tomorrow unless Alexandre beats me to it.

Aug 25 2020, 10:54 AM · Restricted Project
hans added a comment to D85759: [SLPVectorizer] Fix regression from cost model refactoring.

This regression is in release branch too, right? so worth to backport it?

@hans

Aug 25 2020, 10:51 AM · Restricted Project
hans accepted D85998: Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain.
Aug 25 2020, 10:50 AM · Restricted Project
hans added a comment to D86183: [DAGCombine] Remove dead node when it is created by getNegatedExpression.

Pushed to 11.x as 4d16d8dfe50eb45545e844c3c9acafd363637dad

Aug 25 2020, 8:54 AM · Restricted Project
hans added a comment to D85998: Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain.

Seems reasonable to me.

Aug 25 2020, 8:26 AM · Restricted Project