Page MenuHomePhabricator
Feed Advanced Search

Today

StephenTozer closed D88585: [DebugInfo] Support representation of multiple location operands in ISel's SDDbgValue.
Mon, Mar 8, 10:55 AM · Restricted Project, debug-info
StephenTozer closed D88230: [DebugInfo] Support multiple location operands via DIArgList in DbgVariableIntrinsics.

Landed in LLVM commit llvmorg-13-init-3801-ge5d958c45629.

Mon, Mar 8, 6:43 AM · Restricted Project, debug-info

Fri, Mar 5

StephenTozer closed D88175: [DebugInfo] Add new metadata, DIArgList, for referencing a list of SSA values inside a debug variable intrinsic.
Fri, Mar 5, 9:02 AM · Restricted Project, debug-info
djtodoro updated the diff for D82546: [Debugify][OriginalDIMode] Export the report into JSON file.
  • adjust the test to work on Windows as well
Fri, Mar 5, 4:49 AM · Restricted Project, debug-info

Thu, Mar 4

jasonliu added inline comments to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Thu, Mar 4, 7:21 PM · debug-info, Restricted Project
shchenz added inline comments to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Thu, Mar 4, 7:04 PM · debug-info, Restricted Project
jasonliu added inline comments to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Thu, Mar 4, 6:39 PM · debug-info, Restricted Project
shchenz closed D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Thu, Mar 4, 6:08 PM · debug-info, Restricted Project
shchenz added a comment to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.

@jasonliu Please see my inline comments for the corner case and the left FIXME. Thanks for your review.

Thu, Mar 4, 5:17 PM · debug-info, Restricted Project
shchenz updated the diff for D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.

1: add more comment

Thu, Mar 4, 5:16 PM · debug-info, Restricted Project
jasonliu accepted D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.

LGTM if the nit comment is addressed
There are two items that we need to follow up after this patch:

  1. The corner case/bug in https://reviews.llvm.org/D95518#inline-919030
  2. The possibility of addressing the FIXME for https://reviews.llvm.org/D95518#inline-918884
Thu, Mar 4, 10:01 AM · debug-info, Restricted Project
jasonliu added inline comments to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Thu, Mar 4, 9:23 AM · debug-info, Restricted Project
jasonliu added inline comments to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Thu, Mar 4, 7:12 AM · debug-info, Restricted Project
jasonliu added inline comments to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Thu, Mar 4, 6:57 AM · debug-info, Restricted Project
StephenTozer added a comment to D82363: [DebugInfo] Add new instruction and expression operator for variadic debug values.

This fails on bots that have a non-x86 default triple: http://45.33.8.238/macm1/4580/step_10.txt

Probably just needs an explicit triple.

Please take a look, and revert for now if it takes a while to fix.

Thu, Mar 4, 4:38 AM · Restricted Project, debug-info
thakis added a comment to D82363: [DebugInfo] Add new instruction and expression operator for variadic debug values.

This fails on bots that have a non-x86 default triple: http://45.33.8.238/macm1/4580/step_10.txt

Thu, Mar 4, 4:19 AM · Restricted Project, debug-info
StephenTozer added a reverting change for D82363: [DebugInfo] Add new instruction and expression operator for variadic debug values: rGd2000b45d033: Revert "[DebugInfo] Add new instruction and DIExpression operator for variadic….
Thu, Mar 4, 3:59 AM · Restricted Project, debug-info
StephenTozer closed D82363: [DebugInfo] Add new instruction and expression operator for variadic debug values.
Thu, Mar 4, 3:46 AM · Restricted Project, debug-info
djtodoro updated the diff for D82546: [Debugify][OriginalDIMode] Export the report into JSON file.
  • adding a test
Thu, Mar 4, 2:11 AM · Restricted Project, debug-info
djtodoro added a reviewer for D82546: [Debugify][OriginalDIMode] Export the report into JSON file: StephenTozer.
Thu, Mar 4, 2:08 AM · Restricted Project, debug-info

Wed, Mar 3

demoitem updated the diff for D76115: Add debug support for set types.

Added a test case for DIBuilder

Wed, Mar 3, 7:08 PM · debug-info, Restricted Project
shchenz added inline comments to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Wed, Mar 3, 6:23 PM · debug-info, Restricted Project
shchenz added inline comments to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Wed, Mar 3, 6:06 PM · debug-info, Restricted Project
shchenz updated the diff for D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.

1: address @jasonliu comments

Wed, Mar 3, 6:06 PM · debug-info, Restricted Project
jasonliu added inline comments to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Wed, Mar 3, 5:56 PM · debug-info, Restricted Project
jasonliu added inline comments to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Wed, Mar 3, 10:39 AM · debug-info, Restricted Project
StephenTozer updated the diff for D82363: [DebugInfo] Add new instruction and expression operator for variadic debug values.

Rebased onto latest master, numerous small cleanups.

Wed, Mar 3, 4:56 AM · Restricted Project, debug-info
StephenTozer updated the diff for D83890: [DebugInfo] Process DBG_VALUE_LIST in LiveDebugValues.

Rebased onto latest master, address review comments.

Wed, Mar 3, 4:43 AM · Restricted Project, debug-info
djtodoro added a comment to D82546: [Debugify][OriginalDIMode] Export the report into JSON file.

@StephenTozer Thanks!

Wed, Mar 3, 3:02 AM · Restricted Project, debug-info
shchenz added inline comments to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Wed, Mar 3, 12:06 AM · debug-info, Restricted Project

Tue, Mar 2

shchenz updated the diff for D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.

1: address comments

Tue, Mar 2, 11:58 PM · debug-info, Restricted Project
jasonliu added inline comments to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Tue, Mar 2, 11:26 AM · debug-info, Restricted Project
StephenTozer added a comment to D82546: [Debugify][OriginalDIMode] Export the report into JSON file.

The fundamentals of the patch look solid; minor point about the HTML templating, and also I think there should be a couple of tests for the llvm-original-di-preservation script - nothing too complicated, just verifying that it produces the correct HTML for a given input, as with the opt-viewer tests.

Tue, Mar 2, 3:44 AM · Restricted Project, debug-info
shchenz added inline comments to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Tue, Mar 2, 3:03 AM · debug-info, Restricted Project
Orlando added a comment to D97668: [debuginfo-tests] Add some optnone tests.

Thank you @rnk.

Tue, Mar 2, 1:02 AM · Restricted Project, debug-info
Orlando closed D97668: [debuginfo-tests] Add some optnone tests.
Tue, Mar 2, 1:01 AM · Restricted Project, debug-info
shchenz updated the diff for D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.

some simplify to the test case

Tue, Mar 2, 12:31 AM · debug-info, Restricted Project

Mon, Mar 1

shchenz added inline comments to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Mon, Mar 1, 11:46 PM · debug-info, Restricted Project
shchenz updated the diff for D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.

address @jasonliu comments:
1: handle explicit section
2: add more testcases

Mon, Mar 1, 11:46 PM · debug-info, Restricted Project
jasonliu added inline comments to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Mon, Mar 1, 7:49 PM · debug-info, Restricted Project
shchenz added inline comments to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Mon, Mar 1, 5:19 PM · debug-info, Restricted Project
shchenz updated the diff for D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.

1: format fixing

Mon, Mar 1, 5:19 PM · debug-info, Restricted Project
rnk accepted D97668: [debuginfo-tests] Add some optnone tests.

This is probably more integration testing than I think optnone needs, but I don't see any reason to say no to it.

Mon, Mar 1, 1:38 PM · Restricted Project, debug-info
hubert.reinterpretcast added inline comments to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Mon, Mar 1, 10:33 AM · debug-info, Restricted Project
hubert.reinterpretcast added inline comments to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Mon, Mar 1, 10:03 AM · debug-info, Restricted Project
jasonliu added inline comments to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Mon, Mar 1, 9:46 AM · debug-info, Restricted Project
shchenz updated the diff for D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.

typo fix

Mon, Mar 1, 3:18 AM · debug-info, Restricted Project
Orlando requested review of D97668: [debuginfo-tests] Add some optnone tests.
Mon, Mar 1, 1:45 AM · Restricted Project, debug-info
shchenz updated the diff for D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.

1: handle neighbouring .loc

Mon, Mar 1, 1:26 AM · debug-info, Restricted Project

Sun, Feb 28

shchenz added a comment to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.

thanks for your review @hubert.reinterpretcast . See my inline reply.

Sun, Feb 28, 11:11 PM · debug-info, Restricted Project
shchenz updated the diff for D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.

address @hubert.reinterpretcast comments

Sun, Feb 28, 11:07 PM · debug-info, Restricted Project

Sat, Feb 27

shchenz closed D95998: [Debug-Info] [NFC] use emitDwarfUnitLength to handle debug line section unit length field.
Sat, Feb 27, 7:34 PM · debug-info, Restricted Project
hubert.reinterpretcast added inline comments to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Sat, Feb 27, 4:34 PM · debug-info, Restricted Project
hubert.reinterpretcast added inline comments to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Sat, Feb 27, 12:51 PM · debug-info, Restricted Project
hubert.reinterpretcast updated subscribers of D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Sat, Feb 27, 10:38 AM · debug-info, Restricted Project

Fri, Feb 26

djtodoro added a comment to D82547: [Debugify] Expose original debug info preservation check as CC1 option.

Ping :)

Fri, Feb 26, 1:09 PM · Restricted Project, Restricted Project, debug-info
djtodoro added a comment to D82546: [Debugify][OriginalDIMode] Export the report into JSON file.

Ping :)

Fri, Feb 26, 1:09 PM · Restricted Project, debug-info
aprantl added a comment to D97311: [DebugInfo] Introduce DIConstant metadata for representing named constants.

Here's an example that seems to work:

Fri, Feb 26, 10:31 AM · debug-info, Restricted Project
hubert.reinterpretcast added inline comments to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Fri, Feb 26, 9:37 AM · debug-info, Restricted Project
SouraVX added a comment to D97311: [DebugInfo] Introduce DIConstant metadata for representing named constants.

Have you considered instead introducing a bool isConstant field in DILocalVariable? This way we could reuse all the machinery for local/global variables and only need to switch out the TAG in AsmPrinter.

Fri, Feb 26, 8:04 AM · debug-info, Restricted Project
StephenTozer closed D95463: Avoid redundant or out-of-order debug value sinking in InstCombine.
Fri, Feb 26, 5:14 AM · Restricted Project, debug-info
shchenz added a comment to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.

gentle ping...@hubert.reinterpretcast

Fri, Feb 26, 1:21 AM · debug-info, Restricted Project
shchenz updated the diff for D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.

1: make sure what we end is the .text section

Fri, Feb 26, 1:21 AM · debug-info, Restricted Project

Thu, Feb 25

shchenz closed D96409: [debug-info] refactor emitDwarfUnitLength.
Thu, Feb 25, 6:01 PM · Restricted Project, debug-info
dblaikie added a comment to D97311: [DebugInfo] Introduce DIConstant metadata for representing named constants.

Guess it gets a bit complicated if it has to support non-local constants too.

We can already represent optimized out global variables with constant values as !DIGlobalVariableExpression(!DIGlobalVariable(...), !DIExpression(DW_OP_constu, ...)).
We would have to also add a bit to DIGlobalVariable, but other than that this seems perfectly feasible?

Thu, Feb 25, 3:14 PM · debug-info, Restricted Project
aprantl added a comment to D97242: Add more historic DWARF vendor extensions.

Please run tests before committing.

Thu, Feb 25, 3:11 PM · Restricted Project, debug-info
aprantl added a comment to D97311: [DebugInfo] Introduce DIConstant metadata for representing named constants.

Guess it gets a bit complicated if it has to support non-local constants too.

Thu, Feb 25, 3:08 PM · debug-info, Restricted Project
dblaikie added a comment to D97311: [DebugInfo] Introduce DIConstant metadata for representing named constants.

Have you considered instead introducing a bool isConstant field in DILocalVariable? This way we could reuse all the machinery for local/global variables and only need to switch out the TAG in AsmPrinter.

Thu, Feb 25, 2:59 PM · debug-info, Restricted Project
aprantl added a comment to D97311: [DebugInfo] Introduce DIConstant metadata for representing named constants.

Have you considered instead introducing a bool isConstant field in DILocalVariable? This way we could reuse all the machinery for local/global variables and only need to switch out the TAG in AsmPrinter.

Thu, Feb 25, 2:53 PM · debug-info, Restricted Project

Wed, Feb 24

jmorse accepted D95463: Avoid redundant or out-of-order debug value sinking in InstCombine.

LGTM, but pls2leave it 24 hours or so in case @rnk chimes in.

Wed, Feb 24, 9:52 AM · Restricted Project, debug-info
StephenTozer added inline comments to D95463: Avoid redundant or out-of-order debug value sinking in InstCombine.
Wed, Feb 24, 9:35 AM · Restricted Project, debug-info
Orlando closed D96494: [dexter] Force dexter tests to use the host triple.
Wed, Feb 24, 3:17 AM · Restricted Project, debug-info
Orlando updated the diff for D96494: [dexter] Force dexter tests to use the host triple.

Rebase.

Wed, Feb 24, 3:12 AM · Restricted Project, debug-info
Orlando updated the diff for D96494: [dexter] Force dexter tests to use the host triple.

Thanks @rnk! I will land this shortly.

Wed, Feb 24, 3:02 AM · Restricted Project, debug-info
SouraVX added a reviewer for D97311: [DebugInfo] Introduce DIConstant metadata for representing named constants: cchen15.
Wed, Feb 24, 2:25 AM · debug-info, Restricted Project
SouraVX retitled D97311: [DebugInfo] Introduce DIConstant metadata for representing named constants from [WIP][DebugInfo] Introduce DIConstant metadata for representing named constants to [DebugInfo] Introduce DIConstant metadata for representing named constants.
Wed, Feb 24, 12:50 AM · debug-info, Restricted Project
SouraVX updated the diff for D97311: [DebugInfo] Introduce DIConstant metadata for representing named constants.

Resolved the previous mentioned issue. Ready for review.

Wed, Feb 24, 12:48 AM · debug-info, Restricted Project
djtodoro updated the diff for D82547: [Debugify] Expose original debug info preservation check as CC1 option.
  • Rebase on top of trunk
Wed, Feb 24, 12:37 AM · Restricted Project, Restricted Project, debug-info
djtodoro updated the diff for D82546: [Debugify][OriginalDIMode] Export the report into JSON file.
  • Rebase on top of trunk
Wed, Feb 24, 12:25 AM · Restricted Project, debug-info

Tue, Feb 23

thakis added a comment to D97242: Add more historic DWARF vendor extensions.

Also fails locally for me in a normal cmake build. Reverted for now in f14a14dd2564703db02f80c00db8ae492b594f77.

Tue, Feb 23, 7:10 PM · Restricted Project, debug-info
thakis added a reverting change for D97242: Add more historic DWARF vendor extensions: rGf14a14dd2564: Revert "Add more historic DWARF vendor extensions".
Tue, Feb 23, 7:10 PM · Restricted Project, debug-info
thakis added a comment to D97242: Add more historic DWARF vendor extensions.

(breaks check-llvm more on windows: http://45.33.8.238/win/33808/step_11.txt)

Tue, Feb 23, 6:33 PM · Restricted Project, debug-info
thakis added a comment to D97242: Add more historic DWARF vendor extensions.

This breaks check-llvm: http://45.33.8.238/linux/40166/step_12.txt

Tue, Feb 23, 6:32 PM · Restricted Project, debug-info
shchenz added a comment to D95932: [Debug-Info] [NFC] move emitDwarfUnitLength to MCStreamer class.

@ikudrin Hi, I start to commit these NFC changes as now all of them are approved. Welcome your post-commit comment if there is any. Thank you again for your review!

Tue, Feb 23, 6:31 PM · debug-info, Restricted Project
shchenz closed D95932: [Debug-Info] [NFC] move emitDwarfUnitLength to MCStreamer class.
Tue, Feb 23, 6:29 PM · debug-info, Restricted Project
aprantl closed D97242: Add more historic DWARF vendor extensions.
Tue, Feb 23, 5:54 PM · Restricted Project, debug-info
SouraVX added inline comments to D97311: [DebugInfo] Introduce DIConstant metadata for representing named constants.
Tue, Feb 23, 11:46 AM · debug-info, Restricted Project
SouraVX added a project to D97311: [DebugInfo] Introduce DIConstant metadata for representing named constants: debug-info.
Tue, Feb 23, 11:38 AM · debug-info, Restricted Project
rnk accepted D96494: [dexter] Force dexter tests to use the host triple.

lgtm

Tue, Feb 23, 10:44 AM · Restricted Project, debug-info
probinson accepted D97242: Add more historic DWARF vendor extensions.

A few typos. Nice to have these!

Tue, Feb 23, 8:28 AM · Restricted Project, debug-info

Mon, Feb 22

echristo accepted D97242: Add more historic DWARF vendor extensions.

LGTM. Thanks!

Mon, Feb 22, 7:35 PM · Restricted Project, debug-info
shchenz updated the diff for D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.

1: update due to change in D96409 and D95998

Mon, Feb 22, 7:19 PM · debug-info, Restricted Project
shchenz added inline comments to D95998: [Debug-Info] [NFC] use emitDwarfUnitLength to handle debug line section unit length field.
Mon, Feb 22, 7:17 PM · debug-info, Restricted Project
shchenz updated the diff for D95998: [Debug-Info] [NFC] use emitDwarfUnitLength to handle debug line section unit length field.

1: use more meaningful variable name.

Mon, Feb 22, 7:17 PM · debug-info, Restricted Project
shchenz updated the diff for D96409: [debug-info] refactor emitDwarfUnitLength.

1: put "_" in the function body to avoid strange string parameters

Mon, Feb 22, 7:15 PM · Restricted Project, debug-info
aprantl requested review of D97242: Add more historic DWARF vendor extensions.
Mon, Feb 22, 5:25 PM · Restricted Project, debug-info
dblaikie added inline comments to D95998: [Debug-Info] [NFC] use emitDwarfUnitLength to handle debug line section unit length field.
Mon, Feb 22, 11:53 AM · debug-info, Restricted Project
shchenz added inline comments to D96409: [debug-info] refactor emitDwarfUnitLength.
Mon, Feb 22, 5:38 AM · Restricted Project, debug-info
ikudrin added inline comments to D96409: [debug-info] refactor emitDwarfUnitLength.
Mon, Feb 22, 5:07 AM · Restricted Project, debug-info
shchenz added inline comments to D96409: [debug-info] refactor emitDwarfUnitLength.
Mon, Feb 22, 4:18 AM · Restricted Project, debug-info