Page MenuHomePhabricator
Feed All Stories

Today

jhuber6 added inline comments to D117806: [OpenMP] Change default visibility to protected for device declarations.
Thu, Jan 20, 4:02 PM · Restricted Project
jhuber6 updated the diff for D117806: [OpenMP] Change default visibility to protected for device declarations.

Forgot to make this mutually exclusive with user defined visibility value.

Thu, Jan 20, 4:01 PM · Restricted Project
fwolff committed rGd3b188a2d72f: [clang-tidy] Include constructor initializers in `bugprone-exception-escape`… (authored by fwolff).
[clang-tidy] Include constructor initializers in `bugprone-exception-escape`…
Thu, Jan 20, 4:01 PM
fwolff closed D113507: [clang-tidy] Include constructor initializers in `bugprone-exception-escape` check.
Thu, Jan 20, 4:00 PM · Restricted Project
ldionne added a comment to D117582: [libc++] Use reserved identifier for template parameter.

Awesome! I guess this indicates that our buildkite CI never runs tests with _LIBCPP_ABI_OPTIMIZED_LOCALE_NUM_GET defined, is that right? :(

Thu, Jan 20, 4:00 PM · Restricted Project
ldionne edited reviewers for D117512: [libc++][ranges] Add ranges::in_in_out_result, added: var-const; removed: ldionne.
Thu, Jan 20, 3:58 PM · Restricted Project
ldionne added a comment to D117332: [libc++] Make sure basic_string::reserve never shrinks in all standard modes.

Everything here makes sense except the decision to make s.reserve() nonequivalent to s.shrink_to_fit(). I don't see any ABI issue with that, so that part of the patch is orthogonal to the rest — and it seems to be altering behavior that is both useful and cppreference-documented. I suggest doing everything else you're doing, but not that specific one-line diff, because I don't see its upside.

Thu, Jan 20, 3:57 PM · Restricted Project
JonChesterfield added inline comments to D117806: [OpenMP] Change default visibility to protected for device declarations.
Thu, Jan 20, 3:56 PM · Restricted Project
cfang requested review of D117845: [AMDGPU][NFC] Update to AMDGPUUsage for default Code Object Version.
Thu, Jan 20, 3:56 PM · Restricted Project
rampitec requested review of D117844: [AMDGPU] Prevent aliasing of SrcC and Dst in MAI.
Thu, Jan 20, 3:54 PM · Restricted Project
aartbik accepted D117260: Upstream MLIR PyTACO implementation..

Well done Bixia!

Thu, Jan 20, 3:54 PM · Restricted Project
majnemer added a comment to D117569: Constexpr not supported with __declspec(dllimport)..

Your example is different from mine as it nests the constexpr variable inside the function rather than having it at translation-unit scope.

Thu, Jan 20, 3:54 PM · Restricted Project
gkistanova committed rZORG548e2995baa3: Added thinlto-x86-64-bot2 worker; fixed emain notifier for clang-with-thin-lto… (authored by gkistanova).
Added thinlto-x86-64-bot2 worker; fixed emain notifier for clang-with-thin-lto…
Thu, Jan 20, 3:52 PM
airlied committed rGe1b7bd911d9e: [OpenCL] opencl-c.h: add __opencl_c_images and __opencl_c_read_write_images (authored by airlied).
[OpenCL] opencl-c.h: add __opencl_c_images and __opencl_c_read_write_images
Thu, Jan 20, 3:51 PM
airlied closed D107539: [OpenCL] opencl-c.h: add __opencl_c_images and __opencl_c_read_write_images.
Thu, Jan 20, 3:51 PM · Restricted Project
chfast updated the diff for D117680: [InstCombine] Simplify bswap -> shift.

Trigger rebuild.

Thu, Jan 20, 3:47 PM · Restricted Project
mehdi_amini accepted D117260: Upstream MLIR PyTACO implementation..
Thu, Jan 20, 3:43 PM · Restricted Project
klausler requested review of D117843: [flang] Extension: skip over NAMELIST groups.
Thu, Jan 20, 3:40 PM · Restricted Project
klausler committed rG9ddd07922f65: [flang] Handle FLUSH(unknown unit) (authored by klausler).
[flang] Handle FLUSH(unknown unit)
Thu, Jan 20, 3:38 PM
klausler closed D117819: [flang] Handle FLUSH(unknown unit).
Thu, Jan 20, 3:38 PM · Restricted Project, Restricted Project
bixia requested review of D117842: [mlir][sparse] Add createMLIRSparseTensor to the supporting C library..
Thu, Jan 20, 3:38 PM · Restricted Project
tyb0807 added inline comments to D117753: [AArch64] Support for memset tagged intrinsic.
Thu, Jan 20, 3:35 PM · Restricted Project, Restricted Project
tyb0807 added inline comments to D117764: [AArch64][SelectionDAG] CodeGen for Armv8.8/9.3 MOPS.
Thu, Jan 20, 3:35 PM · Restricted Project
klausler committed rG5501c16edf0f: [flang] Fix OPEN/WRITE(SIGN='SUPPRESS') (authored by klausler).
[flang] Fix OPEN/WRITE(SIGN='SUPPRESS')
Thu, Jan 20, 3:35 PM
klausler closed D117816: [flang] Fix OPEN/WRITE(SIGN='SUPPRESS').
Thu, Jan 20, 3:34 PM · Restricted Project, Restricted Project
mehdi_amini accepted D117839: [mlir] Move the Buffer related source files out of Transforms/.

It's great that we have now the bufferization dialect to host these, right? :)

Thu, Jan 20, 3:33 PM · Restricted Project
sivachandra committed rGd92e5412ea57: [libc] Use __builtin_clz to find leading 1 in hypot (authored by cratonica).
[libc] Use __builtin_clz to find leading 1 in hypot
Thu, Jan 20, 3:33 PM
sivachandra closed D117684: [libc] Use __builtin_clz to find leading 1 in hypot.
Thu, Jan 20, 3:33 PM · Restricted Project
leonardchan added a comment to D117537: [cmake] Duplicate `{llvm,compiler_rt}_check_linker_flag` for runtime libs and llvm.

Hi, I suspect that this patch (or D117815) led to the build failure we're seeing on our builders (https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8824480583333895809):

Thu, Jan 20, 3:31 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
mehdi_amini accepted D117841: [mlir:Transforms] Move NormalizeMemRefs to MemRef/Transforms/.

Makes sense, thanks!

Thu, Jan 20, 3:31 PM · Restricted Project
lamb-j added a comment to D117801: [AMDGPU] Move const qualifier placement in AsmParser.

If I'm understanding correctly, moving const to the left of "MCSymbol *"' declares the object as const instead of the pointer. In this case, we get a compilation error on the following line:

Thu, Jan 20, 3:28 PM · Restricted Project
jloser added inline comments to D117714: [libc++] Implement LWG3549: view_interface need not inherit from view_base.
Thu, Jan 20, 3:24 PM · Restricted Project
dschuff added inline comments to D117747: llvm-readobj: support globals in initializer expressions.
Thu, Jan 20, 3:24 PM · Restricted Project
sbc100 committed rGac2f3df8396a: [lld][WebAssembly] Remove redundant config setting (authored by sbc100).
[lld][WebAssembly] Remove redundant config setting
Thu, Jan 20, 3:22 PM
sbc100 closed D117737: [lld][WebAssembly] Remove redundant config setting.
Thu, Jan 20, 3:22 PM · Restricted Project
chfast committed rG8457b61699e8: [test] Add tests for bswap combining. NFC (authored by chfast).
[test] Add tests for bswap combining. NFC
Thu, Jan 20, 3:21 PM
jloser updated the diff for D117714: [libc++] Implement LWG3549: view_interface need not inherit from view_base.

enable_view<void> test

Thu, Jan 20, 3:20 PM · Restricted Project
jloser updated the diff for D117714: [libc++] Implement LWG3549: view_interface need not inherit from view_base.

Remove const and const ref tests for enable_view. The standard expects cv-unqual types.

Thu, Jan 20, 3:19 PM · Restricted Project
rriddle added a reviewer for D117841: [mlir:Transforms] Move NormalizeMemRefs to MemRef/Transforms/: mehdi_amini.
Thu, Jan 20, 3:17 PM · Restricted Project
kaz7 accepted D117683: [VE][NFC] Factor out helper functions.

LGTM.

Thu, Jan 20, 3:17 PM · Restricted Project, Restricted Project
rriddle requested review of D117841: [mlir:Transforms] Move NormalizeMemRefs to MemRef/Transforms/.
Thu, Jan 20, 3:16 PM · Restricted Project
rriddle updated the diff for D117839: [mlir] Move the Buffer related source files out of Transforms/.
Thu, Jan 20, 3:16 PM · Restricted Project
zahiraam added a comment to D117569: Constexpr not supported with __declspec(dllimport)..

I have a question regarding how this work with respect to the dllimport semantics known by the linker.
IIUC, we will now allow a program like:

extern int __declspec(dllimport) dll_import_int;
constexpr int& dll_import_constexpr_ref = dll_import_int;
int& get() {
    return dll_import_constexpr_ref;
}

Here, get will load dll_import_constexpr_ref. However, what will dll_import_constexpr_ref hold? It ought to hold the contents of __imp_?dll_import_int@@3HA. However, we can't dereference __imp_?dll_import_int@@3HA to get to its contents.

@majnemer Thanks for the review.

This test case doesn't link with MSVC. It will generate this error:
Microsoft (R) Incremental Linker Version 14.29.30133.0
Copyright (C) Microsoft Corporation. All rights reserved.

/out:test1.exe
test1.obj
test1.obj : error LNK2001: unresolved external symbol "int dll_import_int" (?dll_import_int@@3HA)
test1.exe : fatal error LNK1120: 1 unresolved externals

The symbols generated with MSVC are:
07 00000000 UNDEF notype External | ?dll_import_int@@3HA (int dll_import_int)
015 00000000 SECT6 notype Static | ?dll_import_constexpr_ref@@3AEAHEA (int & dll_import_constexpr_ref)

Without this patch this test case errors. With this patch clang will generate these symbols:

010 00000000 UNDEF notype External | imp_?dll_import_int@@3HA (declspec(dllimport) int dll_import_int)
012 00000000 SECT5 notype External | ?dll_import_constexpr_ref@@3AEAHEA (int & dll_import_constexpr_ref)
013 00000000 UNDEF notype External | ?dll_import_int@@3HA (int dll_import_int)

and will error at link time with this error:
test1-f1f63b.o : error LNK2019: unresolved external symbol "declspec(dllimport) int dll_import_int" (imp_?dll_import_int@@3HA) referenced in function "int & __cdecl get(void)" (?get@@YAAEAHXZ)
test1-f1f63b.o : error LNK2001: unresolved external symbol "int dll_import_int" (?dll_import_int@@3HA)
a.exe : fatal error LNK1120: 2 unresolved externals

I think that's the behavior expected, right?

My interpretation is that MSVC has a bug: it is forming a reference to ?dll_import_int@@3HA and not __imp_?dll_import_int@@3HA. Could you run a more complete experiment where you have a dll which exports the symbol and you try to import it?

Thu, Jan 20, 3:13 PM · Restricted Project
dschuff accepted D117737: [lld][WebAssembly] Remove redundant config setting.
Thu, Jan 20, 3:12 PM · Restricted Project
bnbarham added a comment to D117730: [DNM][VFS] Do not overwrite the path when nesting RedirectingFileSystems.

Also have bug up at https://github.com/llvm/llvm-project/issues/53306.

Thu, Jan 20, 3:10 PM · Restricted Project, Restricted Project
bnbarham added a comment to D113832: reland: [VFS] Use original path when falling back to external FS.

@keith This patch causes some issues when nesting/chaining RedirectingFileSystems. I have a few tests in https://reviews.llvm.org/D117730 for more details.

Thu, Jan 20, 3:10 PM · Restricted Project, Restricted Project
CJ-Johnson committed rGa5684114445a: [clang-tidy] Update bugprone-stringview-nullptr to consistently prefer the… (authored by CJ-Johnson).
[clang-tidy] Update bugprone-stringview-nullptr to consistently prefer the…
Thu, Jan 20, 3:09 PM
CJ-Johnson closed D117840: [clang-tidy] Update bugprone-stringview-nullptr to consistently prefer the empty string when passing arguments to constructors/functions.
Thu, Jan 20, 3:08 PM · Restricted Project
CJ-Johnson requested review of D117840: [clang-tidy] Update bugprone-stringview-nullptr to consistently prefer the empty string when passing arguments to constructors/functions.
Thu, Jan 20, 3:07 PM · Restricted Project
craig.topper committed rG5e88f527da21: [RISCV] Remove RISCVSubtarget::hasStdExtV() and hasStdExtZve*(). NFC (authored by craig.topper).
[RISCV] Remove RISCVSubtarget::hasStdExtV() and hasStdExtZve*(). NFC
Thu, Jan 20, 3:05 PM
sivachandra committed rG284cd693f1c6: [libc] Move the remaining public types to their own type headers. (authored by sivachandra).
[libc] Move the remaining public types to their own type headers.
Thu, Jan 20, 3:05 PM
sivachandra closed D117838: [libc] Move the remaining public types to their own type headers..
Thu, Jan 20, 3:04 PM · Restricted Project
philnik updated the diff for D117817: [libc++][ranges] Implement ranges::mismatch.
  • Address comments and fix CI
Thu, Jan 20, 2:56 PM · Restricted Project
stellaraccident accepted D117839: [mlir] Move the Buffer related source files out of Transforms/.

Thank you for fixing this layering and severing the cross dependency.

Thu, Jan 20, 2:52 PM · Restricted Project
lebedev.ri updated the summary of D117805: [SimplifyCFG] Merge compatible `invoke`s of a `landingpad`.
Thu, Jan 20, 2:52 PM · Restricted Project
sivachandra added inline comments to D117838: [libc] Move the remaining public types to their own type headers..
Thu, Jan 20, 2:48 PM · Restricted Project
craig.topper committed rGfa8bb224661d: [RISCV] Optimize vector_shuffles that are interleaving the lowest elements of… (authored by craig.topper).
[RISCV] Optimize vector_shuffles that are interleaving the lowest elements of…
Thu, Jan 20, 2:47 PM
craig.topper closed D117743: [RISCV] Optimize vector_shuffles that are interleaving the lowest elements of two vectors..
Thu, Jan 20, 2:47 PM · Restricted Project
var-const added a comment to D117817: [libc++][ranges] Implement ranges::mismatch.

Drive-by comment: can you also update Status/RangesPaper.csv and Status/RangesAlgorithms.csv?

Thu, Jan 20, 2:46 PM · Restricted Project
JDevlieghere accepted D117837: [lldb] Fix timer logging inverted quiet condition.

LGTM

Thu, Jan 20, 2:45 PM · Restricted Project
rsuderman committed rGcd2d7369639e: [mlir][tosa] Limit right-shift to 31 bits (authored by rsuderman).
[mlir][tosa] Limit right-shift to 31 bits
Thu, Jan 20, 2:42 PM
rsuderman closed D117732: [mlir][tosa] Limit right-shift to 31 bits.
Thu, Jan 20, 2:42 PM · Restricted Project
owenpan committed rGc95afac89e00: [clang-format][NFC] Clean up tryMergeLessLess() (authored by owenpan).
[clang-format][NFC] Clean up tryMergeLessLess()
Thu, Jan 20, 2:36 PM
owenpan closed D117759: [clang-format][NFC] Clean up tryMergeLessLess().
Thu, Jan 20, 2:36 PM · Restricted Project, Restricted Project
rriddle added reviewers for D117839: [mlir] Move the Buffer related source files out of Transforms/: mehdi_amini, stellaraccident.
Thu, Jan 20, 2:35 PM · Restricted Project
Quuxplusone requested changes to D117714: [libc++] Implement LWG3549: view_interface need not inherit from view_base.
Thu, Jan 20, 2:34 PM · Restricted Project
rriddle requested review of D117839: [mlir] Move the Buffer related source files out of Transforms/.
Thu, Jan 20, 2:34 PM · Restricted Project
spatel accepted D117680: [InstCombine] Simplify bswap -> shift.

@spatel, can you also review this?

Thu, Jan 20, 2:33 PM · Restricted Project
omjavaid added a comment to D117676: [LLDB] Port toolchain-msvc.test for Arm/AArch4 Windows.

FWIW, I consider the build.py script a failed experiment. The idea itself was not completely bad, but the lack of buy-in from sufficient amount of developers meant that it never really had a chance of fulfilling its (rather lofty) goals.

I think it should be removed or at least scaled back significantly. The only thing it's really used for these days is to invoke msvc and clang-cl, and I'm sure we can achieve the same thing with some lit substitutions as well...

Thu, Jan 20, 2:32 PM
michaelrj accepted D117838: [libc] Move the remaining public types to their own type headers..

LGTM with a minor nit

Thu, Jan 20, 2:32 PM · Restricted Project
sivachandra requested review of D117838: [libc] Move the remaining public types to their own type headers..
Thu, Jan 20, 2:28 PM · Restricted Project
Ericson2314 updated the summary of D101070: Make `llvm_install_symlink` robust with respect to absolute dirs..
Thu, Jan 20, 2:25 PM · Restricted Project, Restricted Project, Restricted Project
craig.topper updated the diff for D117743: [RISCV] Optimize vector_shuffles that are interleaving the lowest elements of two vectors..

Rebase. Fix comment.

Thu, Jan 20, 2:25 PM · Restricted Project
Quuxplusone added inline comments to D117832: Update the Bug Life Cycle docs for the switch to GitHub issues.
Thu, Jan 20, 2:25 PM · Restricted Project
chfast updated the summary of D117680: [InstCombine] Simplify bswap -> shift.
Thu, Jan 20, 2:23 PM · Restricted Project
lebedev.ri removed a reviewer for D115174: [mlir] Set up boilerplate build for MLIR benchmarks: lebedev.ri.
Thu, Jan 20, 2:21 PM · Restricted Project
Ericson2314 updated the diff for D101070: Make `llvm_install_symlink` robust with respect to absolute dirs..

Much simpler now

Thu, Jan 20, 2:21 PM · Restricted Project, Restricted Project, Restricted Project
craig.topper added a comment to D117680: [InstCombine] Simplify bswap -> shift.

I think the commit message needs to be modified after the improved change. It's now longer low/high active bits.

Thu, Jan 20, 2:21 PM · Restricted Project
njames93 committed rG39f779afb354: [clang-tidy][NFC] Remove redundant string creation for comparison (authored by njames93).
[clang-tidy][NFC] Remove redundant string creation for comparison
Thu, Jan 20, 2:20 PM
lebedev.ri accepted D117680: [InstCombine] Simplify bswap -> shift.

https://alive2.llvm.org/ce/z/nvbbU5
https://alive2.llvm.org/ce/z/KiiL3J

Thu, Jan 20, 2:20 PM · Restricted Project
kastiglione requested review of D117837: [lldb] Fix timer logging inverted quiet condition.
Thu, Jan 20, 2:20 PM · Restricted Project
lebedev.ri updated the summary of D117680: [InstCombine] Simplify bswap -> shift.
Thu, Jan 20, 2:20 PM · Restricted Project
mstorsjo added a comment to D117820: Revert "[libc++] [test] UNSUPPORTED my new uniform_int_distribution test on MinGW.".

I had a look, and it seems to run correctly when built with a recent Clang 14 snapshot. But with Clang 13.0.0 as in the CI, it crashes.

Thu, Jan 20, 2:17 PM · Restricted Project
craig.topper accepted D117794: [ISEL] Canonicalise constant splats to RHS..

LGTM

Thu, Jan 20, 2:15 PM · Restricted Project
yota9 updated the diff for D117612: [BOLT] Update dynamic relocations from section relocations.
Thu, Jan 20, 2:14 PM · Restricted Project
Quuxplusone added inline comments to D117832: Update the Bug Life Cycle docs for the switch to GitHub issues.
Thu, Jan 20, 2:13 PM · Restricted Project
Meinersbur committed rG1d4ca42b4380: [OpenMPIRBuilder] Detect ambiguous InsertPoints for apply*WorkshareLoop. NFC. (authored by Meinersbur).
[OpenMPIRBuilder] Detect ambiguous InsertPoints for apply*WorkshareLoop. NFC.
Thu, Jan 20, 2:11 PM
SaurabhJha updated the diff for D115174: [mlir] Set up boilerplate build for MLIR benchmarks.

Remove references to BenchmarkRunConfig from README

Thu, Jan 20, 2:11 PM · Restricted Project
Quuxplusone added a comment to D117832: Update the Bug Life Cycle docs for the switch to GitHub issues.

I've suggested several rewordings, or additional wordings; please take whatever seems good to you. I don't want to block this, regardless.

  • Please use [good first issue] instead of [beginner].
  • It is probably a good idea to list the four "resolution/disposition" labels explicitly somewhere as a foursome: [duplicate], [invalid], [wontfix], [worksforme]. Btw, do we think [obsolete] is also a resolution/disposition? I don't know what its intent was, but I think it's plausibly a sort of compromise between [invalid] and [wontfix], right? If that's our intent, then we should color-code [obsolete] as a resolution (color #cccccc) and mention it in the same breath with the other four.
Thu, Jan 20, 2:10 PM · Restricted Project
reames committed rGc0906f6b21a1: [SLP] Remove stray semicolon to make bots happy (authored by reames).
[SLP] Remove stray semicolon to make bots happy
Thu, Jan 20, 2:09 PM
jhuber6 updated the diff for D117807: [Libomptarget] Change visibility to hidden for device RTL.

Updating visibility and for old runtime.

Thu, Jan 20, 2:08 PM · Restricted Project
Kai updated the diff for D117823: [SystemZ] Properly register machine passes..

Fix formatting in SystemZ.h header file.

Thu, Jan 20, 2:07 PM · Restricted Project
chfast added a comment to D117680: [InstCombine] Simplify bswap -> shift.

@spatel, can you also review this?

Thu, Jan 20, 2:07 PM · Restricted Project
rampitec committed rG41ebd1968165: [AMDGPU] Do not ignore exec use where exec is read as data (authored by rampitec).
[AMDGPU] Do not ignore exec use where exec is read as data
Thu, Jan 20, 2:06 PM
rampitec closed D117814: [AMDGPU] Do not ignore exec use where exec is read as data.
Thu, Jan 20, 2:05 PM · Restricted Project
yota9 updated the diff for D117612: [BOLT] Update dynamic relocations from section relocations.

Replace isJmpRel() with IsJmpRel flag in relocation struct. Since some of the linkers are inconsistent (e.g. the LD places R_AARCH64_TLSDESC in .rela.plt and lld places it in .rela.dyn) the flag usage looks like more robust solution, then on-type decisions.

Thu, Jan 20, 2:05 PM · Restricted Project
SaurabhJha updated the diff for D115174: [mlir] Set up boilerplate build for MLIR benchmarks.

llvm-lit is also a python program, how is it setup?
The rm looks a bit hacky to me, I rather not touch the source directory at all.

Yep, got a solution for it! The problem was mbr seeked to be both a library and a CLI runner. As a library, it used to provide BenchmarkRunConfig so that benchmarks
could import them and return them like this.

Thu, Jan 20, 2:05 PM · Restricted Project
chfast removed reviewers for D117680: [InstCombine] Simplify bswap -> shift: xbolva00, reames, lebedev.ri.
Thu, Jan 20, 2:05 PM · Restricted Project
aaron.ballman added a comment to D117832: Update the Bug Life Cycle docs for the switch to GitHub issues.

A few things to note: we have not yet created the confirmed label, but that is expected to be done shortly. There is already label confusion involving whether we should use beginner (89 issues) or good first issue (29 issues), so I went with beginner in the documentation. I think we should strongly discourage users from creating arbitrary labels on their own because the labels will become useless pretty quickly if there's no consistency as to which are used, so I adjusted the docs accordingly

'good first issue' is a default label provided by GitHub, so it seems like it would be good to use it for consistency with other projects. Is the beginner label something that was created during the github transition?

Thu, Jan 20, 2:04 PM · Restricted Project
Meinersbur requested review of D117835: [OpenMPIRBuilder] Detect and fix ambiguous InsertPoints for createSections..
Thu, Jan 20, 1:59 PM · Restricted Project, Restricted Project