Page MenuHomePhabricator
Feed All Stories

Today

aartbik added a comment to D94852: [mlir][sparse] improved sparse runtime support library.

"extended" FROSTT proposal tracked in https://github.com/frostt-tensor/frostt-tensor.github.io/issues/14

Sat, Jan 16, 7:41 PM · Restricted Project
stellaraccident added a comment to D94387: Add new LLVMComponents CMake module..

Also added file sizes for binaries and libraries in unbundled mode to the above gist.

Sat, Jan 16, 7:18 PM · Restricted Project
critson updated the diff for D94746: [AMDGPU] Move kill lowering to WQM pass and add live mask tracking.

Remove VCC def flags from SI_KILL_I1 and add test.
This bug existed prior to this patch, but was not causing any issues as control flow lowering does not track liveness.
However it matters for WQM lowering of kills as it can lead to stray definitions of VCC.

Sat, Jan 16, 7:11 PM · Restricted Project
stellaraccident abandoned D94000: DRAFT: Teach components to link into shared libs..
Sat, Jan 16, 7:05 PM · Restricted Project
stellaraccident added inline comments to D94000: DRAFT: Teach components to link into shared libs..
Sat, Jan 16, 7:04 PM · Restricted Project
stellaraccident added a reviewer for D94387: Add new LLVMComponents CMake module.: serge-sans-paille.
Sat, Jan 16, 7:02 PM · Restricted Project
stellaraccident added a comment to D94387: Add new LLVMComponents CMake module..

Hi serge-sans-paille, thank you for the comments! They caught me mid-cleanup so, I decided to push a revision with the further minimal changes needed to get the build mostly functional with this facility, as I think it might provide some better context. Now that I've got the tree in a non-hacky building mode and just have a handful of failing tests (around llvm-config mostly), I'll work through your comments a bit.

Sat, Jan 16, 7:01 PM · Restricted Project
tianshilei1992 requested review of D94871: [Clang][OpenMP] Fixed an issue that clang crashed when compiling OpenMP program in device only mode without host IR.
Sat, Jan 16, 7:00 PM · Restricted Project
stellaraccident updated the diff for D94387: Add new LLVMComponents CMake module..

Include minimal changes to the tree to build/test.

Sat, Jan 16, 6:42 PM · Restricted Project
tianshilei1992 updated the diff for D94745: [OpenMP][WIP] Build the deviceRTLs with OpenMP instead of target dependent language.

Continue to add some forward declarations

Sat, Jan 16, 6:38 PM · Restricted Project
tianshilei1992 updated the diff for D94745: [OpenMP][WIP] Build the deviceRTLs with OpenMP instead of target dependent language.

Rebased and fixed some issues

Sat, Jan 16, 6:12 PM · Restricted Project
HsiangKai updated the diff for D94863: [RISCV] Implement vssseg intrinsics..

Rebase.

Sat, Jan 16, 6:09 PM · Restricted Project
HsiangKai updated the diff for D94763: [RISCV] Implement vlsseg intrinsics..

Rebase.

Sat, Jan 16, 6:08 PM · Restricted Project
HsiangKai updated the diff for D94688: [RISCV] Implement vsseg intrinsics..

Rebase.

Sat, Jan 16, 6:08 PM · Restricted Project
LuoYuanke added inline comments to D94155: [X86] Fix tile config register spill issue..
Sat, Jan 16, 6:05 PM · Restricted Project
HsiangKai updated the diff for D94229: [RISCV] Implement vlseg intrinsics..

Rebase.

Sat, Jan 16, 6:02 PM · Restricted Project
LuoYuanke updated the diff for D94155: [X86] Fix tile config register spill issue..

Address Xiang's comments.

Sat, Jan 16, 6:02 PM · Restricted Project
xiangzhangllvm added inline comments to D94155: [X86] Fix tile config register spill issue..
Sat, Jan 16, 5:44 PM · Restricted Project
MaskRay committed rGa048ce13e32d: [X86] Default to -x86-pad-for-align=false to drop assembler difference with or… (authored by MaskRay).
[X86] Default to -x86-pad-for-align=false to drop assembler difference with or…
Sat, Jan 16, 4:40 PM
MaskRay closed D94542: [X86] Default to -x86-pad-for-align=false to drop assembler difference with or w/o -g.
Sat, Jan 16, 4:40 PM · Restricted Project
tianshilei1992 planned changes to D81989: [OpenMP] Introduce low level dependency process to target offloading.
Sat, Jan 16, 2:55 PM · Restricted Project
varungandhi-apple added a comment to D94854: [Clang] Fix SwiftCallingConv's aggregate lowering for _Atomic(_Bool)..

The way you'd test it on the Clang side would be to just write a test case that passes such an aggregate and tests that it's passed as an i8.

Sat, Jan 16, 2:28 PM · Restricted Project
nikic committed rG5238e7b302ff: [InstCombine] Replace one-use select operand based on condition (authored by nikic).
[InstCombine] Replace one-use select operand based on condition
Sat, Jan 16, 2:25 PM
nikic closed D94862: [InstCombine] Replace one-use select operand based on condition.
Sat, Jan 16, 2:25 PM · Restricted Project
lebedev.ri committed rG32fc32317a31: [SimplifyCFG] markAliveBlocks(): catchswitch: preserve PostDomTree (authored by lebedev.ri).
[SimplifyCFG] markAliveBlocks(): catchswitch: preserve PostDomTree
Sat, Jan 16, 2:21 PM
dmgreen committed rG145472421535: [ARM] Align blocks that are not fallthough targets (authored by dmgreen).
[ARM] Align blocks that are not fallthough targets
Sat, Jan 16, 2:20 PM
dmgreen committed rG2a5b576e3ea4: [ARM] Test for aligned blocks. NFC (authored by dmgreen).
[ARM] Test for aligned blocks. NFC
Sat, Jan 16, 2:20 PM
dmgreen closed D94394: [ARM] Align blocks that are not fallthough targets.
Sat, Jan 16, 2:20 PM · Restricted Project
xbolva00 committed rGbfd75bdf3fd6: [NFC] Removed extra text in comments (authored by xbolva00).
[NFC] Removed extra text in comments
Sat, Jan 16, 1:49 PM
aqjune accepted D94862: [InstCombine] Replace one-use select operand based on condition.

LGTM

Sat, Jan 16, 1:40 PM · Restricted Project
njames93 requested changes to D94131: [clang-tidy] Use new mapAnyOf matcher.

Can you either update the description of this patch to include the binaryOperation changes, or remove those changes from here.

Sat, Jan 16, 1:27 PM · Restricted Project
mehdi_amini added inline comments to D94868: [mlir] Enable passing crash reproducer stream factory method.
Sat, Jan 16, 1:04 PM · Restricted Project
thopre closed D94842: Extend mandatory Flake8 cleanness.
Sat, Jan 16, 12:24 PM
thopre closed D94837: Fix use of undefined session variable.
Sat, Jan 16, 12:23 PM
aartbik committed rGd8fc27301d18: [mlir][sparse] improved sparse runtime support library (authored by aartbik).
[mlir][sparse] improved sparse runtime support library
Sat, Jan 16, 12:16 PM
aartbik closed D94852: [mlir][sparse] improved sparse runtime support library.
Sat, Jan 16, 12:16 PM · Restricted Project
aemerson accepted D94350: [GlobalISel] Combine (a[0]) | (a[1] << k1) | ...| (a[m] << kn) into a wide load.

LGTM.

Sat, Jan 16, 11:59 AM · Restricted Project
Paul-C-Anagnostopoulos updated the diff for D94822: [TableGen] Improve algorithm for inheriting class template arguments and fields.

I incorporated the various suggestions.

Sat, Jan 16, 11:23 AM · Restricted Project
tnfchris accepted D94837: Fix use of undefined session variable.

Aha thanks for the explanation

Sat, Jan 16, 11:20 AM
tianshilei1992 committed rGed939f853da1: [OpenMP] Added the support for hidden helper task in RTL (authored by tianshilei1992).
[OpenMP] Added the support for hidden helper task in RTL
Sat, Jan 16, 11:14 AM
tianshilei1992 closed D77609: [OpenMP] Added the support for hidden helper task in RTL.
Sat, Jan 16, 11:13 AM · Restricted Project
spatel committed rG49b96cd9ef2f: [SLP] remove opcode field from reduction data class (authored by spatel).
[SLP] remove opcode field from reduction data class
Sat, Jan 16, 11:11 AM
spatel committed rGfcfcc3cc6b16: [SLP] fix typos; NFC (authored by spatel).
[SLP] fix typos; NFC
Sat, Jan 16, 11:11 AM
spatel committed rG48dbac5b6b0b: [SLP] remove unnecessary use of 'OperationData' (authored by spatel).
[SLP] remove unnecessary use of 'OperationData'
Sat, Jan 16, 11:11 AM
thopre added inline comments to D94837: Fix use of undefined session variable.
Sat, Jan 16, 10:55 AM
xbolva00 committed rG63bedc80da36: [InstSimplify] Handle commutativity for 'and' and 'outer or' for (~A & B) | ~(A… (authored by xbolva00).
[InstSimplify] Handle commutativity for 'and' and 'outer or' for (~A & B) | ~(A…
Sat, Jan 16, 10:43 AM
xbolva00 closed D94870: [InstSimplify] Handle commutativity for 'and' and 'outer or' for (~A & B) | ~(A | B) --> ~A.
Sat, Jan 16, 10:43 AM · Restricted Project
dmgreen added reviewers for D94604: [CodeGen] Allow parallel uses of a resource: steven.zhang, atrick, evgeny777, andreadb.
Sat, Jan 16, 10:38 AM · Restricted Project
lebedev.ri accepted D94870: [InstSimplify] Handle commutativity for 'and' and 'outer or' for (~A & B) | ~(A | B) --> ~A.
Sat, Jan 16, 10:33 AM · Restricted Project
dmgreen committed rG372eb2bbb6fb: [ARM] Add low overhead loops terminators to AnalyzeBranch (authored by dmgreen).
[ARM] Add low overhead loops terminators to AnalyzeBranch
Sat, Jan 16, 10:31 AM
dmgreen committed rGc1ab698dce8d: [ARM] Remove LLC tests from transform/hardware loop tests. (authored by dmgreen).
[ARM] Remove LLC tests from transform/hardware loop tests.
Sat, Jan 16, 10:31 AM
dmgreen closed D94392: [ARM] Add low overhead loops terminators to AnalyzeBranch.
Sat, Jan 16, 10:31 AM · Restricted Project
dmgreen added inline comments to D94778: [AArch64] Further restricts when a dup(*ext) can be rearranged.
Sat, Jan 16, 10:23 AM · Restricted Project
xbolva00 added inline comments to D94870: [InstSimplify] Handle commutativity for 'and' and 'outer or' for (~A & B) | ~(A | B) --> ~A.
Sat, Jan 16, 10:13 AM · Restricted Project
xbolva00 committed rG416854d0f7cd: [InstSimplify] Precommit new testcases; NFC (authored by xbolva00).
[InstSimplify] Precommit new testcases; NFC
Sat, Jan 16, 10:12 AM
xbolva00 updated the diff for D94870: [InstSimplify] Handle commutativity for 'and' and 'outer or' for (~A & B) | ~(A | B) --> ~A.

Simplify code.

Sat, Jan 16, 10:12 AM · Restricted Project
brad added a comment to D77737: [SPARC] Recognize and handle the %lm(sym) operator.

ping.

Sat, Jan 16, 10:12 AM · Restricted Project
tnfchris added a comment to D94837: Fix use of undefined session variable.

This commit adds the parameter and update call sites
accordingly, fixing one of Flake8's F821 warning (undefined name).

Sat, Jan 16, 10:06 AM
hiraditya added inline comments to D94202: Preserve the lexical order of global variables during llvm-link merge.
Sat, Jan 16, 10:01 AM · Restricted Project
tianshilei1992 updated the diff for D77609: [OpenMP] Added the support for hidden helper task in RTL.

Refined test cases and rebased

Sat, Jan 16, 9:49 AM · Restricted Project
lebedev.ri added a comment to D94870: [InstSimplify] Handle commutativity for 'and' and 'outer or' for (~A & B) | ~(A | B) --> ~A.

Please precommit tests.
This is more like it.

Sat, Jan 16, 9:47 AM · Restricted Project
kazu committed rG2082b10d100e: [llvm] Use *::empty (NFC) (authored by kazu).
[llvm] Use *::empty (NFC)
Sat, Jan 16, 9:41 AM
kazu committed rG19aacdb715ae: [llvm] Construct SmallVector with iterator ranges (NFC) (authored by kazu).
[llvm] Construct SmallVector with iterator ranges (NFC)
Sat, Jan 16, 9:41 AM
kazu committed rGba0fc7e1f8d5: [StringExtras] Fix comment typos (NFC) (authored by kazu).
[StringExtras] Fix comment typos (NFC)
Sat, Jan 16, 9:41 AM
GMNGeoffrey added a comment to D94451: Proposal for allowing unsupported build system configuration in-tree.

[snip]

I feel like we've been side-tracked by meta-arguments a lot in this discussion, so I'm going to make a few points and hopefully try to wrap this up.

Sat, Jan 16, 9:40 AM
xbolva00 requested review of D94870: [InstSimplify] Handle commutativity for 'and' and 'outer or' for (~A & B) | ~(A | B) --> ~A.
Sat, Jan 16, 9:32 AM · Restricted Project
Quuxplusone updated the diff for D94807: [libc++] Rationalize our treatment of contiguous iterators and __unwrap_iter()..

Rebase, and fix my new test's constexprness in C++11 mode.

Sat, Jan 16, 9:30 AM · Restricted Project
c-rhodes added a comment to D90687: [LV] Clamp VF hint when unsafe.

The patch that causes the assert is patch cba4accda08f90. I tried commit c63799fc52ff247 that is before your patch and there is no assert. Thank you.

Sat, Jan 16, 9:07 AM · Restricted Project
c-rhodes requested review of D94869: [LV] Fix crash when computing max VF too early.
Sat, Jan 16, 9:00 AM · Restricted Project
dmgreen added a comment to D94765: [WIP]Expand masked mem intrinsics correctly wrt big-endian.

Thanks for the patch. There is a patch to make MVE consistent with the rest of MVE in D94867. This will need rebasing on top of that, with update tests to make the two consistent again.

Sat, Jan 16, 9:00 AM · Restricted Project
jpienaar requested review of D94868: [mlir] Enable passing crash reproducer stream factory method.
Sat, Jan 16, 8:58 AM · Restricted Project
dmgreen requested review of D94867: [ARM] Make a BE predicate bitcast consistent with the rest of llvm.
Sat, Jan 16, 8:57 AM · Restricted Project
fhahn added inline comments to D94547: [lld-macho] Run ObjCContractPass during LTO.
Sat, Jan 16, 8:53 AM · Restricted Project
fhahn committed rGbca16e2fbb45: [LTO] Remove options to disable inlining, vectorization & GVNLoadPRE. (authored by fhahn).
[LTO] Remove options to disable inlining, vectorization & GVNLoadPRE.
Sat, Jan 16, 8:43 AM
fhahn closed D94783: [LTO] Remove options to disable inlining and GVNLoadPRE..
Sat, Jan 16, 8:43 AM · Restricted Project
steakhal added a reviewer for D93167: [NFC] Add CMakeUserPresets.json filename to .gitignore: dblaikie.
Sat, Jan 16, 8:36 AM · Restricted Project
nikic added a comment to D94859: [ValueTracking] Make impliesPoison look into operands of V.

I posted an alternative patch at D94866. It's potentially more expensive, but I think it will cover more of the cases we need.

Sat, Jan 16, 8:27 AM · Restricted Project
nikic requested review of D94866: [ValueTracking] Strengthen impliesPoison reasoning.
Sat, Jan 16, 8:24 AM · Restricted Project
xbolva00 committed rGbdd4dda58b0d: [InstSimplify] Update comments, remove redundant tests (authored by xbolva00).
[InstSimplify] Update comments, remove redundant tests
Sat, Jan 16, 7:32 AM
fhahn added inline comments to D94712: Do not traverse ConstantData use-list in LookInterchange.
Sat, Jan 16, 7:24 AM · Restricted Project
HsiangKai committed rG098dbf190a55: [RISCV] Correct alignment settings for vector registers. (authored by HsiangKai).
[RISCV] Correct alignment settings for vector registers.
Sat, Jan 16, 7:22 AM
HsiangKai closed D94751: [RISCV] Correct alignment settings for vector registers..
Sat, Jan 16, 7:21 AM · Restricted Project
xbolva00 updated subscribers of rGa4e2a5145a29: [InstSimplify] Add (~A & B) | ~(A | B) --> ~A.

define i32 @src(i32 %A, i32 %B) {
%0:

%i = xor i32 %A, 4294967295
%i2 = and i32 %i, %B
%i3 = or i32 %B, %A
%i4 = xor i32 %i3, 4294967295
%i5 = or i32 %i2, %i4
ret i32 %i5

}

>

define i32 @tgt(i32 %A, i32 %B) {
%0:

%i = xor i32 %A, 4294967295
ret i32 %i

}
Transformation seems to be correct!

Sat, Jan 16, 6:55 AM
steveire updated the diff for D94131: [clang-tidy] Use new mapAnyOf matcher.

Update

Sat, Jan 16, 6:54 AM · Restricted Project
xbolva00 committed rGa4e2a5145a29: [InstSimplify] Add (~A & B) | ~(A | B) --> ~A (authored by xbolva00).
[InstSimplify] Add (~A & B) | ~(A | B) --> ~A
Sat, Jan 16, 6:54 AM
xbolva00 committed rG9fc814ed5966: [Tests] Added tests for new instcombine or simplification; NFC (authored by xbolva00).
[Tests] Added tests for new instcombine or simplification; NFC
Sat, Jan 16, 6:54 AM
steveire requested review of D94865: [ASTMatchers] Add callOrConstruct matcher.
Sat, Jan 16, 6:54 AM · Restricted Project
steveire requested review of D94864: [ASTMatchers] Re-order the internals to allow another use-case.
Sat, Jan 16, 6:53 AM · Restricted Project
aganea committed rG25c1578a46ff: Fix llvm::Optional build breaks in MSVC using std::is_trivially_copyable (authored by jplayer-nv).
Fix llvm::Optional build breaks in MSVC using std::is_trivially_copyable
Sat, Jan 16, 6:37 AM
aganea closed D93510: Fix llvm::Optional build breaks in MSVC using std::is_trivially_copyable.
Sat, Jan 16, 6:37 AM · Restricted Project
khchen added inline comments to D94589: [RISCV] Add intrinsics for vector AMO instructions.
Sat, Jan 16, 6:37 AM · Restricted Project
thopre closed D94841: Fix line too long Flake8 warning.
Sat, Jan 16, 6:27 AM
thopre closed D94840: Add import needed for typing hints.
Sat, Jan 16, 6:27 AM
thopre added a comment to D94840: Add import needed for typing hints.

was it being indirectly imported before?

Sat, Jan 16, 6:27 AM
thopre closed D94839: Fix OrderField's copy constructor.
Sat, Jan 16, 6:25 AM
thopre closed D94838: Remove nonsensical fct definition.
Sat, Jan 16, 6:24 AM
HazardyKnusperkeks added a comment to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

Not what I had in mind, but for me that's okay. I can not say anything to the change of the script though.

Sat, Jan 16, 6:24 AM · Restricted Project, Restricted Project
stephenkelly committed rGb765eaf9a617: [ASTMatchers] Add support for CXXRewrittenBinaryOperator (authored by stephenkelly).
[ASTMatchers] Add support for CXXRewrittenBinaryOperator
Sat, Jan 16, 6:23 AM
stephenkelly closed D94130: [ASTMatchers] Add support for CXXRewrittenBinaryOperator.
Sat, Jan 16, 6:23 AM · Restricted Project
thopre updated the summary of D94837: Fix use of undefined session variable.
Sat, Jan 16, 6:23 AM