Page MenuHomePhabricator

[RISCV] Expand scalable-vector truncstores and extloads
ClosedPublic

Authored by frasercrmck on Wed, Mar 31, 5:02 AM.

Details

Summary

Caught in internal testing, these operations are assumed legal by
default, even for scalable vector types. Expand them back into separate
truncations and stores, or loads and extensions.

Also add explicit fixed-length vector tests for these operations, even
though they should have been correct already.

Diff Detail

Event Timeline

frasercrmck created this revision.Wed, Mar 31, 5:02 AM
frasercrmck requested review of this revision.Wed, Mar 31, 5:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptWed, Mar 31, 5:02 AM
  • rebase to hopefully fix the buildbots
craig.topper added inline comments.Thu, Apr 1, 4:53 PM
llvm/lib/Target/RISCV/RISCVISelLowering.cpp
511

You might be better off using integer_scalable_vector_valuetypes(). We need to block mask vectors too.

569

LoadExt for integer fixed vectors is missing.

581

Is the explicit makeArrayRef needed?

  • expand operations also for bool and fixed-length types
  • remove makearrayref
frasercrmck marked 3 inline comments as done.Mon, Apr 5, 3:05 AM
frasercrmck added inline comments.
llvm/lib/Target/RISCV/RISCVISelLowering.cpp
511

Good catch, thanks.

569

Done.

581

Turns out it's not, thanks.

This revision is now accepted and ready to land.Mon, Apr 5, 8:49 AM
This revision was automatically updated to reflect the committed changes.
frasercrmck marked 3 inline comments as done.