This is an archive of the discontinued LLVM Phabricator instance.

Differential D99483

[clang][AIX] Define __STDC_NO_ATOMICS__ for c11 and above
AbandonedPublic

Authored by daltenty on Mar 28 2021, 9:46 PM.

Details

Reviewers
hubert.reinterpretcast
ZarkoCA
cebowleratibm
lkail
Group Reviewers
Restricted Project
Commits
rT253115e2acbe: Added 'host' device for various *_RUN_PLACEHOLDER because
Summary

The libc implementation on AIX does not have stdatomic.h and the requisite interfaces for c11 atomics, so for now it's better to set STDC_NO_ATOMICS

Diff Detail

Event Timeline

daltenty created this revision.Mar 28 2021, 9:46 PM
Herald added a subscriber: jfb. · View Herald TranscriptMar 28 2021, 9:46 PM
daltenty requested review of this revision.Mar 28 2021, 9:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 28 2021, 9:46 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
daltenty added reviewers: hubert.reinterpretcast, ZarkoCA, cebowleratibm.Mar 28 2021, 9:48 PM
Harbormaster completed remote builds in B96039: Diff 333764.Mar 28 2021, 10:31 PM
arquitecto added a commit: rT253115e2acbe: Added 'host' device for various *_RUN_PLACEHOLDER because.Mar 29 2021, 12:15 AM
hubert.reinterpretcast added inline comments.Mar 30 2021, 9:14 AM
clang/lib/Basic/Targets/OSTargets.h
727

Checking Opts.C11 might be sufficient.

jsji added reviewers: lkail, Restricted Project.May 3 2021, 1:44 PM
jsji added a subscriber: jsji.Jun 14 2021, 1:32 PM

Done in https://reviews.llvm.org/D103707?

daltenty abandoned this revision.Jul 19 2021, 10:50 AM

Revision Contents

PathSize
clang/
lib/
Basic/
Targets/
5 lines
test/
Preprocessor/
19 lines

Diff 333764

clang/lib/Basic/Targets/OSTargets.h

Show First 20 Lines • Show All 716 Lines • ▼ Show 20 Lines if (this->PointerWidth == 64) {
Builder.defineMacro("__64BIT__"); Builder.defineMacro("__64BIT__");
} }
// Define _WCHAR_T when it is a fundamental type // Define _WCHAR_T when it is a fundamental type
// (i.e., for C++ without -fno-wchar). // (i.e., for C++ without -fno-wchar).
if (Opts.CPlusPlus && Opts.WChar) { if (Opts.CPlusPlus && Opts.WChar) {
Builder.defineMacro("_WCHAR_T"); Builder.defineMacro("_WCHAR_T");
} }
// The AIX library implementation of C11 atomics is not yet complete.
if (Opts.C11 || Opts.C17 || Opts.C2x) {
hubert.reinterpretcastUnsubmitted
Not Done
ReplyInline Actions

Checking Opts.C11 might be sufficient.

hubert.reinterpretcast: Checking `Opts.C11` might be sufficient.
Builder.defineMacro("__STDC_NO_ATOMICS__");
}
} }
public: public:
AIXTargetInfo(const llvm::Triple &Triple, const TargetOptions &Opts) AIXTargetInfo(const llvm::Triple &Triple, const TargetOptions &Opts)
: OSTargetInfo<Target>(Triple, Opts) { : OSTargetInfo<Target>(Triple, Opts) {
this->TheCXXABI.set(TargetCXXABI::XL); this->TheCXXABI.set(TargetCXXABI::XL);
if (this->PointerWidth == 64) { if (this->PointerWidth == 64) {
▲ Show 20 Lines • Show All 229 Lines • Show Last 20 Lines

clang/test/Preprocessor/aix-nocatomics.c

  • This file was added.
// The AIX library implementation of C11 atomics is incomplete, so test that the
// appropriate macro is set.
// 32-bit cases.
// RUN: %clang_cc1 -E -dM -triple=powerpc-ibm-aix7.1.0.0 -std=c11 < /dev/null | FileCheck -match-full-lines %s
// RUN: %clang_cc1 -E -dM -triple=powerpc-ibm-aix7.1.0.0 -std=c17 < /dev/null | FileCheck -match-full-lines %s
// RUN: %clang_cc1 -E -dM -triple=powerpc-ibm-aix7.1.0.0 -std=c2x < /dev/null | FileCheck -match-full-lines %s
// 64-bit cases.
// RUN: %clang_cc1 -E -dM -triple=powerpc64-ibm-aix7.1.0.0 -std=c11 < /dev/null | FileCheck -match-full-lines %s
// RUN: %clang_cc1 -E -dM -triple=powerpc64-ibm-aix7.1.0.0 -std=c17 < /dev/null | FileCheck -match-full-lines %s
// RUN: %clang_cc1 -E -dM -triple=powerpc64-ibm-aix7.1.0.0 -std=c2x < /dev/null | FileCheck -match-full-lines %s
// CHECK:#define __STDC_NO_ATOMICS__ 1
// Check that it's not set for C before 11.
// RUN: %clang_cc1 -E -dM -triple=powerpc64-ibm-aix7.1.0.0 -std=c99 < /dev/null | FileCheck -match-full-lines -check-prefix C99 %s
// C99-NOT:#define __STDC_NO_ATOMICS__ 1