This is an archive of the discontinued LLVM Phabricator instance.

[clang] Pass option directly to command. NFC
ClosedPublic

Authored by smeenai on Mar 25 2021, 12:23 AM.

Details

Summary

This code was written back when LLVM's minimum required CMake version
was 2.8.8, and I assume ExternalProject_Add_Step didn't take this option
at that point. It does now though, so we should just use the option.
Setting the _EP_* property is entirely equivalent (and is in fact how
these commands behave internally), but that also feels like an internal
implementation detail we shouldn't be relying on.

Diff Detail

Event Timeline

smeenai created this revision.Mar 25 2021, 12:23 AM
smeenai requested review of this revision.Mar 25 2021, 12:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 25 2021, 12:23 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
beanz accepted this revision.Mar 25 2021, 8:51 AM

Woo! Thanks for cleaning up one of my old messes :)

This revision is now accepted and ready to land.Mar 25 2021, 8:51 AM
This revision was landed with ongoing or failed builds.Mar 25 2021, 11:36 AM
This revision was automatically updated to reflect the committed changes.