This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Add a copy constructor to FailureOr
ClosedPublic

Authored by math-fehr on Mar 19 2021, 8:32 AM.

Details

Summary

The copy constructor was missing from FailureOr.

Note that I do not have commit access.

Diff Detail

Event Timeline

math-fehr created this revision.Mar 19 2021, 8:32 AM
math-fehr requested review of this revision.Mar 19 2021, 8:32 AM
math-fehr edited the summary of this revision. (Show Details)Mar 19 2021, 8:34 AM
math-fehr added reviewers: mehdi_amini, rriddle.
math-fehr edited the summary of this revision. (Show Details)Mar 19 2021, 8:37 AM
rriddle accepted this revision.Mar 22 2021, 10:36 AM
This revision is now accepted and ready to land.Mar 22 2021, 10:36 AM

@rriddle, could you land this for me? I do not have commit access.
Also, I see that the build failed, but it seems to be unrelated to the patch. If this is a problem, could you restart the builds?

This revision was landed with ongoing or failed builds.May 25 2021, 12:16 PM
This revision was automatically updated to reflect the committed changes.