This is an archive of the discontinued LLVM Phabricator instance.

[Orc] Make usage of ResourceKeys thread-safe in DebugObjectManagerPlugin
ClosedPublic

Authored by sgraenitz on Mar 18 2021, 6:27 AM.

Details

Summary

Don't leak ResourceKeys from MaterializationResponsibility::withResourceKeyDo() in notifyEmitted().
Also make some improvements in the overall implementation.

Diff Detail

Event Timeline

sgraenitz created this revision.Mar 18 2021, 6:27 AM
sgraenitz requested review of this revision.Mar 18 2021, 6:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 18 2021, 6:27 AM
lhames accepted this revision.Mar 22 2021, 9:28 AM

LGTM.

This revision is now accepted and ready to land.Mar 22 2021, 9:28 AM
This revision was landed with ongoing or failed builds.Mar 22 2021, 9:48 AM
This revision was automatically updated to reflect the committed changes.