Page MenuHomePhabricator
Differential D98763

[lld] add context-sensitive PGO options for COFF.
ClosedPublic
Actions

Authored by YolandaCY on Mar 17 2021, 12:34 AM.

Details

Reviewers
ruiu
tejohnson
xur
pengfei
Commits
rG4f9c61ef7229: [lld] add context-sensitive PGO options for COFF.
Summary

Add lld CSPGO (Contex-Sensitive PGO) options for COFF target.




Reference the ELF options from https://reviews.llvm.org/D56675
Diff Detail
Event Timeline
YolandaCY created this revision.Mar 17 2021, 12:34 AM
Herald added subscribers: wenlei, dang, steven_wu, hiraditya.  ·  View Herald TranscriptMar 17 2021, 12:34 AM
YolandaCY requested review of this revision.Mar 17 2021, 12:34 AM
Herald added a project: Restricted Project.  ·  View Herald TranscriptMar 17 2021, 12:34 AM
Herald added a subscriber: llvm-commits.  ·  View Herald Transcript
YolandaCY added reviewers: ruiu, tejohnson, xur, pengfei.Mar 17 2021, 12:53 AM
This patch is to enable CSPGO for Thinlto in lld on Windows. Could you please help review?
Harbormaster completed remote builds in B94175: Diff 331171.Mar 17 2021, 1:14 AM
xur added a comment.Mar 17 2021, 9:39 AM
This looks good to me. But I'll let other approve this.
YolandaCY added a comment.Mon, Mar 22, 2:36 AM
Thank you Rong. Any feedback from other reviewers?



I have verified this works for both old and new pass manager.



Regards

Yolanda
pengfei added a comment.Wed, Mar 24, 6:56 PM
I don't have much experience on lld. No objections.
tejohnson accepted this revision.Wed, Mar 24, 7:00 PM
lgtm
This revision is now accepted and ready to land.Wed, Mar 24, 7:00 PM
Closed by commit rG4f9c61ef7229: [lld] add context-sensitive PGO options for COFF. (authored by YolandaCY, committed by pengfei).  ·  Explain WhyWed, Mar 24, 11:41 PM
This revision was automatically updated to reflect the committed changes.
pengfei added a commit: rG4f9c61ef7229: [lld] add context-sensitive PGO options for COFF..
Revision Contents
Changeset List
PathSize
lld/
COFF/
6 lines
2 lines
2 lines
4 lines
Diff 333218
View Options
lld/COFF/Config.h
Loading...
View Options
lld/COFF/Driver.cpp
Loading...
View Options
lld/COFF/LTO.cpp
Loading...
View Options
lld/COFF/Options.td
Loading...