This is an archive of the discontinued LLVM Phabricator instance.

[-Wcompletion-handler] Extend list of detected conventions
ClosedPublic

Authored by vsavchenko on Mar 9 2021, 4:56 AM.

Diff Detail

Event Timeline

vsavchenko created this revision.Mar 9 2021, 4:56 AM
vsavchenko requested review of this revision.Mar 9 2021, 4:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 9 2021, 4:56 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
NoQ accepted this revision.Mar 9 2021, 1:22 PM

Looks all clear.

In that document there's also a clause that the conventional completion handler discovered through its suffix has to be the last parameter. I don't immediately see that respective check in the code. Do we have it?

This revision is now accepted and ready to land.Mar 9 2021, 1:22 PM
This revision was landed with ongoing or failed builds.Mar 9 2021, 11:43 PM
This revision was automatically updated to reflect the committed changes.
In D98251#2615049, @NoQ wrote:

Looks all clear.

In that document there's also a clause that the conventional completion handler discovered through its suffix has to be the last parameter. I don't immediately see that respective check in the code. Do we have it?

You are right on that part, I'll try to incorporate that check into the current (a bit tangled) logic.