This is an archive of the discontinued LLVM Phabricator instance.

[clang+lld] Pass -platform_version args to ld64.lld
ClosedPublic

Authored by int3 on Mar 1 2021, 3:57 PM.

Details

Reviewers
thakis
Group Reviewers
Restricted Project
Commits
rG18fa1d380d6c: [clang+lld] Pass -platform_version args to ld64.lld
Summary

Fix regression where we aren't passing -platform_version to new ld64.lld after D95204: [lld-macho] Switch default to new Darwin backend.

Most of the changes were originally in D95204, but I backed them out due to
test failures on builds which have CLANG_DEFAULT_LINKER=lld. The tests are
properly updated in this diff.

Diff Detail

Event Timeline

int3 created this revision.Mar 1 2021, 3:57 PM
int3 requested review of this revision.Mar 1 2021, 3:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 1 2021, 3:57 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
thakis accepted this revision.Mar 1 2021, 4:55 PM

If I understand this right, the right patch description should be "fix regression where we didn't pass -platform_version to new ld64.lld after D95204", right? It's good to fix this :)

The test changes look like http://reviews.llvm.org/rGa9eaf8435d9204f5d71a08cfd7c574e92d434871 so I think they're right :)

This revision is now accepted and ready to land.Mar 1 2021, 4:55 PM
int3 edited the summary of this revision. (Show Details)Mar 2 2021, 9:50 AM
This revision was automatically updated to reflect the committed changes.