This is an archive of the discontinued LLVM Phabricator instance.

Differential D97701

[lldb] Remove XPCServices symlinking
ClosedPublic

Authored by smeenai on Mar 1 2021, 9:47 AM.

Details

Reviewers
vsk
JDevlieghere
Commits
rG015d78a25e51: [lldb] Remove XPCServices symlinking
Summary

This is a downstream change that was accidentally included upstream.

Diff Detail

Event Timeline

smeenai created this revision.Mar 1 2021, 9:47 AM
Herald added a subscriber: mgorny. · View Herald TranscriptMar 1 2021, 9:47 AM
smeenai requested review of this revision.Mar 1 2021, 9:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 1 2021, 9:47 AM
Herald added a subscriber: lldb-commits. · View Herald Transcript
smeenai mentioned this in D85770: Build a flat LLDB.framework for embedded Darwin targets.Mar 1 2021, 9:49 AM
vsk accepted this revision.Mar 1 2021, 10:49 AM

Thanks!

This revision is now accepted and ready to land.Mar 1 2021, 10:49 AM
This revision was landed with ongoing or failed builds.Mar 1 2021, 11:24 AM
Closed by commit rG015d78a25e51: [lldb] Remove XPCServices symlinking (authored by smeenai). · Explain Why
This revision was automatically updated to reflect the committed changes.
smeenai added a commit: rG015d78a25e51: [lldb] Remove XPCServices symlinking.
Harbormaster completed remote builds in B91368: Diff 327157.Mar 1 2021, 12:09 PM

Revision Contents

PathSize
lldb/
cmake/
modules/
10 lines

Diff 327209

lldb/cmake/modules/LLDBFramework.cmake

Show First 20 Lines • Show All 118 Lines • ▼ Show 20 Linesif(NOT APPLE_EMBEDDED)
add_custom_command(TARGET liblldb POST_BUILD add_custom_command(TARGET liblldb POST_BUILD
COMMAND ${CMAKE_COMMAND} -E copy_directory COMMAND ${CMAKE_COMMAND} -E copy_directory
${clang_resource_headers_dir} ${clang_resource_headers_dir}
$<TARGET_FILE_DIR:liblldb>/Resources/Clang/include $<TARGET_FILE_DIR:liblldb>/Resources/Clang/include
COMMENT "LLDB.framework: copy clang vendor-specific headers" COMMENT "LLDB.framework: copy clang vendor-specific headers"
) )
endif() endif()
# IOS framework bundles are flat
if(NOT APPLE_EMBEDDED)
add_custom_command(TARGET liblldb POST_BUILD
COMMAND ${CMAKE_COMMAND} -E create_symlink
Versions/Current/XPCServices
${LLDB_FRAMEWORK_ABSOLUTE_BUILD_DIR}/LLDB.framework/XPCServices
COMMENT "LLDB.framework: create symlink XPCServices"
)
endif()
# Add an rpath pointing to the directory where LLDB.framework is installed. # Add an rpath pointing to the directory where LLDB.framework is installed.
# This allows frameworks (relying on @rpath) to be installed in the same folder and found at runtime. # This allows frameworks (relying on @rpath) to be installed in the same folder and found at runtime.
set_property(TARGET liblldb APPEND PROPERTY INSTALL_RPATH set_property(TARGET liblldb APPEND PROPERTY INSTALL_RPATH
"@loader_path/../../../") "@loader_path/../../../")