This is an archive of the discontinued LLVM Phabricator instance.

[Driver] Rename -fprofile-{prefix-map,compilation-dir} to -fcoverage-{prefix-map,compilation-dir}
ClosedPublic

Authored by phosek on Feb 24 2021, 7:07 PM.

Details

Summary

These flags affect coverage mapping (-fcoverage-mapping), not
-fprofile-[instr-]generate so it makes more sense to use the
-fcoverage-* prefix.

Diff Detail

Event Timeline

phosek created this revision.Feb 24 2021, 7:07 PM
phosek requested review of this revision.Feb 24 2021, 7:07 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 24 2021, 7:07 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript

I realized recently that -fcoverage-{prefix-map,compilation-dir} is a more accurate name but I'd be interested in your opinion, I don't feel too strongly about this.

haowei added a subscriber: haowei.Feb 25 2021, 10:38 AM
keith accepted this revision.Feb 25 2021, 2:34 PM

I personally prefer this, and this is what I landed in swiftc a while back, but I changed to -fprofile-prefix-map based on feedback from you 😛 https://reviews.llvm.org/D83154?id=275480#2146086

But I think the assumption there was it did apply to the other profile related flags

This revision is now accepted and ready to land.Feb 25 2021, 2:34 PM

I personally prefer this, and this is what I landed in swiftc a while back, but I changed to -fprofile-prefix-map based on feedback from you 😛 https://reviews.llvm.org/D83154?id=275480#2146086

But I think the assumption there was it did apply to the other profile related flags

I know, sorry about that :( I originally though of it as more associated with other profile flags but I changed my mind after getting more experience with that part of codebase.

keith added a comment.Feb 25 2021, 3:41 PM

No worries! Makes sense, I think this is a good change

This revision was landed with ongoing or failed builds.Feb 25 2021, 9:54 PM
This revision was automatically updated to reflect the committed changes.
clang/test/Profile/coverage-prefix-map.c