This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Pass file when possible to resolve URI.
ClosedPublic

Authored by hokein on Feb 16 2021, 11:43 PM.

Details

Summary

Some URI scheme needs the hint path to do a correct resolution, we pass
one of the open files as hint path.

This is not perfect, and it might not work for opening files across
project, but it would fix a bug with our internal scheme.

in the long run, removing URIs from all the index internals is a more proper fix.

Diff Detail

Event Timeline

hokein created this revision.Feb 16 2021, 11:43 PM
hokein requested review of this revision.Feb 16 2021, 11:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 16 2021, 11:43 PM
sammccall accepted this revision.Feb 17 2021, 6:24 AM
This revision is now accepted and ready to land.Feb 17 2021, 6:24 AM
This revision was automatically updated to reflect the committed changes.