Page MenuHomePhabricator

SPEC2006: Pronounce endianness flags both ways
AcceptedPublic

Authored by nwf on Feb 10 2021, 10:02 AM.

Details

Summary

473.astar chose to pronounce the CPU endianness C preprocessor symbol differently from the rest of the benchmark suite.

This was caught in the make-based build system, but missed in the cmake-based system.

Diff Detail

Repository
rT test-suite

Event Timeline

nwf created this revision.Feb 10 2021, 10:02 AM
nwf requested review of this revision.Feb 10 2021, 10:02 AM
jrtc27 added a subscriber: jrtc27.

Thanks for catching this.

Just to double-check, so you need BOTH spellings?

Meinersbur accepted this revision.Feb 10 2021, 10:28 AM

LGTM

Just to double-check, so you need BOTH spellings?

SPEC_CPU_BIG_ENDIAN for 473.astar, SPEC_CPU_BIGENDIAN for all others.

This revision is now accepted and ready to land.Feb 10 2021, 10:28 AM