This is an archive of the discontinued LLVM Phabricator instance.

[SimpleLoopUnswitch] Don't non-trivially unswitch loops that are unsafe to clone
ClosedPublic

Authored by aeubanks on Feb 8 2021, 12:54 PM.

Details

Summary

Non-trivial unswitching can clone loops.

The legacy -loop-unswitch pass also checks for this.

Fixes PR49085.

Diff Detail

Event Timeline

aeubanks created this revision.Feb 8 2021, 12:54 PM
aeubanks requested review of this revision.Feb 8 2021, 12:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 8 2021, 12:54 PM
asbirlea accepted this revision.Feb 8 2021, 1:04 PM
This revision is now accepted and ready to land.Feb 8 2021, 1:04 PM

Thanks! I can confirm that this fixes the assertion I was hitting.

This revision was landed with ongoing or failed builds.Feb 8 2021, 1:19 PM
This revision was automatically updated to reflect the committed changes.