This is an archive of the discontinued LLVM Phabricator instance.

Differential D95604

Explicitly use python3 for lit sandbox
ClosedPublic

Authored by ostannard on Jan 28 2021, 2:46 AM.

Details

Reviewers
serge-sans-paille
dblaikie
maxim-kuvyrkov
gkistanova
rovka
Commits
rZORG2d096eb6dc44: Explicitly use python3 for lit sandbox
Summary

Without this, virtualenv defaults to python2 (at least on Ubuntu 18.04), which causes problems on the ARM/AArch64 bots which no longer have python2 installed.

Diff Detail

Event Timeline

ostannard created this revision.Jan 28 2021, 2:46 AM
Herald added a reviewer: gkistanova. · View Herald TranscriptJan 28 2021, 2:46 AM
Herald added a subscriber: kristof.beyls. · View Herald Transcript
ostannard requested review of this revision.Jan 28 2021, 2:46 AM
rovka accepted this revision.Jan 28 2021, 3:08 AM
rovka added a subscriber: rovka.

LGTM.

This revision is now accepted and ready to land.Jan 28 2021, 3:08 AM
Closed by commit rZORG2d096eb6dc44: Explicitly use python3 for lit sandbox (authored by ostannard). · Explain WhyJan 29 2021, 2:10 AM
This revision was automatically updated to reflect the committed changes.
ostannard added a commit: rZORG2d096eb6dc44: Explicitly use python3 for lit sandbox.

Revision Contents

PathSize
zorg/
buildbot/
builders/
2 lines

Diff 320080

zorg/buildbot/builders/ClangBuilder.py

Show First 20 Lines • Show All 526 Lines • ▼ Show 20 Lines if runTestSuite:
# Steps to prepare, build and run LNT # Steps to prepare, build and run LNT
f.addStep(ShellCommand(name='clean sandbox', f.addStep(ShellCommand(name='clean sandbox',
command=['rm', '-rf', 'sandbox'], command=['rm', '-rf', 'sandbox'],
haltOnFailure=True, haltOnFailure=True,
description='removing sandbox directory', description='removing sandbox directory',
workdir='test', workdir='test',
env=env)) env=env))
f.addStep(ShellCommand(name='recreate sandbox', f.addStep(ShellCommand(name='recreate sandbox',
command=['virtualenv', 'sandbox'], command=['virtualenv', '--python=python3', 'sandbox'],
haltOnFailure=True, haltOnFailure=True,
description='recreating sandbox', description='recreating sandbox',
workdir='test', workdir='test',
env=env)) env=env))
f.addStep(ShellCommand(name='setup lit', f.addStep(ShellCommand(name='setup lit',
command=[python, lnt_setup, 'develop'], command=[python, lnt_setup, 'develop'],
haltOnFailure=True, haltOnFailure=True,
description='setting up LNT in sandbox', description='setting up LNT in sandbox',
Show All 15 Lines