diff --git a/llvm/lib/Object/WasmObjectFile.cpp b/llvm/lib/Object/WasmObjectFile.cpp --- a/llvm/lib/Object/WasmObjectFile.cpp +++ b/llvm/lib/Object/WasmObjectFile.cpp @@ -693,7 +693,8 @@ } default: - return make_error("Invalid symbol type", + return make_error("Invalid symbol type: " + + Twine(unsigned(Info.Kind)), object_error::parse_failed); } @@ -850,14 +851,15 @@ uint32_t PreviousOffset = 0; while (RelocCount--) { wasm::WasmRelocation Reloc = {}; - Reloc.Type = readVaruint32(Ctx); + uint32_t type = readVaruint32(Ctx); + Reloc.Type = type; Reloc.Offset = readVaruint32(Ctx); if (Reloc.Offset < PreviousOffset) return make_error("Relocations not in offset order", object_error::parse_failed); PreviousOffset = Reloc.Offset; Reloc.Index = readVaruint32(Ctx); - switch (Reloc.Type) { + switch (type) { case wasm::R_WASM_FUNCTION_INDEX_LEB: case wasm::R_WASM_TABLE_INDEX_SLEB: case wasm::R_WASM_TABLE_INDEX_SLEB64: @@ -935,9 +937,8 @@ Reloc.Addend = readVarint32(Ctx); break; default: - return make_error("Bad relocation type: " + - Twine(Reloc.Type), - object_error::parse_failed); + return make_error( + "Bad relocation type: " + Twine(type), object_error::parse_failed); } // Relocations must fit inside the section, and must appear in order. They diff --git a/llvm/test/Object/Inputs/WASM/bad-reloc-type.wasm b/llvm/test/Object/Inputs/WASM/bad-reloc-type.wasm new file mode 100644 index 0000000000000000000000000000000000000000..0000000000000000000000000000000000000000 GIT binary patch literal 0 Hc$@&1 | FileCheck %s + +CHECK: Bad relocation type: 63 diff --git a/llvm/test/Object/wasm-bad-symbol-type.test b/llvm/test/Object/wasm-bad-symbol-type.test new file mode 100644 --- /dev/null +++ b/llvm/test/Object/wasm-bad-symbol-type.test @@ -0,0 +1,3 @@ +RUN: not llvm-objdump -s %p/Inputs/WASM/bad-symbol-type.wasm 2>&1 | FileCheck %s + +CHECK: Invalid symbol type: 63