Page MenuHomePhabricator

[Clang][OpenMP][NVPTX] Replace `libomptarget-nvptx-path` with `libomptarget-nvptx-bc-path`
ClosedPublic

Authored by tianshilei1992 on Jan 21 2021, 12:07 PM.

Details

Summary

D94700 removed the static library so we no longer need to pass
-llibomptarget-nvptx to nvlink. Since the bitcode library is the only device
runtime for now, instead of emitting a warning when it is not found, an error
should be raised. We also set a new option libomptarget-nvptx-bc-path to let
user choose which bitcode library is being used.

Diff Detail

Event Timeline

tianshilei1992 requested review of this revision.Jan 21 2021, 12:07 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 21 2021, 12:07 PM
tianshilei1992 edited the summary of this revision. (Show Details)Jan 21 2021, 12:08 PM
JonChesterfield accepted this revision.Jan 21 2021, 4:17 PM

LGTM, thanks!

This revision is now accepted and ready to land.Jan 21 2021, 4:17 PM

Fixed the test issue caused by wrong path seperator on Windows and Linux

Made test more robust

Fixed test case

Still LGTM. A little surprised these are being run on windows, but good to be robust.

Still LGTM. A little surprised these are being run on windows, but good to be robust.

It's driver test which only invokes -###. ;-) No actual execution.