Page MenuHomePhabricator

[PowerPC] Update Refactored Load/Store Implementation, XForm VSX Patterns, and Tests
Needs ReviewPublic

Authored by amyk on Jan 20 2021, 10:56 PM.

Details

Reviewers
power-llvm-team
nemanjai
Group Reviewers
Restricted Project
Summary

This patch includes the following updates to the load/store refactoring effort introduced in D93370:

  • Update various VSX patterns that use to "force" an XForm, to instead just XForm. This allows the ability for the patterns to compute the most optimal addressing mode (and to produce a DForm instruction when possible)
  • Check the alignment of Frame Index
  • Update pattern and test case for the LXVD2X/STXVD2X intrinsics
  • Update LIT test cases that use to use the XForm instruction to use the DForm instruction

Depends on D93370

Diff Detail

Event Timeline

amyk created this revision.Jan 20 2021, 10:56 PM
amyk requested review of this revision.Jan 20 2021, 10:56 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2021, 10:56 PM
amyk updated this revision to Diff 319727.Wed, Jan 27, 6:11 PM

Rebase patch and also add additional handling for frame index (if the frame index is not aligned, match to an XForm instruction).

amyk updated this revision to Diff 322977.Thu, Feb 11, 6:03 AM
  • Rebase the patch with the latest trunk.
  • Updated alignment checks for the frame index.
amyk updated this revision to Diff 323859.Mon, Feb 15, 6:04 PM

Update patch based on dependent patch changes.

NeHuang added inline comments.
llvm/lib/Target/PowerPC/PPCISelLowering.cpp
16647

nit: remove duplicate only

16657

nit: double check if the frame index is aligned