Page MenuHomePhabricator

[clang][cli] Generate HeaderSearch options separately
ClosedPublic

Authored by jansvoboda11 on Jan 15 2021, 9:30 AM.

Details

Summary

This patch moves parsing of header search options from generateCC1Options to separate GenerateHeaderSearchArgs.

The round-trip algorithm in D94472 requires this separation to be able to run parsing and generating only for the options that need to be tested via round-tripping.

This also moves the GENERATE_OPTION_WITH_MARSHALLING to the top of the file, because other kinds of options will be generated in separate functions that will be spread throughout CompilerInvocation.cpp to be close to their parsing counterparts.

Diff Detail

Event Timeline

jansvoboda11 requested review of this revision.Jan 15 2021, 9:30 AM
jansvoboda11 created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJan 15 2021, 9:30 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
jansvoboda11 edited the summary of this revision. (Show Details)Jan 15 2021, 10:08 AM
This revision is now accepted and ready to land.Jan 25 2021, 12:11 PM
This revision was landed with ongoing or failed builds.Jan 27 2021, 5:57 AM
This revision was automatically updated to reflect the committed changes.