This is an archive of the discontinued LLVM Phabricator instance.

Differential D94592

[NFC][AsmPrinter] Windows warning: Use explicit cast
ClosedPublic

Authored by dstuttard on Jan 13 2021, 4:58 AM.

Details

Reviewers
HsiangKai
evandro
Commits
rG259936f4910a: [NFC][AsmPrinter] Windows warning: Use explicit cast
Summary

static_cast for uint64_t to unsigned gives a MS VC build warning
for Windows:

warning C4309: 'static_cast': truncation of constant value

Use an explicit cast instead.

Change-Id: I692d335b4913070686a102780c1fb05b893a2f69

Diff Detail

Event Timeline

dstuttard created this revision.Jan 13 2021, 4:58 AM
Herald added a subscriber: hiraditya. · View Herald TranscriptJan 13 2021, 4:58 AM
dstuttard requested review of this revision.Jan 13 2021, 4:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 13 2021, 4:58 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
dstuttard added reviewers: HsiangKai, evandro.Jan 13 2021, 5:01 AM
dstuttard updated this revision to Diff 316372.Jan 13 2021, 5:25 AM

More in line with other similar fixes

Harbormaster completed remote builds in B85000: Diff 316369.Jan 13 2021, 6:27 AM
Harbormaster completed remote builds in B85002: Diff 316372.Jan 13 2021, 6:32 AM
HsiangKai accepted this revision.Jan 13 2021, 7:02 AM

LGTM.

This revision is now accepted and ready to land.Jan 13 2021, 7:02 AM
This revision was landed with ongoing or failed builds.Jan 14 2021, 1:12 AM
Closed by commit rG259936f4910a: [NFC][AsmPrinter] Windows warning: Use explicit cast (authored by dstuttard). · Explain Why
This revision was automatically updated to reflect the committed changes.
dstuttard added a commit: rG259936f4910a: [NFC][AsmPrinter] Windows warning: Use explicit cast.

Revision Contents

PathSize
llvm/
lib/
CodeGen/
AsmPrinter/
4 lines

Diff 316587

llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp

Show First 20 Lines • Show All 840 Lines • ▼ Show 20 Linesstatic void emitComments(const MachineInstr &MI, raw_ostream &CommentOS) {
// We assume a single instruction only has a spill or reload, not // We assume a single instruction only has a spill or reload, not
// both. // both.
Optional<unsigned> Size; Optional<unsigned> Size;
if ((Size = MI.getRestoreSize(TII))) { if ((Size = MI.getRestoreSize(TII))) {
CommentOS << *Size << "-byte Reload\n"; CommentOS << *Size << "-byte Reload\n";
} else if ((Size = MI.getFoldedRestoreSize(TII))) { } else if ((Size = MI.getFoldedRestoreSize(TII))) {
if (*Size) { if (*Size) {
if (*Size == static_cast<unsigned>(MemoryLocation::UnknownSize)) if (*Size == unsigned(MemoryLocation::UnknownSize))
CommentOS << "Unknown-size Folded Reload\n"; CommentOS << "Unknown-size Folded Reload\n";
else else
CommentOS << *Size << "-byte Folded Reload\n"; CommentOS << *Size << "-byte Folded Reload\n";
} }
} else if ((Size = MI.getSpillSize(TII))) { } else if ((Size = MI.getSpillSize(TII))) {
CommentOS << *Size << "-byte Spill\n"; CommentOS << *Size << "-byte Spill\n";
} else if ((Size = MI.getFoldedSpillSize(TII))) { } else if ((Size = MI.getFoldedSpillSize(TII))) {
if (*Size) { if (*Size) {
if (*Size == static_cast<unsigned>(MemoryLocation::UnknownSize)) if (*Size == unsigned(MemoryLocation::UnknownSize))
CommentOS << "Unknown-size Folded Spill\n"; CommentOS << "Unknown-size Folded Spill\n";
else else
CommentOS << *Size << "-byte Folded Spill\n"; CommentOS << *Size << "-byte Folded Spill\n";
} }
} }
// Check for spill-induced copies // Check for spill-induced copies
if (MI.getAsmPrinterFlag(MachineInstr::ReloadReuse)) if (MI.getAsmPrinterFlag(MachineInstr::ReloadReuse))
▲ Show 20 Lines • Show All 2,643 Lines • Show Last 20 Lines