This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] Fixed the link error that cannot find static data member
ClosedPublic

Authored by tianshilei1992 on Jan 12 2021, 11:59 AM.

Details

Summary

Constant static data member can be defined in the class without another
define after the class in C++17. Although it is C++17, Clang can still handle it
even w/o the flag for C++17. Unluckily, GCC cannot handle that.

Diff Detail

Event Timeline

tianshilei1992 requested review of this revision.Jan 12 2021, 11:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 12 2021, 11:59 AM
jhuber6 accepted this revision.Jan 12 2021, 12:07 PM

LGTM.

This revision is now accepted and ready to land.Jan 12 2021, 12:07 PM
This revision was landed with ongoing or failed builds.Jan 12 2021, 1:48 PM
This revision was automatically updated to reflect the committed changes.