This is an archive of the discontinued LLVM Phabricator instance.

Differential D94445

[libc][NFC] Make __support/common.h an in tree header.
ClosedPublic

Authored by sivachandra on Jan 11 2021, 1:04 PM.

Details

Reviewers
michaelrj
Commits
rGaefeb5f136e7: [libc][NFC] Make __support/common.h an in tree header.
Summary

It was previously a generated header. It can easily converted to a
generated header if required in future.

Diff Detail

Event Timeline

sivachandra created this revision.Jan 11 2021, 1:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 11 2021, 1:04 PM
Herald added subscribers: libc-commits, ecnelises, tschuett, mgorny. · View Herald Transcript
sivachandra requested review of this revision.Jan 11 2021, 1:04 PM
michaelrj accepted this revision.Jan 11 2021, 1:09 PM

LGTM

This revision is now accepted and ready to land.Jan 11 2021, 1:09 PM
This revision was landed with ongoing or failed builds.Jan 11 2021, 1:11 PM
Closed by commit rGaefeb5f136e7: [libc][NFC] Make __support/common.h an in tree header. (authored by sivachandra). · Explain Why
This revision was automatically updated to reflect the committed changes.
sivachandra added a commit: rGaefeb5f136e7: [libc][NFC] Make __support/common.h an in tree header..
Harbormaster completed remote builds in B84751: Diff 315920.Jan 11 2021, 2:30 PM

Revision Contents

PathSize
libc/
src/
__support/
10 lines
common.h
common.h.def
18 lines

Diff 315921

libc/src/__support/CMakeLists.txt

add_gen_header( add_header_library(
common common
DEF_FILE common.h.def HDRS
PARAMS common.h
platform_defs=../../config/${LIBC_TARGET_OS}/platform_defs.h.inc
GEN_HDR common.h
DATA_FILES
../../config/${LIBC_TARGET_OS}/platform_defs.h.inc
) )

libc/src/__support/common.h

  • This file was moved from libc/src/__support/common.h.def.
//===-- Common internal contructs -----------------------------------------===// //===-- Common internal contructs -----------------------------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#ifndef LLVM_LIBC_SUPPORT_COMMON_H #ifndef LLVM_LIBC_SUPPORT_COMMON_H
#define LLVM_LIBC_SUPPORT_COMMON_H #define LLVM_LIBC_SUPPORT_COMMON_H
#define LIBC_INLINE_ASM __asm__ __volatile__ #define LIBC_INLINE_ASM __asm__ __volatile__
#define likely(x) __builtin_expect (!!(x), 1) #define likely(x) __builtin_expect(!!(x), 1)
#define unlikely(x) __builtin_expect (x, 0) #define unlikely(x) __builtin_expect(x, 0)
#define UNUSED __attribute__((unused)) #define UNUSED __attribute__((unused))
#ifndef LLVM_LIBC_FUNCTION_ATTR #ifndef LLVM_LIBC_FUNCTION_ATTR
#define LLVM_LIBC_FUNCTION_ATTR #define LLVM_LIBC_FUNCTION_ATTR
#endif #endif
#ifdef LLVM_LIBC_PUBLIC_PACKAGING #ifdef LLVM_LIBC_PUBLIC_PACKAGING
#define LLVM_LIBC_FUNCTION(type, name, arglist) \ #define LLVM_LIBC_FUNCTION(type, name, arglist) \
LLVM_LIBC_FUNCTION_ATTR decltype(__llvm_libc::name) __##name##_impl__ __asm__(#name); \ LLVM_LIBC_FUNCTION_ATTR decltype(__llvm_libc::name) \
__##name##_impl__ __asm__(#name); \
decltype(__llvm_libc::name) name [[gnu::alias(#name)]]; \ decltype(__llvm_libc::name) name [[gnu::alias(#name)]]; \
type __##name##_impl__ arglist type __##name##_impl__ arglist
#else #else
#define LLVM_LIBC_FUNCTION(type, name, arglist)\ #define LLVM_LIBC_FUNCTION(type, name, arglist) type name arglist
type name arglist
#endif #endif
#endif // LLVM_LIBC_SUPPORT_COMMON_H #endif // LLVM_LIBC_SUPPORT_COMMON_H

libc/src/__support/common.h.def

  • This file was moved to libc/src/__support/common.h.