Page MenuHomePhabricator

[AArch64] [Windows] Properly add :lo12: reloc specifiers when generating assembly
ClosedPublic

Authored by mstorsjo on Sat, Jan 9, 2:32 PM.

Details

Summary

This makes sure that assembly output actually can be assembled.

Set the correct MCExpr relocations specifier VK_PAGEOFF - and also set VK_PAGE consistently even though it's not visible in the assembly output.

Diff Detail

Event Timeline

mstorsjo created this revision.Sat, Jan 9, 2:32 PM
mstorsjo requested review of this revision.Sat, Jan 9, 2:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptSat, Jan 9, 2:32 PM
compnerd accepted this revision.Mon, Jan 11, 10:21 AM

LGTM; please fix the formatting lint.

This revision is now accepted and ready to land.Mon, Jan 11, 10:21 AM
This revision was landed with ongoing or failed builds.Tue, Jan 12, 1:59 PM
This revision was automatically updated to reflect the committed changes.