Page MenuHomePhabricator

[AArch64] Fix crash caused by invalid vector element type
ClosedPublic

Authored by NickGuy on Thu, Jan 7, 7:43 AM.

Details

Summary

Fixes a crash caused by D91255, when LLVMTy is null when calling changeExtendedVectorElementType.

Diff Detail

Event Timeline

NickGuy created this revision.Thu, Jan 7, 7:43 AM
fhahn added a subscriber: fhahn.Thu, Jan 7, 7:45 AM

this needs a test?

NickGuy updated this revision to Diff 315153.Thu, Jan 7, 8:47 AM

this needs a test?

Possibly; Though it doesn't change the supported scope covered by the tests in D91255, it might be worth having one to make sure the crash doesn't reoccur.

dmajor added a comment.Thu, Jan 7, 8:49 AM

Confirmed this fixes our original full-size repro, thanks! I'll let those better knowledgeable than me review the change though.

dmgreen accepted this revision.Thu, Jan 7, 2:55 PM

LGTM thanks, but please try and simplify the test case if you can.

llvm/test/CodeGen/AArch64/aarch64-dup-ext-vectortype-crash.ll
13

Can this test be made simpler? It possibly just needs an extend from a non-expected type, splat into a mul.

This revision is now accepted and ready to land.Thu, Jan 7, 2:55 PM
This revision was automatically updated to reflect the committed changes.
NickGuy added inline comments.Fri, Jan 8, 4:08 AM
llvm/test/CodeGen/AArch64/aarch64-dup-ext-vectortype-crash.ll
13

Done, thanks for the tip