Page MenuHomePhabricator
Differential D94167

[ARM][GISel] Treat calls as variadic even if only fixed arguments provided
ClosedPublic
Actions

Authored by ostannard on Wed, Jan 6, 4:18 AM.

Details

Reviewers
rovka
yroux
DavidSpickett
t.p.northover
Summary

For the ARM hard-float calling convention, calls to variadic functions need to be treated differently, even if only the fixed arguments are provided.




This fixes GCC-C-execute-pr68390 in the test-suite, which is failing on the ARM GlobaISel bot.
Diff Detail
Event Timeline
ostannard created this revision.Wed, Jan 6, 4:18 AM
Herald added subscribers: danielkiss, hiraditya, kristof.beyls.  ·  View Herald TranscriptWed, Jan 6, 4:18 AM
ostannard requested review of this revision.Wed, Jan 6, 4:18 AM
Herald added a project: Restricted Project.  ·  View Herald TranscriptWed, Jan 6, 4:18 AM
Harbormaster completed remote builds in B84186: Diff 314855.Wed, Jan 6, 4:53 AM
ostannard added reviewers: yroux, DavidSpickett.Thu, Jan 14, 8:27 AM
Ping.
hiraditya added a reviewer: t.p.northover.Thu, Jan 14, 8:30 AM
yroux accepted this revision.Thu, Jan 14, 11:41 PM
LGTM
This revision is now accepted and ready to land.Thu, Jan 14, 11:41 PM
ostannard closed this revision.Fri, Jan 15, 1:37 AM
Committed as rG3676ef1053.
Revision Contents
Changeset List
PathSize
llvm/
lib/
Target/
ARM/
8 lines
test/
CodeGen/
ARM/
GlobalISel/
21 lines
Diff 314855
View Options
llvm/lib/Target/ARM/ARMCallLowering.cpp
Loading...
View Options
llvm/test/CodeGen/ARM/GlobalISel/irtranslator-varargs-lowering.ll
Loading...