This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Add a partial test of vector sadd.overflow to demonstrate intrinsics with multiple scalable vector results.
ClosedPublic

Authored by craig.topper on Jan 5 2021, 7:34 PM.

Details

Summary

This builds on D94142 where scalable vectors are allowed in structs.

This test is incomplete because our isel patterns aren't ready
for the comparisons needed for overflow checking yet. See the FIXME.

I did have to fix one scalable vector issue in the vector type
creation for these intrinsics.

Diff Detail

Event Timeline

craig.topper created this revision.Jan 5 2021, 7:34 PM
craig.topper requested review of this revision.Jan 5 2021, 7:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 5 2021, 7:34 PM
Herald added a subscriber: MaskRay. · View Herald Transcript

I was actually going to take the time today/tomorrow to push a patch with what I have for setcc for review. Is that all you need to get on your way to better support for the overflow result?

This revision was not accepted when it landed; it landed in state Needs Review.Jan 18 2021, 10:43 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.

I've committed a modified version of this patch that uses both results.