This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/GlobalISel: Add baseline IR tests for fdiv
ClosedPublic

Authored by arsenm on Jan 5 2021, 7:15 PM.

Details

Summary

The fdiv lowering is currently split between an IR pass and codegen,
so make sure this works end to end. We also currently differ from the
DAG on some edge cases, which this will show in a future change.

Diff Detail

Event Timeline

arsenm created this revision.Jan 5 2021, 7:15 PM
arsenm requested review of this revision.Jan 5 2021, 7:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 5 2021, 7:15 PM
Herald added a subscriber: wdng. · View Herald Transcript
foad accepted this revision.Jan 6 2021, 2:48 AM

Seems obvious.

llvm/test/CodeGen/AMDGPU/GlobalISel/fdiv.f16.ll
54–74

Would update_llc_test_checks common these up if you added a GFX89 prefix? Same for loads of other tests.

This revision is now accepted and ready to land.Jan 6 2021, 2:48 AM
arsenm added inline comments.Jan 6 2021, 8:34 AM
llvm/test/CodeGen/AMDGPU/GlobalISel/fdiv.f16.ll
54–74

Apparently it is (I wasn't smart enough to order the checks from most preferred to least)