Page MenuHomePhabricator

[mlir] Fix mlir_async_runtime.lib creation for MSVC.
AcceptedPublic

Authored by jamboree on Dec 24 2020, 11:18 PM.

Details

Summary

The extern "C" functions exported with MLIR_ASYNCRUNTIME_EXPORT are inside namespace mlir::runtime. MSVC has problems in associating the decls with the impls if they are not qualified properly.

This patch put the impls inside the mlir::runtime namespace as the decls.

Diff Detail

Event Timeline

jamboree created this revision.Dec 24 2020, 11:18 PM
jamboree requested review of this revision.Dec 24 2020, 11:18 PM
ezhulenev accepted this revision.Dec 25 2020, 2:19 AM
ezhulenev added inline comments.
mlir/lib/ExecutionEngine/AsyncRuntime.cpp
174
This revision is now accepted and ready to land.Dec 25 2020, 2:19 AM
jamboree updated this revision to Diff 313731.Dec 25 2020, 8:02 AM

Add a comment as requested.