This is an archive of the discontinued LLVM Phabricator instance.

[NFC, Refactor] Modernize StorageClass from Specifiers.h to a scoped enum (II)
ClosedPublic

Authored by tschuett on Dec 23 2020, 7:59 AM.

Diff Detail

Event Timeline

tschuett created this revision.Dec 23 2020, 7:59 AM
tschuett requested review of this revision.Dec 23 2020, 7:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 23 2020, 7:59 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
aaron.ballman accepted this revision.Jan 4 2021, 10:01 AM

LGTM aside from some minor nits.

clang/include/clang/AST/Decl.h
1078–1088

You changed the definition of isLegalForFunction() to use a switch statement rather than use <= -- should this one be changed to a switch or the other one changed back to <= (or is there a reason to not be consistent)?

clang/lib/Serialization/ASTReaderDecl.cpp
1416

Is there a benefit to the two-layer of casts as opposed to storing the read value directly into SClass?

This revision is now accepted and ready to land.Jan 4 2021, 10:01 AM
tschuett updated this revision to Diff 314412.Jan 4 2021, 11:26 AM

Rebased

addressed review comments

tschuett marked 2 inline comments as done.Jan 4 2021, 11:27 AM
tschuett updated this revision to Diff 314423.Jan 4 2021, 11:53 AM

fix libclang

tschuett updated this revision to Diff 314434.Jan 4 2021, 12:24 PM

libclang take II

tschuett updated this revision to Diff 314442.Jan 4 2021, 1:12 PM

fixed unittest