[RISCV] Add new V instructions and aliases in v1.0-08a0b46.
ClosedPublic
Actions

Authored by HsiangKai on Dec 20 2020, 11:23 PM.

Details

Reviewers

craig.topper
evandro
frasercrmck
rogfer01

Summary

New V instructions:
vfrsqrte7.v
vfrece7.v
vrgatherei16.vv

New aliases:
vneg.v
vncvt.x.x.w
vfneg.v

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	540 ms	x64 debian > lld.ELF::wrap-shlib-undefined.s Script: -- : 'RUN: at line 3'; rm -rf /mnt/disks/ssd0/agent/llvm-project/build/tools/lld/test/ELF/Output/wrap-shlib-undefined.s.tmp && split-file /mnt/disks/ssd0/agent/llvm-project/lld/test/ELF/wrap-shlib-undefined.s /mnt/disks/ssd0/agent/llvm-project/build/tools/lld/test/ELF/Output/wrap-shlib-undefined.s.tmp
	680 ms	x64 windows > lld.ELF::wrap-shlib-undefined.s Script: -- : 'RUN: at line 3'; rm -rf C:\ws\w64\llvm-project\premerge-checks\build\tools\lld\test\ELF\Output\wrap-shlib-undefined.s.tmp && split-file C:\ws\w64\llvm-project\premerge-checks\lld\test\ELF\wrap-shlib-undefined.s C:\ws\w64\llvm-project\premerge-checks\build\tools\lld\test\ELF\Output\wrap-shlib-undefined.s.tmp

Event Timeline

HsiangKai created this revision.Dec 20 2020, 11:23 PM

Herald added subscribers: NickHung, luismarques, apazos and 24 others. · View Herald TranscriptDec 20 2020, 11:23 PM

HsiangKai requested review of this revision.Dec 20 2020, 11:23 PM

Herald added a project: Restricted Project. · View Herald TranscriptDec 20 2020, 11:23 PM

Herald added a subscriber: MaskRay. · View Herald Transcript

HsiangKai mentioned this in D93578: [RISCV] Upgrade RISC-V V extension MC to v1.0-08a0b46..Dec 20 2020, 11:27 PM

HsiangKai edited the summary of this revision. (Show Details)Dec 20 2020, 11:31 PM

craig.topper added inline comments.Dec 20 2020, 11:50 PM

llvm/lib/Target/RISCV/RISCVInstrInfoV.td
805	Do you know if vfabs.v has been discussed for the V spec? We have a fabs.s alias for scalar. Seems odd that its not in the vector spec.

Harbormaster completed remote builds in B83101: Diff 313026.Dec 20 2020, 11:58 PM

kito-cheng added inline comments.Dec 21 2020, 2:26 AM

llvm/lib/Target/RISCV/RISCVInstrInfoV.td
805	I sent PR to spec before but not merge yet. https://github.com/riscv/riscv-v-spec/pull/574

LGTM. But please title this "[RISCV] Add new V instructions and aliases in v1.0-08a0b46." and clarify in the commit message which ones are aliases.

This revision is now accepted and ready to land.Dec 21 2020, 9:59 AM

HsiangKai retitled this revision from [RISCV] Add new V instructions in v1.0-08a0b46. to [RISCV] Add new V instructions and aliases in v1.0-08a0b46..Dec 21 2020, 2:12 PM

HsiangKai edited the summary of this revision. (Show Details)

LGTM.

HsiangKai mentioned this in D94583: [RISCV] Update V extension to v1.0-draft 08a0b464..Jan 12 2021, 10:54 PM

Rebase.

Harbormaster completed remote builds in B85836: Diff 317775.Jan 19 2021, 10:52 PM

arcbbb added a child revision: D95014: [RISCV] Add intrinsics for vrgatherei16 instruction.Jan 19 2021, 11:07 PM

arcbbb added a child revision: D95113: [RISCV] Add intrinsics for RVV v1.0 VFRSQRTE7 & VFRECE7.Jan 20 2021, 7:22 PM

Landed in 266820be352d5b824cb01c93df1b00184fcc7803.