Page MenuHomePhabricator

Rename files with same (case insensitive) name
ClosedPublic

Authored by hiraditya on Dec 18 2020, 11:44 AM.

Details

Summary

This is causing issue with rebasing on mac because there is already a file DIModule.ll in the same directory.

https://reviews.llvm.org/D93462 added a new file dimodule.ll

Diff Detail

Event Timeline

hiraditya requested review of this revision.Dec 18 2020, 11:44 AM
hiraditya created this revision.
Herald added a project: Restricted Project. · View Herald Transcript
hiraditya edited the summary of this revision. (Show Details)Dec 18 2020, 11:46 AM
hiraditya added reviewers: thakis, cchen15.
smeenai accepted this revision.Dec 18 2020, 11:53 AM

LGTM to unbreak the checkout. @cchen15 can choose a different name if they want later.

This revision is now accepted and ready to land.Dec 18 2020, 11:53 AM

Thanks for catching this for me. I don't work on Mac. :(

I don't see other tests using 'verify-' as prefix. Would it be more succinct to just call it dimodule-external-fortran.ll?

ok i'll rename this before commit.

Thanks a lot, Aditya. Again, my apologies for the screw-up. I will make sure I won't make the same mistake next time I add a new file.

dyung added a subscriber: dyung.Dec 18 2020, 12:22 PM

This issue also affects Windows, so please commit this change.

It seems, I'm no longer having access to the llvm-project. Please commit this for me.

I need to setup access token because github has changed commit policy recently.

This revision was automatically updated to reflect the committed changes.